)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0f92f49bff2640a8f931192cf8a3ca50289b6851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79beb753_5ab69269","updated":"2023-08-25 15:50:10.000000000","message":"Hopefully Greg was able to verify this","commit_id":"6e533fdb678fc724ddc9846f717b86bd80f0d22e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3ffa1cc8226e612702963c3a2a78c17283e69b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8de3258_fc7e18fe","updated":"2023-08-24 16:23:19.000000000","message":"recheck neutron-fullstack-with-uwsgi non related issue","commit_id":"6e533fdb678fc724ddc9846f717b86bd80f0d22e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"06e79924824db932a9054fde7d5b1032365786af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69fee328_fa56ff4c","in_reply_to":"79beb753_5ab69269","updated":"2023-08-25 16:24:47.000000000","message":"Octavia is using the device ID to \"mark\" the VIP port, so this solution is not working for Octavia. I need to find another way...","commit_id":"6e533fdb678fc724ddc9846f717b86bd80f0d22e"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1319d438ccb5708430d93ed940325c286b63f4e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c84eacaa_55cbfc88","updated":"2023-08-28 14:01:11.000000000","message":"LGTM, thanks","commit_id":"a3b00768d648742034a4e834875fc4586655787c"}],"neutron/common/ovn/utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6cad3ebc4311f0e97c4d7f755a0e19c2a7b72f96","unresolved":true,"context_lines":[{"line_number":1065,"context_line":"    # host ID fields, at the same time, this is because Nova is trying to bind"},{"line_number":1066,"context_line":"    # the port to a VM (device ID) in a host (host ID)."},{"line_number":1067,"context_line":"    if not (port[\u0027device_id\u0027] !\u003d original_port[\u0027device_id\u0027] and"},{"line_number":1068,"context_line":"            port[portbindings.HOST_ID] !\u003d original_port[portbindings.HOST_ID]):"},{"line_number":1069,"context_line":"        return"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    fixed_ips \u003d port.get(\u0027fixed_ips\u0027, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"efa59a87_24d5e86f","line":1068,"updated":"2023-08-28 21:29:06.000000000","message":"nit: or we could remove the double-negative, same result :)\n\n    if (port[\u0027device_id\u0027] \u003d\u003d original_port[\u0027device_id\u0027] or\n            port[portbindings.HOST_ID] \u003d\u003d original_port[portbindings.HOST_ID]):\n        return","commit_id":"a3b00768d648742034a4e834875fc4586655787c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8c2efd0fe03bae915c53002f5e426a27e9d00a1e","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"    # host ID fields, at the same time, this is because Nova is trying to bind"},{"line_number":1066,"context_line":"    # the port to a VM (device ID) in a host (host ID)."},{"line_number":1067,"context_line":"    if not (port[\u0027device_id\u0027] !\u003d original_port[\u0027device_id\u0027] and"},{"line_number":1068,"context_line":"            port[portbindings.HOST_ID] !\u003d original_port[portbindings.HOST_ID]):"},{"line_number":1069,"context_line":"        return"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    fixed_ips \u003d port.get(\u0027fixed_ips\u0027, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba666a42_388188ec","line":1068,"in_reply_to":"efa59a87_24d5e86f","updated":"2023-08-30 14:17:43.000000000","message":"Yes, but how is written now is a direct translation of the doc text: we need to check that we are not updating, at the same time, both parameters.\n\nI prefer to keep it as is now.\n\n(note: I usually prefer to make the boolean operation you did and use your expression, but not in this case).","commit_id":"a3b00768d648742034a4e834875fc4586655787c"}]}