)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c57b4af3a3aac97f3c6466eec357083d1d7c00d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d447c10c_512ae5bb","updated":"2023-08-28 07:11:12.000000000","message":"It can be a discussion topic, but currently it is allowed on the API, see:\nhttps://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/api/definitions/portbindings_extended.py#L87\n\nhttps://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/api/definitions/portbindings.py#L187","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"436b42ae566d6fad6abef5f68f76ce0c7a7f2b0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c707d57f_bbe73a65","updated":"2023-11-13 21:53:48.000000000","message":"Proposed api-ref change https://review.opendev.org/c/openstack/neutron-lib/+/900826 as per the discussion during the last drivers meeting.","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5d5c3b70027cc900379a0b1237c18d64d6a591ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e174e11c_346e7b0a","updated":"2023-08-28 07:13:52.000000000","message":"So if we disable the PUT on bound port, it should be documented also","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c9287b06e3c21cb04e3fe335ed2527682d20458d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"581c0493_fda7a833","updated":"2023-11-14 15:56:39.000000000","message":"So we decided at last week\u0027s driver meeting to let this go forward as-is and update the api-ref that it will fail if the port is bound, since changing vnic_type on a bound port will make it unusable.\n\nFull discussion here:\n\nhttps://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-11-10-14.00.log.html#l-25","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"74cfc11389443d38793371e740ba69f8110bc845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60cb38d7_96eea816","in_reply_to":"00325ad0_8cd2bf83","updated":"2023-09-19 11:46:09.000000000","message":"Can yo bring it to the drivers meeting? Would be good to vote on this, I see this as Rodolfo said, an new extension is necessary as we change the API (and allow PUT only for unbound ports). Perhaps too much bureucracy for a bug but better than silently changing the API","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bd2e93cdaae988eaf3d6ba8abb57ae63086a32ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00325ad0_8cd2bf83","in_reply_to":"458d06c5_2e9ff4e6","updated":"2023-09-11 16:26:55.000000000","message":"Thanks Lajos and Rodolfo for your inputs!\n\nI agree with the documentation part. I tried to search for a good place where to put it, suggestions are welcome.\n\nI would not disable PUT in the API as it makes sense to update the type for unbound ports. Since such an update requires to know the state of the port, it does not belong on the API level but lower where we can query a DB. So the PUT still shall be accepted by the API imho.\n\nWhat do you think?","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8bac1060c1223c757587a906a04eff141b205408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84d597fa_b22c9346","in_reply_to":"60cb38d7_96eea816","updated":"2023-10-13 21:25:28.000000000","message":"Oops, I missed this comment, sorry. I will bring it next week.","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c135745f0c02beb668c6ad7d82084d9cb98f59f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"458d06c5_2e9ff4e6","in_reply_to":"e174e11c_346e7b0a","updated":"2023-08-30 13:59:14.000000000","message":"I agree with Lajos. That is currently accepted by the API (although it shouldn\u0027t initially). Thus this change, although needed, should be done via a API extension and a release note.","commit_id":"b72cd170edfb5a5c1602da769719c445d0ebf643"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b959445468d7b9e9d773137e505738528bc7cbe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e28dd7ae_cca8cfe3","updated":"2023-11-14 16:48:10.000000000","message":"nit on release note","commit_id":"7d47d933affa07c6459182d3dccb1e6494db5092"}],"releasenotes/notes/update-vnic-type-d2cb5b78d5ba1c32.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b959445468d7b9e9d773137e505738528bc7cbe7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In previous versions administrator was allowed to update a port"},{"line_number":5,"context_line":"    ``binding:vnic_type`` attribute even if it was bound. This is now blocked"},{"line_number":6,"context_line":"    and the update operation of the attribute returns the ``Conflict (409)``"},{"line_number":7,"context_line":"    response code."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eb38e054_a2f07eda","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":38},"updated":"2023-11-14 16:48:10.000000000","message":"s/versions, an administrator","commit_id":"7d47d933affa07c6459182d3dccb1e6494db5092"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0b333f354dbea27a02720bc530593aea7192dcf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In previous versions administrator was allowed to update a port"},{"line_number":5,"context_line":"    ``binding:vnic_type`` attribute even if it was bound. This is now blocked"},{"line_number":6,"context_line":"    and the update operation of the attribute returns the ``Conflict (409)``"},{"line_number":7,"context_line":"    response code."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2c7edd77_722d654f","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":38},"in_reply_to":"eb38e054_a2f07eda","updated":"2023-11-15 13:59:58.000000000","message":"Done","commit_id":"7d47d933affa07c6459182d3dccb1e6494db5092"}]}
