)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce55e70c33d9b0ae4e73b809cf27fe4d746e3013","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b760248_be4fa35a","updated":"2023-09-08 21:30:04.000000000","message":"So I threw out this as an option:\n\nhttps://review.opendev.org/c/openstack/neutron/+/894399\n\nIt doesn\u0027t work at the moment, but does remove even more unused things :)","commit_id":"c8ec889009890744dde569afa273bbce04e3e18d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"040a8839d61d929d354345cd701106dee8980a37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc6a6a29_cb0e9d33","in_reply_to":"4b760248_be4fa35a","updated":"2023-09-13 14:35:10.000000000","message":"Thanks :) In my patch I also breakdown the MetadataDriver into functions as it was really stateless class that\u0027s not even been instantiated.","commit_id":"c8ec889009890744dde569afa273bbce04e3e18d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8387f64ff05c0db5d3e2c0a83c7e1000bac5e41f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e2efd15_df8a3715","updated":"2023-09-14 17:29:59.000000000","message":"-1 until we choose a way forward","commit_id":"1999376e16ea3f346a6fbb5d4201eace18de74db"}],"neutron/agent/ovn/metadata/driver.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"a0e599da58b543de566073e3a4ecb09a421bdded","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    return callback"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def _get_metadata_proxy_process_manager(network_id, conf,"},{"line_number":171,"context_line":"                                        ns_name, callback\u003dNone):"},{"line_number":172,"context_line":"    return external_process.ProcessManager("},{"line_number":173,"context_line":"        conf\u003dconf,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b1d966f_e5ecd1f3","line":170,"updated":"2023-09-07 19:36:44.000000000","message":"Just FYI. Bugged me why there is so much dead code in here and then I realized that it is mostly becaue most of the code here started as a copy/paste from the agent/metadata/* . For example:  https://opendev.org/openstack/neutron/src/commit/8cba9a2ee86cb3b65645674ef315c14cfb261143/neutron/agent/metadata/driver.py#L273-L283","commit_id":"c8ec889009890744dde569afa273bbce04e3e18d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8387f64ff05c0db5d3e2c0a83c7e1000bac5e41f","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                raise"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class MetadataDriver(object):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    monitors \u003d {}"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9d4d1a3b_199f4fc4","side":"PARENT","line":148,"updated":"2023-09-14 17:29:59.000000000","message":"The non-OVN version of this class is actually used by the l3-agent, so removing this will not allow us to create a common class.\n\nTake a look at https://review.opendev.org/c/openstack/neutron/+/894399 so see where I\u0027m going with that (this file is almost empty)","commit_id":"37c49986994abce3afa9b28cc30b7810dc281f04"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30d2126563cc821439df53938340a955769a3755","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                raise"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class MetadataDriver(object):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    monitors \u003d {}"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ac4899a8_52c6ed56","side":"PARENT","line":148,"in_reply_to":"9d4d1a3b_199f4fc4","updated":"2023-09-22 21:44:12.000000000","message":"I think the way forward would be having common code for the haproxy configuration and handling but different MetadataDrivers","commit_id":"37c49986994abce3afa9b28cc30b7810dc281f04"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d66a42cf245594ae55569d657d4f27fe2a20bd48","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                raise"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class MetadataDriver(object):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    monitors \u003d {}"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2f30050e_96ccacb1","side":"PARENT","line":148,"in_reply_to":"ac4899a8_52c6ed56","updated":"2023-09-24 18:03:30.000000000","message":"The problem I see with forking the OVN driver like this is that there will be \"bug creep\" since it will be different from the base driver. There\u0027s already a little of that today in simple things like the way it cleans up files, etc. Once Daniel\u0027s IPv6 change merges the only real difference is the names used in each agent.","commit_id":"37c49986994abce3afa9b28cc30b7810dc281f04"}]}