)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47a2789e5b3ece24553f4423344490966720d04c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63da1a6c_280438f5","updated":"2023-09-26 14:46:08.000000000","message":"LGTM","commit_id":"1d7e99bc0f10509166b240ad503e649fef4ebab3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"51053bc6000279f21e95d5c5f570e0d82b3902bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0b69c95_0574cd7e","updated":"2023-09-27 13:46:57.000000000","message":"recheck\n\nanother single functional test failure due to a random timeout. :/","commit_id":"1d7e99bc0f10509166b240ad503e649fef4ebab3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5cc7e527c2a64210732a5a877f4875170708bf90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"07ad673e_32fa0a2c","updated":"2023-09-26 19:31:38.000000000","message":"recheck functional\n\nUnrelated ml2/ovs L3 agent timeout","commit_id":"1d7e99bc0f10509166b240ad503e649fef4ebab3"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"855eeac1d5e4421513a9576c83fd77c126838d8b","unresolved":true,"context_lines":[{"line_number":304,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":305,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips in Z+1."},{"line_number":306,"context_line":"    @has_lock_periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":307,"context_line":"    @rerun_on_schema_updates"},{"line_number":308,"context_line":"    def migrate_to_stateful_fips(self):"},{"line_number":309,"context_line":"        \"\"\"Perform the migration from stateless to stateful Floating IPs. \"\"\""},{"line_number":310,"context_line":"        admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":3,"id":"164cd196_e723e249","line":307,"updated":"2023-09-26 18:56:54.000000000","message":"Just so I understand this correctly, can this run any other way than the periodic? I.e. if it runs on a schema update should the lock check stay?","commit_id":"1d7e99bc0f10509166b240ad503e649fef4ebab3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"84fb9a91444da2a68c4ba6b26b7de05f19d15aff","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    # to perform the migration every 10 seconds until completed."},{"line_number":305,"context_line":"    # TODO(ihrachys): Remove the migration to stateful fips in Z+1."},{"line_number":306,"context_line":"    @has_lock_periodic(spacing\u003d10, run_immediately\u003dTrue)"},{"line_number":307,"context_line":"    @rerun_on_schema_updates"},{"line_number":308,"context_line":"    def migrate_to_stateful_fips(self):"},{"line_number":309,"context_line":"        \"\"\"Perform the migration from stateless to stateful Floating IPs. \"\"\""},{"line_number":310,"context_line":"        admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9b733a46_4deea735","line":307,"in_reply_to":"164cd196_e723e249","updated":"2023-09-26 19:21:13.000000000","message":"If it runs on a schema update, it should still require the lock (we only want one worker on one host doing the operations). To my knowledge, this runs only as a periodic, since it was previously wrapped with `@periodics.periodic`.\n\nThough this was a one-shot thing and we\u0027re already past Z+1 which the TODO mentions it should be removed in (there are several methods in here that are like that, but I figured we should clean those up separately).","commit_id":"1d7e99bc0f10509166b240ad503e649fef4ebab3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"858f16b70cbe220fa09f5ef7e1f64ec06906db24","unresolved":true,"context_lines":[{"line_number":680,"context_line":"                         {ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: \u0027false\u0027})))"},{"line_number":681,"context_line":"        raise periodics.NeverAgain()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    # TODO(lucasagomes): Remove this in the Z cycle"},{"line_number":684,"context_line":"    # A static spacing value is used here, but this method will only run"},{"line_number":685,"context_line":"    # once per lock due to the use of periodics.NeverAgain()."},{"line_number":686,"context_line":"    @has_lock_periodic(spacing\u003d600, run_immediately\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4dbe2d78_738e7b24","line":683,"range":{"start_line":683,"start_character":44,"end_line":683,"end_character":51},"updated":"2023-10-09 07:39:36.000000000","message":"nit: as this static spacing is used in many of the methods here, this TODO can be removed as I see","commit_id":"1d7e99bc0f10509166b240ad503e649fef4ebab3"}]}