)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"41c3dbd8d9511f6f443508eca0abd11e65ed6614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"acb58bd7_1f254aa8","updated":"2023-09-29 12:26:27.000000000","message":"Thanks for fixing this issue. Since this is a simple patch, do you mind having a comment clarifying why we are invoking this ? It took me awhile to realize the reason why we needed to do what this patch is doing. I guess this will happen to other people when they read the code.","commit_id":"2921896fee55f9eb27a2f0bd3b51530261330143"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fe94d1015cf7058b9752872da7b6bfcd62b1be2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"869b31ab_f142f79a","updated":"2023-10-02 13:00:20.000000000","message":"recheck\ntest_verify_created_server_ephemeral_disk failure in neutron-ovn-tempest-ipv6-only-ovs-release job is unrelated","commit_id":"5da65c4803bfab80662a41b4cd20c6246b84ec31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"923f09fe9db886074d5a31c31a6eaa878749cfaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92816b09_71fdaca0","updated":"2023-10-04 15:25:28.000000000","message":"recheck OVS HA error fixed","commit_id":"a76aa019772cc35b07a404c213b327169c188243"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"41c3dbd8d9511f6f443508eca0abd11e65ed6614","unresolved":true,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def match_fn(self, event, row, old):"},{"line_number":434,"context_line":"        if not super().match_fn(event, row, old):"},{"line_number":435,"context_line":"            return False"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        if len(old._data) \u003d\u003d 1 and \u0027external_ids\u0027 in old._data:"},{"line_number":438,"context_line":"            # NOTE: since [1], the NB logical_router_port.external_ids are"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fe86dcd_70023534","line":435,"updated":"2023-09-29 12:26:27.000000000","message":"Took me awhile to understand why we needed this.\n\nSo when we override the match_fn() function the condition from L429 is not triggered by the base class.\n\nCan we add a comment for this ?\n\nBecause when we look at other match_fn() examples in this file they don\u0027t invoke the base class method, so it gets confusing when reading the code.\n\nAnother solution is to just test the port type ourselves in this overwritten match_fn() and removing the condition from L429.\n\n```\nif row.type !\u003d ovn_const.OVN_CHASSIS_REDIRECT:\n    return False\n```\n\nAny way thanks for fixing this issue!","commit_id":"2921896fee55f9eb27a2f0bd3b51530261330143"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c573ade17baa1e9350d9102de63fded4dbd4de55","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def match_fn(self, event, row, old):"},{"line_number":434,"context_line":"        if not super().match_fn(event, row, old):"},{"line_number":435,"context_line":"            return False"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        if len(old._data) \u003d\u003d 1 and \u0027external_ids\u0027 in old._data:"},{"line_number":438,"context_line":"            # NOTE: since [1], the NB logical_router_port.external_ids are"}],"source_content_type":"text/x-python","patch_set":1,"id":"133e5ad9_57659efa","line":435,"in_reply_to":"1fe86dcd_70023534","updated":"2023-09-29 12:44:12.000000000","message":"Right, that was the other option. I\u0027ll use the direct comparison in the match_fn method.","commit_id":"2921896fee55f9eb27a2f0bd3b51530261330143"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"872d5a18bc37961f97652d26d6640bc462e3d901","unresolved":true,"context_lines":[{"line_number":426,"context_line":"        self.l3_plugin \u003d directory.get_plugin(constants.L3)"},{"line_number":427,"context_line":"        table \u003d \u0027Port_Binding\u0027"},{"line_number":428,"context_line":"        events \u003d (self.ROW_UPDATE,)"},{"line_number":429,"context_line":"        super(PortBindingChassisEvent, self).__init__(events, table, None)"},{"line_number":430,"context_line":"        self.event_name \u003d \u0027PortBindingChassisEvent\u0027"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def match_fn(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3cf4cc_eb7ae185","line":429,"updated":"2023-10-02 15:20:54.000000000","message":"nit: since you were changing could have used \"new\" syntax:\n\n super().__init__(events, table, None)","commit_id":"5da65c4803bfab80662a41b4cd20c6246b84ec31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3b46f59b9ce70b99511f4e91355fb4d6c59aa014","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        self.l3_plugin \u003d directory.get_plugin(constants.L3)"},{"line_number":427,"context_line":"        table \u003d \u0027Port_Binding\u0027"},{"line_number":428,"context_line":"        events \u003d (self.ROW_UPDATE,)"},{"line_number":429,"context_line":"        super(PortBindingChassisEvent, self).__init__(events, table, None)"},{"line_number":430,"context_line":"        self.event_name \u003d \u0027PortBindingChassisEvent\u0027"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def match_fn(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ad0155d4_0eda0b69","line":429,"in_reply_to":"df3cf4cc_eb7ae185","updated":"2023-10-02 16:24:10.000000000","message":"Done","commit_id":"5da65c4803bfab80662a41b4cd20c6246b84ec31"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"872d5a18bc37961f97652d26d6640bc462e3d901","unresolved":true,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def match_fn(self, event, row, old):"},{"line_number":433,"context_line":"        if row.type !\u003d ovn_const.OVN_CHASSIS_REDIRECT:"},{"line_number":434,"context_line":"            return False"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        if len(old._data) \u003d\u003d 1 and \u0027external_ids\u0027 in old._data:"},{"line_number":437,"context_line":"            # NOTE: since [1], the NB logical_router_port.external_ids are"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f3c934c_769276b1","line":434,"updated":"2023-10-02 15:20:54.000000000","message":"There was no test added/updated for this :(","commit_id":"5da65c4803bfab80662a41b4cd20c6246b84ec31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3b46f59b9ce70b99511f4e91355fb4d6c59aa014","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def match_fn(self, event, row, old):"},{"line_number":433,"context_line":"        if row.type !\u003d ovn_const.OVN_CHASSIS_REDIRECT:"},{"line_number":434,"context_line":"            return False"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        if len(old._data) \u003d\u003d 1 and \u0027external_ids\u0027 in old._data:"},{"line_number":437,"context_line":"            # NOTE: since [1], the NB logical_router_port.external_ids are"}],"source_content_type":"text/x-python","patch_set":2,"id":"c86c215d_25a07079","line":434,"in_reply_to":"1f3c934c_769276b1","updated":"2023-10-02 16:24:10.000000000","message":"Done","commit_id":"5da65c4803bfab80662a41b4cd20c6246b84ec31"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b7869ea6b11e8585005cb6e528c2b16794cde821","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def match_fn(self, event, row, old):"},{"line_number":433,"context_line":"        if row.type !\u003d ovn_const.OVN_CHASSIS_REDIRECT:"},{"line_number":434,"context_line":"            return False"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        if len(old._data) \u003d\u003d 1 and \u0027external_ids\u0027 in old._data:"},{"line_number":437,"context_line":"            # NOTE: since [1], the NB logical_router_port.external_ids are"}],"source_content_type":"text/x-python","patch_set":2,"id":"bdb2aa0c_0e5a6600","line":434,"in_reply_to":"c86c215d_25a07079","updated":"2023-10-02 21:28:11.000000000","message":"I didn\u0027t see a new version?","commit_id":"5da65c4803bfab80662a41b4cd20c6246b84ec31"}]}