)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6fec99d985b67c1cb3db5631292f40fdb9582ae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"91e4567a_3edf85c5","updated":"2023-10-06 07:45:00.000000000","message":"BTW, the number of tables drop from 192 to 135. And I\u0027m sure that we can remove more tables created by default but used by external plugins; but that requires a bigger refactor.","commit_id":"4836a29ca5b47b7c636aef9bacdbf561f80920a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f5ee9ef54952f485eb1a6a7b7067784712cb918","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f85d7f77_fad45859","updated":"2023-10-10 07:35:44.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"6f6426a4027158c0eecf6c0cf8f77d2f917fb14b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5d4b62f4fe3e36fab2b9954062b51f672a796c56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"88832ead_75a61dfd","updated":"2023-10-10 13:28:20.000000000","message":"I suppose we don\u0027t have to send out mail or such as these are really old and spider webbed tables","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cf4892c1be108cc937b9118b908915c336cbda16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4d4816fa_8c449a46","in_reply_to":"88832ead_75a61dfd","updated":"2023-10-10 14:11:22.000000000","message":"I reviewed all these tables related to former plugins and none of them are active right now.","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4078b1684728bc43c394e203f8076efabf35edb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"129e0a9e_d3ca9ec7","updated":"2023-10-13 04:32:03.000000000","message":"This broke some jobs as neutron_vpnaas refers cisco_csr table during migration https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e98/897995/4/check/openstacksdk-functional-devstack-networking-ext/e987fb8/job-output.txt","commit_id":"8aad0949855e9828a7f85fde4d28b8fa524714a8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c36b1dfb4a30397bf81d214d30eaf733cd1f8154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"30f2a584_42f5e434","in_reply_to":"129e0a9e_d3ca9ec7","updated":"2023-10-13 04:58:45.000000000","message":"pushed https://review.opendev.org/c/openstack/neutron-vpnaas/+/898153","commit_id":"8aad0949855e9828a7f85fde4d28b8fa524714a8"}],"neutron/db/migration/alembic_migrations/external.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4613afa50fb734ceacdc1001c044b0bbbc5e9a2b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    \u0027maclearningstates\u0027,"},{"line_number":80,"context_line":"    \u0027portqueuemappings\u0027,"},{"line_number":81,"context_line":"    \u0027networkqueuemappings\u0027,"},{"line_number":82,"context_line":"    \u0027qosqueues\u0027,"},{"line_number":83,"context_line":"    \u0027lsn_port\u0027,"},{"line_number":84,"context_line":"    \u0027lsn\u0027,"},{"line_number":85,"context_line":"    \u0027nsxv_router_bindings\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fbf5dc69_59b15c5c","line":82,"updated":"2023-10-11 00:27:21.000000000","message":"Not sure why this moved","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09a230e1ef8e86e18a8a9146ee5ecd8a3e8cb8be","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \u0027maclearningstates\u0027,"},{"line_number":80,"context_line":"    \u0027portqueuemappings\u0027,"},{"line_number":81,"context_line":"    \u0027networkqueuemappings\u0027,"},{"line_number":82,"context_line":"    \u0027qosqueues\u0027,"},{"line_number":83,"context_line":"    \u0027lsn_port\u0027,"},{"line_number":84,"context_line":"    \u0027lsn\u0027,"},{"line_number":85,"context_line":"    \u0027nsxv_router_bindings\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"efbfd628_1d95287e","line":82,"in_reply_to":"8e92272f_89b584d4","updated":"2023-10-11 08:00:40.000000000","message":"Sorry, now I understand: I should have done this in https://review.opendev.org/c/openstack/neutron/+/897472/10/neutron/db/migration/alembic_migrations/versions/2024.1/expand/054e34dbe6b4_drop_unused_tables.py, not here!\n\nThanks!","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"afa1cd1bdbd033b565ca9c4ff2214cf81687a9be","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \u0027maclearningstates\u0027,"},{"line_number":80,"context_line":"    \u0027portqueuemappings\u0027,"},{"line_number":81,"context_line":"    \u0027networkqueuemappings\u0027,"},{"line_number":82,"context_line":"    \u0027qosqueues\u0027,"},{"line_number":83,"context_line":"    \u0027lsn_port\u0027,"},{"line_number":84,"context_line":"    \u0027lsn\u0027,"},{"line_number":85,"context_line":"    \u0027nsxv_router_bindings\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8e92272f_89b584d4","line":82,"in_reply_to":"fbf5dc69_59b15c5c","updated":"2023-10-11 07:59:41.000000000","message":"Because it is referred as foreign key in \"networkqueuemappings\" and \"portqueuemappings\". With this order, we first delete these tables first and then \"qosqueues\" without having any conflict. I\u0027ve done this with several tables in this list.","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"}],"neutron/db/migration/alembic_migrations/versions/2024.1/expand/054e34dbe6b4_drop_unused_tables.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4a7079cf7a164bc76602e99b9e4b47dbf4d6ce1d","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    inspector \u003d sa.inspect(op.get_bind())"},{"line_number":44,"context_line":"    db_tables \u003d inspector.get_table_names()"},{"line_number":45,"context_line":"    tables_to_drop \u003d list(TABLES_TO_DROP)"},{"line_number":46,"context_line":"    while tables_to_drop:"},{"line_number":47,"context_line":"        # Tables that have not been dropped in this iteration."},{"line_number":48,"context_line":"        missed_tables \u003d []"},{"line_number":49,"context_line":"        for table in tables_to_drop:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f45583fe_270ebce5","line":46,"updated":"2023-10-05 16:41:56.000000000","message":"So this can spin forever on failure?","commit_id":"4836a29ca5b47b7c636aef9bacdbf561f80920a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"12a2b0162072a300f6efaba8d622ae225aeab534","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    inspector \u003d sa.inspect(op.get_bind())"},{"line_number":44,"context_line":"    db_tables \u003d inspector.get_table_names()"},{"line_number":45,"context_line":"    tables_to_drop \u003d list(TABLES_TO_DROP)"},{"line_number":46,"context_line":"    while tables_to_drop:"},{"line_number":47,"context_line":"        # Tables that have not been dropped in this iteration."},{"line_number":48,"context_line":"        missed_tables \u003d []"},{"line_number":49,"context_line":"        for table in tables_to_drop:"}],"source_content_type":"text/x-python","patch_set":3,"id":"04bd6a49_4b45446e","line":46,"in_reply_to":"f45583fe_270ebce5","updated":"2023-10-06 07:37:16.000000000","message":"Yes but the CI is proving that this is not happening. In any case, I\u0027ll create a check between loops to ensure the \"tables_to_drop\" length is shrinking in each iteration.","commit_id":"4836a29ca5b47b7c636aef9bacdbf561f80920a5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4613afa50fb734ceacdc1001c044b0bbbc5e9a2b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                errors.append(str(_exc))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if len(missed_tables) \u003d\u003d len(tables_to_drop):"},{"line_number":102,"context_line":"            raise Exception(_(\u0027The following tables have been not dropped \u0027"},{"line_number":103,"context_line":"                              \u0027from the Neutron database: %(missed_tables)s.\\n\u0027"},{"line_number":104,"context_line":"                              \u0027List of errors: %(errors)s\u0027 %"},{"line_number":105,"context_line":"                              {\u0027missed_tables\u0027: \u0027, \u0027.join(missed_tables),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5ebae5fd_a010b348","line":102,"range":{"start_line":102,"start_character":57,"end_line":102,"end_character":65},"updated":"2023-10-11 00:27:21.000000000","message":"nit: not been","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"afa1cd1bdbd033b565ca9c4ff2214cf81687a9be","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                errors.append(str(_exc))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if len(missed_tables) \u003d\u003d len(tables_to_drop):"},{"line_number":102,"context_line":"            raise Exception(_(\u0027The following tables have been not dropped \u0027"},{"line_number":103,"context_line":"                              \u0027from the Neutron database: %(missed_tables)s.\\n\u0027"},{"line_number":104,"context_line":"                              \u0027List of errors: %(errors)s\u0027 %"},{"line_number":105,"context_line":"                              {\u0027missed_tables\u0027: \u0027, \u0027.join(missed_tables),"}],"source_content_type":"text/x-python","patch_set":10,"id":"a4a274d5_d5548d28","line":102,"range":{"start_line":102,"start_character":57,"end_line":102,"end_character":65},"in_reply_to":"5ebae5fd_a010b348","updated":"2023-10-11 07:59:41.000000000","message":"Done","commit_id":"c2e0687044522cdf87e1065438d4bedfdc63a6aa"}]}