)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"de4ffbc51f2226cc6c94fdc0dcf422631d73e01e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"27d01241_2fde763a","updated":"2023-10-11 05:53:39.000000000","message":"LGTM, +1 on adding coverage to not regress on this as it will be unnotice","commit_id":"a5e764c8c24883495912afa92e19db0ef462b46a"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ae2a337077022330e2f5ad3851b06dbbcc62b3","unresolved":true,"context_lines":[{"line_number":453,"context_line":"                # when it sees an ARP coming from the VIP"},{"line_number":454,"context_line":"                if port_type !\u003d ovn_const.LSP_TYPE_VIRTUAL:"},{"line_number":455,"context_line":"                    options[ovn_const.LSP_OPTIONS_REQUESTED_CHASSIS_KEY] \u003d \\"},{"line_number":456,"context_line":"                        chassis"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if self.is_mcast_flood_broken and port_type not in ("},{"line_number":459,"context_line":"                \u0027vtep\u0027, ovn_const.LSP_TYPE_LOCALPORT, \u0027router\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4eda8f2_46ad96aa","line":456,"updated":"2023-10-05 20:56:04.000000000","message":"Looks like it was just mis-indented so I\u0027m fine with doing this, but should tweak a unit test since it should have been caught.","commit_id":"a5e764c8c24883495912afa92e19db0ef462b46a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1366b5341d40a6f430aea12c9671d9a946ef4142","unresolved":true,"context_lines":[{"line_number":453,"context_line":"                # when it sees an ARP coming from the VIP"},{"line_number":454,"context_line":"                if port_type !\u003d ovn_const.LSP_TYPE_VIRTUAL:"},{"line_number":455,"context_line":"                    options[ovn_const.LSP_OPTIONS_REQUESTED_CHASSIS_KEY] \u003d \\"},{"line_number":456,"context_line":"                        chassis"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if self.is_mcast_flood_broken and port_type not in ("},{"line_number":459,"context_line":"                \u0027vtep\u0027, ovn_const.LSP_TYPE_LOCALPORT, \u0027router\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fb8bcb1_3ddf8136","line":456,"in_reply_to":"53562a91_3c711135","updated":"2023-10-11 10:32:09.000000000","message":"Both (previous code and new code) are correct. This is just an optimization to avoid writing empty keys in the OVN DB registers. If \"not chassis\", the key:\n* base code: will be empty,\n* patch code: won\u0027t be written.\n\nIn both cases the OVN behaviour will be the same but it is better not to write it. I don\u0027t think we need any additional test here.","commit_id":"a5e764c8c24883495912afa92e19db0ef462b46a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4c93c0e1921880abe3f25ffc8f89490d44343c07","unresolved":true,"context_lines":[{"line_number":453,"context_line":"                # when it sees an ARP coming from the VIP"},{"line_number":454,"context_line":"                if port_type !\u003d ovn_const.LSP_TYPE_VIRTUAL:"},{"line_number":455,"context_line":"                    options[ovn_const.LSP_OPTIONS_REQUESTED_CHASSIS_KEY] \u003d \\"},{"line_number":456,"context_line":"                        chassis"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if self.is_mcast_flood_broken and port_type not in ("},{"line_number":459,"context_line":"                \u0027vtep\u0027, ovn_const.LSP_TYPE_LOCALPORT, \u0027router\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"53562a91_3c711135","line":456,"in_reply_to":"95f3d92d_a92890ac","updated":"2023-10-11 02:03:17.000000000","message":"I\u0027m guessing there is not an existing unit test since moving this inside the block didn\u0027t fail as I would have expected. I think if it\u0027s easy we should add one so we don\u0027t possibly regress.","commit_id":"a5e764c8c24883495912afa92e19db0ef462b46a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"23db271f463d2dbad23553a0b5cad08ecf9f61f2","unresolved":true,"context_lines":[{"line_number":453,"context_line":"                # when it sees an ARP coming from the VIP"},{"line_number":454,"context_line":"                if port_type !\u003d ovn_const.LSP_TYPE_VIRTUAL:"},{"line_number":455,"context_line":"                    options[ovn_const.LSP_OPTIONS_REQUESTED_CHASSIS_KEY] \u003d \\"},{"line_number":456,"context_line":"                        chassis"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if self.is_mcast_flood_broken and port_type not in ("},{"line_number":459,"context_line":"                \u0027vtep\u0027, ovn_const.LSP_TYPE_LOCALPORT, \u0027router\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"95f3d92d_a92890ac","line":456,"in_reply_to":"d4eda8f2_46ad96aa","updated":"2023-10-06 15:42:58.000000000","message":"Not sure I understand. Which test case should be tweaked? The gate passes.\n\nOr do you mean that there should be a new test case that validates that empty chassis is not set? Is it a particularly useful test case?","commit_id":"a5e764c8c24883495912afa92e19db0ef462b46a"}]}