)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"71f1977e746a3f7014c8a963a9e62dee04a7eda0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"096852fc_7b4187f7","updated":"2024-01-08 15:10:54.000000000","message":"recently a issue was reported for add-route option https://issues.redhat.com/browse/FDP-240 so would be worth to check that when this patch get\u0027s revised","commit_id":"03f546ff51bdb52442fea04b967db27c58083a48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"99556dc924da0cc7c272afe00672b6efeb9e1ea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf696eaf_13e4c068","in_reply_to":"096852fc_7b4187f7","updated":"2024-01-24 12:40:55.000000000","message":"The same issue was reported in https://bugs.launchpad.net/neutron/+bug/2035281 and addressed in a different way: https://review.opendev.org/c/openstack/neutron/+/895260","commit_id":"03f546ff51bdb52442fea04b967db27c58083a48"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4aaf2adfbde9d16666c16019ae16adf83d9d4dff","unresolved":true,"context_lines":[{"line_number":848,"context_line":"            ip[\"subnet_id\"] for ip in ext_gw_info.get(\u0027external_fixed_ips\u0027, [])"},{"line_number":849,"context_line":"        ]"},{"line_number":850,"context_line":"        # TODO -- how to check if fip is NOT within external_fixed_ips subnets"},{"line_number":851,"context_line":"        if False:"},{"line_number":852,"context_line":"            columns[\u0027options\u0027] \u003d {\u0027add_route\u0027: \u0027true\u0027}"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5b597fb_a435a637","line":851,"updated":"2023-10-11 14:01:40.000000000","message":"I\u0027m not sure how to handle this to be honest, looking at the Neutron API, it seems that the `subnet_id` is set to `None` for some reason, so I can\u0027t figure out what subnet_id the FIP is a part of.\n\nI can do a lookup with the IP or maybe using device_owner / device_id.. but perhaps someone who understands the code better than me might know how to get around it.","commit_id":"03f546ff51bdb52442fea04b967db27c58083a48"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0edc91e47328613753218faf1a726a7cec1a92b6","unresolved":true,"context_lines":[{"line_number":848,"context_line":"            ip[\"subnet_id\"] for ip in ext_gw_info.get(\u0027external_fixed_ips\u0027, [])"},{"line_number":849,"context_line":"        ]"},{"line_number":850,"context_line":"        # TODO -- how to check if fip is NOT within external_fixed_ips subnets"},{"line_number":851,"context_line":"        if False:"},{"line_number":852,"context_line":"            columns[\u0027options\u0027] \u003d {\u0027add_route\u0027: \u0027true\u0027}"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        if ovn_conf.is_ovn_distributed_floating_ip():"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6dea7db_b454c07e","line":851,"in_reply_to":"b5b597fb_a435a637","updated":"2023-10-19 14:51:31.000000000","message":"This could be achieved by storing the subnet_id in the FIP OVO, same as we are doing with the network_id. In this case, I suggest to make this new field as synthetic and populate it in the method \"FloatingIP.from_db_object\". The value is stored in \"db_obj.port.fixed_ips\". This is a list of IPAllocation registers. Because we have one single FIP, there should be just one IPAllocation. This register has a \"subnet_id\" field. So this should be something like \"db_obj.port.fixed_ips[0].subnet_id\".\n\nBecause we are not using this value outside the Neutron server, I don\u0027t recommend creating a new API extension (unless, in a future, this parameter is needed).","commit_id":"03f546ff51bdb52442fea04b967db27c58083a48"}]}