)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"401239ee4b477e0aec790d34493aa3da2b671953","unresolved":true,"context_lines":[{"line_number":17,"context_line":"is used to load the configuration, execute the sync process and"},{"line_number":18,"context_line":"register the metadata extension."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This extension will replace the need of the OVN metadata agent. The"},{"line_number":21,"context_line":"deprecation of this agent will imply the refactor of the existing code"},{"line_number":22,"context_line":"that now is shared betweem both agents."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"c590f65a_f24b2eef","line":20,"updated":"2024-01-19 16:40:55.000000000","message":"release note should probably be included, explaining that 1) this is happening and 2) what to do, if anything, to migrate to the single agent.","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb800e18e998613c585483d88421c7d55249049","unresolved":false,"context_lines":[{"line_number":17,"context_line":"is used to load the configuration, execute the sync process and"},{"line_number":18,"context_line":"register the metadata extension."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This extension will replace the need of the OVN metadata agent. The"},{"line_number":21,"context_line":"deprecation of this agent will imply the refactor of the existing code"},{"line_number":22,"context_line":"that now is shared betweem both agents."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"b9838f42_685c3fcb","line":20,"in_reply_to":"c590f65a_f24b2eef","updated":"2024-01-22 16:15:24.000000000","message":"As commented, we\u0027ll first implement the code and then, once tested, we\u0027ll plan the migration.","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"401239ee4b477e0aec790d34493aa3da2b671953","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This extension will replace the need of the OVN metadata agent. The"},{"line_number":21,"context_line":"deprecation of this agent will imply the refactor of the existing code"},{"line_number":22,"context_line":"that now is shared betweem both agents."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch is also adding a new zuul job"},{"line_number":25,"context_line":"\"neutron-tempest-plugin-ovn-with-ovn-agent\". This job is using the OVN"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"df619a2e_9d5eb5f1","line":22,"updated":"2024-01-19 16:40:55.000000000","message":"nit: between","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb800e18e998613c585483d88421c7d55249049","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This extension will replace the need of the OVN metadata agent. The"},{"line_number":21,"context_line":"deprecation of this agent will imply the refactor of the existing code"},{"line_number":22,"context_line":"that now is shared betweem both agents."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch is also adding a new zuul job"},{"line_number":25,"context_line":"\"neutron-tempest-plugin-ovn-with-ovn-agent\". This job is using the OVN"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"8e6d950b_08c82e32","line":22,"in_reply_to":"df619a2e_9d5eb5f1","updated":"2024-01-22 16:15:24.000000000","message":"Done","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d197d4fe2d73a4a04b4284bab9f95eb74aeff338","unresolved":true,"context_lines":[{"line_number":25,"context_line":"\"neutron-tempest-plugin-ovn-with-ovn-agent\". This job is using the OVN"},{"line_number":26,"context_line":"agent with the metadata extension, instead of using the OVN metadata"},{"line_number":27,"context_line":"agent. This job requires the devstack patch referred in the"},{"line_number":28,"context_line":"\"depends-on\"."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/c/openstack/devstack/+/904171"},{"line_number":31,"context_line":"Needed-By: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/909860"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"0a8c6ced_d87e14a3","line":28,"updated":"2024-02-22 16:45:39.000000000","message":"The n-t-p patch was updated to not have this job.","commit_id":"3767c9a975a4f7a89ea4a0ae3aa58346040ed94d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d4899447ec49e511632f493ee85940a012d452da","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"neutron-tempest-plugin-ovn-with-ovn-agent\". This job is using the OVN"},{"line_number":26,"context_line":"agent with the metadata extension, instead of using the OVN metadata"},{"line_number":27,"context_line":"agent. This job requires the devstack patch referred in the"},{"line_number":28,"context_line":"\"depends-on\"."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/c/openstack/devstack/+/904171"},{"line_number":31,"context_line":"Needed-By: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/909860"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1d639a3d_c05663f5","line":28,"in_reply_to":"0a8c6ced_d87e14a3","updated":"2024-02-26 07:44:33.000000000","message":"Right, I\u0027m updating the description now.","commit_id":"3767c9a975a4f7a89ea4a0ae3aa58346040ed94d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3e976fff2161f477158b69dbe07536de5306d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6eb2f590_95c30943","updated":"2023-12-22 14:59:54.000000000","message":"recheck devstack patch","commit_id":"47634764fb49ed0836b509bdca2946577f8b9b7d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"401239ee4b477e0aec790d34493aa3da2b671953","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"228da77a_7c9688bc","updated":"2024-01-19 16:40:55.000000000","message":"I haven\u0027t reviewed the code itself, yet (I will do it in the next review session first thing); just drive-by request to add release note / migration steps. (Assuming we are ready to migrate?)","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a1da546264df9b648ab50c6a86c47598fd093b96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7cbd3d68_28524d3e","updated":"2024-01-17 09:54:18.000000000","message":"ping fellow reviewers","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb800e18e998613c585483d88421c7d55249049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"91346a3c_a4af36fc","in_reply_to":"228da77a_7c9688bc","updated":"2024-01-22 16:15:24.000000000","message":"We\u0027ll first implement the agent extension, the devstack code and the required CI jobs to test it. Once done, I\u0027ll push a needed documentation and a RFE to start this migration.","commit_id":"bd6c4a9a93e1a0467d1714cd7bbf85d23714fbfc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b3effc52398a5c1dda4baa04d2a0d79d7c74e3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bd4afac8_16055406","updated":"2024-02-22 09:48:01.000000000","message":"just some comments regarding CI jobs. Otherwise LGTM for me. Thx for that patch.","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"65b71d2c32d1dfd5a0d41a39dbb470a962c47fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"679a1df0_22748896","updated":"2024-02-08 16:55:50.000000000","message":"ping fellow reviewers","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"679b68e5938c063ded4aebcde4a21ac42a36c59d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c630cc96_7c0155ef","updated":"2024-01-29 19:49:58.000000000","message":"ping fellow reviewers","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a823091bfed2918552a036c8a00760038b31f295","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"0c81adf6_9c5b9602","updated":"2024-02-22 16:34:16.000000000","message":"recheck neutron-tempest-plugin-ovn","commit_id":"3767c9a975a4f7a89ea4a0ae3aa58346040ed94d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7aa7e2e8ad03dad13b788b101eb60f4f0a877e9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0bd7bcc3_e1cc7bef","updated":"2024-02-26 10:18:04.000000000","message":"recheck n-t-p dependency","commit_id":"a73c172f31ea4890690d6b9d5fe1fe14d99c9f5f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a335e02bae41c7334a58086bce6e954df5fd6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f8ddd745_be2d321a","updated":"2024-02-27 21:57:16.000000000","message":"Just a few comments","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"836cfa612b79d77ba6869e9a49cd9262d5b15bbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"af411226_606bff24","updated":"2024-02-27 14:58:05.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1158433a1cc3afda5703f8240be02aeb226f82e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"4efdaa6f_a9371d03","updated":"2024-03-01 11:06:52.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"9c84bada522db26f61f48c521a5e19595c0ca222"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cc0391d1ca65785381f5c1ece7961d1504490e20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"cec71cc6_cf0f8a06","updated":"2024-03-04 14:27:14.000000000","message":"recheck neutron-functional-with-uwsgi\n\nFT error --\u003e https://review.opendev.org/c/openstack/neutron/+/910941","commit_id":"f31538b24f0626849adaf2ccbd354a73be3e1fcd"}],"neutron/agent/ovn/agent/ovn_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a335e02bae41c7334a58086bce6e954df5fd6d9","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                                          self._chassis)"},{"line_number":114,"context_line":"        self._ovn_bridge \u003d ovsdb.get_ovn_bridge(self.ovs_idl)"},{"line_number":115,"context_line":"        LOG.info(\"Loaded chassis name %s (UUID: %s) and ovn bridge %s.\","},{"line_number":116,"context_line":"                 self.chassis, self._chassis_id, self.ovn_bridge)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _load_ovs_idl(self):"},{"line_number":119,"context_line":"        events \u003d []"}],"source_content_type":"text/x-python","patch_set":22,"id":"c74c29e0_1a356057","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":47},"updated":"2024-02-27 21:57:16.000000000","message":"nit: this could have stayed self.chassis_id like the other two here I think","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b04a9e37e2c5a5f873a54bc1fae2cf9010eeafe","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                          self._chassis)"},{"line_number":114,"context_line":"        self._ovn_bridge \u003d ovsdb.get_ovn_bridge(self.ovs_idl)"},{"line_number":115,"context_line":"        LOG.info(\"Loaded chassis name %s (UUID: %s) and ovn bridge %s.\","},{"line_number":116,"context_line":"                 self.chassis, self._chassis_id, self.ovn_bridge)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _load_ovs_idl(self):"},{"line_number":119,"context_line":"        events \u003d []"}],"source_content_type":"text/x-python","patch_set":22,"id":"ad02d3cd_5288285f","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":47},"in_reply_to":"c74c29e0_1a356057","updated":"2024-02-29 09:35:43.000000000","message":"Done","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"}],"neutron/agent/ovn/extensions/metadata.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dba5407d059c7a6bec200d1d4d7d7d3de412b773","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":174,"context_line":"        self.register_metadata_agent()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Raise the \"is_started\" flag."},{"line_number":177,"context_line":"        self._is_started \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"40fb2508_0a512fcf","line":176,"updated":"2024-01-25 03:29:23.000000000","message":"nit: I know what you mean but when I read \"raise\" I am expecting an exception :). Also I dont think comment is needed here, the code is self explanatory","commit_id":"a5696781796cca43be8e96a41cb631c04c30b554"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"825484389cec03caad2e635cfa964ea058065692","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":174,"context_line":"        self.register_metadata_agent()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Raise the \"is_started\" flag."},{"line_number":177,"context_line":"        self._is_started \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"755fe355_72fd18ab","line":176,"in_reply_to":"40fb2508_0a512fcf","updated":"2024-01-25 06:59:07.000000000","message":"Done","commit_id":"a5696781796cca43be8e96a41cb631c04c30b554"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"7a67d9b4b020895f0d25c80ff594dabb21f6981e","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @property"},{"line_number":98,"context_line":"    def name(self):"},{"line_number":99,"context_line":"        return \u0027Metadata OVN agent extension\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @property"},{"line_number":102,"context_line":"    def ovs_idl_events(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"48047655_0a7155b4","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":45},"updated":"2024-01-25 20:52:30.000000000","message":"maybe more of personal preference. I would name it \"OVN agent metadata extension\" and same change whenever this string appears.","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b5d7fef21eb3bc8f2830f6b389f8a396f1bb06a","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @property"},{"line_number":98,"context_line":"    def name(self):"},{"line_number":99,"context_line":"        return \u0027Metadata OVN agent extension\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @property"},{"line_number":102,"context_line":"    def ovs_idl_events(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"11c2dcac_10b6a55c","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":45},"in_reply_to":"48047655_0a7155b4","updated":"2024-01-29 19:52:55.000000000","message":"I\u0027ve used the same pattern in the other extensions: \"\u003cname\u003e OVN agent extension\"","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"7a67d9b4b020895f0d25c80ff594dabb21f6981e","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        Reload the configuration and sync the agent again."},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        self.agent_api.load_config()"},{"line_number":159,"context_line":"        self.sync()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def start(self):"},{"line_number":162,"context_line":"        self._load_config()"}],"source_content_type":"text/x-python","patch_set":18,"id":"82938cd9_5395f467","line":159,"updated":"2024-01-25 20:52:30.000000000","message":"maybe i am overthinking again... But you are relying on the fact that the agent is the only class with the `sync()` but if someone adds `sync` to the extension class that will be called first because of the python MRO. I would be explicit here with `super(self, MetadaAgent).sync()`","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b5d7fef21eb3bc8f2830f6b389f8a396f1bb06a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        Reload the configuration and sync the agent again."},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        self.agent_api.load_config()"},{"line_number":159,"context_line":"        self.sync()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def start(self):"},{"line_number":162,"context_line":"        self._load_config()"}],"source_content_type":"text/x-python","patch_set":18,"id":"e383213b_1c79d1d8","line":159,"in_reply_to":"82938cd9_5395f467","updated":"2024-01-29 19:52:55.000000000","message":"This is something we\u0027ll need to handle during the code reviews. In any case, this extension should change nothing or very little until the migration from Metadata agent to OVN agent (with metadata extension) is done and the Metadata agent code is removed.","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"7a67d9b4b020895f0d25c80ff594dabb21f6981e","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        self._proxy.run()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Do the initial sync."},{"line_number":171,"context_line":"        self.sync()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.register_metadata_agent()"},{"line_number":174,"context_line":"        self._is_started \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"8c0959b0_c873cd87","line":171,"updated":"2024-01-25 20:52:30.000000000","message":"consider same here and as I mentioned above","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b5d7fef21eb3bc8f2830f6b389f8a396f1bb06a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        self._proxy.run()"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Do the initial sync."},{"line_number":171,"context_line":"        self.sync()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.register_metadata_agent()"},{"line_number":174,"context_line":"        self._is_started \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"61d498ed_f0b4d20a","line":171,"in_reply_to":"8c0959b0_c873cd87","updated":"2024-01-29 19:52:55.000000000","message":"ditto","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a335e02bae41c7334a58086bce6e954df5fd6d9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                                                               \u0027ip_addresses\u0027,"},{"line_number":57,"context_line":"                                                               \u0027logical_port\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"OVN_METADATA_UUID_NAMESPACE \u003d uuid.UUID(\u0027d34bf9f6-da32-4871-9af8-15a4626b41ab\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _sync_lock(f):"}],"source_content_type":"text/x-python","patch_set":22,"id":"ee0f5aa6_c6e04645","line":59,"updated":"2024-02-27 21:57:16.000000000","message":"Some of the above is also defined in neutron/agent/ovn/metadata/agent.py should they be moved to a common place? So is _sync_lock().","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b04a9e37e2c5a5f873a54bc1fae2cf9010eeafe","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                                               \u0027ip_addresses\u0027,"},{"line_number":57,"context_line":"                                                               \u0027logical_port\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"OVN_METADATA_UUID_NAMESPACE \u003d uuid.UUID(\u0027d34bf9f6-da32-4871-9af8-15a4626b41ab\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _sync_lock(f):"}],"source_content_type":"text/x-python","patch_set":22,"id":"22c02314_b8817f2b","line":59,"in_reply_to":"ee0f5aa6_c6e04645","updated":"2024-02-29 09:35:43.000000000","message":"Actually is it not used.\n\nThe method \"_sync_lock\" has a global variable _SYNC_STATE_LOCK created in this file, that should be different for each decorator. In any case, this code should be refactored once the OVN metadata agent is replaced with the OVN agent with metadata extension.","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dba5407d059c7a6bec200d1d4d7d7d3de412b773","unresolved":true,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def agent(self):"},{"line_number":105,"context_line":"        \"\"\"This method provide support for the OVN agent"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        This event can be used in the OVN metadata agent and in the OVN"},{"line_number":108,"context_line":"        agent metadata extension."}],"source_content_type":"text/x-python","patch_set":17,"id":"ee10f194_2d0edbb5","line":105,"updated":"2024-01-25 03:29:23.000000000","message":"nit: provides","commit_id":"a5696781796cca43be8e96a41cb631c04c30b554"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"825484389cec03caad2e635cfa964ea058065692","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def agent(self):"},{"line_number":105,"context_line":"        \"\"\"This method provide support for the OVN agent"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        This event can be used in the OVN metadata agent and in the OVN"},{"line_number":108,"context_line":"        agent metadata extension."}],"source_content_type":"text/x-python","patch_set":17,"id":"6d200417_5f222959","line":105,"in_reply_to":"ee10f194_2d0edbb5","updated":"2024-01-25 06:59:07.000000000","message":"Done","commit_id":"a5696781796cca43be8e96a41cb631c04c30b554"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dba5407d059c7a6bec200d1d4d7d7d3de412b773","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        This event can be used in the OVN metadata agent and in the OVN"},{"line_number":108,"context_line":"        agent metadata extension."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        if not self._agent_or_extension:"},{"line_number":111,"context_line":"            if isinstance(self._agent, ovn_neutron_agent.OVNNeutronAgent):"},{"line_number":112,"context_line":"                self._agent_or_extension \u003d self._agent[\u0027metadata\u0027]"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                self._agent_or_extension \u003d self._agent"},{"line_number":115,"context_line":"        return self._agent_or_extension"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"d6d63806_3cd29455","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":54},"updated":"2024-01-25 03:29:23.000000000","message":"Maybe I am overthinking this and this class will be never needed beyond just this transition from agent to agent extension. BUT I think this should have the third option. In case the `self._agent` is not the instance of OVNNeutronAgent, or the ovn metadataextension. In that case maybe raise the `NotImplementedError`","commit_id":"a5696781796cca43be8e96a41cb631c04c30b554"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"825484389cec03caad2e635cfa964ea058065692","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        This event can be used in the OVN metadata agent and in the OVN"},{"line_number":108,"context_line":"        agent metadata extension."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        if not self._agent_or_extension:"},{"line_number":111,"context_line":"            if isinstance(self._agent, ovn_neutron_agent.OVNNeutronAgent):"},{"line_number":112,"context_line":"                self._agent_or_extension \u003d self._agent[\u0027metadata\u0027]"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                self._agent_or_extension \u003d self._agent"},{"line_number":115,"context_line":"        return self._agent_or_extension"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"2dc94ad2_130e9ac6","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":54},"in_reply_to":"d6d63806_3cd29455","updated":"2024-01-25 06:59:07.000000000","message":"Done","commit_id":"a5696781796cca43be8e96a41cb631c04c30b554"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a335e02bae41c7334a58086bce6e954df5fd6d9","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class _OVNExtensionEvent(abc.ABC):"},{"line_number":90,"context_line":"    \"\"\"Implements a method to retrieve the correct caller agent"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    The events inheriting from this class could be called from the OVN metadata"}],"source_content_type":"text/x-python","patch_set":22,"id":"9f15d1d8_01573f08","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":32},"updated":"2024-02-27 21:57:16.000000000","message":"s/metaclass\u003dabc.ABCMeta as that\u0027s what we do elsewhere, https://docs.python.org/3/library/abc.html","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b04a9e37e2c5a5f873a54bc1fae2cf9010eeafe","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class _OVNExtensionEvent(abc.ABC):"},{"line_number":90,"context_line":"    \"\"\"Implements a method to retrieve the correct caller agent"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    The events inheriting from this class could be called from the OVN metadata"}],"source_content_type":"text/x-python","patch_set":22,"id":"21ff1970_3215fcec","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":32},"in_reply_to":"9f15d1d8_01573f08","updated":"2024-02-29 09:35:43.000000000","message":"Done","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a335e02bae41c7334a58086bce6e954df5fd6d9","unresolved":true,"context_lines":[{"line_number":417,"context_line":"                                          self._chassis)"},{"line_number":418,"context_line":"        self._ovn_bridge \u003d self._get_ovn_bridge()"},{"line_number":419,"context_line":"        LOG.debug(\"Loaded chassis name %s (UUID: %s) and ovn bridge %s.\","},{"line_number":420,"context_line":"                  self._chassis, self._chassis_id, self.ovn_bridge)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def _update_chassis_private_config(self):"},{"line_number":423,"context_line":"        \"\"\"Update the Chassis_Private register information"}],"source_content_type":"text/x-python","patch_set":22,"id":"9c55c6e9_da4401da","line":420,"updated":"2024-02-27 21:57:16.000000000","message":"And here is different from the other file","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5b04a9e37e2c5a5f873a54bc1fae2cf9010eeafe","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                                          self._chassis)"},{"line_number":418,"context_line":"        self._ovn_bridge \u003d self._get_ovn_bridge()"},{"line_number":419,"context_line":"        LOG.debug(\"Loaded chassis name %s (UUID: %s) and ovn bridge %s.\","},{"line_number":420,"context_line":"                  self._chassis, self._chassis_id, self.ovn_bridge)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def _update_chassis_private_config(self):"},{"line_number":423,"context_line":"        \"\"\"Update the Chassis_Private register information"}],"source_content_type":"text/x-python","patch_set":22,"id":"ca444124_493865e1","line":420,"in_reply_to":"9c55c6e9_da4401da","updated":"2024-02-29 09:35:43.000000000","message":"Done","commit_id":"72132d8c23424cac7f79e665114f054a8ef47086"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7bfb87fcc8f5e5ea196acbcac9dbe7bfdff51099","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self._post_fork_event.clear()"},{"line_number":461,"context_line":"        self.sb_idl \u003d ovsdb.MetadataAgentOvnSbIdl("},{"line_number":462,"context_line":"            chassis\u003dself._chassis, tables\u003dtables, events\u003devents).start()"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # Now IDL connections can be safely used."},{"line_number":465,"context_line":"        self._post_fork_event.set()"}],"source_content_type":"text/x-python","patch_set":28,"id":"233cb29f_26b3b109","line":462,"updated":"2024-03-13 16:24:48.000000000","message":"nit: probably didn\u0027t need to change, same below, but not critical","commit_id":"fe31f4fe029388ffd393d94bb0899ee8d5632bf9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a4aa5af00a56c76fba737eac117f16d3d0c63e5c","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self._post_fork_event.clear()"},{"line_number":461,"context_line":"        self.sb_idl \u003d ovsdb.MetadataAgentOvnSbIdl("},{"line_number":462,"context_line":"            chassis\u003dself._chassis, tables\u003dtables, events\u003devents).start()"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # Now IDL connections can be safely used."},{"line_number":465,"context_line":"        self._post_fork_event.set()"}],"source_content_type":"text/x-python","patch_set":28,"id":"e8d6ec3d_c0355d27","line":462,"in_reply_to":"233cb29f_26b3b109","updated":"2024-03-13 16:27:59.000000000","message":"Right. If I need to respin the patch, I\u0027ll undo this change.","commit_id":"fe31f4fe029388ffd393d94bb0899ee8d5632bf9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"771315fbec0ac175900cf3ce5a081517d309a476","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self._post_fork_event.clear()"},{"line_number":461,"context_line":"        self.sb_idl \u003d ovsdb.MetadataAgentOvnSbIdl("},{"line_number":462,"context_line":"            chassis\u003dself._chassis, tables\u003dtables, events\u003devents).start()"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # Now IDL connections can be safely used."},{"line_number":465,"context_line":"        self._post_fork_event.set()"}],"source_content_type":"text/x-python","patch_set":28,"id":"f91c23f2_2045ca4e","line":462,"in_reply_to":"e8d6ec3d_c0355d27","updated":"2024-03-14 10:02:27.000000000","message":"Done","commit_id":"fe31f4fe029388ffd393d94bb0899ee8d5632bf9"}],"neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1c05ddb86d1f4d9d87d1d300aff14083a0010933","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        # The agent has initialized with br-int and above list_br doesn\u0027t"},{"line_number":212,"context_line":"        # return it, hence the agent should trigger reconfiguration and store"},{"line_number":213,"context_line":"        # new br-new value to its attribute."},{"line_number":214,"context_line":"        self.assertEqual(self.OVN_BRIDGE, self.agent._ovn_bridge)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # NOTE: The IP address is specifically picked such that it fits the"},{"line_number":217,"context_line":"        # metadata port external_ids: { neutron:cidrs }. This is because agent"}],"source_content_type":"text/x-python","patch_set":25,"id":"47ae3711_7ce771a7","line":214,"updated":"2024-03-01 18:22:23.000000000","message":"Does this need to change? Shouldn\u0027t the @property for ovn_bridge return it? Same below.","commit_id":"9c84bada522db26f61f48c521a5e19595c0ca222"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"521575cbb2e965113efaa3e2c84159c8e8bff806","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        # The agent has initialized with br-int and above list_br doesn\u0027t"},{"line_number":212,"context_line":"        # return it, hence the agent should trigger reconfiguration and store"},{"line_number":213,"context_line":"        # new br-new value to its attribute."},{"line_number":214,"context_line":"        self.assertEqual(self.OVN_BRIDGE, self.agent._ovn_bridge)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # NOTE: The IP address is specifically picked such that it fits the"},{"line_number":217,"context_line":"        # metadata port external_ids: { neutron:cidrs }. This is because agent"}],"source_content_type":"text/x-python","patch_set":25,"id":"8b5b5613_641e7f39","line":214,"in_reply_to":"47ae3711_7ce771a7","updated":"2024-03-04 08:24:21.000000000","message":"Not really, I don\u0027t know why I changed it. Maybe that was done in a previous version before adding the @property.","commit_id":"9c84bada522db26f61f48c521a5e19595c0ca222"}],"neutron/tests/unit/agent/ovn/metadata/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1c05ddb86d1f4d9d87d1d300aff14083a0010933","unresolved":true,"context_lines":[{"line_number":501,"context_line":"        self.agent._load_config()"},{"line_number":502,"context_line":"        self.assertEqual(valid_uuid_str, self.agent.chassis)"},{"line_number":503,"context_line":"        self.assertEqual(uuid.UUID(valid_uuid_str), self.agent._chassis_id)"},{"line_number":504,"context_line":"        self.assertEqual(\u0027br-ovn\u0027, self.agent._ovn_bridge)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        # Chassis name non UUID formatted string. OVN bridge not defined,"},{"line_number":507,"context_line":"        # \"br-int\" assigned by default."}],"source_content_type":"text/x-python","patch_set":25,"id":"659738b9_e6e043dd","line":504,"updated":"2024-03-01 18:22:23.000000000","message":"Same comment on these and below.","commit_id":"9c84bada522db26f61f48c521a5e19595c0ca222"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"521575cbb2e965113efaa3e2c84159c8e8bff806","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        self.agent._load_config()"},{"line_number":502,"context_line":"        self.assertEqual(valid_uuid_str, self.agent.chassis)"},{"line_number":503,"context_line":"        self.assertEqual(uuid.UUID(valid_uuid_str), self.agent._chassis_id)"},{"line_number":504,"context_line":"        self.assertEqual(\u0027br-ovn\u0027, self.agent._ovn_bridge)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        # Chassis name non UUID formatted string. OVN bridge not defined,"},{"line_number":507,"context_line":"        # \"br-int\" assigned by default."}],"source_content_type":"text/x-python","patch_set":25,"id":"b93e67e3_ebfbf9b8","line":504,"in_reply_to":"659738b9_e6e043dd","updated":"2024-03-04 08:24:21.000000000","message":"Done","commit_id":"9c84bada522db26f61f48c521a5e19595c0ca222"}],"zuul.d/base.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b3effc52398a5c1dda4baa04d2a0d79d7c74e3d","unresolved":true,"context_lines":[{"line_number":270,"context_line":"              enable_ipset: false  # Not compatible with nftables"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"- job:"},{"line_number":273,"context_line":"    name: neutron-tempest-plugin-ovn-with-ovn-agent"},{"line_number":274,"context_line":"    parent: neutron-tempest-plugin-ovn"},{"line_number":275,"context_line":"    vars:"},{"line_number":276,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"8d045a7c_0442515b","line":273,"updated":"2024-02-22 09:48:01.000000000","message":"this job should be defined in the neutron-tempest-plugin repo IMO\n\nAnd second thing about it: basically metadata functionality is very simple and it is actually tested in all of the jobs like tempest-full etc. So maybe we can simply modify existing neutron-tempest-plugin-ovn job so it will use metadata extension and neutron-ovn-metadata-agent will be tested everywhere else. That way we will not have new job and we should have coverage for everything. Wdyt about it?","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"98b550061875220e31a91b4c64d72da2bb1968c1","unresolved":false,"context_lines":[{"line_number":270,"context_line":"              enable_ipset: false  # Not compatible with nftables"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"- job:"},{"line_number":273,"context_line":"    name: neutron-tempest-plugin-ovn-with-ovn-agent"},{"line_number":274,"context_line":"    parent: neutron-tempest-plugin-ovn"},{"line_number":275,"context_line":"    vars:"},{"line_number":276,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a65e0734_680affdc","line":273,"in_reply_to":"34ef9d98_3a267b21","updated":"2024-02-22 12:48:58.000000000","message":"Done","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7135b821f9b736c41ce90d0e80c7b45bca38d19c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"              enable_ipset: false  # Not compatible with nftables"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"- job:"},{"line_number":273,"context_line":"    name: neutron-tempest-plugin-ovn-with-ovn-agent"},{"line_number":274,"context_line":"    parent: neutron-tempest-plugin-ovn"},{"line_number":275,"context_line":"    vars:"},{"line_number":276,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f89736a8_e293eeac","line":273,"in_reply_to":"8d045a7c_0442515b","updated":"2024-02-22 11:45:07.000000000","message":"Once this patch is merged, I\u0027ll move the definition of this job to n-t-p. I can\u0027t push a n-t-p update before having the functionality in Neutron.","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb67a558cb945427a1943f06a9282f89482c3cc4","unresolved":true,"context_lines":[{"line_number":270,"context_line":"              enable_ipset: false  # Not compatible with nftables"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"- job:"},{"line_number":273,"context_line":"    name: neutron-tempest-plugin-ovn-with-ovn-agent"},{"line_number":274,"context_line":"    parent: neutron-tempest-plugin-ovn"},{"line_number":275,"context_line":"    vars:"},{"line_number":276,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"34ef9d98_3a267b21","line":273,"in_reply_to":"f89736a8_e293eeac","updated":"2024-02-22 11:50:35.000000000","message":"But You can have neutron-tempest-plugin now with depends-on pointing to this patch. That way it would be tested in the neutron-tempest-plugin patch and we can merge first one and later n-t-p patch","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"}],"zuul.d/project.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b3effc52398a5c1dda4baa04d2a0d79d7c74e3d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      - neutron-skip-level-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-tempest-plugin-ovn-with-ovn-agent"},{"line_number":22,"context_line":"        - neutron-functional-with-uwsgi"},{"line_number":23,"context_line":"        - neutron-fullstack-with-uwsgi"},{"line_number":24,"context_line":"        - neutron-ovs-grenade-multinode"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7fafe64c_3f703765","line":21,"updated":"2024-02-22 09:48:01.000000000","message":"this job could be part of the \"neutron-tempest-plugin-jobs\" template simply","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7135b821f9b736c41ce90d0e80c7b45bca38d19c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      - neutron-skip-level-jobs"},{"line_number":19,"context_line":"    check:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - neutron-tempest-plugin-ovn-with-ovn-agent"},{"line_number":22,"context_line":"        - neutron-functional-with-uwsgi"},{"line_number":23,"context_line":"        - neutron-fullstack-with-uwsgi"},{"line_number":24,"context_line":"        - neutron-ovs-grenade-multinode"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"10e58cc9_fe835b5b","line":21,"in_reply_to":"7fafe64c_3f703765","updated":"2024-02-22 11:45:07.000000000","message":"I will, for sure, once we have the functionality merged and running, I\u0027ll migrate this job to n-t-p from Neutron.","commit_id":"e04ce3db258f385ab9d82f472126d5d0bcd6e761"}]}