)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1d3e1da83e6d13360c1c8e2ed0fff6ee163c4c4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce3bac63_4cc1b2c8","updated":"2023-10-30 11:05:36.000000000","message":"Unit test failures seem related to the patch!","commit_id":"ffbaf38ebe7e925c7fbbd575e3c53e394690ecb9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d1484cb0599b05ed408596943fbc88874e3d7c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"beae6042_3b2cdfbc","in_reply_to":"ce3bac63_4cc1b2c8","updated":"2023-11-07 09:36:45.000000000","message":"thanks for checking","commit_id":"ffbaf38ebe7e925c7fbbd575e3c53e394690ecb9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"12bc2599d1c520a29f203270c51782781938cb02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1fdbdff6_5d1f1cfc","updated":"2023-11-30 09:39:59.000000000","message":"Finally I got back here","commit_id":"32256fbf82aae016bc484e3b6fd0841f84e1a24e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d05fef8018ac2c766defd22a860187e2598d425c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"575cc7fb_bccded37","updated":"2023-12-04 14:59:10.000000000","message":"Good catch! This should be backported up to Zed.","commit_id":"37384a4705e4ee1d8c044534459c9d48621dd537"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"41e3175747bc26f03328b837fff48a6a26a805b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f37294f1_cbdb998d","updated":"2023-12-11 10:57:47.000000000","message":"recheck\nfullstack timeout is not related and the tests passed","commit_id":"37384a4705e4ee1d8c044534459c9d48621dd537"}],"neutron/db/l3_db.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"a5526f1b13d0c4e3131d5ed7a4ad32ab25b87bf6","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_obj)"},{"line_number":1608,"context_line":"            old_fixed_port_id \u003d floatingip_obj.fixed_port_id"},{"line_number":1609,"context_line":"            assoc_result \u003d self._update_fip_assoc(context, fip, floatingip_obj)"},{"line_number":1610,"context_line":"            if self._is_fip_qos_supported and \u0027qos_policy_id\u0027 in fip:"},{"line_number":1611,"context_line":"                floatingip_obj.qos_policy_id \u003d fip.get(qos_const.QOS_POLICY_ID)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            floatingip_obj.update()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b774192_b9389f2c","line":1610,"range":{"start_line":1610,"start_character":62,"end_line":1610,"end_character":65},"updated":"2023-11-07 09:48:43.000000000","message":"nit: is this \"in\" or \u003d\u003d ? I think in would accept results like \u0027qos_policy_id123\u0027 and inputs like that.","commit_id":"d017e11478e0ee339526df1aa570d9c657dcd2b3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b5827d79df43e7d5912604ef83caef982af8c90a","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_obj)"},{"line_number":1608,"context_line":"            old_fixed_port_id \u003d floatingip_obj.fixed_port_id"},{"line_number":1609,"context_line":"            assoc_result \u003d self._update_fip_assoc(context, fip, floatingip_obj)"},{"line_number":1610,"context_line":"            if self._is_fip_qos_supported and \u0027qos_policy_id\u0027 in fip:"},{"line_number":1611,"context_line":"                floatingip_obj.qos_policy_id \u003d fip.get(qos_const.QOS_POLICY_ID)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            floatingip_obj.update()"}],"source_content_type":"text/x-python","patch_set":2,"id":"cbdd6a49_c1e601fa","line":1610,"range":{"start_line":1610,"start_character":62,"end_line":1610,"end_character":65},"in_reply_to":"1b774192_b9389f2c","updated":"2023-11-07 17:04:24.000000000","message":"fip actually is a dict so in here checks if qos_policy_id is among the keys of the dict.\nA terrible side of non-typed languages :-)","commit_id":"d017e11478e0ee339526df1aa570d9c657dcd2b3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a0e115a69a5ef59a0ba977f456d43a455e0205d1","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_obj)"},{"line_number":1608,"context_line":"            old_fixed_port_id \u003d floatingip_obj.fixed_port_id"},{"line_number":1609,"context_line":"            assoc_result \u003d self._update_fip_assoc(context, fip, floatingip_obj)"},{"line_number":1610,"context_line":"            if self._is_fip_qos_supported and \u0027qos_policy_id\u0027 in fip:"},{"line_number":1611,"context_line":"                floatingip_obj.qos_policy_id \u003d fip.get(qos_const.QOS_POLICY_ID)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            floatingip_obj.update()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd4cdc5a_ab1cad9d","line":1610,"range":{"start_line":1610,"start_character":62,"end_line":1610,"end_character":65},"in_reply_to":"cbdd6a49_c1e601fa","updated":"2023-12-08 09:46:55.000000000","message":"yeah, and keys in that dict are defined in the API definition so there shouldn\u0027t be anything like qos_policy_id123 there 😊","commit_id":"d017e11478e0ee339526df1aa570d9c657dcd2b3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f7dfa2e4fd0b72a1621805ceae0aceaae967d75","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_obj)"},{"line_number":1608,"context_line":"            old_fixed_port_id \u003d floatingip_obj.fixed_port_id"},{"line_number":1609,"context_line":"            assoc_result \u003d self._update_fip_assoc(context, fip, floatingip_obj)"},{"line_number":1610,"context_line":"            if self._is_fip_qos_supported and \u0027qos_policy_id\u0027 in fip:"},{"line_number":1611,"context_line":"                floatingip_obj.qos_policy_id \u003d fip.get(qos_const.QOS_POLICY_ID)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            floatingip_obj.update()"}],"source_content_type":"text/x-python","patch_set":10,"id":"74e2a87d_2b8353b3","line":1610,"range":{"start_line":1610,"start_character":47,"end_line":1610,"end_character":60},"updated":"2023-12-04 14:59:53.000000000","message":"nit: this could be qos_const.QOS_POLICY_ID","commit_id":"37384a4705e4ee1d8c044534459c9d48621dd537"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c4fa738e678099a5eb3566ee8118df1f689aee43","unresolved":true,"context_lines":[{"line_number":1608,"context_line":"            old_fixed_port_id \u003d floatingip_obj.fixed_port_id"},{"line_number":1609,"context_line":"            assoc_result \u003d self._update_fip_assoc(context, fip, floatingip_obj)"},{"line_number":1610,"context_line":"            if self._is_fip_qos_supported and \u0027qos_policy_id\u0027 in fip:"},{"line_number":1611,"context_line":"                floatingip_obj.qos_policy_id \u003d fip.get(qos_const.QOS_POLICY_ID)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"            floatingip_obj.update()"},{"line_number":1614,"context_line":"            floatingip_dict \u003d self._make_floatingip_dict(floatingip_obj)"}],"source_content_type":"text/x-python","patch_set":10,"id":"0d193380_d56a47a3","line":1611,"range":{"start_line":1611,"start_character":47,"end_line":1611,"end_character":79},"updated":"2023-12-04 16:18:23.000000000","message":"nit: and if you change the above this could also be fip[qos_const.QOS_POLICY_ID] now since we know the field is present","commit_id":"37384a4705e4ee1d8c044534459c9d48621dd537"}],"neutron/tests/unit/db/test_l3_db.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"12bc2599d1c520a29f203270c51782781938cb02","unresolved":true,"context_lines":[{"line_number":312,"context_line":"            id\u003dfip_id, qos_policy_id\u003dnew_qos_id, fixed_ip_address\u003dNone,"},{"line_number":313,"context_line":"            fixed_port_id\u003dNone, last_known_router_id\u003dNone, router_id\u003dNone"},{"line_number":314,"context_line":"        )"},{"line_number":315,"context_line":"        self.assertEquals(2, make_fip_dict.call_count)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # Remove the QoS Id (update to None):"},{"line_number":318,"context_line":"        make_fip_dict.reset_mock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"b10b9309_b98d6a3f","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":54},"updated":"2023-11-30 09:39:59.000000000","message":"I don\u0027t understand how the asserthascalls failed here, as the 2 calls were identical (at least I can\u0027t see the diff )","commit_id":"32256fbf82aae016bc484e3b6fd0841f84e1a24e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66fbf8155358fb539d1be508bee15364dcb4db7d","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            id\u003dfip_id, qos_policy_id\u003dqos_p_id"},{"line_number":264,"context_line":"        )"},{"line_number":265,"context_line":"        mock_update_fip_ovo.return_value \u003d None"},{"line_number":266,"context_line":"        mock_get_fip_ovo.retuen_value \u003d l3_obj.FloatingIP("},{"line_number":267,"context_line":"            id\u003dfip_id, qos_policy_id\u003dqos_p_id"},{"line_number":268,"context_line":"        )"},{"line_number":269,"context_line":"        make_fip_dict.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"820c4840_bd4b39bb","line":266,"range":{"start_line":266,"start_character":25,"end_line":266,"end_character":37},"updated":"2023-12-01 16:19:01.000000000","message":"s/return_value","commit_id":"1ae1c06285d079fa1cce5fbca7b9e4160c383a9d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b5b3aaee35bbd2865addafb42e207059a523a80b","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            id\u003dfip_id, qos_policy_id\u003dqos_p_id"},{"line_number":264,"context_line":"        )"},{"line_number":265,"context_line":"        mock_update_fip_ovo.return_value \u003d None"},{"line_number":266,"context_line":"        mock_get_fip_ovo.retuen_value \u003d l3_obj.FloatingIP("},{"line_number":267,"context_line":"            id\u003dfip_id, qos_policy_id\u003dqos_p_id"},{"line_number":268,"context_line":"        )"},{"line_number":269,"context_line":"        make_fip_dict.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"6e1b30f6_35f09bca","line":266,"range":{"start_line":266,"start_character":25,"end_line":266,"end_character":37},"in_reply_to":"820c4840_bd4b39bb","updated":"2023-12-04 15:37:40.000000000","message":"thanks, pep8 and this one..... I need some vacation I suppose.","commit_id":"1ae1c06285d079fa1cce5fbca7b9e4160c383a9d"}]}