)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7466edf64c231b3242dc3ae806813d8ca526b04c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d92550da_a312c2c3","updated":"2023-11-04 00:14:05.000000000","message":"This is a good idea. LGTM","commit_id":"d90433b42c9d230e155b72c3a1349f60a3db577b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"57ad94e297da8bda40174777c12a15e7deaa9640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c91c4609_087ad5cb","updated":"2023-11-05 05:05:10.000000000","message":"recheck unrelated failure","commit_id":"d90433b42c9d230e155b72c3a1349f60a3db577b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"480e1659102daa08b16acaa58f5fcad64061882d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"73e4def9_7f4d25eb","updated":"2023-11-07 20:15:37.000000000","message":"Michael approves the previous PS and nothing has really changed, lgtm.","commit_id":"a555a274e6ac0e444222cc5f34ed62fb888b27c5"}],"neutron/conf/services/extdns_designate_driver.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a3d1da9b4a89a8ef48b6fadf676a58b062b6719","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __call__(self, value):"},{"line_number":29,"context_line":"        value \u003d super(ZonePrefixIPv4, self).__call__(value)"},{"line_number":30,"context_line":"        if value % 8 !\u003d 0:"},{"line_number":31,"context_line":"            raise ValueError(_(\u0027Should be multiple of 8\u0027))"},{"line_number":32,"context_line":"        return value"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7cd7ebb7_d77d8294","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":26},"updated":"2023-11-07 10:19:47.000000000","message":"nit: you shoud use choices for ipv4","commit_id":"a555a274e6ac0e444222cc5f34ed62fb888b27c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c860c25e3f1420941779e03e19c3a94533d659ad","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __call__(self, value):"},{"line_number":29,"context_line":"        value \u003d super(ZonePrefixIPv4, self).__call__(value)"},{"line_number":30,"context_line":"        if value % 8 !\u003d 0:"},{"line_number":31,"context_line":"            raise ValueError(_(\u0027Should be multiple of 8\u0027))"},{"line_number":32,"context_line":"        return value"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b9b5b118_7b761c79","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":26},"in_reply_to":"7cd7ebb7_d77d8294","updated":"2023-11-07 10:54:13.000000000","message":"I initially thought to use choices(even for IPv6) but adding the choices property results in having the following comment block in the config file when I generate it by oslo-config-generator.\n\n```\n# Possible values:\n# 8 - \u003cNo description provided\u003e\n# 16 - \u003cNo description provided\u003e\n# 24 - \u003cNo description provided\u003e\n#ipv4_ptr_zone_prefix_size \u003d 24\n```\n\nI can probably consider adding description for IPv4, but I felt the rendered result still looks ugly, so I decided to use this own validation instead of choices field.","commit_id":"a555a274e6ac0e444222cc5f34ed62fb888b27c5"}],"neutron/services/externaldns/drivers/designate/driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08137689bea631c5fea63b45a9ec73881abbfbb4","unresolved":true,"context_lines":[{"line_number":28,"context_line":"from neutron.conf.services import extdns_designate_driver"},{"line_number":29,"context_line":"from neutron.services.externaldns import driver"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"IPV4_PTR_ZONE_PREFIX_MIN_SIZE \u003d 8"},{"line_number":32,"context_line":"IPV4_PTR_ZONE_PREFIX_MAX_SIZE \u003d 24"},{"line_number":33,"context_line":"IPV6_PTR_ZONE_PREFIX_MIN_SIZE \u003d 4"},{"line_number":34,"context_line":"IPV6_PTR_ZONE_PREFIX_MAX_SIZE \u003d 124"}],"source_content_type":"text/x-python","patch_set":3,"id":"29a2955f_554adb86","line":31,"updated":"2023-11-05 05:14:59.000000000","message":"these can be removed.","commit_id":"d90433b42c9d230e155b72c3a1349f60a3db577b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a222d3a6b94b29cc0a82e1ccec66bca817b4ce74","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.conf.services import extdns_designate_driver"},{"line_number":29,"context_line":"from neutron.services.externaldns import driver"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"IPV4_PTR_ZONE_PREFIX_MIN_SIZE \u003d 8"},{"line_number":32,"context_line":"IPV4_PTR_ZONE_PREFIX_MAX_SIZE \u003d 24"},{"line_number":33,"context_line":"IPV6_PTR_ZONE_PREFIX_MIN_SIZE \u003d 4"},{"line_number":34,"context_line":"IPV6_PTR_ZONE_PREFIX_MAX_SIZE \u003d 124"}],"source_content_type":"text/x-python","patch_set":3,"id":"8434828a_4b7acead","line":31,"in_reply_to":"29a2955f_554adb86","updated":"2023-11-05 05:15:49.000000000","message":"Done","commit_id":"d90433b42c9d230e155b72c3a1349f60a3db577b"}]}