)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9e7a69c3dbd4041abb198d4992370213911f1884","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Change the dns_exc.DNSDomainNotFound and"},{"line_number":10,"context_line":"dns_exc.DuplicateRecordSet exceptions to error log, for deletions"},{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ce8ba612_8b9ae524","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":16},"updated":"2024-02-06 17:02:35.000000000","message":"For both types of messages, change to...","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"46118ac8b8b97b090c0d6903ca73ab0b37a5db65","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change the dns_exc.DNSDomainNotFound and"},{"line_number":10,"context_line":"dns_exc.DuplicateRecordSet exceptions to error log, for deletions"},{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"50c864cc_8621a70c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"484cfcb2_fa7a7d22","updated":"2024-03-07 11:06:15.000000000","message":"Sorry, I completely missed the commit message in my head this was the release note.\n\nI changed the commit message to:\n\nChange non-harmful stack trace errors for dns_exc.DNSDomainNotFound and\ndns_exc.DuplicateRecordSe to error log messages. This prevents the logs\nfrom filling with stack traces where a error messages would have been\nsufficient enough.\n\nI hope this is sufficient and what we are looking for.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change the dns_exc.DNSDomainNotFound and"},{"line_number":10,"context_line":"dns_exc.DuplicateRecordSet exceptions to error log, for deletions"},{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ec9d5d76_cb2900ac","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"ce8ba612_8b9ae524","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4bdb2a239dcbab6beb9063fff03ff11122385a39","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change the dns_exc.DNSDomainNotFound and"},{"line_number":10,"context_line":"dns_exc.DuplicateRecordSet exceptions to error log, for deletions"},{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"484cfcb2_fa7a7d22","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"ec9d5d76_cb2900ac","updated":"2024-02-21 15:58:34.000000000","message":"it\u0027s not done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9e7a69c3dbd4041abb198d4992370213911f1884","unresolved":true,"context_lines":[{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2042925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"90cf4ddf_829460c6","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":48},"updated":"2024-02-06 17:02:35.000000000","message":"-\u003e error messages","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4bdb2a239dcbab6beb9063fff03ff11122385a39","unresolved":false,"context_lines":[{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2042925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"eb120005_4abdde0b","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":48},"in_reply_to":"21fbd674_07f0366d","updated":"2024-02-21 15:58:34.000000000","message":"it\u0027s not done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2042925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"21fbd674_07f0366d","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":48},"in_reply_to":"90cf4ddf_829460c6","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"46118ac8b8b97b090c0d6903ca73ab0b37a5db65","unresolved":false,"context_lines":[{"line_number":11,"context_line":"change the dns_exc.DNSDomainNotFound to warning messages. For both"},{"line_number":12,"context_line":"type of messaged changed to message with a new more generic message,"},{"line_number":13,"context_line":"instead of the exception messages. This prevents the logs from"},{"line_number":14,"context_line":"filling with stack traces where a error messages would have been"},{"line_number":15,"context_line":"sufficient enough."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2042925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"788b4abb_bdbf4448","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":48},"in_reply_to":"eb120005_4abdde0b","updated":"2024-03-07 11:06:15.000000000","message":"Fixed this with the new commit message.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ab7ca95b11721181d9d14ada2ce1223d23435d3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Change exception messages to error log messages for DNS integration."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change non-harmful stack trace errors for dns_exc.DNSDomainNotFound and"},{"line_number":10,"context_line":"dns_exc.DuplicateRecordSe to error log messages. This prevents the logs"},{"line_number":11,"context_line":"from filling with stack traces where error messages would have been"},{"line_number":12,"context_line":"sufficient enough."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ada921d3_145d2439","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":25},"updated":"2024-03-18 20:10:12.000000000","message":"RecordSet (note the missing `t`)","commit_id":"cfd0c1ab671cc6f6bcd65a533457370eba95c722"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"aed3a4d9c8392f2e7378cff257bab2faaecd5e0d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change exception messages to error log messages for DNS integration."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change non-harmful stack trace errors for dns_exc.DNSDomainNotFound and"},{"line_number":10,"context_line":"dns_exc.DuplicateRecordSe to error log messages. This prevents the logs"},{"line_number":11,"context_line":"from filling with stack traces where error messages would have been"},{"line_number":12,"context_line":"sufficient enough."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"55853a69_c75e0a6f","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":25},"in_reply_to":"ada921d3_145d2439","updated":"2024-03-26 11:05:07.000000000","message":"Fixed it","commit_id":"cfd0c1ab671cc6f6bcd65a533457370eba95c722"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"18c26288c868bca74283bce814e540718b0c0272","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa9e7672_c732bc42","updated":"2023-11-06 16:45:29.000000000","message":"Hi Jayce, is this something you wanted to backport to stable releases? If so you would need to file a bug, otherwise it seems like trivial change. I added Miguel since wrote this code originally.","commit_id":"d6406c1565cd97099a11e84430fb08c958c356ce"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"a4ef7007c894260fb10be1c9d98447ddc18c2ce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a467880_17934764","in_reply_to":"fa9e7672_c732bc42","updated":"2023-11-06 16:57:10.000000000","message":"That is indeed something that would be nice, I will file a bug report later.","commit_id":"d6406c1565cd97099a11e84430fb08c958c356ce"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e788e95244599c94b95d844f610799c70ae92eee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2274f162_0217cc5a","updated":"2023-11-07 17:00:12.000000000","message":"I think this needs a release note, since operators may need to adapt their log handling.","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"d0f478819764784a1fcd3890b4f96fb140e2656f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f2c43209_1f2a8d3d","in_reply_to":"2274f162_0217cc5a","updated":"2023-11-08 14:39:10.000000000","message":"I will add a release note with my next push.","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f4a5503ce3b2060731d9b8ccdacbe42de0cfc2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61fa66d7_1660356c","updated":"2023-11-08 21:18:00.000000000","message":"nit: neutron/services/externaldns/driver.py doesn\u0027t mention DNSDomainNotFound as a possible exception for delete_record_set but does for create_record_set right above it","commit_id":"5f03b8fd09f77cc40921eba66c6ed14594ba2316"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b3bf1bfe7d8e124711b08b10c87af046e3ab542f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7407d46f_73f109b5","updated":"2023-11-24 15:38:13.000000000","message":"How can I proceed with Zuul giving the errors? since the run before the last recheck run the neutron-ovs-grenade-multinode check was a success but last run it failed. Should i just do another recheck?","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9e7a69c3dbd4041abb198d4992370213911f1884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"963827d0_fb63af77","updated":"2024-02-06 17:02:35.000000000","message":"What Rodolfo said + release notes should be more readable.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c56e3904c33609c611629bc95f4f14d978db7591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1aaf7a4c_4bcb819e","updated":"2023-11-29 09:17:29.000000000","message":"recheck","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"3998d2398e2ac98f89fddec6831fa61052f33ade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7255f6ab_c097779d","updated":"2023-11-17 12:57:48.000000000","message":"recheck","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"45c03a1a4fb3a3f03b545ca3d5c0a55e834312e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"905216ed_310b25de","updated":"2023-11-24 11:56:11.000000000","message":"recheck","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"5d73f54292e68d1d09ccc2c561b5af1c48d97e28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"de82de55_7a4083d6","updated":"2024-01-31 10:47:51.000000000","message":"recheck","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c15305e622e469bcf2f7e8cc5c2862d348d6d6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0b65f230_10d6575e","updated":"2024-01-09 20:07:32.000000000","message":"recheck bump and get fresh logs","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4bdb2a239dcbab6beb9063fff03ff11122385a39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c187680e_9e380fd9","updated":"2024-02-21 15:58:34.000000000","message":"Let\u0027s do another round to fix typo in release note and commit message.","commit_id":"3fb57c50a9b825cab6c2df03239d370999ea9b81"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ab7ca95b11721181d9d14ada2ce1223d23435d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"31adaa06_07e9fc79","updated":"2024-03-18 20:10:12.000000000","message":"Whoever merges can edit the commit message before +Wing it.","commit_id":"cfd0c1ab671cc6f6bcd65a533457370eba95c722"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"7d53cf5c17cc53d22e25ebc4519a183e6c8ad866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b4f09e9a_110f32a4","updated":"2024-03-11 16:40:05.000000000","message":"recheck","commit_id":"cfd0c1ab671cc6f6bcd65a533457370eba95c722"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"4819829e516de45bc726fca1b6c696066ebb5e3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e1f1f6de_1759e423","updated":"2024-03-07 14:23:40.000000000","message":"recheck","commit_id":"cfd0c1ab671cc6f6bcd65a533457370eba95c722"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d67f63370184c1b06128a8e6fe310e7bb897d191","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5293dd08_1e04736c","updated":"2024-04-05 13:47:33.000000000","message":"Dict should be updated; or message.","commit_id":"6c8ff5e6970ec797bc46498c75c7240bf1a212ce"}],"neutron/db/dns_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            self.dns_driver.delete_record_set(context, dns_domain, dns_name,"},{"line_number":215,"context_line":"                                              ips)"},{"line_number":216,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":217,"context_line":"            LOG.warning(\"The DNS domain %(domain)s is not found. \""},{"line_number":218,"context_line":"                      \"Deletion of Floating IP record %(name)s from external \""},{"line_number":219,"context_line":"                      \"DNS service will be skipped.\","},{"line_number":220,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"50744b62_6fcec90b","line":217,"range":{"start_line":217,"start_character":51,"end_line":217,"end_character":53},"updated":"2023-11-15 01:00:08.000000000","message":"s/was","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            self.dns_driver.delete_record_set(context, dns_domain, dns_name,"},{"line_number":215,"context_line":"                                              ips)"},{"line_number":216,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":217,"context_line":"            LOG.warning(\"The DNS domain %(domain)s is not found. \""},{"line_number":218,"context_line":"                      \"Deletion of Floating IP record %(name)s from external \""},{"line_number":219,"context_line":"                      \"DNS service will be skipped.\","},{"line_number":220,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da70dc61_83abbce3","line":217,"range":{"start_line":217,"start_character":51,"end_line":217,"end_character":53},"in_reply_to":"50744b62_6fcec90b","updated":"2023-11-15 10:58:43.000000000","message":"Done","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":215,"context_line":"                                              ips)"},{"line_number":216,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":217,"context_line":"            LOG.warning(\"The DNS domain %(domain)s is not found. \""},{"line_number":218,"context_line":"                      \"Deletion of Floating IP record %(name)s from external \""},{"line_number":219,"context_line":"                      \"DNS service will be skipped.\","},{"line_number":220,"context_line":"                      {\"name\": dns_name,"},{"line_number":221,"context_line":"                       \"domain\": dns_domain})"}],"source_content_type":"text/x-python","patch_set":9,"id":"07c5174c_78431b1a","line":218,"updated":"2023-11-15 01:00:08.000000000","message":"nit: can you indent these to the same depth of the \" on the line above, basically like it was before.","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                                              ips)"},{"line_number":216,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":217,"context_line":"            LOG.warning(\"The DNS domain %(domain)s is not found. \""},{"line_number":218,"context_line":"                      \"Deletion of Floating IP record %(name)s from external \""},{"line_number":219,"context_line":"                      \"DNS service will be skipped.\","},{"line_number":220,"context_line":"                      {\"name\": dns_name,"},{"line_number":221,"context_line":"                       \"domain\": dns_domain})"}],"source_content_type":"text/x-python","patch_set":9,"id":"a079bb8e_c55e7bc4","line":218,"in_reply_to":"07c5174c_78431b1a","updated":"2023-11-15 10:58:43.000000000","message":"Done","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            self.dns_driver.create_record_set(context, dns_domain, dns_name,"},{"line_number":250,"context_line":"                                              ips)"},{"line_number":251,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":252,"context_line":"            LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":253,"context_line":"                      \"Creation of Floating IP record %(name)s from external \""},{"line_number":254,"context_line":"                      \"DNS service will be skipped.\","},{"line_number":255,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"4348d083_57b9fb59","line":252,"range":{"start_line":252,"start_character":49,"end_line":252,"end_character":51},"updated":"2023-11-15 01:00:08.000000000","message":"s/was","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            self.dns_driver.create_record_set(context, dns_domain, dns_name,"},{"line_number":250,"context_line":"                                              ips)"},{"line_number":251,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":252,"context_line":"            LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":253,"context_line":"                      \"Creation of Floating IP record %(name)s from external \""},{"line_number":254,"context_line":"                      \"DNS service will be skipped.\","},{"line_number":255,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"563a1078_8d851187","line":252,"range":{"start_line":252,"start_character":49,"end_line":252,"end_character":51},"in_reply_to":"4348d083_57b9fb59","updated":"2023-11-15 10:58:43.000000000","message":"Done","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                      {\"name\": dns_name,"},{"line_number":256,"context_line":"                       \"domain\": dns_domain})"},{"line_number":257,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":258,"context_line":"            LOG.error(\"A Floating IP record for %(name)s in domain %(domain)s \""},{"line_number":259,"context_line":"                      \"already exists. record creation in external DNS \""},{"line_number":260,"context_line":"                      \"service will be skipped.\","},{"line_number":261,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"13350789_4d81f5ab","line":258,"updated":"2023-11-15 01:00:08.000000000","message":"In this case was it created properly since it already existed? If so then based on comments this should be LOG.warning","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                      {\"name\": dns_name,"},{"line_number":256,"context_line":"                       \"domain\": dns_domain})"},{"line_number":257,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":258,"context_line":"            LOG.error(\"A Floating IP record for %(name)s in domain %(domain)s \""},{"line_number":259,"context_line":"                      \"already exists. record creation in external DNS \""},{"line_number":260,"context_line":"                      \"service will be skipped.\","},{"line_number":261,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"f258ab5a_797b7ad8","line":258,"in_reply_to":"13350789_4d81f5ab","updated":"2023-11-15 10:58:43.000000000","message":"You can\u0027t be certain it was created properly since the IP in the recordset might be different then the Floating IP.","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            self.dns_driver.delete_record_set(context, dns_domain, dns_name,"},{"line_number":215,"context_line":"                                              ips)"},{"line_number":216,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":217,"context_line":"            LOG.warning(\"The DNS domain %(domain)s was not found. Deletion \""},{"line_number":218,"context_line":"                        \"of Floating IP record %(name)s from external DNS \""},{"line_number":219,"context_line":"                        \"service will be skipped.\","},{"line_number":220,"context_line":"                        {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"116c8e8a_efe1459d","line":217,"updated":"2024-02-05 09:28:06.000000000","message":"same comment: Error deleting floating IP data from external DNS service. The DNS domain () was not found...","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            self.dns_driver.delete_record_set(context, dns_domain, dns_name,"},{"line_number":215,"context_line":"                                              ips)"},{"line_number":216,"context_line":"        except dns_exc.DNSDomainNotFound:"},{"line_number":217,"context_line":"            LOG.warning(\"The DNS domain %(domain)s was not found. Deletion \""},{"line_number":218,"context_line":"                        \"of Floating IP record %(name)s from external DNS \""},{"line_number":219,"context_line":"                        \"service will be skipped.\","},{"line_number":220,"context_line":"                        {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"d436c493_5df00b9c","line":217,"in_reply_to":"116c8e8a_efe1459d","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                         \"domain\": dns_domain})"},{"line_number":222,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":223,"context_line":"            LOG.error(\"Duplicate Floating IP records for %(name)s in domain \""},{"line_number":224,"context_line":"                      \"%(domain)s were found. record deletion in external DNS \""},{"line_number":225,"context_line":"                      \"service will be skipped.\","},{"line_number":226,"context_line":"                      {\"name\": dns_name,"},{"line_number":227,"context_line":"                       \"domain\": dns_domain})"}],"source_content_type":"text/x-python","patch_set":10,"id":"00bc43c9_7ab9fc2c","line":224,"range":{"start_line":224,"start_character":46,"end_line":224,"end_character":47},"updated":"2024-02-05 09:28:06.000000000","message":"s/r/R","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                         \"domain\": dns_domain})"},{"line_number":222,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":223,"context_line":"            LOG.error(\"Duplicate Floating IP records for %(name)s in domain \""},{"line_number":224,"context_line":"                      \"%(domain)s were found. record deletion in external DNS \""},{"line_number":225,"context_line":"                      \"service will be skipped.\","},{"line_number":226,"context_line":"                      {\"name\": dns_name,"},{"line_number":227,"context_line":"                       \"domain\": dns_domain})"}],"source_content_type":"text/x-python","patch_set":10,"id":"4e03f393_134db500","line":224,"range":{"start_line":224,"start_character":46,"end_line":224,"end_character":47},"in_reply_to":"00bc43c9_7ab9fc2c","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4bdb2a239dcbab6beb9063fff03ff11122385a39","unresolved":true,"context_lines":[{"line_number":220,"context_line":"                      {\"name\": dns_name,"},{"line_number":221,"context_line":"                       \"domain\": dns_domain})"},{"line_number":222,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":223,"context_line":"            LOG.error(\"Error deleting Floating IP data from external DNS \""},{"line_number":224,"context_line":"                      \"service. Duplicate Floating IP records for %(name)s in \""},{"line_number":225,"context_line":"                      \"domain %(domain)s were found.\","},{"line_number":226,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"feda5281_a5282d3c","line":223,"range":{"start_line":223,"start_character":50,"end_line":223,"end_character":54},"updated":"2024-02-21 15:58:34.000000000","message":"is there a reason why it\u0027s \"FIP record\" above but \"FIP data\" here?","commit_id":"3fb57c50a9b825cab6c2df03239d370999ea9b81"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"46118ac8b8b97b090c0d6903ca73ab0b37a5db65","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                      {\"name\": dns_name,"},{"line_number":221,"context_line":"                       \"domain\": dns_domain})"},{"line_number":222,"context_line":"        except dns_exc.DuplicateRecordSet:"},{"line_number":223,"context_line":"            LOG.error(\"Error deleting Floating IP data from external DNS \""},{"line_number":224,"context_line":"                      \"service. Duplicate Floating IP records for %(name)s in \""},{"line_number":225,"context_line":"                      \"domain %(domain)s were found.\","},{"line_number":226,"context_line":"                      {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"24e03090_e54ff2b9","line":223,"range":{"start_line":223,"start_character":50,"end_line":223,"end_character":54},"in_reply_to":"feda5281_a5282d3c","updated":"2024-03-07 11:06:15.000000000","message":"No there is not, my next push will change this into record instead of data.","commit_id":"3fb57c50a9b825cab6c2df03239d370999ea9b81"}],"neutron/plugins/ml2/extensions/dns_integration.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"18c26288c868bca74283bce814e540718b0c0272","unresolved":true,"context_lines":[{"line_number":498,"context_line":"                                           dns_name, records):"},{"line_number":499,"context_line":"    try:"},{"line_number":500,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":501,"context_line":"    except dns_exc.DNSDomainNotFound as e:"},{"line_number":502,"context_line":"        LOG.warning(\"Error deleting port data from external DNS \""},{"line_number":503,"context_line":"                      \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":504,"context_line":"                      \"IP addresses \u0027%(ips)s\u0027. DNS service driver message \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9e0870ee_e33c77a7","line":501,"updated":"2023-11-06 16:45:29.000000000","message":"So it can never throw a DuplicateRecordSet on delete? Just wondering since the commit message doesn\u0027t mention this.","commit_id":"d6406c1565cd97099a11e84430fb08c958c356ce"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"a4ef7007c894260fb10be1c9d98447ddc18c2ce4","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                                           dns_name, records):"},{"line_number":499,"context_line":"    try:"},{"line_number":500,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":501,"context_line":"    except dns_exc.DNSDomainNotFound as e:"},{"line_number":502,"context_line":"        LOG.warning(\"Error deleting port data from external DNS \""},{"line_number":503,"context_line":"                      \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":504,"context_line":"                      \"IP addresses \u0027%(ips)s\u0027. DNS service driver message \""}],"source_content_type":"text/x-python","patch_set":1,"id":"375c0e4d_8e7d05cd","line":501,"in_reply_to":"9e0870ee_e33c77a7","updated":"2023-11-06 16:57:10.000000000","message":"Good point Brian, I wanted to push that in another change but I accidentally forgot to remove the change. But indeed duplicate recordsets cannot exist since the DuplicateRecordSet is already thrown on a creation, and for example Designate also does not allow DuplicateRecordSets to exist. I will change the description to include this.","commit_id":"d6406c1565cd97099a11e84430fb08c958c356ce"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e788e95244599c94b95d844f610799c70ae92eee","unresolved":true,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except (dns_exc.DNSDomainNotFound, dns_exc.DuplicateRecordSet) as e:"},{"line_number":489,"context_line":"        LOG.warning(\"Error publishing port data in external DNS \""},{"line_number":490,"context_line":"                    \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":491,"context_line":"                    \"DNS service driver message \u0027%(message)s\u0027\","},{"line_number":492,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc0970fd_5c097319","line":489,"range":{"start_line":489,"start_character":12,"end_line":489,"end_character":19},"updated":"2023-11-07 17:00:12.000000000","message":"An error is an error, so IMO LOG.error would fit better","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"d0f478819764784a1fcd3890b4f96fb140e2656f","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except (dns_exc.DNSDomainNotFound, dns_exc.DuplicateRecordSet) as e:"},{"line_number":489,"context_line":"        LOG.warning(\"Error publishing port data in external DNS \""},{"line_number":490,"context_line":"                    \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":491,"context_line":"                    \"DNS service driver message \u0027%(message)s\u0027\","},{"line_number":492,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e3cc92a4_429c1eff","line":489,"range":{"start_line":489,"start_character":12,"end_line":489,"end_character":19},"in_reply_to":"22a68a02_c9ee577b","updated":"2023-11-08 14:39:10.000000000","message":"I will push change the LOG.warning to LOG.error I will also change the error messages a bit.","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13a943187b0d8fadc27169288e3f38af98b3558b","unresolved":true,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except (dns_exc.DNSDomainNotFound, dns_exc.DuplicateRecordSet) as e:"},{"line_number":489,"context_line":"        LOG.warning(\"Error publishing port data in external DNS \""},{"line_number":490,"context_line":"                    \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":491,"context_line":"                    \"DNS service driver message \u0027%(message)s\u0027\","},{"line_number":492,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"22a68a02_c9ee577b","line":489,"range":{"start_line":489,"start_character":12,"end_line":489,"end_character":19},"in_reply_to":"fc0970fd_5c097319","updated":"2023-11-07 17:18:18.000000000","message":"I agree with frickler and for me creation failure looks like a real error which operators have to be careful about.","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13a943187b0d8fadc27169288e3f38af98b3558b","unresolved":true,"context_lines":[{"line_number":499,"context_line":"    try:"},{"line_number":500,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":501,"context_line":"    except dns_exc.DNSDomainNotFound as e:"},{"line_number":502,"context_line":"        LOG.warning(\"Error deleting port data from external DNS \""},{"line_number":503,"context_line":"                    \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":504,"context_line":"                    \"IP addresses \u0027%(ips)s\u0027. DNS service driver message \""},{"line_number":505,"context_line":"                    \"\u0027%(message)s\u0027\","}],"source_content_type":"text/x-python","patch_set":4,"id":"84b4a498_81949737","line":502,"updated":"2023-11-07 17:18:18.000000000","message":"If this is not an error then it\u0027s better to update this message.\n\n```\nThe DNS domain $(domain)s is not found. Deletion of recordset %(name)s from external DNS service will be skipped.\n```\n\nI\u0027m not too sure about the benefit of showing the exception message here, because the situation may be quite apparent but please correct me if I\u0027m wrong.","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"d0f478819764784a1fcd3890b4f96fb140e2656f","unresolved":false,"context_lines":[{"line_number":499,"context_line":"    try:"},{"line_number":500,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":501,"context_line":"    except dns_exc.DNSDomainNotFound as e:"},{"line_number":502,"context_line":"        LOG.warning(\"Error deleting port data from external DNS \""},{"line_number":503,"context_line":"                    \"service. Name: \u0027%(name)s\u0027. Domain: \u0027%(domain)s\u0027. \""},{"line_number":504,"context_line":"                    \"IP addresses \u0027%(ips)s\u0027. DNS service driver message \""},{"line_number":505,"context_line":"                    \"\u0027%(message)s\u0027\","}],"source_content_type":"text/x-python","patch_set":4,"id":"07d5d6c2_b6bc7571","line":502,"in_reply_to":"84b4a498_81949737","updated":"2023-11-08 14:39:10.000000000","message":"I agree with you, I will push a change which handles the exceptions apart from each other, that way the exception message (in text) can be removed and more generic error messages can be used.","commit_id":"e49d0d3622974ee494fb4c6d1cca8e0b1cf14c7d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f4a5503ce3b2060731d9b8ccdacbe42de0cfc2d","unresolved":true,"context_lines":[{"line_number":508,"context_line":"                  \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                  {\"name\": dns_name,"},{"line_number":511,"context_line":"                   \"domain\": dns_domain})"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"def _update_port_in_external_dns_service(resource, event, trigger, payload):"}],"source_content_type":"text/x-python","patch_set":6,"id":"4d6de770_cbe0d12e","line":511,"updated":"2023-11-08 21:18:00.000000000","message":"neutron/db/dns_db.py _delete_floatingip_from_external_dns_service() has the same issue as this - will catch duplicate record set. I suppose it needs a similar change?","commit_id":"5f03b8fd09f77cc40921eba66c6ed14594ba2316"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"d95d3ea18fdc64f93a2f7c497f40c919050823ae","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                  \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                  {\"name\": dns_name,"},{"line_number":511,"context_line":"                   \"domain\": dns_domain})"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"def _update_port_in_external_dns_service(resource, event, trigger, payload):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a4993a55_58f0894b","line":511,"in_reply_to":"4d6de770_cbe0d12e","updated":"2023-11-10 13:13:51.000000000","message":"Indeed, I just pushed a new patchset which includes _delete_floatingip_from_external_dns_service and _add_ips_to_external_dns_service in neutron/db/dns_db.py.","commit_id":"5f03b8fd09f77cc40921eba66c6ed14594ba2316"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d7cd01a3c9f9c85802de8792c4769309426ae516","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":508,"context_line":"                  \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7ea383a8_efa9c4d0","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":17},"updated":"2023-11-13 15:44:29.000000000","message":"among the 4 cases being changed, this one might be only a candidate for warning level, because operators can do nothing about this, but I\u0027m ok with the error level as well, if that still works for you.","commit_id":"84691bb0a501df7b376faec1335119e830afb696"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"dcb6460a9b9d76de8899a4e3f92816638988d5f0","unresolved":true,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":508,"context_line":"                  \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ac51b9f3_8e0c5114","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":17},"in_reply_to":"7ea383a8_efa9c4d0","updated":"2023-11-13 16:22:12.000000000","message":"I agree with you, but I do think this should then be changed to warning for the DNSDomainNotFound exception in _remove_data_from_external_dns_service (neutron/plugins/ml2/extensions/dns_integration.py) and also in _delete_floatingip_from_external_dns_service (neutron/db/dns_db.py), what do you think about it?","commit_id":"84691bb0a501df7b376faec1335119e830afb696"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"9c6be3dea5a94e23eae147893da67ece51e706a5","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":508,"context_line":"                  \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"6acad1bd_d771de1f","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":17},"in_reply_to":"89c00c05_d46651b6","updated":"2023-11-14 11:48:54.000000000","message":"I agree with your perspective. I will modify the deletions to warnings messages for \u0027dns_exc.DNSDomainNotFound\u0027 errors. I will keep the other error messages in place.","commit_id":"84691bb0a501df7b376faec1335119e830afb696"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90320f0a02091904e15da8cede706453419620bb","unresolved":true,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":508,"context_line":"                  \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"89c00c05_d46651b6","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":17},"in_reply_to":"ac51b9f3_8e0c5114","updated":"2023-11-13 16:49:34.000000000","message":"IMO we should select the log level according to the impact of the failure.\n\nIn case of creation failure\n- If the resource was created properly then the log can be warning\n- If the resource was NOT created properly then the log should be error\n\nIn case of deletion failure\n- If the resource was deleted or does not exist then the log can be warning\n- If the resource could be left then the log should be error\n\nIIUC if the associated DNS domain is not found, we can assume the records in the domain does not exist. Then DNSDmainNotFound can be treated as warning when deleting a recordset, IMO, according to the rule above.\nOn the other hand if we assume the resource is not in the desired state then the log should be error level, as I mentioned earlier for creation failure.\n\nOne more important point is whether the error can be a user error instead of a system error. If the issue indicates wrong input by user instead of system error then it might make sense to use less critical level such as warning, but for it\u0027s not clear if the error is always caused by user errors so this point might not be valid for this specific case.","commit_id":"84691bb0a501df7b376faec1335119e830afb696"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d7cd01a3c9f9c85802de8792c4769309426ae516","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                  {\"name\": dns_name,"},{"line_number":511,"context_line":"                   \"domain\": dns_domain})"},{"line_number":512,"context_line":"    except dns_exc.DuplicateRecordSet:"},{"line_number":513,"context_line":"        LOG.error(\"A duplicate recordset for %(name)s in domain \""},{"line_number":514,"context_line":"                  \"%(domain)s was found. record deletion in external DNS \""},{"line_number":515,"context_line":"                  \"service will be skipped.\","},{"line_number":516,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"36ae3e58_6ea15c1f","line":513,"range":{"start_line":513,"start_character":19,"end_line":513,"end_character":40},"updated":"2023-11-13 15:44:29.000000000","message":"(nit) `Duplicate recordsets for %(name)s in domain %(domain)s were found.` (plural) might be better.","commit_id":"84691bb0a501df7b376faec1335119e830afb696"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"dcb6460a9b9d76de8899a4e3f92816638988d5f0","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                  {\"name\": dns_name,"},{"line_number":511,"context_line":"                   \"domain\": dns_domain})"},{"line_number":512,"context_line":"    except dns_exc.DuplicateRecordSet:"},{"line_number":513,"context_line":"        LOG.error(\"A duplicate recordset for %(name)s in domain \""},{"line_number":514,"context_line":"                  \"%(domain)s was found. record deletion in external DNS \""},{"line_number":515,"context_line":"                  \"service will be skipped.\","},{"line_number":516,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"84f5475e_c7708452","line":513,"range":{"start_line":513,"start_character":19,"end_line":513,"end_character":40},"in_reply_to":"36ae3e58_6ea15c1f","updated":"2023-11-13 16:22:12.000000000","message":"Ah yes, I will fix this with my next push 😄.","commit_id":"84691bb0a501df7b376faec1335119e830afb696"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":489,"context_line":"        LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":490,"context_line":"                  \"Creation of recordset %(name)s from external \""},{"line_number":491,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":492,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"135a9b4b_bb1c9e36","line":489,"range":{"start_line":489,"start_character":45,"end_line":489,"end_character":47},"updated":"2023-11-15 01:00:08.000000000","message":"s/was","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":489,"context_line":"        LOG.error(\"The DNS domain %(domain)s is not found. \""},{"line_number":490,"context_line":"                  \"Creation of recordset %(name)s from external \""},{"line_number":491,"context_line":"                  \"DNS service will be skipped.\","},{"line_number":492,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"8195d74d_1bbd7730","line":489,"range":{"start_line":489,"start_character":45,"end_line":489,"end_character":47},"in_reply_to":"135a9b4b_bb1c9e36","updated":"2023-11-15 10:58:43.000000000","message":"Done","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":492,"context_line":"                  {\"name\": dns_name,"},{"line_number":493,"context_line":"                   \"domain\": dns_domain})"},{"line_number":494,"context_line":"    except dns_exc.DuplicateRecordSet:"},{"line_number":495,"context_line":"        LOG.error(\"A recordset for %(name)s in domain %(domain)s \""},{"line_number":496,"context_line":"                  \"already exists. Recordset creation in external DNS \""},{"line_number":497,"context_line":"                  \"service will be skipped.\","},{"line_number":498,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"0dbc57f4_f2bf4ad8","line":495,"updated":"2023-11-15 01:00:08.000000000","message":"Same comment as other file","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                  {\"name\": dns_name,"},{"line_number":493,"context_line":"                   \"domain\": dns_domain})"},{"line_number":494,"context_line":"    except dns_exc.DuplicateRecordSet:"},{"line_number":495,"context_line":"        LOG.error(\"A recordset for %(name)s in domain %(domain)s \""},{"line_number":496,"context_line":"                  \"already exists. Recordset creation in external DNS \""},{"line_number":497,"context_line":"                  \"service will be skipped.\","},{"line_number":498,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"f0b50e49_c4b7868e","line":495,"in_reply_to":"0dbc57f4_f2bf4ad8","updated":"2023-11-15 10:58:43.000000000","message":"You can\u0027t be certain it was created properly since the IP in the recordset might have an different then the IP you are trying to assign to the recordset.","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.warning(\"The DNS domain %(domain)s is not found. \""},{"line_number":508,"context_line":"                    \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                    \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9e22cb32_d364dc41","line":507,"range":{"start_line":507,"start_character":47,"end_line":507,"end_character":49},"updated":"2023-11-15 01:00:08.000000000","message":"s/was","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.warning(\"The DNS domain %(domain)s is not found. \""},{"line_number":508,"context_line":"                    \"Deletion of recordset %(name)s from external \""},{"line_number":509,"context_line":"                    \"DNS service will be skipped.\","},{"line_number":510,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"db85140b_5513a629","line":507,"range":{"start_line":507,"start_character":47,"end_line":507,"end_character":49},"in_reply_to":"9e22cb32_d364dc41","updated":"2023-11-15 10:58:43.000000000","message":"Done","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":489,"context_line":"        LOG.error(\"The DNS domain %(domain)s was not found. Creation \""},{"line_number":490,"context_line":"                  \"of recordset %(name)s from external DNS service \""},{"line_number":491,"context_line":"                  \"will be skipped.\","},{"line_number":492,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"196aa355_ac2fb595","line":489,"range":{"start_line":489,"start_character":18,"end_line":489,"end_character":19},"updated":"2024-02-05 09:28:06.000000000","message":"You should also report the action that was executed (as in the previous message): Error publishing port data","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    try:"},{"line_number":487,"context_line":"        dns_driver.create_record_set(context, dns_domain, dns_name, records)"},{"line_number":488,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":489,"context_line":"        LOG.error(\"The DNS domain %(domain)s was not found. Creation \""},{"line_number":490,"context_line":"                  \"of recordset %(name)s from external DNS service \""},{"line_number":491,"context_line":"                  \"will be skipped.\","},{"line_number":492,"context_line":"                  {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"091e5e82_1115407d","line":489,"range":{"start_line":489,"start_character":18,"end_line":489,"end_character":19},"in_reply_to":"196aa355_ac2fb595","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.warning(\"The DNS domain %(domain)s was not found. Deletion \""},{"line_number":508,"context_line":"                    \"of recordset %(name)s from external DNS service \""},{"line_number":509,"context_line":"                    \"will be skipped.\","},{"line_number":510,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9bc96766_633a1505","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":19},"updated":"2024-02-05 09:28:06.000000000","message":"Why warning and not error?","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.warning(\"The DNS domain %(domain)s was not found. Deletion \""},{"line_number":508,"context_line":"                    \"of recordset %(name)s from external DNS service \""},{"line_number":509,"context_line":"                    \"will be skipped.\","},{"line_number":510,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"32ab4ec7_63e5aa57","line":507,"updated":"2024-02-05 09:28:06.000000000","message":"ditto: Error deleting port data from external DNS service","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.warning(\"The DNS domain %(domain)s was not found. Deletion \""},{"line_number":508,"context_line":"                    \"of recordset %(name)s from external DNS service \""},{"line_number":509,"context_line":"                    \"will be skipped.\","},{"line_number":510,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8957d981_66b6a38c","line":507,"in_reply_to":"32ab4ec7_63e5aa57","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    try:"},{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.warning(\"The DNS domain %(domain)s was not found. Deletion \""},{"line_number":508,"context_line":"                    \"of recordset %(name)s from external DNS service \""},{"line_number":509,"context_line":"                    \"will be skipped.\","},{"line_number":510,"context_line":"                    {\"name\": dns_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"d86eb7f3_126c0716","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":19},"in_reply_to":"9bc96766_633a1505","updated":"2024-02-20 16:22:19.000000000","message":"I chose to use warning instead of error because a user might not have a DNS Domain setup in their project. Meanly I used warning because I thought that would fit better since this is mostly an user error not an error caused by the system. I have changed it to error now.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b365338360a1785346e604253e85a2d9c08ea265","unresolved":true,"context_lines":[{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.error(\"Error deleting port data from external DNS service. \""},{"line_number":508,"context_line":"                  \"The DNS domain %(domain)s was not found.\","},{"line_number":509,"context_line":"                  {\"name\": dns_name,"},{"line_number":510,"context_line":"                   \"domain\": dns_domain})"},{"line_number":511,"context_line":"    except dns_exc.DuplicateRecordSet:"}],"source_content_type":"text/x-python","patch_set":15,"id":"85239b45_1fb4c950","line":508,"updated":"2024-03-26 15:13:57.000000000","message":"This has no %(name)s variable, if that was intentional then the key should be removed from the dictionary.","commit_id":"6c8ff5e6970ec797bc46498c75c7240bf1a212ce"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"bf8e807555038fd8ffe3e259cc826be48d705829","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        dns_driver.delete_record_set(context, dns_domain, dns_name, records)"},{"line_number":506,"context_line":"    except dns_exc.DNSDomainNotFound:"},{"line_number":507,"context_line":"        LOG.error(\"Error deleting port data from external DNS service. \""},{"line_number":508,"context_line":"                  \"The DNS domain %(domain)s was not found.\","},{"line_number":509,"context_line":"                  {\"name\": dns_name,"},{"line_number":510,"context_line":"                   \"domain\": dns_domain})"},{"line_number":511,"context_line":"    except dns_exc.DuplicateRecordSet:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5604f090_da0ec4da","line":508,"in_reply_to":"85239b45_1fb4c950","updated":"2024-04-10 15:07:47.000000000","message":"I changed the dictionary, it appears this isn\u0027t my best run for upstreaming changes 😞.","commit_id":"6c8ff5e6970ec797bc46498c75c7240bf1a212ce"}],"releasenotes/notes/change-dns-integration-logging-from-exception-to-error-7927d91f915046c3.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f4a5503ce3b2060731d9b8ccdacbe42de0cfc2d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    would have been sufficient enough. The error messages have also been changed to more generic messages."},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Removed catching of the exception dns_exc.DuplicateRecordSet from _remove_data_from_external_dns_service"},{"line_number":9,"context_line":"    since a duplicate recordset should not exist in the first place whilst removing."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"151338d9_5cc073b2","line":9,"updated":"2023-11-08 21:18:00.000000000","message":"I guess the messages seem fine, can you just fix the wrapping?","commit_id":"5f03b8fd09f77cc40921eba66c6ed14594ba2316"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"d95d3ea18fdc64f93a2f7c497f40c919050823ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    would have been sufficient enough. The error messages have also been changed to more generic messages."},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Removed catching of the exception dns_exc.DuplicateRecordSet from _remove_data_from_external_dns_service"},{"line_number":9,"context_line":"    since a duplicate recordset should not exist in the first place whilst removing."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e220d675_d6412ba5","line":9,"in_reply_to":"151338d9_5cc073b2","updated":"2023-11-10 13:13:51.000000000","message":"Just pushed a new patchset, which should fix this","commit_id":"5f03b8fd09f77cc40921eba66c6ed14594ba2316"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"773150a725898117912b893001a44ab1ab4bf595","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    deletion of a record set. This prevents the logs from filling"},{"line_number":8,"context_line":"    with stack traces where an error log messages would have been"},{"line_number":9,"context_line":"    sufficient enough. The error messages have also been changed to more"},{"line_number":10,"context_line":"    generic messages."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"84c6d74d_775d0b5e","line":10,"updated":"2023-11-15 01:00:08.000000000","message":"This note might have to change based on any changes you do","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"b57aaf900f98f56586d011b5e57314a3b775f102","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    deletion of a record set. This prevents the logs from filling"},{"line_number":8,"context_line":"    with stack traces where an error log messages would have been"},{"line_number":9,"context_line":"    sufficient enough. The error messages have also been changed to more"},{"line_number":10,"context_line":"    generic messages."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f7e0bee9_f85279a3","line":10,"in_reply_to":"84c6d74d_775d0b5e","updated":"2023-11-15 10:58:43.000000000","message":"Done","commit_id":"ead56ef2ab8bbae48c03bbaaa5a02a06e2c119cc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9e7a69c3dbd4041abb198d4992370213911f1884","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changed dns_exc.DuplicateRecordSet exception to error log messages"},{"line_number":5,"context_line":"    instead of exception messages. Changed dns_exc.DNSDomainNotFound"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e367faeb_59f5a1e6","line":2,"updated":"2024-02-06 17:02:35.000000000","message":"This should probably be a `fixes` section, and it should not give details about particular exception type names etc. Just say that \"Non-harmful stack trace errors cleaned from DNS integration plugin.\"\n\nAdmins reading it don\u0027t need these details.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changed dns_exc.DuplicateRecordSet exception to error log messages"},{"line_number":5,"context_line":"    instead of exception messages. Changed dns_exc.DNSDomainNotFound"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b9186c3e_9e24e0df","line":2,"in_reply_to":"e367faeb_59f5a1e6","updated":"2024-02-20 16:22:19.000000000","message":"Done","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changed dns_exc.DuplicateRecordSet exception to error log messages"},{"line_number":5,"context_line":"    instead of exception messages. Changed dns_exc.DNSDomainNotFound"},{"line_number":6,"context_line":"    to error messages on creation of a recordset and to warning on"},{"line_number":7,"context_line":"    deletion of a recordset. This prevents the logs from filling with"},{"line_number":8,"context_line":"    stack traces where an warning or error log messages would have been"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"eb7ff964_5cf386ae","line":5,"range":{"start_line":4,"start_character":39,"end_line":5,"end_character":33},"updated":"2024-02-05 09:28:06.000000000","message":"Why?","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changed dns_exc.DuplicateRecordSet exception to error log messages"},{"line_number":5,"context_line":"    instead of exception messages. Changed dns_exc.DNSDomainNotFound"},{"line_number":6,"context_line":"    to error messages on creation of a recordset and to warning on"},{"line_number":7,"context_line":"    deletion of a recordset. This prevents the logs from filling with"},{"line_number":8,"context_line":"    stack traces where an warning or error log messages would have been"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a8ebdf41_ea2377fd","line":5,"range":{"start_line":4,"start_character":39,"end_line":5,"end_character":33},"in_reply_to":"eb7ff964_5cf386ae","updated":"2024-02-20 16:22:19.000000000","message":"I changed the note to a simpler version now.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6cb31442acb2dc3762e5238139c4de1f79338f3f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changed dns_exc.DuplicateRecordSet exception to error log messages"},{"line_number":5,"context_line":"    instead of exception messages. Changed dns_exc.DNSDomainNotFound"},{"line_number":6,"context_line":"    to error messages on creation of a recordset and to warning on"},{"line_number":7,"context_line":"    deletion of a recordset. This prevents the logs from filling with"},{"line_number":8,"context_line":"    stack traces where an warning or error log messages would have been"},{"line_number":9,"context_line":"    sufficient enough. The affected log messages have also been changed"},{"line_number":10,"context_line":"    to more generic messages."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"629243af_1927defe","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":27},"updated":"2024-02-05 09:28:06.000000000","message":"Why?","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"c0ed40c9e21809d0c9fb979d3bb4a41018aafcb2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changed dns_exc.DuplicateRecordSet exception to error log messages"},{"line_number":5,"context_line":"    instead of exception messages. Changed dns_exc.DNSDomainNotFound"},{"line_number":6,"context_line":"    to error messages on creation of a recordset and to warning on"},{"line_number":7,"context_line":"    deletion of a recordset. This prevents the logs from filling with"},{"line_number":8,"context_line":"    stack traces where an warning or error log messages would have been"},{"line_number":9,"context_line":"    sufficient enough. The affected log messages have also been changed"},{"line_number":10,"context_line":"    to more generic messages."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d3dac08a_19b31118","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":27},"in_reply_to":"629243af_1927defe","updated":"2024-02-20 16:22:19.000000000","message":"I changed the note to a simpler version now.","commit_id":"02c5ce5e1d38d59b243b1b19fd8575767fb7a45f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4bdb2a239dcbab6beb9063fff03ff11122385a39","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Cleaned non-harmful stack trace errors from DNS integration plugin. This"},{"line_number":5,"context_line":"    prevents the logs from filling with stack traces where an error log"},{"line_number":6,"context_line":"    messages would have been sufficient."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bb6a9db9_78bfd8b1","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":61},"updated":"2024-02-21 15:58:34.000000000","message":"remove \u0027an\u0027 since it\u0027s plural (\u0027messages\u0027)","commit_id":"3fb57c50a9b825cab6c2df03239d370999ea9b81"},{"author":{"_account_id":34401,"name":"Jayce Houtman","email":"jhoutman@houtknots.com","username":"houtknots"},"change_message_id":"46118ac8b8b97b090c0d6903ca73ab0b37a5db65","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Cleaned non-harmful stack trace errors from DNS integration plugin. This"},{"line_number":5,"context_line":"    prevents the logs from filling with stack traces where an error log"},{"line_number":6,"context_line":"    messages would have been sufficient."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"66490124_c5e7609f","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":61},"in_reply_to":"bb6a9db9_78bfd8b1","updated":"2024-03-07 11:06:15.000000000","message":"Will be changed with my next push","commit_id":"3fb57c50a9b825cab6c2df03239d370999ea9b81"}]}