)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8d5c7f2589311947a58ae22366d62c23336e683b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e7f5496_9843579d","updated":"2023-11-27 16:13:41.000000000","message":"Just a -1 for my comment, but will approve if we want to fix what i found in a follow-on.","commit_id":"23ef2dfc4221cbbe7db2bfef43df9d52f18f97bf"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6b3d5459864609aadf6c29ebdca7091cd583add9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e404f9e1_617ad3b1","updated":"2023-11-27 10:28:21.000000000","message":"thanks, seems a better option","commit_id":"23ef2dfc4221cbbe7db2bfef43df9d52f18f97bf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"312a153cdc4b7fdf5b21ae5fe44f1f38434aa5be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4c951cf7_84abd10a","updated":"2023-11-28 20:48:47.000000000","message":"Thanks for the other patch, lgtm now","commit_id":"ed07a430f50cbb4231f4887e8b86163ab173717c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38c340d9e90b4023dc48bf819420a15f088caabf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0a44fab_765f6196","updated":"2023-11-28 06:46:17.000000000","message":"recheck unrelated failure","commit_id":"ed07a430f50cbb4231f4887e8b86163ab173717c"}],"neutron/conf/agent/metadata/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8d5c7f2589311947a58ae22366d62c23336e683b","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                    (constants.IP_VERSION_4, \u0027IPv4\u0027),"},{"line_number":116,"context_line":"                    (constants.IP_VERSION_6, \u0027IPv6\u0027)"},{"line_number":117,"context_line":"                ]),"},{"line_number":118,"context_line":"                default\u003d[constants.IP_VERSION_4],"},{"line_number":119,"context_line":"                help\u003d_(\u0027Comma separated list of the metadata address IP \u0027"},{"line_number":120,"context_line":"                       \u0027versions (4, 6) for which rate limiting will be \u0027"},{"line_number":121,"context_line":"                       \u0027enabled. The default is to rate limit only for the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"197ffe73_d6be7668","line":118,"updated":"2023-11-27 16:13:41.000000000","message":"So the one thing I noticed is that this option (and all those in this block) are not in either metadata agent sample ini file. It seems the original change forgot to add METADATA_RATE_LIMITING_OPTS to list_metadata_agent_opts() for both agent types.\n\nBasically, running this:\n\ntox -e genconfig\n\nshould have then found these options somewhere in the etc/ directory.\n\nIf you want to fix that in this change I wouldn\u0027t be opposed, else I\u0027ll do a follow-on. These are the files\n\nneutron/conf/agent/ovn/metadata/config.py\nneutron/opts.py","commit_id":"23ef2dfc4221cbbe7db2bfef43df9d52f18f97bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f633ea63218f3e5a4596436fc7468daf4588e23a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                    (constants.IP_VERSION_4, \u0027IPv4\u0027),"},{"line_number":116,"context_line":"                    (constants.IP_VERSION_6, \u0027IPv6\u0027)"},{"line_number":117,"context_line":"                ]),"},{"line_number":118,"context_line":"                default\u003d[constants.IP_VERSION_4],"},{"line_number":119,"context_line":"                help\u003d_(\u0027Comma separated list of the metadata address IP \u0027"},{"line_number":120,"context_line":"                       \u0027versions (4, 6) for which rate limiting will be \u0027"},{"line_number":121,"context_line":"                       \u0027enabled. The default is to rate limit only for the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"d9f2fc47_455465d3","line":118,"in_reply_to":"197ffe73_d6be7668","updated":"2023-11-28 00:58:34.000000000","message":"That\u0027s a nice catch ! I\u0027ve decided to create a separate change[1] to fix the missing options because we might want to backport it separately. (This change is just an improvement so may not worth backporting)\n\n[1] https://review.opendev.org/c/openstack/neutron/+/902013","commit_id":"23ef2dfc4221cbbe7db2bfef43df9d52f18f97bf"}],"neutron/conf/plugins/ml2/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8d5c7f2589311947a58ae22366d62c23336e683b","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                (constants.IP_VERSION_4, \u0027IPv4\u0027),"},{"line_number":73,"context_line":"                (constants.IP_VERSION_6, \u0027IPv6\u0027)"},{"line_number":74,"context_line":"            ]),"},{"line_number":75,"context_line":"            help\u003d_(\"IP version of all overlay (tunnel) network endpoints.\")),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027tunnelled_network_rp_name\u0027,"},{"line_number":77,"context_line":"               default\u003dcommon_const.RP_TUNNELLED,"},{"line_number":78,"context_line":"               help\u003d_(\"Resource provider name for the host with tunnelled \""}],"source_content_type":"text/x-python","patch_set":4,"id":"f5a975a1_1d60184b","line":75,"updated":"2023-11-27 16:13:41.000000000","message":"I think the text in the resultant ini sample file is better now (if you ignore the bold my cut/paste is causing):\n\n# IP version of all overlay (tunnel) network endpoints. (integer value)\n# Possible values:\n# 4 - IPv4\n# 6 - IPv6\n#overlay_ip_version \u003d 4","commit_id":"23ef2dfc4221cbbe7db2bfef43df9d52f18f97bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f633ea63218f3e5a4596436fc7468daf4588e23a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                (constants.IP_VERSION_4, \u0027IPv4\u0027),"},{"line_number":73,"context_line":"                (constants.IP_VERSION_6, \u0027IPv6\u0027)"},{"line_number":74,"context_line":"            ]),"},{"line_number":75,"context_line":"            help\u003d_(\"IP version of all overlay (tunnel) network endpoints.\")),"},{"line_number":76,"context_line":"    cfg.StrOpt(\u0027tunnelled_network_rp_name\u0027,"},{"line_number":77,"context_line":"               default\u003dcommon_const.RP_TUNNELLED,"},{"line_number":78,"context_line":"               help\u003d_(\"Resource provider name for the host with tunnelled \""}],"source_content_type":"text/x-python","patch_set":4,"id":"60299ec3_60a69f92","line":75,"in_reply_to":"f5a975a1_1d60184b","updated":"2023-11-28 00:58:34.000000000","message":"Yes. that\u0027s one of the benefits of this change :-)","commit_id":"23ef2dfc4221cbbe7db2bfef43df9d52f18f97bf"}]}