)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e6ac4acc6b20480e9ceec1afcea38841c0f87dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e6ca8f5_2cc22040","updated":"2024-01-11 17:28:09.000000000","message":"Looks good Rodolfo, just a few grammatical things.","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"}],"doc/source/ovn/ovn_agent.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e6ac4acc6b20480e9ceec1afcea38841c0f87dd","unresolved":true,"context_lines":[{"line_number":13,"context_line":"OVN and OVS database connectivity"},{"line_number":14,"context_line":"---------------------------------"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The OVN agent can access to the local OVS database where the service is"},{"line_number":17,"context_line":"running. It also access to the Northbound and Southbound OVN databases. The"},{"line_number":18,"context_line":"connection strings to these databases are defined in the agent configuration"},{"line_number":19,"context_line":"file:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e6f08dc5_24b7695a","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":31},"updated":"2024-01-11 17:28:09.000000000","message":"s/access the","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3f2ec97538cd49575c9f32222d6826bb0d21c18","unresolved":false,"context_lines":[{"line_number":13,"context_line":"OVN and OVS database connectivity"},{"line_number":14,"context_line":"---------------------------------"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The OVN agent can access to the local OVS database where the service is"},{"line_number":17,"context_line":"running. It also access to the Northbound and Southbound OVN databases. The"},{"line_number":18,"context_line":"connection strings to these databases are defined in the agent configuration"},{"line_number":19,"context_line":"file:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"95846d68_eef02ecb","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":31},"in_reply_to":"e6f08dc5_24b7695a","updated":"2024-01-15 16:07:51.000000000","message":"Done","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e6ac4acc6b20480e9ceec1afcea38841c0f87dd","unresolved":true,"context_lines":[{"line_number":14,"context_line":"---------------------------------"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The OVN agent can access to the local OVS database where the service is"},{"line_number":17,"context_line":"running. It also access to the Northbound and Southbound OVN databases. The"},{"line_number":18,"context_line":"connection strings to these databases are defined in the agent configuration"},{"line_number":19,"context_line":"file:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6bad707a_36972adf","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":23},"updated":"2024-01-11 17:28:09.000000000","message":"s/also has access","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3f2ec97538cd49575c9f32222d6826bb0d21c18","unresolved":false,"context_lines":[{"line_number":14,"context_line":"---------------------------------"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The OVN agent can access to the local OVS database where the service is"},{"line_number":17,"context_line":"running. It also access to the Northbound and Southbound OVN databases. The"},{"line_number":18,"context_line":"connection strings to these databases are defined in the agent configuration"},{"line_number":19,"context_line":"file:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b2cb8da0_0bd0b0ef","line":17,"range":{"start_line":17,"start_character":12,"end_line":17,"end_character":23},"in_reply_to":"6bad707a_36972adf","updated":"2024-01-15 16:07:51.000000000","message":"Done","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e6ac4acc6b20480e9ceec1afcea38841c0f87dd","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Each extension should define a set of OVS, OVN Northbound and OVN Southbound"},{"line_number":62,"context_line":"tables to monitorize and a set of events, related to these databases. The OVN"},{"line_number":63,"context_line":"agent will create the corresponding IDL connections using the conjunction of"},{"line_number":64,"context_line":"these tables and events."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b616ee4d_426f80a8","line":62,"range":{"start_line":62,"start_character":7,"end_line":62,"end_character":26},"updated":"2024-01-11 17:28:09.000000000","message":"s/to monitor a (?)","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3f2ec97538cd49575c9f32222d6826bb0d21c18","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Each extension should define a set of OVS, OVN Northbound and OVN Southbound"},{"line_number":62,"context_line":"tables to monitorize and a set of events, related to these databases. The OVN"},{"line_number":63,"context_line":"agent will create the corresponding IDL connections using the conjunction of"},{"line_number":64,"context_line":"these tables and events."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7e999cd3_46ae86da","line":62,"range":{"start_line":62,"start_character":7,"end_line":62,"end_character":26},"in_reply_to":"b616ee4d_426f80a8","updated":"2024-01-15 16:07:51.000000000","message":"Done","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e6ac4acc6b20480e9ceec1afcea38841c0f87dd","unresolved":true,"context_lines":[{"line_number":64,"context_line":"these tables and events."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Event driven service"},{"line_number":68,"context_line":"--------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The OVN agent is a ``oslo_service.service.Service`` type class, that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"075d20db_ba91280b","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":12},"updated":"2024-01-11 17:28:09.000000000","message":"nit: Event-driven","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3f2ec97538cd49575c9f32222d6826bb0d21c18","unresolved":false,"context_lines":[{"line_number":64,"context_line":"these tables and events."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Event driven service"},{"line_number":68,"context_line":"--------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The OVN agent is a ``oslo_service.service.Service`` type class, that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b625e2eb_e1ff5538","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":12},"in_reply_to":"075d20db_ba91280b","updated":"2024-01-15 16:07:51.000000000","message":"Done","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e6ac4acc6b20480e9ceec1afcea38841c0f87dd","unresolved":true,"context_lines":[{"line_number":70,"context_line":"The OVN agent is a ``oslo_service.service.Service`` type class, that is"},{"line_number":71,"context_line":"launched when the script is executed. Once initialized, the service is waiting"},{"line_number":72,"context_line":"for new events that will trigger actions. As mentioned in the previous section,"},{"line_number":73,"context_line":"each extension defines a set of events that will attend changes in the OVS and"},{"line_number":74,"context_line":"OVN database tables."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b3a6a346_2c819468","line":73,"range":{"start_line":73,"start_character":49,"end_line":73,"end_character":55},"updated":"2024-01-11 17:28:09.000000000","message":"I\u0027m not sure \u0027attend\u0027 is the correct word, even though \"occur with or as a result of\" is one of the definitions of it. Maybe just use \"occur as a result of\" ?","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3f2ec97538cd49575c9f32222d6826bb0d21c18","unresolved":false,"context_lines":[{"line_number":70,"context_line":"The OVN agent is a ``oslo_service.service.Service`` type class, that is"},{"line_number":71,"context_line":"launched when the script is executed. Once initialized, the service is waiting"},{"line_number":72,"context_line":"for new events that will trigger actions. As mentioned in the previous section,"},{"line_number":73,"context_line":"each extension defines a set of events that will attend changes in the OVS and"},{"line_number":74,"context_line":"OVN database tables."}],"source_content_type":"text/x-rst","patch_set":1,"id":"62710105_e08c8018","line":73,"range":{"start_line":73,"start_character":49,"end_line":73,"end_character":55},"in_reply_to":"b3a6a346_2c819468","updated":"2024-01-15 16:07:51.000000000","message":"I think I\u0027m going to change that to \"each extension will subscribe to a set of events from the OVN and OVS databases; these events will trigger a set of actions executed in the OVN agent.\"","commit_id":"892bc64efc9e03175eeed5d6d44ddf1c5fe92a5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fe5373387a1f040c6cfc9f7ad63a1c819f622e31","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The OVN agent is a service that could be executed in any node running the"},{"line_number":7,"context_line":"ovn-controller service. This agent provides additional functionalities not"},{"line_number":8,"context_line":"provided by the OVN CMS; for example, a metadata proxy between the virtual"},{"line_number":9,"context_line":"machines and the Nova metadata service. This agent will replace the need of"},{"line_number":10,"context_line":"the OVN metadata agent."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"876cd196_bd733473","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":23},"updated":"2024-01-19 16:38:38.000000000","message":"hm. OVN is not CMS. \"by OVN\"?","commit_id":"7775f584cc7ceb3e63da9f55c823eb83900abb51"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"37a0c10a9e9146bcb403676470f846c72e87b73e","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The OVN agent is a service that could be executed in any node running the"},{"line_number":7,"context_line":"ovn-controller service. This agent provides additional functionalities not"},{"line_number":8,"context_line":"provided by the OVN CMS; for example, a metadata proxy between the virtual"},{"line_number":9,"context_line":"machines and the Nova metadata service. This agent will replace the need of"},{"line_number":10,"context_line":"the OVN metadata agent."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"95462385_42221579","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":23},"in_reply_to":"876cd196_bd733473","updated":"2024-01-22 16:20:15.000000000","message":"Sorry, Neutron is the CMS, not OVN.","commit_id":"7775f584cc7ceb3e63da9f55c823eb83900abb51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fe5373387a1f040c6cfc9f7ad63a1c819f622e31","unresolved":true,"context_lines":[{"line_number":7,"context_line":"ovn-controller service. This agent provides additional functionalities not"},{"line_number":8,"context_line":"provided by the OVN CMS; for example, a metadata proxy between the virtual"},{"line_number":9,"context_line":"machines and the Nova metadata service. This agent will replace the need of"},{"line_number":10,"context_line":"the OVN metadata agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"OVN and OVS database connectivity"}],"source_content_type":"text/x-rst","patch_set":2,"id":"16e93e64_9b21c270","line":10,"updated":"2024-01-19 16:38:38.000000000","message":"would be nice to explain if anything should be done by admins to migrate to the new single agent setup. Or does it belong elsewhere? Perhaps a release note (and docs update) included in the previous patch in the series - the one that implements metadata extension?","commit_id":"7775f584cc7ceb3e63da9f55c823eb83900abb51"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"37a0c10a9e9146bcb403676470f846c72e87b73e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ovn-controller service. This agent provides additional functionalities not"},{"line_number":8,"context_line":"provided by the OVN CMS; for example, a metadata proxy between the virtual"},{"line_number":9,"context_line":"machines and the Nova metadata service. This agent will replace the need of"},{"line_number":10,"context_line":"the OVN metadata agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"OVN and OVS database connectivity"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0e20402b_ce5f68b6","line":10,"in_reply_to":"16e93e64_9b21c270","updated":"2024-01-22 16:20:15.000000000","message":"The migration is the next step. Once this code is widely tested in the CI (in its own CI job), I\u0027ll create a RFE to propose the migration, how should be done, when the metadata agent will be deprecated. Although this should be trivial (mostly transparent, both agents should deliver exactly the same functionality), this change should be consider in a RFE and presented to the community.","commit_id":"7775f584cc7ceb3e63da9f55c823eb83900abb51"}]}