)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"48ff966826106fe8b3e9da264e0072e44d340fee","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change moves the part that cleans up the old DHCP setup to ensure"},{"line_number":16,"context_line":"it is executed first."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":19,"context_line":"Change-Id: Iecdb2d81ee077c9b9057d0708c5c88e159970039"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8a1255e2_f783c352","line":17,"updated":"2024-01-16 10:13:03.000000000","message":"Do you have perhaps a bug report also?\nIs it possible to add or extend unit test for this scenario perhaps?","commit_id":"460532f6e7c4c8ad143a09e84c20f41fe71d2242"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d13d3e21a478ea80fece88e05d697d07bff0ed22","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change moves the part that cleans up the old DHCP setup to ensure"},{"line_number":16,"context_line":"it is executed first."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":19,"context_line":"Change-Id: Iecdb2d81ee077c9b9057d0708c5c88e159970039"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"933050f8_a2eceb0e","line":17,"in_reply_to":"8a1255e2_f783c352","updated":"2024-01-17 10:25:33.000000000","message":"Sure i will take care of all that. Thank you","commit_id":"460532f6e7c4c8ad143a09e84c20f41fe71d2242"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79583f029d7cae5e9ff0b4916292dc8d05fbc181","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change moves the part that cleans up the old DHCP setup to ensure"},{"line_number":16,"context_line":"it is executed first."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":19,"context_line":"Change-Id: Iecdb2d81ee077c9b9057d0708c5c88e159970039"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"590775c6_1863fe6d","line":17,"in_reply_to":"933050f8_a2eceb0e","updated":"2024-01-26 15:05:25.000000000","message":"Done","commit_id":"460532f6e7c4c8ad143a09e84c20f41fe71d2242"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0919a00c5862dc9a0ec1c7100f7f4e1213c905cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5db4d6c_93d33839","updated":"2024-01-26 15:04:59.000000000","message":"recheck timeout on neutron.tests.unit.extensions.test_timestamp.TimeStampDBMixinTestCase.test_update_timpestamp","commit_id":"ac45f17f49fe8191e3fafeb562c2deef96a07cbc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4272ca65629fb94957347cd4d4057eb6ddf164a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"38e9285c_1a1ce884","updated":"2024-02-08 08:38:37.000000000","message":"Looks ok","commit_id":"1ad8c6285f85282376cd924b9378a82cfd58fcf5"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"48ff966826106fe8b3e9da264e0072e44d340fee","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":222,"context_line":"        if sid_subnets:"},{"line_number":223,"context_line":"            ret \u003d []"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":226,"context_line":"                # TODO(sahid): This whole block bellow should be removed in"},{"line_number":227,"context_line":"                # future, when we know that all environements have migrated to"}],"source_content_type":"text/x-python","patch_set":1,"id":"4aea5f48_440daeb7","line":224,"updated":"2024-01-16 10:13:03.000000000","message":"nit: to make review simpler please avoid useless whitespace changes","commit_id":"460532f6e7c4c8ad143a09e84c20f41fe71d2242"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d13d3e21a478ea80fece88e05d697d07bff0ed22","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":222,"context_line":"        if sid_subnets:"},{"line_number":223,"context_line":"            ret \u003d []"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":226,"context_line":"                # TODO(sahid): This whole block bellow should be removed in"},{"line_number":227,"context_line":"                # future, when we know that all environements have migrated to"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ea0c3d0_a6ae736b","line":224,"in_reply_to":"4aea5f48_440daeb7","updated":"2024-01-17 10:25:33.000000000","message":"Yes that makes sense, will fix that as-well.","commit_id":"460532f6e7c4c8ad143a09e84c20f41fe71d2242"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79583f029d7cae5e9ff0b4916292dc8d05fbc181","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                sid_subnets[subnet.get(\u0027segment_id\u0027)].append(subnet)"},{"line_number":222,"context_line":"        if sid_subnets:"},{"line_number":223,"context_line":"            ret \u003d []"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            for seg_id, subnets in sid_subnets.items():"},{"line_number":226,"context_line":"                # TODO(sahid): This whole block bellow should be removed in"},{"line_number":227,"context_line":"                # future, when we know that all environements have migrated to"}],"source_content_type":"text/x-python","patch_set":1,"id":"b20fdc1b_ab510695","line":224,"in_reply_to":"6ea0c3d0_a6ae736b","updated":"2024-01-26 15:05:25.000000000","message":"Done","commit_id":"460532f6e7c4c8ad143a09e84c20f41fe71d2242"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ce4a1a617044dcec39b2c63b890f4a02abaeef32","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                # agent. Then the process will recreate it considering a dhcp"},{"line_number":232,"context_line":"                # agent per segmentation id."},{"line_number":233,"context_line":"                segment \u003d sid_segment.get(seg_id)"},{"line_number":234,"context_line":"                if segment and segment.segment_index \u003d\u003d 0:"},{"line_number":235,"context_line":"                    if action in [\u0027enable\u0027, \u0027disable\u0027]:"},{"line_number":236,"context_line":"                        self._call_driver("},{"line_number":237,"context_line":"                            \u0027disable\u0027, network, segment\u003dNone, block\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c787c48_3f3c2966","side":"PARENT","line":234,"updated":"2024-01-17 14:48:27.000000000","message":"There was no need to check for segment_index \u003d\u003d 0 Calling _call_driver with segment\u003dNone one time would be enough.","commit_id":"d34c1f916f689160c82af6ccd746e8c9e809fa8b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79583f029d7cae5e9ff0b4916292dc8d05fbc181","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                # agent. Then the process will recreate it considering a dhcp"},{"line_number":232,"context_line":"                # agent per segmentation id."},{"line_number":233,"context_line":"                segment \u003d sid_segment.get(seg_id)"},{"line_number":234,"context_line":"                if segment and segment.segment_index \u003d\u003d 0:"},{"line_number":235,"context_line":"                    if action in [\u0027enable\u0027, \u0027disable\u0027]:"},{"line_number":236,"context_line":"                        self._call_driver("},{"line_number":237,"context_line":"                            \u0027disable\u0027, network, segment\u003dNone, block\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c716d98_ad3904e1","side":"PARENT","line":234,"in_reply_to":"0c787c48_3f3c2966","updated":"2024-01-26 15:05:25.000000000","message":"Done","commit_id":"d34c1f916f689160c82af6ccd746e8c9e809fa8b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4cd05d3aa48943bae858b8eb7dffcf8c1fe6d494","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0f93540_6ff28e54","line":1,"updated":"2024-01-22 14:18:10.000000000","message":"Please delete this extra line.","commit_id":"849a808ae7bd2610bf879b94cd311e8847d3a9ee"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79583f029d7cae5e9ff0b4916292dc8d05fbc181","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"47a652e7_2f3f75f8","line":1,"in_reply_to":"d0f93540_6ff28e54","updated":"2024-01-26 15:05:25.000000000","message":"Done","commit_id":"849a808ae7bd2610bf879b94cd311e8847d3a9ee"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8a5ddea43ce166511bb3c47f7fb69d234076c99a","unresolved":true,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"            # TODO(sahid): This whole block bellow should be removed in"},{"line_number":227,"context_line":"            # future, when we know that all environements have migrated to"},{"line_number":228,"context_line":"            # at least zed.  This is expected to help for environements"},{"line_number":229,"context_line":"            # that already have deployed RPN.  For any first segment"},{"line_number":230,"context_line":"            # associated to a subnet we want to disable its dhcp"},{"line_number":231,"context_line":"            # agent. Then the process will recreate it considering a dhcp"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2e84ecc_7ede58e4","line":228,"range":{"start_line":228,"start_character":14,"end_line":228,"end_character":26},"updated":"2024-01-17 15:00:00.000000000","message":"Is this still needed? We are in Caracal now.","commit_id":"849a808ae7bd2610bf879b94cd311e8847d3a9ee"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79583f029d7cae5e9ff0b4916292dc8d05fbc181","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"            # TODO(sahid): This whole block bellow should be removed in"},{"line_number":227,"context_line":"            # future, when we know that all environements have migrated to"},{"line_number":228,"context_line":"            # at least zed.  This is expected to help for environements"},{"line_number":229,"context_line":"            # that already have deployed RPN.  For any first segment"},{"line_number":230,"context_line":"            # associated to a subnet we want to disable its dhcp"},{"line_number":231,"context_line":"            # agent. Then the process will recreate it considering a dhcp"}],"source_content_type":"text/x-python","patch_set":3,"id":"95774bf6_d3ef9923","line":228,"range":{"start_line":228,"start_character":14,"end_line":228,"end_character":26},"in_reply_to":"6d023cc4_38788401","updated":"2024-01-26 15:05:25.000000000","message":"Done","commit_id":"849a808ae7bd2610bf879b94cd311e8847d3a9ee"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e6607d1ffbed48ff0404c594c4e948bbecdf9705","unresolved":true,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"            # TODO(sahid): This whole block bellow should be removed in"},{"line_number":227,"context_line":"            # future, when we know that all environements have migrated to"},{"line_number":228,"context_line":"            # at least zed.  This is expected to help for environements"},{"line_number":229,"context_line":"            # that already have deployed RPN.  For any first segment"},{"line_number":230,"context_line":"            # associated to a subnet we want to disable its dhcp"},{"line_number":231,"context_line":"            # agent. Then the process will recreate it considering a dhcp"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d023cc4_38788401","line":228,"range":{"start_line":228,"start_character":14,"end_line":228,"end_character":26},"in_reply_to":"e2e84ecc_7ede58e4","updated":"2024-01-17 15:04:58.000000000","message":"It\u0027s something that we certainly want to backport to zed. I guess we can consider to remove it after that.","commit_id":"849a808ae7bd2610bf879b94cd311e8847d3a9ee"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8ef1011622a1ace3c6e2a0e8a5857e7ea16add2b","unresolved":true,"context_lines":[{"line_number":225,"context_line":"            # TODO(sahid): This whole block bellow should be removed in"},{"line_number":226,"context_line":"            # future, when we know that all environements have migrated to"},{"line_number":227,"context_line":"            # at least zed.  This is expected to help for environements"},{"line_number":228,"context_line":"            # that already have deployed RPN.  For any first segment"},{"line_number":229,"context_line":"            # associated to a subnet we want to disable its dhcp"},{"line_number":230,"context_line":"            # agent. Then the process will recreate it considering a dhcp"},{"line_number":231,"context_line":"            # agent per segmentation id."},{"line_number":232,"context_line":"            if action in [\u0027enable\u0027, \u0027disable\u0027]:"},{"line_number":233,"context_line":"                self._call_driver("}],"source_content_type":"text/x-python","patch_set":6,"id":"8e6b8cd1_81efdcd2","line":230,"range":{"start_line":228,"start_character":47,"end_line":230,"end_character":20},"updated":"2024-02-08 19:45:09.000000000","message":"I think the change below is ok, but this comment was specific to the old code (first segment), so should be changed to be more generic, like \"First, disable the dhcp agent for the network.\"\n\nAlso, we are past Zed, can we not remove it completely?","commit_id":"1ad8c6285f85282376cd924b9378a82cfd58fcf5"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8ef1011622a1ace3c6e2a0e8a5857e7ea16add2b","unresolved":true,"context_lines":[{"line_number":397,"context_line":"            _call_driver.mock_calls \u003d\u003d ["},{"line_number":398,"context_line":"                mock.call(\"disable\", network, segment\u003dNone, block\u003dTrue),"},{"line_number":399,"context_line":"                mock.call(\"enable\", network, segment\u003dseg1),"},{"line_number":400,"context_line":"                mock.call(\"enable\", network, segment\u003dseg0)]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def test_call_driver_no_network(self):"},{"line_number":403,"context_line":"        network \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"7974af66_d9f6dfe8","line":400,"updated":"2024-02-08 19:45:09.000000000","message":"This doesn\u0027t look right. Typically you would put the calls in a list, then do:\n\nself.assert_has_calls(calls)\n\nThere is no assert the calls were made above.","commit_id":"1ad8c6285f85282376cd924b9378a82cfd58fcf5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92df139d7e034a25a8cad483543974bc77a470f2","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            _call_driver.mock_calls \u003d\u003d ["},{"line_number":398,"context_line":"                mock.call(\"disable\", network, segment\u003dNone, block\u003dTrue),"},{"line_number":399,"context_line":"                mock.call(\"enable\", network, segment\u003dseg1),"},{"line_number":400,"context_line":"                mock.call(\"enable\", network, segment\u003dseg0)]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def test_call_driver_no_network(self):"},{"line_number":403,"context_line":"        network \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"253deb79_8507e8f1","line":400,"in_reply_to":"7974af66_d9f6dfe8","updated":"2024-04-05 13:43:19.000000000","message":"Done","commit_id":"1ad8c6285f85282376cd924b9378a82cfd58fcf5"}]}