)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2725027f62ee0c78c361dda1d8c6b2aeba1ccf71","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated keystone_admin conf section to reflect changes in middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystoneclient module now prefers auth_uri and identity_uri."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1313783"},{"line_number":12,"context_line":"Change-Id: I8bce9bfc01859dad82e5a98f4ac1da54ed86392a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa98f980_e72a8f2b","line":9,"updated":"2014-09-08 09:29:05.000000000","message":"this is lacking a docimpact flag describing the new configuration vars\n\nwill this break an upgrade?","commit_id":"30daf8360dbb043f3a976f7ffcb63ef1363d82e0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"011240608862f4c13c8084a42eb15d5543342521","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated keystone_admin conf section to reflect changes in middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystoneclient module now prefers auth_uri and identity_uri."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1313783"},{"line_number":12,"context_line":"Change-Id: I8bce9bfc01859dad82e5a98f4ac1da54ed86392a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa98f980_4af0c2c9","line":9,"in_reply_to":"fa98f980_e72a8f2b","updated":"2014-09-08 09:56:08.000000000","message":"It should not break the upgrade (the new keystone client we depend on has backwards compatibility with the old way, and we\u0027ve introduced backwards compatibility for plugins that relied on the values too), but yes, DocImpact is probably worth being mentioned here.","commit_id":"30daf8360dbb043f3a976f7ffcb63ef1363d82e0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5c1a75b4fb15bed74bf107b0a4cbfff7907699ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated keystone_admin conf section to reflect changes in middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystoneclient module now prefers auth_uri and identity_uri."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1313783"},{"line_number":12,"context_line":"Change-Id: I8bce9bfc01859dad82e5a98f4ac1da54ed86392a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa98f980_0356b12a","line":9,"updated":"2014-09-16 17:41:57.000000000","message":"s/keystoneclient/keystonemiddleware/\n\nauth_token is now provided by keystonemiddleware instead of keystoneclient.","commit_id":"32dbe4b650a0aef6b47cddbe2001b698f26ba4db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c04a687932e874bccfd5b42304a25645456aacfe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated keystone_admin conf section to reflect changes in middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystoneclient module now prefers auth_uri and identity_uri."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1313783"},{"line_number":12,"context_line":"Change-Id: I8bce9bfc01859dad82e5a98f4ac1da54ed86392a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"da9df570_05e3c733","line":9,"in_reply_to":"fa98f980_0356b12a","updated":"2014-09-24 09:15:50.000000000","message":"Done","commit_id":"32dbe4b650a0aef6b47cddbe2001b698f26ba4db"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"8cddd0f9e2e957401e79e5b531da8a4b7079926b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystonemiddleware module now prefers auth_uri and identity_uri."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1313783"},{"line_number":12,"context_line":"Change-Id: I8bce9bfc01859dad82e5a98f4ac1da54ed86392a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8c0949_b1361ae6","line":11,"updated":"2014-10-29 22:13:45.000000000","message":"Do we need the DocImpact  flag a we change the configuration?","commit_id":"5c04c9e2e0fee0241e3dd967b393820f098e433f"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"1de92c31b23552f2d2f2773bce940648472994c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"keystonemiddleware module now prefers auth_uri and identity_uri."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 1313783"},{"line_number":12,"context_line":"Change-Id: I8bce9bfc01859dad82e5a98f4ac1da54ed86392a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8c0949_95a4a358","line":11,"in_reply_to":"7a8c0949_b1361ae6","updated":"2014-10-30 08:07:22.000000000","message":"DocImpact\n+ 1","commit_id":"5c04c9e2e0fee0241e3dd967b393820f098e433f"}],"etc/neutron.conf":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"22e09e2d17177b3a82001e796473c3536eac7b24","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"[keystone_authtoken]"},{"line_number":401,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":402,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":403,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":404,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":405,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":5,"id":"3ae8d1ca_03622dd8","line":402,"updated":"2014-05-27 07:24:18.000000000","message":"is it used anywhere?","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"258940f0a2ef4a78518a22491346ce62e978a90a","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"[keystone_authtoken]"},{"line_number":401,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":402,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":403,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":404,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":405,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":5,"id":"3ae8d1ca_a3a41958","line":402,"in_reply_to":"3ae8d1ca_03622dd8","updated":"2014-05-27 07:58:43.000000000","message":"As per keystoneclient options descriptions [1], identity_uri is the option that deprecates auth_[host|port|protocol] options though the code shows that middleware will issue warnings if any of these two options is missing [2] [3].\n\n[1]: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L200\n[2]: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L429\n[3]: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L453","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"78ea25ec3fbfd8da2ed8247f15937cbf203e633c","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"[keystone_authtoken]"},{"line_number":401,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":402,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":403,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":404,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":405,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":5,"id":"3ae8d1ca_99886ce9","line":402,"in_reply_to":"3ae8d1ca_86abab88","updated":"2014-05-27 09:01:09.000000000","message":"Ionut: I don\u0027t change defaults, I just port it to new options. If you think https should be default, you can send a separate patch for this.\n\nOleg: if we don\u0027t specify it, we still get warnings in logs, even though we don\u0027t use it explicitly.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"1a5aa52463558dfe57cd051f73fedfa0edabc228","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"[keystone_authtoken]"},{"line_number":401,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":402,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":403,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":404,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":405,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":5,"id":"3ae8d1ca_b901a83b","line":402,"in_reply_to":"3ae8d1ca_99886ce9","updated":"2014-05-27 09:03:46.000000000","message":"Ihar: Ah, ok. Just noticed that auth_protocol was http here. Ok. My comment was based on the keystoneclient auth_token default.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"08f653c912129940e2fb4f011d39503abcf73f41","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"[keystone_authtoken]"},{"line_number":401,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":402,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":403,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":404,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":405,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":5,"id":"3ae8d1ca_a62b472f","line":402,"in_reply_to":"3ae8d1ca_a3a41958","updated":"2014-05-27 08:21:40.000000000","message":"Thanks for the links, I understand the replacing of auth_[host|port|protocol] to auth_uri. However is identity_uri option used anywhere in Neutron code so is there a need to add it to the config file?","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"fbbe5d19daf20dc555cd471805a8b08fa4bfde07","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"[keystone_authtoken]"},{"line_number":401,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":402,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":403,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":404,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":405,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":5,"id":"3ae8d1ca_86abab88","line":402,"in_reply_to":"3ae8d1ca_a62b472f","updated":"2014-05-27 08:29:19.000000000","message":"@Ihar: shouldn\u0027t the default be https?\n\n@Oleg: neutron uses keystoneclient\u0027s authtoken middleware which in turn uses identity_uri. It\u0027s not used in neutron code, but it is used by neutron.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a512d5e91ce5809a946c64f5cd3241e813f499dc","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"[keystone_authtoken]"},{"line_number":534,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":535,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":536,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":537,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":538,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":6,"id":"1abeadc6_1b29cd9a","line":535,"updated":"2014-08-23 18:08:07.000000000","message":"where is this identity_uri used ?","commit_id":"c639861568cfaa381c3525f4d4a0ebddbe93e1b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"912bb0167cf647da4289d410c361ef0614df8853","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"[keystone_authtoken]"},{"line_number":534,"context_line":"auth_uri \u003d http://127.0.0.1:5000/v2.0/"},{"line_number":535,"context_line":"identity_uri \u003d http://127.0.0.1:35357/"},{"line_number":536,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"},{"line_number":537,"context_line":"admin_user \u003d %SERVICE_USER%"},{"line_number":538,"context_line":"admin_password \u003d %SERVICE_PASSWORD%"}],"source_content_type":"text/plain","patch_set":6,"id":"fa98f980_15050014","line":535,"in_reply_to":"1abeadc6_1b29cd9a","updated":"2014-09-08 09:22:27.000000000","message":"In keystoneclient/middleware/auth_token.py","commit_id":"c639861568cfaa381c3525f4d4a0ebddbe93e1b6"}],"neutron/common/utils.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f87a500ee1dfee97f50cf1abd5facfd2490ac78b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    if conf.auth_uri:"},{"line_number":315,"context_line":"        auth_uri \u003d conf.auth_uri.rstrip(\u0027/\u0027)"},{"line_number":316,"context_line":"    else:"},{"line_number":317,"context_line":"        auth_uri \u003d \u0027%s://%s:%s\u0027 % (conf.auth_protocol,"},{"line_number":318,"context_line":"                                   conf.auth_host,"},{"line_number":319,"context_line":"                                   conf.auth_port)"},{"line_number":320,"context_line":"    return \u0027%s/v2.0\u0027 % auth_uri"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_875f1f75","line":317,"updated":"2014-08-25 16:00:09.000000000","message":"For clarify, should used dict and named argument formatting (\"%(protocol)s://...). Where are these conf variables specified? Looks like they were removed.","commit_id":"c639861568cfaa381c3525f4d4a0ebddbe93e1b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"912bb0167cf647da4289d410c361ef0614df8853","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    if conf.auth_uri:"},{"line_number":315,"context_line":"        auth_uri \u003d conf.auth_uri.rstrip(\u0027/\u0027)"},{"line_number":316,"context_line":"    else:"},{"line_number":317,"context_line":"        auth_uri \u003d \u0027%s://%s:%s\u0027 % (conf.auth_protocol,"},{"line_number":318,"context_line":"                                   conf.auth_host,"},{"line_number":319,"context_line":"                                   conf.auth_port)"},{"line_number":320,"context_line":"    return \u0027%s/v2.0\u0027 % auth_uri"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_07407334","line":317,"in_reply_to":"1abeadc6_875f1f75","updated":"2014-09-08 09:22:27.000000000","message":"User is forced to specify either auth_uri (the new way) or auth_[protocol|host|port] (the old way). They were removed from default configuration file that is using new way, but still, existing deployments may use the old values, that\u0027s what the code is for - to handle configuration files that were not migrated to new way yet.","commit_id":"c639861568cfaa381c3525f4d4a0ebddbe93e1b6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5c1a75b4fb15bed74bf107b0a4cbfff7907699ee","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def get_keystone_url(conf):"},{"line_number":363,"context_line":"    if conf.auth_uri:"},{"line_number":364,"context_line":"        auth_uri \u003d conf.auth_uri.rstrip(\u0027/\u0027)"},{"line_number":365,"context_line":"    else:"},{"line_number":366,"context_line":"        auth_uri \u003d (\u0027%(protocol)s://%(host)s:%(port)s\u0027 %"},{"line_number":367,"context_line":"            {\u0027protocol\u0027: conf.auth_protocol,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa98f980_7e5556f9","line":364,"updated":"2014-09-16 17:41:57.000000000","message":"Keystonemiddleware now suggests to use identity_uri rather than (auth_host, auth_protocol, auth_port). How about using identity_uri instead of auth_uri?","commit_id":"32dbe4b650a0aef6b47cddbe2001b698f26ba4db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c04a687932e874bccfd5b42304a25645456aacfe","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def get_keystone_url(conf):"},{"line_number":363,"context_line":"    if conf.auth_uri:"},{"line_number":364,"context_line":"        auth_uri \u003d conf.auth_uri.rstrip(\u0027/\u0027)"},{"line_number":365,"context_line":"    else:"},{"line_number":366,"context_line":"        auth_uri \u003d (\u0027%(protocol)s://%(host)s:%(port)s\u0027 %"},{"line_number":367,"context_line":"            {\u0027protocol\u0027: conf.auth_protocol,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_2589ab26","line":364,"in_reply_to":"fa98f980_7e5556f9","updated":"2014-09-24 09:15:50.000000000","message":"Indeed. Also, auth_uri may be versioned, while identity_uri is unversioned, and existing consumers require v2.0.","commit_id":"32dbe4b650a0aef6b47cddbe2001b698f26ba4db"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5dbb5c23e36cbefd0dcf08daa576f1dfb61e5089","unresolved":false,"context_lines":[{"line_number":368,"context_line":"             \u0027host\u0027: conf.auth_host,"},{"line_number":369,"context_line":"             \u0027port\u0027: conf.auth_port})"},{"line_number":370,"context_line":"    # NOTE(ihrachys): all existing consumers assume version 2.0"},{"line_number":371,"context_line":"    return \u0027%s/v2.0\u0027 % auth_uri"}],"source_content_type":"text/x-python","patch_set":13,"id":"baa201ad_c6e1942b","line":371,"updated":"2014-10-15 11:33:58.000000000","message":"is there really no nicer way than to hard code version here?","commit_id":"f14784a66ca57e1e0e51e7db868675bcffdcf3d7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2e0a0870a6797f447f7db3149482e07415f2b303","unresolved":false,"context_lines":[{"line_number":368,"context_line":"             \u0027host\u0027: conf.auth_host,"},{"line_number":369,"context_line":"             \u0027port\u0027: conf.auth_port})"},{"line_number":370,"context_line":"    # NOTE(ihrachys): all existing consumers assume version 2.0"},{"line_number":371,"context_line":"    return \u0027%s/v2.0\u0027 % auth_uri"}],"source_content_type":"text/x-python","patch_set":13,"id":"baa201ad_c1d5fee5","line":371,"in_reply_to":"baa201ad_c6e1942b","updated":"2014-10-15 11:55:51.000000000","message":"In ideal world, neutron would request that data from service catalog and not config file.","commit_id":"f14784a66ca57e1e0e51e7db868675bcffdcf3d7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d16d3573b9594a503b4d3060e7e731afe3ee0cc","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def get_keystone_url(conf):"},{"line_number":363,"context_line":"    if conf.identity_uri:"},{"line_number":364,"context_line":"        auth_uri \u003d conf.identity_uri.rstrip(\u0027/\u0027)"},{"line_number":365,"context_line":"    else:"},{"line_number":366,"context_line":"        auth_uri \u003d (\u0027%(protocol)s://%(host)s:%(port)s\u0027 %"},{"line_number":367,"context_line":"            {\u0027protocol\u0027: conf.auth_protocol,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_e3483bb5","line":364,"updated":"2014-11-24 05:04:40.000000000","message":"How about using urlparse.urljoin()? It deals duplicated slashes appropriately. For example,\n\n  In [2]: urlparse.urljoin(\u0027http://127.0.0.1:35357/\u0027, \u0027/v2.0/\u0027)\n  Out[2]: \u0027http://127.0.0.1:35357/v2.0/\u0027\n\n  In [3]: urlparse.urljoin(\u0027http://127.0.0.1:35357\u0027, \u0027/v2.0/\u0027)\n  Out[3]: \u0027http://127.0.0.1:35357/v2.0/\u0027","commit_id":"16fab21af203fd6f877a9d881c4e304ed98e8450"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ee2b2e6ba0f9c56903be688735dc6158ff59fff3","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def get_keystone_url(conf):"},{"line_number":363,"context_line":"    if conf.identity_uri:"},{"line_number":364,"context_line":"        auth_uri \u003d conf.identity_uri.rstrip(\u0027/\u0027)"},{"line_number":365,"context_line":"    else:"},{"line_number":366,"context_line":"        auth_uri \u003d (\u0027%(protocol)s://%(host)s:%(port)s\u0027 %"},{"line_number":367,"context_line":"            {\u0027protocol\u0027: conf.auth_protocol,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_a459d836","line":364,"in_reply_to":"5a890539_e3483bb5","updated":"2014-11-24 09:15:25.000000000","message":"But it does not handle correctly the following case:\n\n  \u003e\u003e\u003e urlparse.urljoin(\u0027http://127.0.0.1/keystone\u0027, \u0027/v2.0/\u0027)\n  \u0027http://127.0.0.1/v2.0/\u0027","commit_id":"16fab21af203fd6f877a9d881c4e304ed98e8450"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d16d3573b9594a503b4d3060e7e731afe3ee0cc","unresolved":false,"context_lines":[{"line_number":362,"context_line":"def get_keystone_url(conf):"},{"line_number":363,"context_line":"    if conf.identity_uri:"},{"line_number":364,"context_line":"        auth_uri \u003d conf.identity_uri.rstrip(\u0027/\u0027)"},{"line_number":365,"context_line":"    else:"},{"line_number":366,"context_line":"        auth_uri \u003d (\u0027%(protocol)s://%(host)s:%(port)s\u0027 %"},{"line_number":367,"context_line":"            {\u0027protocol\u0027: conf.auth_protocol,"},{"line_number":368,"context_line":"             \u0027host\u0027: conf.auth_host,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a890539_63eb6b78","line":365,"updated":"2014-11-24 05:04:40.000000000","message":"conf.auth_uri is never considered. Is it intended?\nauth_uri exists in the sample config file, but it is not referred in the code. I think it is confusing.","commit_id":"16fab21af203fd6f877a9d881c4e304ed98e8450"}],"neutron/plugins/ibm/sdnve_api.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"2d34812470ace3d37cb9a4de9b0089a9384b5ec7","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        username \u003d username or keystone_conf.admin_user"},{"line_number":346,"context_line":"        tenant_name \u003d tenant_name or keystone_conf.admin_tenant_name"},{"line_number":347,"context_line":"        password \u003d password or keystone_conf.admin_password"},{"line_number":348,"context_line":"        auth_url \u003d auth_url or keystone_conf.auth_uri"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        self.overlay_signature \u003d cfg.CONF.SDNVE.overlay_signature"},{"line_number":351,"context_line":"        self.of_signature \u003d cfg.CONF.SDNVE.of_signature"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_2c0b6dd7","line":348,"updated":"2014-05-28 09:16:07.000000000","message":"I\u0027m concerned that we\u0027re not providing backwards compatibility for old style configurations.  We should work with the keystone to provide a utility method that constructs the uri from fragments.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df8a8a64365fbdc34c26816c6a9a588da5287737","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        username \u003d username or keystone_conf.admin_user"},{"line_number":346,"context_line":"        tenant_name \u003d tenant_name or keystone_conf.admin_tenant_name"},{"line_number":347,"context_line":"        password \u003d password or keystone_conf.admin_password"},{"line_number":348,"context_line":"        auth_url \u003d auth_url or keystone_conf.auth_uri"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        self.overlay_signature \u003d cfg.CONF.SDNVE.overlay_signature"},{"line_number":351,"context_line":"        self.of_signature \u003d cfg.CONF.SDNVE.of_signature"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_5c4a2481","line":348,"in_reply_to":"3ae8d1ca_2c0b6dd7","updated":"2014-05-28 10:58:40.000000000","message":"We depend on keystoneclient version that will construct auth_uri for us if obsolete options are provided.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d383d114201beee49c3de16beb921316fbb57f75","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        username \u003d username or keystone_conf.admin_user"},{"line_number":346,"context_line":"        tenant_name \u003d tenant_name or keystone_conf.admin_tenant_name"},{"line_number":347,"context_line":"        password \u003d password or keystone_conf.admin_password"},{"line_number":348,"context_line":"        auth_url \u003d auth_url or keystone_conf.auth_uri"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        self.overlay_signature \u003d cfg.CONF.SDNVE.overlay_signature"},{"line_number":351,"context_line":"        self.of_signature \u003d cfg.CONF.SDNVE.of_signature"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_f36c2639","line":348,"in_reply_to":"3ae8d1ca_5c4a2481","updated":"2014-06-03 17:13:06.000000000","message":"We will break upgrades unless we provide support for the old method is keystone_conf.auth_uri is defined.   Keystone\u0027s compatibility is only in the middleware (https://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/middleware/auth_token.py#n477)","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5dbb5c23e36cbefd0dcf08daa576f1dfb61e5089","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        # catalog contents"},{"line_number":351,"context_line":"        auth_url \u003d (auth_url or"},{"line_number":352,"context_line":"                    keystone_conf.auth_uri or"},{"line_number":353,"context_line":"                    utils.get_keystone_url(keystone_conf))"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        self.overlay_signature \u003d cfg.CONF.SDNVE.overlay_signature"},{"line_number":356,"context_line":"        self.of_signature \u003d cfg.CONF.SDNVE.of_signature"}],"source_content_type":"text/x-python","patch_set":13,"id":"baa201ad_86878cb4","line":353,"updated":"2014-10-15 11:33:58.000000000","message":"so in get_keystone_url and after discussion you prefer conf.identity_uri cos \u0027its the right thing to do\u0027 as per keystoneclient recommendation. Here however you prefer conf.auth_uri - of course the problem is that for identity_uri you still have to reconstruct by adding the version.\n\nI feel like all this logic belongs in get_keystone_url anyway as it is repeated for arista - would be neater imo\n\nauth_url \u003d utils.get_keystone_url(conf) \n\nalways. then utils.get_keystone_url can do the right thing.","commit_id":"f14784a66ca57e1e0e51e7db868675bcffdcf3d7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bb3a5eb47808cab26608cf0418e132e6dd1cf3b2","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        # catalog contents"},{"line_number":351,"context_line":"        auth_url \u003d (auth_url or"},{"line_number":352,"context_line":"                    keystone_conf.auth_uri or"},{"line_number":353,"context_line":"                    utils.get_keystone_url(keystone_conf))"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        self.overlay_signature \u003d cfg.CONF.SDNVE.overlay_signature"},{"line_number":356,"context_line":"        self.of_signature \u003d cfg.CONF.SDNVE.of_signature"}],"source_content_type":"text/x-python","patch_set":13,"id":"baa201ad_ff9352a0","line":353,"in_reply_to":"baa201ad_86878cb4","updated":"2014-10-16 15:47:12.000000000","message":"Done","commit_id":"f14784a66ca57e1e0e51e7db868675bcffdcf3d7"}],"neutron/plugins/ml2/drivers/arista/mechanism_arista.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"19312872437d0b0935197b19dc08337572cf4912","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        auth_uri \u003d (keystone_conf.auth_uri or"},{"line_number":380,"context_line":"                    utils.get_keystone_url(keystone_conf))"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        cmds \u003d [\u0027auth url %s user %s password %s tenant %s\u0027 %"},{"line_number":383,"context_line":"                (auth_uri,"},{"line_number":384,"context_line":"                 keystone_conf.admin_user,"},{"line_number":385,"context_line":"                 keystone_conf.admin_password,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_fc96dd4a","line":382,"updated":"2014-09-15 12:02:54.000000000","message":"Nit: could use named format string specifiers and dict for readability on these two.","commit_id":"d42916561e005ffdc3900404eef71beba55732a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea41e15dafb5d86f2241eeb5dba49dc416224c1d","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        auth_uri \u003d (keystone_conf.auth_uri or"},{"line_number":380,"context_line":"                    utils.get_keystone_url(keystone_conf))"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        cmds \u003d [\u0027auth url %s user %s password %s tenant %s\u0027 %"},{"line_number":383,"context_line":"                (auth_uri,"},{"line_number":384,"context_line":"                 keystone_conf.admin_user,"},{"line_number":385,"context_line":"                 keystone_conf.admin_password,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_df6f4bc2","line":382,"in_reply_to":"fa98f980_fc96dd4a","updated":"2014-09-15 12:54:02.000000000","message":"Done","commit_id":"d42916561e005ffdc3900404eef71beba55732a4"}],"neutron/plugins/ml2/drivers/mech_arista/mechanism_arista.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"2d34812470ace3d37cb9a4de9b0089a9384b5ec7","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        critical end-point information is registered with EOS."},{"line_number":370,"context_line":"        \"\"\""},{"line_number":371,"context_line":"        cmds \u003d [\u0027auth url %s user \"%s\" password \"%s\"\u0027 %"},{"line_number":372,"context_line":"                (self.keystone_conf.auth_uri,"},{"line_number":373,"context_line":"                 self.keystone_conf.admin_user,"},{"line_number":374,"context_line":"                 self.keystone_conf.admin_password)]"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_4cb519ed","line":372,"updated":"2014-05-28 09:16:07.000000000","message":"same comment as before on backwards compatibility.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df8a8a64365fbdc34c26816c6a9a588da5287737","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        critical end-point information is registered with EOS."},{"line_number":370,"context_line":"        \"\"\""},{"line_number":371,"context_line":"        cmds \u003d [\u0027auth url %s user \"%s\" password \"%s\"\u0027 %"},{"line_number":372,"context_line":"                (self.keystone_conf.auth_uri,"},{"line_number":373,"context_line":"                 self.keystone_conf.admin_user,"},{"line_number":374,"context_line":"                 self.keystone_conf.admin_password)]"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_bc588857","line":372,"in_reply_to":"3ae8d1ca_4cb519ed","updated":"2014-05-28 10:58:40.000000000","message":"See reply as before.","commit_id":"d5ed0d64b21402f9a2e51112726ac6a2d1f2ad73"}],"neutron/tests/unit/cisco/l3/test_l3_router_appliance_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"19312872437d0b0935197b19dc08337572cf4912","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        test_opts \u003d ["},{"line_number":163,"context_line":"            cfg.StrOpt(\u0027auth_uri\u0027, default\u003d\u0027http://localhost:35357/v2.0\u0027),"},{"line_number":164,"context_line":"            cfg.StrOpt(\u0027admin_user\u0027, default\u003d\u0027neutron\u0027),"},{"line_number":165,"context_line":"            cfg.StrOpt(\u0027admin_password\u0027, default\u003d\u0027secrete\u0027)]"},{"line_number":166,"context_line":"        cfg.CONF.register_opts(test_opts, \u0027keystone_authtoken\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self._mock_l3_admin_tenant()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_1ccba172","line":165,"updated":"2014-09-15 12:02:54.000000000","message":"Outside of patch set, but should have secret\u003dTrue here.","commit_id":"d42916561e005ffdc3900404eef71beba55732a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea41e15dafb5d86f2241eeb5dba49dc416224c1d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        test_opts \u003d ["},{"line_number":163,"context_line":"            cfg.StrOpt(\u0027auth_uri\u0027, default\u003d\u0027http://localhost:35357/v2.0\u0027),"},{"line_number":164,"context_line":"            cfg.StrOpt(\u0027admin_user\u0027, default\u003d\u0027neutron\u0027),"},{"line_number":165,"context_line":"            cfg.StrOpt(\u0027admin_password\u0027, default\u003d\u0027secrete\u0027)]"},{"line_number":166,"context_line":"        cfg.CONF.register_opts(test_opts, \u0027keystone_authtoken\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self._mock_l3_admin_tenant()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_5f5b5b21","line":165,"in_reply_to":"fa98f980_1ccba172","updated":"2014-09-15 12:54:02.000000000","message":"I don\u0027t think it\u0027s worth to be fixed. It\u0027s in unit test.","commit_id":"d42916561e005ffdc3900404eef71beba55732a4"}],"neutron/tests/unit/ml2/drivers/arista/test_arista_mechanism_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"19312872437d0b0935197b19dc08337572cf4912","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    def test_register_with_eos(self):"},{"line_number":507,"context_line":"        self.drv.register_with_eos()"},{"line_number":508,"context_line":"        auth \u003d fake_keystone_info_class()"},{"line_number":509,"context_line":"        auth_cmd \u003d \u0027auth url %s user %s password %s tenant %s\u0027 % ("},{"line_number":510,"context_line":"                    auth.auth_uri,"},{"line_number":511,"context_line":"                    auth.admin_user,"},{"line_number":512,"context_line":"                    auth.admin_password,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_7cbcaddc","line":509,"updated":"2014-09-15 12:02:54.000000000","message":"nit: Could use format specifier strings and dict, for readability.","commit_id":"d42916561e005ffdc3900404eef71beba55732a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea41e15dafb5d86f2241eeb5dba49dc416224c1d","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    def test_register_with_eos(self):"},{"line_number":507,"context_line":"        self.drv.register_with_eos()"},{"line_number":508,"context_line":"        auth \u003d fake_keystone_info_class()"},{"line_number":509,"context_line":"        auth_cmd \u003d \u0027auth url %s user %s password %s tenant %s\u0027 % ("},{"line_number":510,"context_line":"                    auth.auth_uri,"},{"line_number":511,"context_line":"                    auth.admin_user,"},{"line_number":512,"context_line":"                    auth.admin_password,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_dfe90b80","line":509,"in_reply_to":"fa98f980_7cbcaddc","updated":"2014-09-15 12:54:02.000000000","message":"Done","commit_id":"d42916561e005ffdc3900404eef71beba55732a4"}]}
