)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4b474684b15079c7f53eef6c1c64e2a548ea6c2b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a default goto table\u003d94 for openvswitch fw"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If enable explicitly_egress_direct\u003dTrue and set port as"},{"line_number":10,"context_line":"no security group and port_security\u003dFalse, the ingress"},{"line_number":11,"context_line":"flood will reappear. The pipleline is:"},{"line_number":12,"context_line":"Ingress"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aedff3e_22b719fa","line":9,"updated":"2024-02-14 12:39:33.000000000","message":"No action just to be written somewhere.\nexplicitly_egress_direct is now affect ingress traffic also (the same is for developers: the constants ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE is now for ingress traffic also!)\nSo a mental TODO at least should be taken that this is not good cfg option naming for operators, and not good constant naming for maintainers.","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e8591d6614e271ce1600c2c4507e8a8f77d5ac4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a default goto table\u003d94 for openvswitch fw"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If enable explicitly_egress_direct\u003dTrue and set port as"},{"line_number":10,"context_line":"no security group and port_security\u003dFalse, the ingress"},{"line_number":11,"context_line":"flood will reappear. The pipleline is:"},{"line_number":12,"context_line":"Ingress"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ef5fa5d5_d6a19407","line":9,"in_reply_to":"9aedff3e_22b719fa","updated":"2024-04-25 02:07:09.000000000","message":"TODO is added to the config doc.","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"7ccb0c74549662670f6cd081a48876e8c9e1f42f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0d0a64f_c9df5fc8","updated":"2024-02-01 10:47:06.000000000","message":"Liu, thanks for this patch!","commit_id":"44e04bc98e20df3d23db6f2f5a2d4de17a3ac549"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"17c89b333ce1cd891e7ec1f5699cc94149634bb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"549bbaaf_2c5b0251","updated":"2024-02-01 15:09:04.000000000","message":"recheck neutron-functional-with-uwsgi","commit_id":"44e04bc98e20df3d23db6f2f5a2d4de17a3ac549"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4b474684b15079c7f53eef6c1c64e2a548ea6c2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea9f09d1_c1265fa4","updated":"2024-02-14 12:39:33.000000000","message":"If you have to upload a new patch please consider my small doc update comment otherwise just a note that the cfg option and constant naming is not true now (we speak about egress in the cfg and in the constant name but it is affecting ingress also)","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33089a6195cac50f419442f083e550e51fd4a47e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8afcb3f9_746bb4e8","updated":"2024-03-06 22:55:27.000000000","message":"Think there\u0027s just some nits in the docs.\n\nOnce 2024.2 opens we can merge this and backport.","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd3b1939a93986d1bbf556ddaef83b2921966fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52098067_b25d3e3c","updated":"2024-05-06 23:56:52.000000000","message":"Just nit regarding help message typo","commit_id":"b265b1743f1738be343c5a0d76a44ccb0f46995b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"34ab9ccb0eceeb1253b6d4d015bf5b1e2fcc963f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2b5121d_7dca364e","updated":"2024-05-21 03:49:08.000000000","message":"Seems redhat guys are not very interesting in the ml2/ovs, maybe I should push this work in by approving myself then, since this code is running in our deployments for a really long time. And Bence may test this alreay I guess.","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9fe8e969965f088aa65a12fbb67cc38acb72b865","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99ba3e07_9ebc6884","updated":"2024-06-04 04:59:00.000000000","message":"recheck","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f768dfdc4220e5c239490ab105f7b7c7c804a1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"977f85e3_97ff4229","updated":"2024-06-03 02:35:36.000000000","message":"recheck\n\nFailures not realted to this change.","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"53106fb45d6e767258daf044e6a745d878209ae1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eb074c70_29403b51","in_reply_to":"2fa9c3a0_2fa17aaf","updated":"2024-05-24 02:06:42.000000000","message":"Thank you Brian, I understand that the choice of Redhat is definitely based on comprehensive considerations from many aspects.\n\nAdded the list to the \"On Demand Agenda\" with title \"Bug fix and feature of ML2/OVS\".\n\n[1] https://wiki.openstack.org/wiki/Network/Meetings#On_Demand_Agenda","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"98717f250dfd192de4d403805d472cd6c714e60c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2fa9c3a0_2fa17aaf","in_reply_to":"e2b5121d_7dca364e","updated":"2024-05-22 21:38:13.000000000","message":"I\u0027m sorry you are frustrated, there are a number of patches proposed that have never merged, I would like to try and reduce that if possible since the work put into them is not trivial.\n\nBut yes, both Red Hat and Canonical are mainly interested in OVN since Ussuri or so, it\u0027s the decision we\u0027ve made.\n\nMaybe we need to make a list of reviews for ML2/OVS that are priorities for you so we can get them merged? Things tend to get lost otherwise. Can you put that info in the meeting wiki?","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"}],"doc/source/contributor/internals/openvswitch_firewall.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33089a6195cac50f419442f083e550e51fd4a47e","unresolved":true,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"The OVS firewall will initialize a default goto table 94 flow"},{"line_number":529,"context_line":"on TRANSIENT_TABLE |table_60|, if ``explicitly_egress_direct``"},{"line_number":530,"context_line":"is set to True, which is mainly for ports without security group"},{"line_number":531,"context_line":"and disabled port_security. For instance:"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"48b5b73e_f065906c","line":530,"range":{"start_line":530,"start_character":59,"end_line":530,"end_character":64},"updated":"2024-03-06 22:55:27.000000000","message":"nit: s/groups","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e8591d6614e271ce1600c2c4507e8a8f77d5ac4","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"The OVS firewall will initialize a default goto table 94 flow"},{"line_number":529,"context_line":"on TRANSIENT_TABLE |table_60|, if ``explicitly_egress_direct``"},{"line_number":530,"context_line":"is set to True, which is mainly for ports without security group"},{"line_number":531,"context_line":"and disabled port_security. For instance:"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"424fa05d_18fc6374","line":530,"range":{"start_line":530,"start_character":59,"end_line":530,"end_character":64},"in_reply_to":"48b5b73e_f065906c","updated":"2024-04-25 02:07:09.000000000","message":"Done","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4b474684b15079c7f53eef6c1c64e2a548ea6c2b","unresolved":true,"context_lines":[{"line_number":533,"context_line":"::"},{"line_number":534,"context_line":"  table\u003d60, priority\u003d2 actions\u003dresubmit(,94)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Then for packets from the outside to VM witouts security functionalities"},{"line_number":537,"context_line":"will go to table 94 and do the same direct actions."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"cc3178bd_230ce05f","line":536,"range":{"start_line":536,"start_character":48,"end_line":536,"end_character":72},"updated":"2024-02-14 12:39:33.000000000","message":"I think in this doc it worth to mention what you mean by no security functionalities (--disable-port-security --no-security-group \u003d\u003e if I understand well this patch handles these cases)","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4b474684b15079c7f53eef6c1c64e2a548ea6c2b","unresolved":true,"context_lines":[{"line_number":533,"context_line":"::"},{"line_number":534,"context_line":"  table\u003d60, priority\u003d2 actions\u003dresubmit(,94)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Then for packets from the outside to VM witouts security functionalities"},{"line_number":537,"context_line":"will go to table 94 and do the same direct actions."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e10366b3_651a1aad","line":536,"range":{"start_line":536,"start_character":40,"end_line":536,"end_character":47},"updated":"2024-02-14 12:39:33.000000000","message":"nit: without","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e8591d6614e271ce1600c2c4507e8a8f77d5ac4","unresolved":false,"context_lines":[{"line_number":533,"context_line":"::"},{"line_number":534,"context_line":"  table\u003d60, priority\u003d2 actions\u003dresubmit(,94)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Then for packets from the outside to VM witouts security functionalities"},{"line_number":537,"context_line":"will go to table 94 and do the same direct actions."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"20e5e0ee_1d3be263","line":536,"range":{"start_line":536,"start_character":48,"end_line":536,"end_character":72},"in_reply_to":"cc3178bd_230ce05f","updated":"2024-04-25 02:07:09.000000000","message":"Done","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e8591d6614e271ce1600c2c4507e8a8f77d5ac4","unresolved":false,"context_lines":[{"line_number":533,"context_line":"::"},{"line_number":534,"context_line":"  table\u003d60, priority\u003d2 actions\u003dresubmit(,94)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Then for packets from the outside to VM witouts security functionalities"},{"line_number":537,"context_line":"will go to table 94 and do the same direct actions."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"42784852_43d2eeed","line":536,"range":{"start_line":536,"start_character":40,"end_line":536,"end_character":47},"in_reply_to":"e10366b3_651a1aad","updated":"2024-04-25 02:07:09.000000000","message":"Done","commit_id":"af7dbeb352c13adc93323330dfbe5ad63745225f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"111ccf37f3acb83c2295e2cbd63f2003fc166691","unresolved":true,"context_lines":[{"line_number":533,"context_line":"::"},{"line_number":534,"context_line":"  table\u003d60, priority\u003d2 actions\u003dresubmit(,94)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Then for packets from the outside to VM without security functionalities"},{"line_number":537,"context_line":"(--disable-port-security --no-security-group)"},{"line_number":538,"context_line":"will go to table 94 and do the same direct actions."},{"line_number":539,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"a413230a_86ac7264","line":536,"range":{"start_line":536,"start_character":1,"end_line":536,"end_character":72},"updated":"2024-04-30 12:28:40.000000000","message":"yeah this is explicitly _ingress_direct we can say :-)","commit_id":"b265b1743f1738be343c5a0d76a44ccb0f46995b"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"7ccb0c74549662670f6cd081a48876e8c9e1f42f","unresolved":true,"context_lines":[{"line_number":646,"context_line":"                    \u0027resubmit(,%d)\u0027 % ovs_consts.BASE_EGRESS_TABLE,"},{"line_number":647,"context_line":"        )"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        if cfg.CONF.AGENT.explicitly_egress_direct:"},{"line_number":650,"context_line":"            self._add_flow("},{"line_number":651,"context_line":"                table\u003dovs_consts.TRANSIENT_TABLE,"},{"line_number":652,"context_line":"                priority\u003d2,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b911c01e_e95439c1","line":649,"updated":"2024-02-01 10:47:06.000000000","message":"I guess originally ingress and egres here were used in the sense of going in and out of a vm and not in the openflow sense.\n\nHowever at this point this config option really controls both egress and ingress. I understand it\u0027s hard to rename config options, but I believe it would be good to at least document this in the config option help.","commit_id":"44e04bc98e20df3d23db6f2f5a2d4de17a3ac549"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e1985eeeab30d3847cf93fddf0ca068ec77de3f9","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                    \u0027resubmit(,%d)\u0027 % ovs_consts.BASE_EGRESS_TABLE,"},{"line_number":647,"context_line":"        )"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        if cfg.CONF.AGENT.explicitly_egress_direct:"},{"line_number":650,"context_line":"            self._add_flow("},{"line_number":651,"context_line":"                table\u003dovs_consts.TRANSIENT_TABLE,"},{"line_number":652,"context_line":"                priority\u003d2,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e66ca5e_f789fcab","line":649,"in_reply_to":"b911c01e_e95439c1","updated":"2024-02-02 01:00:00.000000000","message":"Ack, sure, I will update the openflow firewall DOC.","commit_id":"44e04bc98e20df3d23db6f2f5a2d4de17a3ac549"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c7f49f2ba41a0efd481a0a2e28f26e6f08d5240b","unresolved":true,"context_lines":[{"line_number":1273,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(dst_port)"},{"line_number":1274,"context_line":"        )"},{"line_number":1275,"context_line":"        # For packets from patch ports."},{"line_number":1276,"context_line":"        self._add_flow("},{"line_number":1277,"context_line":"            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE,"},{"line_number":1278,"context_line":"            priority\u003d12,"},{"line_number":1279,"context_line":"            dl_dst\u003dmac,"},{"line_number":1280,"context_line":"            dl_vlan\u003dvlan_tag,"},{"line_number":1281,"context_line":"            actions\u003d\u0027strip_vlan,output:{:d}\u0027.format(dst_port)"},{"line_number":1282,"context_line":"        )"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"        # The former flow may not match, that means the destination port is"},{"line_number":1285,"context_line":"        # not in this host. So, we direct the packet to mapped bridge(s)."}],"source_content_type":"text/x-python","patch_set":3,"id":"65cdb146_d52c0858","line":1282,"range":{"start_line":1276,"start_character":8,"end_line":1282,"end_character":9},"updated":"2024-03-25 14:46:29.000000000","message":"You need to define the \"flow_group_id\" if you are not providing the \"in_port\" or the \"reg_port\" [1]\n\n[1]https://github.com/openstack/neutron/blob/4e9d03d29fc87c5f9730d55b59b0ddd0201a85e6/neutron/agent/linux/openvswitch_firewall/firewall.py#L602-L610","commit_id":"2d4453b8df11d5c1ba72350f21fb985f52cd67fc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e8591d6614e271ce1600c2c4507e8a8f77d5ac4","unresolved":false,"context_lines":[{"line_number":1273,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(dst_port)"},{"line_number":1274,"context_line":"        )"},{"line_number":1275,"context_line":"        # For packets from patch ports."},{"line_number":1276,"context_line":"        self._add_flow("},{"line_number":1277,"context_line":"            table\u003dovs_consts.ACCEPTED_EGRESS_TRAFFIC_NORMAL_TABLE,"},{"line_number":1278,"context_line":"            priority\u003d12,"},{"line_number":1279,"context_line":"            dl_dst\u003dmac,"},{"line_number":1280,"context_line":"            dl_vlan\u003dvlan_tag,"},{"line_number":1281,"context_line":"            actions\u003d\u0027strip_vlan,output:{:d}\u0027.format(dst_port)"},{"line_number":1282,"context_line":"        )"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"        # The former flow may not match, that means the destination port is"},{"line_number":1285,"context_line":"        # not in this host. So, we direct the packet to mapped bridge(s)."}],"source_content_type":"text/x-python","patch_set":3,"id":"71fced0a_454e4915","line":1282,"range":{"start_line":1276,"start_character":8,"end_line":1282,"end_character":9},"in_reply_to":"65cdb146_d52c0858","updated":"2024-04-25 02:07:09.000000000","message":"Done","commit_id":"2d4453b8df11d5c1ba72350f21fb985f52cd67fc"}],"neutron/conf/plugins/ml2/drivers/ovs_conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd3b1939a93986d1bbf556ddaef83b2921966fbf","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                       \"traffic will not use action NORMAL. The accepted \""},{"line_number":228,"context_line":"                       \"egress packets will be taken care of in the final \""},{"line_number":229,"context_line":"                       \"egress tables direct output flows for unicast \""},{"line_number":230,"context_line":"                       \"traffic. This also will change the pipleline for \""},{"line_number":231,"context_line":"                       \"ingress traffic to ports without security, the final \""},{"line_number":232,"context_line":"                       \"output action will be hit in table 94. \""},{"line_number":233,"context_line":"                       \"TODO(liuyulong): consider adding a new configuration \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9bb9467c_9b6f2b4c","line":230,"range":{"start_line":230,"start_character":33,"end_line":230,"end_character":68},"updated":"2024-05-06 23:56:52.000000000","message":"s/This will also change the pipeline","commit_id":"b265b1743f1738be343c5a0d76a44ccb0f46995b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"915e948a3b6fd4e0183026b7d50cec3779f4b28d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                       \"traffic will not use action NORMAL. The accepted \""},{"line_number":228,"context_line":"                       \"egress packets will be taken care of in the final \""},{"line_number":229,"context_line":"                       \"egress tables direct output flows for unicast \""},{"line_number":230,"context_line":"                       \"traffic. This also will change the pipleline for \""},{"line_number":231,"context_line":"                       \"ingress traffic to ports without security, the final \""},{"line_number":232,"context_line":"                       \"output action will be hit in table 94. \""},{"line_number":233,"context_line":"                       \"TODO(liuyulong): consider adding a new configuration \""}],"source_content_type":"text/x-python","patch_set":4,"id":"a1dad46e_ab79df79","line":230,"range":{"start_line":230,"start_character":33,"end_line":230,"end_character":68},"in_reply_to":"9bb9467c_9b6f2b4c","updated":"2024-05-09 01:25:28.000000000","message":"Done","commit_id":"b265b1743f1738be343c5a0d76a44ccb0f46995b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd3b1939a93986d1bbf556ddaef83b2921966fbf","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                       \"ingress traffic to ports without security, the final \""},{"line_number":232,"context_line":"                       \"output action will be hit in table 94. \""},{"line_number":233,"context_line":"                       \"TODO(liuyulong): consider adding a new configuration \""},{"line_number":234,"context_line":"                       \"item to control ingress behavior.\")),"},{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"dhcp_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"30e69ef0_3fb27282","line":234,"updated":"2024-05-06 23:56:52.000000000","message":"I don\u0027t think we need a TODO in the help message, can put in a comment?","commit_id":"b265b1743f1738be343c5a0d76a44ccb0f46995b"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"915e948a3b6fd4e0183026b7d50cec3779f4b28d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                       \"ingress traffic to ports without security, the final \""},{"line_number":232,"context_line":"                       \"output action will be hit in table 94. \""},{"line_number":233,"context_line":"                       \"TODO(liuyulong): consider adding a new configuration \""},{"line_number":234,"context_line":"                       \"item to control ingress behavior.\")),"},{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"dhcp_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"07a5386b_7e77f0bd","line":234,"in_reply_to":"30e69ef0_3fb27282","updated":"2024-05-09 01:25:28.000000000","message":"Done","commit_id":"b265b1743f1738be343c5a0d76a44ccb0f46995b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"abf028b4f71bdf95b291fb523078f9ca59b80e1b","unresolved":true,"context_lines":[{"line_number":223,"context_line":"    cfg.BoolOpt(\u0027baremetal_smartnic\u0027, default\u003dFalse,"},{"line_number":224,"context_line":"                help\u003d_(\"Enable the agent to process Smart NIC ports.\")),"},{"line_number":225,"context_line":"    # TODO(liuyulong): consider adding a new configuration"},{"line_number":226,"context_line":"    # item to control ingress behavior."},{"line_number":227,"context_line":"    cfg.BoolOpt(\u0027explicitly_egress_direct\u0027, default\u003dFalse,"},{"line_number":228,"context_line":"                help\u003d_(\"When set to True, the accepted egress unicast \""},{"line_number":229,"context_line":"                       \"traffic will not use action NORMAL. The accepted \""}],"source_content_type":"text/x-python","patch_set":5,"id":"c937a5a8_a040f9bd","line":226,"updated":"2024-05-20 09:16:38.000000000","message":"nit: do we really need this TODO here? I have feeling that it will stay here forever and in some time nobody will remember what config knob and why should be considered to be added","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"34ab9ccb0eceeb1253b6d4d015bf5b1e2fcc963f","unresolved":true,"context_lines":[{"line_number":223,"context_line":"    cfg.BoolOpt(\u0027baremetal_smartnic\u0027, default\u003dFalse,"},{"line_number":224,"context_line":"                help\u003d_(\"Enable the agent to process Smart NIC ports.\")),"},{"line_number":225,"context_line":"    # TODO(liuyulong): consider adding a new configuration"},{"line_number":226,"context_line":"    # item to control ingress behavior."},{"line_number":227,"context_line":"    cfg.BoolOpt(\u0027explicitly_egress_direct\u0027, default\u003dFalse,"},{"line_number":228,"context_line":"                help\u003d_(\"When set to True, the accepted egress unicast \""},{"line_number":229,"context_line":"                       \"traffic will not use action NORMAL. The accepted \""}],"source_content_type":"text/x-python","patch_set":5,"id":"6f4b248e_b354768e","line":226,"in_reply_to":"c937a5a8_a040f9bd","updated":"2024-05-21 03:49:08.000000000","message":"If the team can accept patch works a bit more fast, IMO, coders will be happy to do these TODO tasks.","commit_id":"d6f56c5f96c42e1682f3d1723a65253429778c20"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"7ccb0c74549662670f6cd081a48876e8c9e1f42f","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.install_goto(dest_table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":65,"context_line":"        self.install_goto(dest_table_id\u003dconstants.TRANSIENT_TABLE,"},{"line_number":66,"context_line":"                          table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":67,"context_line":"        self.install_normal(table_id\u003dconstants.TRANSIENT_TABLE, priority\u003d1)"},{"line_number":68,"context_line":"        self.init_dhcp(enable_openflow_dhcp\u003denable_openflow_dhcp,"},{"line_number":69,"context_line":"                       enable_dhcpv6\u003denable_dhcpv6)"},{"line_number":70,"context_line":"        self.install_drop(table_id\u003dconstants.ARP_SPOOF_TABLE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"36240328_688c2e16","line":67,"updated":"2024-02-01 10:47:06.000000000","message":"When explicitly_egress_direct is True we\u0027ll never hit the priority\u003d1 normal action, right?","commit_id":"44e04bc98e20df3d23db6f2f5a2d4de17a3ac549"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e1985eeeab30d3847cf93fddf0ca068ec77de3f9","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.install_goto(dest_table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":65,"context_line":"        self.install_goto(dest_table_id\u003dconstants.TRANSIENT_TABLE,"},{"line_number":66,"context_line":"                          table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":67,"context_line":"        self.install_normal(table_id\u003dconstants.TRANSIENT_TABLE, priority\u003d1)"},{"line_number":68,"context_line":"        self.init_dhcp(enable_openflow_dhcp\u003denable_openflow_dhcp,"},{"line_number":69,"context_line":"                       enable_dhcpv6\u003denable_dhcpv6)"},{"line_number":70,"context_line":"        self.install_drop(table_id\u003dconstants.ARP_SPOOF_TABLE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f87dfe0d_d88d9a59","line":67,"in_reply_to":"36240328_688c2e16","updated":"2024-02-02 01:00:00.000000000","message":"Yes, any packets not hit direct flows will still run NORMAL action added by this patch in table 94.","commit_id":"44e04bc98e20df3d23db6f2f5a2d4de17a3ac549"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c7f49f2ba41a0efd481a0a2e28f26e6f08d5240b","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.install_goto(dest_table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":65,"context_line":"        self.install_goto(dest_table_id\u003dconstants.TRANSIENT_TABLE,"},{"line_number":66,"context_line":"                          table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":67,"context_line":"        self.install_normal(table_id\u003dconstants.TRANSIENT_TABLE, priority\u003d1)"},{"line_number":68,"context_line":"        self.init_dhcp(enable_openflow_dhcp\u003denable_openflow_dhcp,"},{"line_number":69,"context_line":"                       enable_dhcpv6\u003denable_dhcpv6)"},{"line_number":70,"context_line":"        self.install_drop(table_id\u003dconstants.ARP_SPOOF_TABLE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2d0f22ba_b60c5f62","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":75},"updated":"2024-03-25 14:46:29.000000000","message":"Why not adding here a branch depending on the \"explicitly_egress_direct\" option? If not defined, use the normal action; if set, add the resubmit flow defined in [1]\n\n[1]https://review.opendev.org/c/openstack/neutron/+/907382/3/neutron/agent/linux/openvswitch_firewall/firewall.py#649","commit_id":"2d4453b8df11d5c1ba72350f21fb985f52cd67fc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3e8591d6614e271ce1600c2c4507e8a8f77d5ac4","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.install_goto(dest_table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":65,"context_line":"        self.install_goto(dest_table_id\u003dconstants.TRANSIENT_TABLE,"},{"line_number":66,"context_line":"                          table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":67,"context_line":"        self.install_normal(table_id\u003dconstants.TRANSIENT_TABLE, priority\u003d1)"},{"line_number":68,"context_line":"        self.init_dhcp(enable_openflow_dhcp\u003denable_openflow_dhcp,"},{"line_number":69,"context_line":"                       enable_dhcpv6\u003denable_dhcpv6)"},{"line_number":70,"context_line":"        self.install_drop(table_id\u003dconstants.ARP_SPOOF_TABLE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed7915b0_f1eb2a9d","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":75},"in_reply_to":"2d0f22ba_b60c5f62","updated":"2024-04-25 02:07:09.000000000","message":"That flow you mentioned is related to the openflow security group, because the direct flows in table 94 are all added there. If there is no security group (firewall_driver \u003d noop, enable_security_group \u003d False), the explicitly_egress_direct controls nothing. And also when agent has no security group enabled (firewall_driver \u003d noop, enable_security_group \u003d False), we have take care of that in the ovs-agent main loop, direct it to table 94 will hurt that. So we should not add that branch here. And current change looks more clear to developers, IMO.","commit_id":"2d4453b8df11d5c1ba72350f21fb985f52cd67fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"111ccf37f3acb83c2295e2cbd63f2003fc166691","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.install_goto(dest_table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":65,"context_line":"        self.install_goto(dest_table_id\u003dconstants.TRANSIENT_TABLE,"},{"line_number":66,"context_line":"                          table_id\u003dPACKET_RATE_LIMIT)"},{"line_number":67,"context_line":"        self.install_normal(table_id\u003dconstants.TRANSIENT_TABLE, priority\u003d1)"},{"line_number":68,"context_line":"        self.init_dhcp(enable_openflow_dhcp\u003denable_openflow_dhcp,"},{"line_number":69,"context_line":"                       enable_dhcpv6\u003denable_dhcpv6)"},{"line_number":70,"context_line":"        self.install_drop(table_id\u003dconstants.ARP_SPOOF_TABLE)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f17aef7b_47fbb7e5","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":75},"in_reply_to":"ed7915b0_f1eb2a9d","updated":"2024-04-30 12:28:40.000000000","message":"I think it is fine now, what worth to check in a follow-up patch to rename these tables/constants etc as it is not just egress but about ingress also","commit_id":"2d4453b8df11d5c1ba72350f21fb985f52cd67fc"}]}