)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5d8fa583d41b8766e2e6d7b05f2f5928741404cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f05dc3c0_e8c35bd5","updated":"2024-02-06 09:00:59.000000000","message":"recheck\nneutron-functional-with-uwsgi failure is not related","commit_id":"1fba25b8dc1dcd5031cd7f5fe1e0032de7c67905"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b95e97e551e11cba6e2e1010e712ca5f32d66fed","unresolved":true,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        raise periodics.NeverAgain()"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    # TODO(slaweq): Remove this in the C+3 cycle"},{"line_number":930,"context_line":"    @has_lock_periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":931,"context_line":"    def add_gw_port_info_to_logical_router_port(self):"},{"line_number":932,"context_line":"        \"\"\"Add info if LRP is connecting internal subnet or ext gateway.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"874302c3_7be34215","line":929,"range":{"start_line":929,"start_character":20,"end_line":929,"end_character":48},"updated":"2024-02-01 12:43:01.000000000","message":"could you explain why to remove this method?","commit_id":"9fb4b0fe0c7a74348c4c63df4097ed4968f942fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed8d42192b927445ea7648defccc6650bca3892","unresolved":true,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        raise periodics.NeverAgain()"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    # TODO(slaweq): Remove this in the C+3 cycle"},{"line_number":930,"context_line":"    @has_lock_periodic(spacing\u003d600, run_immediately\u003dTrue)"},{"line_number":931,"context_line":"    def add_gw_port_info_to_logical_router_port(self):"},{"line_number":932,"context_line":"        \"\"\"Add info if LRP is connecting internal subnet or ext gateway.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"f20c559c_41f979c1","line":929,"range":{"start_line":929,"start_character":20,"end_line":929,"end_character":48},"in_reply_to":"874302c3_7be34215","updated":"2024-02-09 08:40:33.000000000","message":"In C release it will be run and new key will be added to external ids in the deployments. In next SLURP release it won\u0027t be needed anymore IMO (and yes, I updated todo comment to remove it in the next SLURP cycle, which will be E).","commit_id":"9fb4b0fe0c7a74348c4c63df4097ed4968f942fc"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"69b455535e5f0adb9891824ca825222932f59528","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY:"},{"line_number":1579,"context_line":"                utils.ovn_name(port[\u0027network_id\u0027]),"},{"line_number":1580,"context_line":"            ovn_const.OVN_ROUTER_IS_EXT_GW:"},{"line_number":1581,"context_line":"                str(const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get(\u0027device_owner\u0027))}"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        router_id \u003d port.get(\u0027device_id\u0027)"},{"line_number":1584,"context_line":"        if router_id:"}],"source_content_type":"text/x-python","patch_set":4,"id":"b94cf8d6_aae54b87","line":1581,"range":{"start_line":1581,"start_character":76,"end_line":1581,"end_character":77},"updated":"2024-02-09 08:28:20.000000000","message":"nit: add a new line to keep the git history next time we add a new parameter.","commit_id":"d4a526d888f8437ccc2d5e93f99b78292170a18e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed8d42192b927445ea7648defccc6650bca3892","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY:"},{"line_number":1579,"context_line":"                utils.ovn_name(port[\u0027network_id\u0027]),"},{"line_number":1580,"context_line":"            ovn_const.OVN_ROUTER_IS_EXT_GW:"},{"line_number":1581,"context_line":"                str(const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get(\u0027device_owner\u0027))}"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        router_id \u003d port.get(\u0027device_id\u0027)"},{"line_number":1584,"context_line":"        if router_id:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea5beb39_226cb8fb","line":1581,"range":{"start_line":1581,"start_character":76,"end_line":1581,"end_character":77},"in_reply_to":"b94cf8d6_aae54b87","updated":"2024-02-09 08:40:33.000000000","message":"Done","commit_id":"d4a526d888f8437ccc2d5e93f99b78292170a18e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2faeb54b2ccbc0325ed8eca65985096a176cb698","unresolved":true,"context_lines":[{"line_number":1579,"context_line":"                utils.ovn_name(port[\u0027network_id\u0027]),"},{"line_number":1580,"context_line":"            ovn_const.OVN_ROUTER_IS_EXT_GW:"},{"line_number":1581,"context_line":"                str(const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get(\u0027device_owner\u0027)),"},{"line_number":1582,"context_line":"            }"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"        router_id \u003d port.get(\u0027device_id\u0027)"},{"line_number":1585,"context_line":"        if router_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd3f700f_7524959f","line":1582,"range":{"start_line":1582,"start_character":12,"end_line":1582,"end_character":13},"updated":"2024-02-09 09:44:47.000000000","message":"this may need to be at the same indent as ext_ids, according to hacking","commit_id":"5abcc7c4553f611d9eee81a1431854952090c01f"}],"neutron/services/portforwarding/drivers/ovn/driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"69b455535e5f0adb9891824ca825222932f59528","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            if not network_id:"},{"line_number":154,"context_line":"                continue"},{"line_number":155,"context_line":"            if ovn_utils.is_provider_network(network_id):"},{"line_number":156,"context_line":"                LOG.warning(\"Port forwarding %(pf_id)s configured in the \""},{"line_number":157,"context_line":"                            \"router %(router_id)s will not work properly as \""},{"line_number":158,"context_line":"                            \"distributed floating IPs are enabled \""},{"line_number":159,"context_line":"                            \"and at least one provider network \""}],"source_content_type":"text/x-python","patch_set":4,"id":"92c25b97_783c53a9","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":28},"updated":"2024-02-09 08:28:20.000000000","message":"Be careful: you are not passing the variables to format the string.","commit_id":"d4a526d888f8437ccc2d5e93f99b78292170a18e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed8d42192b927445ea7648defccc6650bca3892","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if not network_id:"},{"line_number":154,"context_line":"                continue"},{"line_number":155,"context_line":"            if ovn_utils.is_provider_network(network_id):"},{"line_number":156,"context_line":"                LOG.warning(\"Port forwarding %(pf_id)s configured in the \""},{"line_number":157,"context_line":"                            \"router %(router_id)s will not work properly as \""},{"line_number":158,"context_line":"                            \"distributed floating IPs are enabled \""},{"line_number":159,"context_line":"                            \"and at least one provider network \""}],"source_content_type":"text/x-python","patch_set":4,"id":"943bf38f_e57f158c","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":28},"in_reply_to":"92c25b97_783c53a9","updated":"2024-02-09 08:40:33.000000000","message":"Done","commit_id":"d4a526d888f8437ccc2d5e93f99b78292170a18e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"69b455535e5f0adb9891824ca825222932f59528","unresolved":true,"context_lines":[{"line_number":157,"context_line":"                            \"router %(router_id)s will not work properly as \""},{"line_number":158,"context_line":"                            \"distributed floating IPs are enabled \""},{"line_number":159,"context_line":"                            \"and at least one provider network \""},{"line_number":160,"context_line":"                            \"(%(network_id)s)is connected to that router. \""},{"line_number":161,"context_line":"                            \"See bug https://launchpad.net/bugs/2028846 for \""},{"line_number":162,"context_line":"                            \"more details.\")"},{"line_number":163,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"8fded3b2_4e732411","line":160,"range":{"start_line":160,"start_character":45,"end_line":160,"end_character":47},"updated":"2024-02-09 08:28:20.000000000","message":"nit: add a space","commit_id":"d4a526d888f8437ccc2d5e93f99b78292170a18e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"aed8d42192b927445ea7648defccc6650bca3892","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                            \"router %(router_id)s will not work properly as \""},{"line_number":158,"context_line":"                            \"distributed floating IPs are enabled \""},{"line_number":159,"context_line":"                            \"and at least one provider network \""},{"line_number":160,"context_line":"                            \"(%(network_id)s)is connected to that router. \""},{"line_number":161,"context_line":"                            \"See bug https://launchpad.net/bugs/2028846 for \""},{"line_number":162,"context_line":"                            \"more details.\")"},{"line_number":163,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"c40fd2a7_a871b575","line":160,"range":{"start_line":160,"start_character":45,"end_line":160,"end_character":47},"in_reply_to":"8fded3b2_4e732411","updated":"2024-02-09 08:40:33.000000000","message":"Done","commit_id":"d4a526d888f8437ccc2d5e93f99b78292170a18e"}]}