)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f51886c6130787be7f0afd0c265a876f7cf0f874","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4fa639d_665eb112","updated":"2024-02-07 07:13:31.000000000","message":"+1 only because this change deserves a short release note","commit_id":"b1c17fbf02dac2c4cae8728a4fca95a4f1a06ea8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d6111dd93bafe11ed0521739ff9014cbd60d9231","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45187870_5fc85d73","updated":"2024-02-07 16:08:13.000000000","message":"As suggested by Rodolfo, a short relnote would be good.","commit_id":"b1c17fbf02dac2c4cae8728a4fca95a4f1a06ea8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a46967f05bd6eb5be4b7fb31dba4047025e3bacd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43165d62_0a2d703f","updated":"2024-02-08 04:39:25.000000000","message":"Yeah, I\u0027ll add a release note as suggested. Seems I didn\u0027t `git add` when I created this patch ...","commit_id":"b1c17fbf02dac2c4cae8728a4fca95a4f1a06ea8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3afc485338bbf915cfc8d436ca6f8fb2ea4b5c8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5dddbe8_1528f5e9","in_reply_to":"a4fa639d_665eb112","updated":"2024-02-08 08:11:08.000000000","message":"Done","commit_id":"b1c17fbf02dac2c4cae8728a4fca95a4f1a06ea8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1b42b882766517f5a9bebc1f890443686307d058","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0f2876dc_7fe4ccd5","updated":"2024-02-09 10:54:22.000000000","message":"Good clean-up of those config options. Thanks!","commit_id":"8f2f14ae31e630a7fa5d601b876a982f145093b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"26ea6841447fe681cc5c466b6a8c6110c767357f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3d0ae462_e4b04c97","updated":"2024-02-12 08:51:46.000000000","message":"recheck\npip package conflict, in some jobs, hope this is temporary","commit_id":"78e8f1dca0769877ecdd412e73841d7a90b5b8e5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e45199f152fa4cbc1795635245d39f4597a94ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d658500d_1cae2ab1","updated":"2024-02-12 17:49:48.000000000","message":"recheck timeout is irrelevant to this change.","commit_id":"78e8f1dca0769877ecdd412e73841d7a90b5b8e5"}],"neutron/conf/service.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d6111dd93bafe11ed0521739ff9014cbd60d9231","unresolved":true,"context_lines":[{"line_number":30,"context_line":"                      \u0027of CPUs available for best performance, capped by \u0027"},{"line_number":31,"context_line":"                      \u0027potential RAM usage.\u0027)),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027rpc_workers\u0027,"},{"line_number":33,"context_line":"               min\u003d0,"},{"line_number":34,"context_line":"               help\u003d_(\u0027Number of RPC worker processes for service. \u0027"},{"line_number":35,"context_line":"                      \u0027If not specified, the default is equal to half the \u0027"},{"line_number":36,"context_line":"                      \u0027number of API workers. If set to 0, no RPC worker \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"6cd6dd20_f9293e96","line":33,"updated":"2024-02-07 16:08:13.000000000","message":"This answers my question from the other review, so you can ignore that.","commit_id":"b1c17fbf02dac2c4cae8728a4fca95a4f1a06ea8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3afc485338bbf915cfc8d436ca6f8fb2ea4b5c8d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                      \u0027of CPUs available for best performance, capped by \u0027"},{"line_number":31,"context_line":"                      \u0027potential RAM usage.\u0027)),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027rpc_workers\u0027,"},{"line_number":33,"context_line":"               min\u003d0,"},{"line_number":34,"context_line":"               help\u003d_(\u0027Number of RPC worker processes for service. \u0027"},{"line_number":35,"context_line":"                      \u0027If not specified, the default is equal to half the \u0027"},{"line_number":36,"context_line":"                      \u0027number of API workers. If set to 0, no RPC worker \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bbd720d8_2727aa7c","line":33,"in_reply_to":"6cd6dd20_f9293e96","updated":"2024-02-08 08:11:08.000000000","message":"Done","commit_id":"b1c17fbf02dac2c4cae8728a4fca95a4f1a06ea8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"64a21dfe704f39ae1fba202b37d14571d1cab422","unresolved":true,"context_lines":[{"line_number":24,"context_line":"               default\u003d40,"},{"line_number":25,"context_line":"               help\u003d_(\u0027Seconds between running periodic tasks.\u0027)),"},{"line_number":26,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027,"},{"line_number":27,"context_line":"               min\u003d1,"},{"line_number":28,"context_line":"               help\u003d_(\u0027Number of separate API worker processes for service. \u0027"},{"line_number":29,"context_line":"                      \u0027If not specified, the default is equal to the number \u0027"},{"line_number":30,"context_line":"                      \u0027of CPUs available for best performance, capped by \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7d3301b8_29c7be98","line":27,"range":{"start_line":27,"start_character":15,"end_line":27,"end_character":20},"updated":"2024-02-08 10:11:14.000000000","message":"the default currently is that if api_workers isnot set the default will be counted (https://opendev.org/openstack/neutron/src/branch/master/neutron/service.py#L151 ), so setting it to 1 as default makes that part useless","commit_id":"1ab177ed2b60dc606f2b70009b3d193f91844c2c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cc0dd083b119413c09567a9bf6eea103299200c9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"               default\u003d40,"},{"line_number":25,"context_line":"               help\u003d_(\u0027Seconds between running periodic tasks.\u0027)),"},{"line_number":26,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027,"},{"line_number":27,"context_line":"               min\u003d1,"},{"line_number":28,"context_line":"               help\u003d_(\u0027Number of separate API worker processes for service. \u0027"},{"line_number":29,"context_line":"                      \u0027If not specified, the default is equal to the number \u0027"},{"line_number":30,"context_line":"                      \u0027of CPUs available for best performance, capped by \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"b4f19ba3_4bc5914b","line":27,"range":{"start_line":27,"start_character":15,"end_line":27,"end_character":20},"in_reply_to":"7d3301b8_29c7be98","updated":"2024-02-08 12:41:30.000000000","message":"this is not default but the minimum boundary. The default is still None.","commit_id":"1ab177ed2b60dc606f2b70009b3d193f91844c2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7ed39f4220cf6750093153fd178509fdda841bc8","unresolved":true,"context_lines":[{"line_number":24,"context_line":"               default\u003d40,"},{"line_number":25,"context_line":"               help\u003d_(\u0027Seconds between running periodic tasks.\u0027)),"},{"line_number":26,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027,"},{"line_number":27,"context_line":"               min\u003d1,"},{"line_number":28,"context_line":"               help\u003d_(\u0027Number of separate API worker processes for service. \u0027"},{"line_number":29,"context_line":"                      \u0027If not specified, the default is equal to the number \u0027"},{"line_number":30,"context_line":"                      \u0027of CPUs available for best performance, capped by \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"c005741a_a537def0","line":27,"range":{"start_line":27,"start_character":15,"end_line":27,"end_character":20},"in_reply_to":"b4f19ba3_4bc5914b","updated":"2024-02-12 08:50:48.000000000","message":"right","commit_id":"1ab177ed2b60dc606f2b70009b3d193f91844c2c"}],"neutron/tests/unit/test_service.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9b87a9a4a892c3ca0eaf083d2c51703fe3268880","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        self.assertEqual(expected_call, start_call)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_api_workers_zero(self):"},{"line_number":96,"context_line":"        self._test_api_workers(1, 1)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_api_workers_default(self):"},{"line_number":99,"context_line":"        self._test_api_workers(None, self.worker_count)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a5d1204_785b4c20","line":96,"updated":"2024-02-12 05:22:56.000000000","message":"the test case no longer matches with test name","commit_id":"8f2f14ae31e630a7fa5d601b876a982f145093b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dacf5a6fdd38f9b288a6d20ff36d745cef2e21fe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.assertEqual(expected_call, start_call)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_api_workers_zero(self):"},{"line_number":96,"context_line":"        self._test_api_workers(1, 1)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_api_workers_default(self):"},{"line_number":99,"context_line":"        self._test_api_workers(None, self.worker_count)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dc1b60c2_13bf76fc","line":96,"in_reply_to":"1a5d1204_785b4c20","updated":"2024-02-12 05:55:36.000000000","message":"good catch ! done.","commit_id":"8f2f14ae31e630a7fa5d601b876a982f145093b0"}]}