)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eaf608a5d37838b319bebc87fc69ea6e69c86702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99a08b0f_d3a0b769","updated":"2024-02-23 16:31:28.000000000","message":"recheck, https://review.opendev.org/c/openstack/neutron/+/909998 merged","commit_id":"9811b36a06fd3b4951947d923e235a1033b886f3"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"6b0f1a01591c878047ab7f31b32af83f7161f264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91ae8df9_594dad01","updated":"2024-02-27 08:31:57.000000000","message":"The proposed fix in this patch is incorrect as the length of `gateway_old` may differ from `gateway_new` even when there are no changes in number of actual ports.\n\nWill follow up with a correct solution.","commit_id":"af6f4d8958602c32ff2c206157096c7a1a799342"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ae56bc25bbae365f8a46d6158622cb39a5d82656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2de67141_9f0dfc00","updated":"2024-02-26 12:29:09.000000000","message":"recheck","commit_id":"af6f4d8958602c32ff2c206157096c7a1a799342"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"fd4e8e381f0ba67922a1aabeac53768d772574cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"63f19cf3_f20b8531","updated":"2024-02-29 10:13:30.000000000","message":"Last failure due to issue unrelated to this change, awaiting resolution in https://review.opendev.org/c/openstack/neutron/+/910583","commit_id":"af66a6137bdec3823ba9c0d08426b7a61de134c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"af72d065cb06b71c23dfc833a3378c5f73ff38a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"72ca8045_f17f58c1","updated":"2024-02-29 18:23:04.000000000","message":"recheck dependency gate failure","commit_id":"743bd1ccefa0735a0b9460d1c231a66b372c99d0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e9c9101ed6ec1ec2409195220328c3d5634b580d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e4adaa2c_599bd29a","updated":"2024-03-01 03:36:42.000000000","message":"recheck test timeout","commit_id":"743bd1ccefa0735a0b9460d1c231a66b372c99d0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c67906999f45eff71bea31ded943f6b9c406883e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"347e811e_bbe62804","updated":"2024-02-29 23:19:26.000000000","message":"recheck unrelated test failure","commit_id":"743bd1ccefa0735a0b9460d1c231a66b372c99d0"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ad8f9703af78710047a784f3067031ed1916f5dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0b1b375a_083ba511","updated":"2024-03-01 06:59:48.000000000","message":"recheck unrelated test failures (tearDown `tempest.api.compute.admin.test_volume.AttachSCSIVolumeTestJSON` and setupClass `tempest.api.compute.admin.test_hypervisor.HypervisorAdminUnderV252Test`)","commit_id":"743bd1ccefa0735a0b9460d1c231a66b372c99d0"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ea1310a460d11aad75bb36d35e0d79b63c39b118","unresolved":true,"context_lines":[{"line_number":1470,"context_line":"                    ovn_router_ext_gw_lrps \u003d ["},{"line_number":1471,"context_line":"                        port"},{"line_number":1472,"context_line":"                        for port in getattr(ovn_router, \u0027ports\u0027, [])"},{"line_number":1473,"context_line":"                        if getattr(port, \u0027external_ids\u0027, {}).get("},{"line_number":1474,"context_line":"                            ovn_const.OVN_ROUTER_IS_EXT_GW) \u003d\u003d \u0027True\u0027"},{"line_number":1475,"context_line":"                    ]"},{"line_number":1476,"context_line":"                    if (len(gateway_new) !\u003d len(ovn_router_ext_gw_lrps) or"},{"line_number":1477,"context_line":"                        self._check_external_ips_changed("}],"source_content_type":"text/x-python","patch_set":9,"id":"a1eb9bf7_5a161654","line":1474,"range":{"start_line":1473,"start_character":28,"end_line":1474,"end_character":59},"updated":"2024-02-28 19:04:41.000000000","message":"can we use strutils.bool_from_string from oslo_utils here, and check that bool is actuallt True?\nif strutils.bool_from_string(getattr(port, \u0027external_ids\u0027, {}).get(\n                               ovn_const.OVN_ROUTER_IS_EXT_GW, False)","commit_id":"abd226fce4675666b388463b700d018c2981b708"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"26942c1dc0e044a7bbbe1120aa82b9778adacd1c","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"                    ovn_router_ext_gw_lrps \u003d ["},{"line_number":1471,"context_line":"                        port"},{"line_number":1472,"context_line":"                        for port in getattr(ovn_router, \u0027ports\u0027, [])"},{"line_number":1473,"context_line":"                        if getattr(port, \u0027external_ids\u0027, {}).get("},{"line_number":1474,"context_line":"                            ovn_const.OVN_ROUTER_IS_EXT_GW) \u003d\u003d \u0027True\u0027"},{"line_number":1475,"context_line":"                    ]"},{"line_number":1476,"context_line":"                    if (len(gateway_new) !\u003d len(ovn_router_ext_gw_lrps) or"},{"line_number":1477,"context_line":"                        self._check_external_ips_changed("}],"source_content_type":"text/x-python","patch_set":9,"id":"c9534240_5e260dc2","line":1474,"range":{"start_line":1473,"start_character":28,"end_line":1474,"end_character":59},"in_reply_to":"a1eb9bf7_5a161654","updated":"2024-02-29 08:03:01.000000000","message":"That is indeed a nice improvement. Thank you for pointing it out!\n\nNew patch set on the way.","commit_id":"abd226fce4675666b388463b700d018c2981b708"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dfea5e4fd5ea6b7614ec5d167727a4eb8147efd6","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"                        for port in getattr(ovn_router, \u0027ports\u0027, [])"},{"line_number":1474,"context_line":"                        if strutils.bool_from_string("},{"line_number":1475,"context_line":"                            getattr(port, \u0027external_ids\u0027, {}).get("},{"line_number":1476,"context_line":"                                ovn_const.OVN_ROUTER_IS_EXT_GW, False))"},{"line_number":1477,"context_line":"                    ]"},{"line_number":1478,"context_line":"                    if (len(gateway_new) !\u003d len(ovn_router_ext_gw_lrps) or"},{"line_number":1479,"context_line":"                        self._check_external_ips_changed("}],"source_content_type":"text/x-python","patch_set":11,"id":"fc121477_8ab163c8","line":1476,"range":{"start_line":1476,"start_character":62,"end_line":1476,"end_character":69},"updated":"2024-02-29 15:49:03.000000000","message":"nit: not necessary, \"None\" will return False","commit_id":"743bd1ccefa0735a0b9460d1c231a66b372c99d0"}]}
