)]}'
{"MANIFEST.in":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"c74c70e224e617ebd2193bea7ca7969109555b63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"include Authors"},{"line_number":2,"context_line":"include ChangeLog"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"exclude .gitignore"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAJn%2F%2F%2F90%3D","line":1,"updated":"2012-06-29 11:43:10.000000000","message":"quantum/openstack/common/setup.py generates AUTHORS","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"include Authors"},{"line_number":2,"context_line":"include ChangeLog"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"exclude .gitignore"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAJn%2F%2F%2Fw8%3D","line":1,"in_reply_to":"AAAAJn%2F%2F%2F90%3D","updated":"2012-06-29 17:11:40.000000000","message":"Yes. This is why it needs to be included in the MANIFEST.in. By default with this patch, everything that\u0027s stored in git will be included, but git does not store AUTHORS (or ChangeLog) - but we still want it in the tarball.","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"include Authors"},{"line_number":2,"context_line":"include ChangeLog"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"exclude .gitignore"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAJn%2F%2F%2Fso%3D","line":1,"in_reply_to":"AAAAJn%2F%2F%2FvQ%3D","updated":"2012-06-29 17:48:02.000000000","message":"BWAHAHAHAHA. Nice. Thanks!","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"c74c70e224e617ebd2193bea7ca7969109555b63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"include Authors"},{"line_number":2,"context_line":"include ChangeLog"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"exclude .gitignore"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAJn%2F%2F%2FvQ%3D","line":1,"in_reply_to":"AAAAJn%2F%2F%2Fw8%3D","updated":"2012-06-29 17:24:42.000000000","message":"I guess I wasn\u0027t clear, note the case, should be AUTHORS\nUnless you\u0027re on case-insensitive filesystem, setup.py sdist shows\nwarning: no files found matching \u0027Authors\u0027\nWorks with follow-up patch:\n--- a/MANIFEST.in\n+++ b/MANIFEST.in\n@@ -1,4 +1,4 @@\n-include Authors\n+include AUTHORS\n include ChangeLog\n \n exclude .gitignore","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"}],"setup.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"23dc09b8d16ec43f759c7b7e29f4404f325e8180","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    install_requires\u003drequires,"},{"line_number":83,"context_line":"    dependency_links\u003ddepend_links,"},{"line_number":84,"context_line":"    include_package_data\u003dFalse,"},{"line_number":85,"context_line":"    setup_requires\u003d[\u0027setuptools_git\u003e\u003d0.4\u0027],"},{"line_number":86,"context_line":"    packages\u003dsetuptools.find_packages(\u0027.\u0027),"},{"line_number":87,"context_line":"    cmdclass\u003dsetup.get_cmdclass(),"},{"line_number":88,"context_line":"    data_files\u003dDataFiles,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAJ3%2F%2F%2F00%3D","line":85,"updated":"2012-07-02 01:04:22.000000000","message":"Why should we add this? Is it related to the bug referred to or other feature? If it has nothing to do with the bug referred to, we had better have it in another change.","commit_id":"6d9ddf1c3737762fa12ce3b910075ed05da48cd9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"    install_requires\u003drequires,"},{"line_number":83,"context_line":"    dependency_links\u003ddepend_links,"},{"line_number":84,"context_line":"    include_package_data\u003dFalse,"},{"line_number":85,"context_line":"    setup_requires\u003d[\u0027setuptools_git\u003e\u003d0.4\u0027],"},{"line_number":86,"context_line":"    packages\u003dsetuptools.find_packages(\u0027.\u0027),"},{"line_number":87,"context_line":"    cmdclass\u003dsetup.get_cmdclass(),"},{"line_number":88,"context_line":"    data_files\u003dDataFiles,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAJ3%2F%2F%2FzM%3D","line":85,"in_reply_to":"AAAAJ3%2F%2F%2F00%3D","updated":"2012-07-02 02:25:57.000000000","message":"This is one of the ways we can solve this, which solves it more systemically rather than symptom at a time. We could solve it directly in MANIFEST.in, but we\u0027re actually looking at migrating away from listing files to include in MANIFEST.in across the project. So - two bird with one stone.","commit_id":"6d9ddf1c3737762fa12ce3b910075ed05da48cd9"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"    install_requires\u003drequires,"},{"line_number":83,"context_line":"    dependency_links\u003ddepend_links,"},{"line_number":84,"context_line":"    include_package_data\u003dFalse,"},{"line_number":85,"context_line":"    setup_requires\u003d[\u0027setuptools_git\u003e\u003d0.4\u0027],"},{"line_number":86,"context_line":"    packages\u003dsetuptools.find_packages(\u0027.\u0027),"},{"line_number":87,"context_line":"    cmdclass\u003dsetup.get_cmdclass(),"},{"line_number":88,"context_line":"    data_files\u003dDataFiles,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAJ3%2F%2F%2Fyc%3D","line":85,"in_reply_to":"AAAAJ3%2F%2F%2Fys%3D","updated":"2012-07-02 03:09:12.000000000","message":"It is possible to make a completely different patch that fixes the bug alone. However, that would just fix the current symptom of the bug, and would not solve the root cause.\n\nIt is not possible to add setuptools-git and not also make the corresponding change to MANIFEST.in\n\nThis has nothing to do with the berrange article. This is about addressing in a more systematic way how files are included in sdist tarballs. You\u0027ll note we\u0027ve merged a similar patch to nova recently:\n\nhttps://review.openstack.org/#/c/8912/\n\nand I intend to submit similar patches to the other projects.\n\nAs for this change, I could make a patch that just includes the specific missing files in MANIFEST.in, but I\u0027d just follow it with a patch which would be this patch again and would remove the lines from MANIFEST.in again - so it seems like extra work to make a patch I\u0027m just going to revert. However - I\u0027m a flexible guy :)","commit_id":"6d9ddf1c3737762fa12ce3b910075ed05da48cd9"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"23dc09b8d16ec43f759c7b7e29f4404f325e8180","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    install_requires\u003drequires,"},{"line_number":83,"context_line":"    dependency_links\u003ddepend_links,"},{"line_number":84,"context_line":"    include_package_data\u003dFalse,"},{"line_number":85,"context_line":"    setup_requires\u003d[\u0027setuptools_git\u003e\u003d0.4\u0027],"},{"line_number":86,"context_line":"    packages\u003dsetuptools.find_packages(\u0027.\u0027),"},{"line_number":87,"context_line":"    cmdclass\u003dsetup.get_cmdclass(),"},{"line_number":88,"context_line":"    data_files\u003dDataFiles,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAJ3%2F%2F%2Fys%3D","line":85,"in_reply_to":"AAAAJ3%2F%2F%2FzM%3D","updated":"2012-07-02 02:52:16.000000000","message":"Can the MANIFEST.in fix the bug alone?\nCan the setuptools_git fix the bug alone?\nDo we need both to fix the bug?\nDoes the two birds with one stone fit in with http://berrange.com/posts/2012/06/27/thoughts-on-improving-openstack-git-commit-practicehistory/?","commit_id":"6d9ddf1c3737762fa12ce3b910075ed05da48cd9"}],"tools/install_venv.py":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"c74c70e224e617ebd2193bea7ca7969109555b63","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    run_command([\u0027tools/with_venv.sh\u0027, \u0027pip\u0027, \u0027install\u0027, \u0027-r\u0027,"},{"line_number":99,"context_line":"                 TEST_REQUIRES], redirect_output\u003dFalse)"},{"line_number":100,"context_line":"    run_command([\u0027tools/with_venv.sh\u0027, \u0027pip\u0027, \u0027install\u0027,"},{"line_number":101,"context_line":"                 \u0027setuptools_git\u003e\u003d0.4\u0027], redirect_output\u003dFalse)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # Tell the virtual env how to \"import quantum\""},{"line_number":104,"context_line":"    pthfile \u003d os.path.join(venv, \"lib\", PY_VERSION, \"site-packages\","}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAJn%2F%2F%2FqM%3D","line":101,"updated":"2012-06-29 18:16:10.000000000","message":"Too bad this must be duplicated here and in setup.py but I don\u0027t see other way...","commit_id":"b0889f95b219ad277889d32b85d9d7d7915fa002"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":98,"context_line":"    run_command([\u0027tools/with_venv.sh\u0027, \u0027pip\u0027, \u0027install\u0027, \u0027-r\u0027,"},{"line_number":99,"context_line":"                 TEST_REQUIRES], redirect_output\u003dFalse)"},{"line_number":100,"context_line":"    run_command([\u0027tools/with_venv.sh\u0027, \u0027pip\u0027, \u0027install\u0027,"},{"line_number":101,"context_line":"                 \u0027setuptools_git\u003e\u003d0.4\u0027], redirect_output\u003dFalse)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # Tell the virtual env how to \"import quantum\""},{"line_number":104,"context_line":"    pthfile \u003d os.path.join(venv, \"lib\", PY_VERSION, \"site-packages\","}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAJn%2F%2F%2FmM%3D","line":101,"in_reply_to":"AAAAJn%2F%2F%2FqM%3D","updated":"2012-06-29 19:38:29.000000000","message":"Agree.","commit_id":"b0889f95b219ad277889d32b85d9d7d7915fa002"}],"tools/pip-requires":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"c74c70e224e617ebd2193bea7ca7969109555b63","unresolved":false,"context_lines":[{"line_number":5,"context_line":"lxml"},{"line_number":6,"context_line":"netaddr"},{"line_number":7,"context_line":"python-gflags\u003d\u003d1.3"},{"line_number":8,"context_line":"setuptools_git\u003e\u003d0.4"},{"line_number":9,"context_line":"sqlalchemy\u003e0.6.4"},{"line_number":10,"context_line":"webob\u003d\u003d1.2.0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAJn%2F%2F%2F9w%3D","line":8,"updated":"2012-06-29 11:43:10.000000000","message":"Isn\u0027t pip-requires for run-time, not build-time dependencies?","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"lxml"},{"line_number":6,"context_line":"netaddr"},{"line_number":7,"context_line":"python-gflags\u003d\u003d1.3"},{"line_number":8,"context_line":"setuptools_git\u003e\u003d0.4"},{"line_number":9,"context_line":"sqlalchemy\u003e0.6.4"},{"line_number":10,"context_line":"webob\u003d\u003d1.2.0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAJn%2F%2F%2Fwo%3D","line":8,"in_reply_to":"AAAAJn%2F%2F%2F9w%3D","updated":"2012-06-29 17:11:40.000000000","message":"Mostly - but in this case, it\u0027s kind of hard to run setup.py without it, and that\u0027s needed to run python setup.py develop. Also, this file is used for tox\u0027s creation of virtualenvs.","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"lxml"},{"line_number":6,"context_line":"netaddr"},{"line_number":7,"context_line":"python-gflags\u003d\u003d1.3"},{"line_number":8,"context_line":"setuptools_git\u003e\u003d0.4"},{"line_number":9,"context_line":"sqlalchemy\u003e0.6.4"},{"line_number":10,"context_line":"webob\u003d\u003d1.2.0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAJn%2F%2F%2FsY%3D","line":8,"in_reply_to":"AAAAJn%2F%2F%2Fu8%3D","updated":"2012-06-29 17:48:02.000000000","message":"I\u0027m a gonna try something completely different. One sec...","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"c74c70e224e617ebd2193bea7ca7969109555b63","unresolved":false,"context_lines":[{"line_number":5,"context_line":"lxml"},{"line_number":6,"context_line":"netaddr"},{"line_number":7,"context_line":"python-gflags\u003d\u003d1.3"},{"line_number":8,"context_line":"setuptools_git\u003e\u003d0.4"},{"line_number":9,"context_line":"sqlalchemy\u003e0.6.4"},{"line_number":10,"context_line":"webob\u003d\u003d1.2.0"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAJn%2F%2F%2Fu8%3D","line":8,"in_reply_to":"AAAAJn%2F%2F%2Fwo%3D","updated":"2012-06-29 17:24:42.000000000","message":"\u003e this file is used for tox\u0027s creation of virtualenvs\n\nShould it be in test-requires then?","commit_id":"6d4b6ea190b26deb2c01af09c6b2cbc0b19c9e75"}]}
