)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b97dbbeba1bcb0ac0a295a95d40620c6ef652772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f6b944d_bbe9e154","updated":"2024-03-20 07:23:41.000000000","message":"In this patch it was also needed to bump the oslo.service version","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"67fc148bbe8239efbce27511b07a756f1bef141e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"020e7018_5f1e930d","updated":"2024-03-08 14:52:22.000000000","message":"The patch depends on oslo service but zuul should take care of the dependency","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2e6498ce321c864e49a6552d0cd0da98b3675b8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f07a2bf_e877062d","updated":"2024-03-11 09:06:57.000000000","message":"This patch will need to bump the oslo.service version, once merged the patch.","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"757ee44c6c0d7f4abb861e10f75481c1f9615ade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c68925a8_0e2dd686","updated":"2024-03-15 16:32:03.000000000","message":"Would be nice to forbid adding new signal handlers omitting oslo.service somehow. Maybe even just with with flake8 check for signal.signal... (can always be overridden with # noqa).","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f4dd741053ba10b9f20c81fa00e0801e6ad34ae0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"84e21e3c_8f72e9ba","updated":"2024-03-19 17:02:44.000000000","message":"rechech\n\nthe patch this depends on has merged","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1f3a2eebe67a15efde3756f357fd7cae6a583906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21a5b9a9_e74c868c","updated":"2024-03-19 18:56:27.000000000","message":"recheck dependent merged","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6636fb8c699c230185a4eb6d52d9268777c67c6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c5035c1_d18393d9","in_reply_to":"78ed270a_7e977ee3","updated":"2024-06-03 20:25:40.000000000","message":"3.5.0 was tagged and is available as of May 23rd","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc2163076c9e493a7db154cd92dc759a262d257e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"93a0ed0d_5f0ac345","in_reply_to":"7c5035c1_d18393d9","updated":"2024-06-03 21:06:03.000000000","message":"Thanks. Bumping here: https://review.opendev.org/c/openstack/neutron/+/921079","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ba09388b9e973bd44e59436ac0449c0c0744c7b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de3e4a13_539f0592","in_reply_to":"7f6b944d_bbe9e154","updated":"2024-03-20 13:50:40.000000000","message":"I guess I missed that with all the +2\u0027s. Terry - can you send a follow-up?","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba156e7c08f7a4860cb74eacbdd43b8b645cb802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"78ed270a_7e977ee3","in_reply_to":"9b20eca1_cf88d788","updated":"2024-06-03 20:21:17.000000000","message":"Was it bumped since then?","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c537132810e6f3e789cf11e099d6b6464cfdfd60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9b20eca1_cf88d788","in_reply_to":"de3e4a13_539f0592","updated":"2024-03-20 15:12:47.000000000","message":"Is there an actual oslo.service version that includes the patch with which to update the requirements? I wouldn\u0027t think so yet.","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"757ee44c6c0d7f4abb861e10f75481c1f9615ade","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        # Attempt to remove the node from the ring when the worker stops"},{"line_number":316,"context_line":"        sh \u003d oslo_service.SignalHandler()"},{"line_number":317,"context_line":"        atexit.register(self._remove_node_from_hash_ring)"},{"line_number":318,"context_line":"        sh.add_handler(\"SIGTERM\", self._remove_node_from_hash_ring)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":321,"context_line":"        if not self._hash_ring_probe_event.is_set():"}],"source_content_type":"text/x-python","patch_set":4,"id":"f3dabc06_ffe68a01","line":318,"updated":"2024-03-15 16:32:03.000000000","message":"(that\u0027s a curious api to pass a string and not a signal value...)","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f31557b3ef08a40ad08feb43774b8cb187e03c74","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # Attempt to remove the node from the ring when the worker stops"},{"line_number":316,"context_line":"        sh \u003d oslo_service.SignalHandler()"},{"line_number":317,"context_line":"        atexit.register(self._remove_node_from_hash_ring)"},{"line_number":318,"context_line":"        sh.add_handler(\"SIGTERM\", self._remove_node_from_hash_ring)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":321,"context_line":"        if not self._hash_ring_probe_event.is_set():"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f8a06a2_679a1ded","line":318,"in_reply_to":"6a798a99_e45f2119","updated":"2024-03-19 22:09:25.000000000","message":"yeah, it irritated me as well and cost me about 20 minutes of debugging. but the api is what it is at this point.","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"77029093e71465d7f553f12107af6af8c8dc008b","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        # Attempt to remove the node from the ring when the worker stops"},{"line_number":316,"context_line":"        sh \u003d oslo_service.SignalHandler()"},{"line_number":317,"context_line":"        atexit.register(self._remove_node_from_hash_ring)"},{"line_number":318,"context_line":"        sh.add_handler(\"SIGTERM\", self._remove_node_from_hash_ring)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":321,"context_line":"        if not self._hash_ring_probe_event.is_set():"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a798a99_e45f2119","line":318,"in_reply_to":"f3dabc06_ffe68a01","updated":"2024-03-18 13:03:43.000000000","message":"true, the valid values are collected here: https://opendev.org/openstack/oslo.service/src/branch/master/oslo_service/service.py#L138","commit_id":"a4e49b6b8fcf9acfa4e84c65de19ffd56b9022e7"}]}
