)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d2cddf88fac82f1991829454085387cf00b0b2f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a0bc035_86c1a7cc","updated":"2024-03-20 21:33:15.000000000","message":"Thanks for fixing this.\n\nIf you don\u0027t mind we might as well add a release note saying it\u0027s now available in the other drivers, the steps are:\n\n(assuming you\u0027re in your neutron repo)\n$ reno new \"some-name-describing-change\" (but use a real string there)\nCreated new notes file in releasenotes/notes/\"some-name\"-a7a0107b8bc464af.yaml\n\nedit resulting file, deleting all the lines and add something like this:\n\n+---\n+features:\n+  - |\n+    Remote address group support was added to the iptables-based firewall\n+    drivers (IptablesFirewallDriver and OVSHybridIptablesFirewallDriver),\n+    Previously it was only available in the OVSFirewallDriver.\n+    For more information, see bug\n+    `2058138 \u003chttps://bugs.launchpad.net/neutron/+bug/2058138\u003e`_\n\n$ git add $file","commit_id":"7651d1fb0697a235725d246105324f377391c066"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9f35f630a2dc3281869dd3c4afd52141171666aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dde7c525_60985b87","updated":"2024-03-21 12:52:00.000000000","message":"How is this patch dealing with address groups of different IP types? (IPv4 and IPv6)","commit_id":"5e1188ef38da3f196aadf82a3842fa982c9a0c83"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9029f96677977eb1a625a0489a5db337cf87b093","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04866b7f_5c42939e","updated":"2024-03-21 08:28:10.000000000","message":"thanks","commit_id":"5e1188ef38da3f196aadf82a3842fa982c9a0c83"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"e336d541b5888c0639bc9d823333c83873bb679d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9dc512c4_08c0397a","in_reply_to":"8a347b25_a0890069","updated":"2024-03-21 22:54:22.000000000","message":"Thanks for reviewing. I\u0027d appreciate a pointer please.\n\nI assert that remote address groups and remote security groups share the same underlying implementation. If IPv6 works with remote security groups, and we expect it does, we\u0027d also expect IPv6 to work with remote address groups.","commit_id":"5e1188ef38da3f196aadf82a3842fa982c9a0c83"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c2f04d3cc6e18f206fd2730c0cdd8acfa446107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c89e12c_f4e2e354","in_reply_to":"9dc512c4_08c0397a","updated":"2024-03-25 14:24:05.000000000","message":"An address group can have multiple IPs with different types (4 and 6). By default, a rule is only type 4 or 6. In any case, if we are considering just the rule definition, we should only take the specific Ip types.\n\nApart from this, I was expecting more testing than what is provided in this patch. But this morning I saw https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/913850. Due to this validation, I\u0027ll approve the backports.\n\nIn any case, I would like to consider, for future testing patches, how it works with an AG with IPv4 and IPv6 addresses.","commit_id":"5e1188ef38da3f196aadf82a3842fa982c9a0c83"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd0659dc5808e771186b809558fb2732e33c552b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a347b25_a0890069","in_reply_to":"dde7c525_60985b87","updated":"2024-03-21 14:41:38.000000000","message":"Can you explain a little more Rodolfo? I couldn\u0027t exactly see where the OVS firewall driver did this.","commit_id":"5e1188ef38da3f196aadf82a3842fa982c9a0c83"}],"releasenotes/notes/iptables-support-remote-address-groups-89da589aad3c01d3.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67328cf137b70691ec32521c2860f8d502b79df5","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    drivers (IptablesFirewallDriver and OVSHybridIptablesFirewallDriver),"},{"line_number":6,"context_line":"    Previously it was only available in the OVSFirewallDriver."},{"line_number":7,"context_line":"    For more information, see bug"},{"line_number":8,"context_line":"    `2058138 \u003chttps://bugs.launchpad.net/neutron/+bug/2058138\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ae1c55da_a71d0141","line":8,"updated":"2024-03-20 23:37:00.000000000","message":"I don\u0027t think the below warning matters, release notes seemed to render correctly","commit_id":"5e1188ef38da3f196aadf82a3842fa982c9a0c83"}]}