)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5acac4e4247a5b076df4d46dce02ddfb920eb758","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68c08f7d_edf3fa97","updated":"2024-05-15 15:09:55.000000000","message":"This is incorporated into https://review.opendev.org/c/openstack/neutron/+/919594 now. Thanks for your work, this should\u0027ve merged a lot earlier.","commit_id":"c5483ec3a7e169dc6c04d6db2f3d6a9f0e59ec31"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"81de0e61d15c214c860db77371321af3e057caed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30e4942d_8f5aa8ec","in_reply_to":"68c08f7d_edf3fa97","updated":"2024-05-15 15:29:47.000000000","message":"thanks!  believe me I was not excited to change the behavior of str(url) but the security implications / complaints as you can imagine became impossible to ignore","commit_id":"c5483ec3a7e169dc6c04d6db2f3d6a9f0e59ec31"}],"neutron/tests/fullstack/base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"916606718b1b7dbc94279c70b9237d04441bd99f","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        # neutron server against this database."},{"line_number":61,"context_line":"        _orig_db_url \u003d cfg.CONF.database.connection"},{"line_number":62,"context_line":"        cfg.CONF.set_override("},{"line_number":63,"context_line":"            \u0027connection\u0027, self.engine.url.render_as_string(hide_password\u003dFalse), group\u003d\u0027database\u0027)"},{"line_number":64,"context_line":"        self.addCleanup("},{"line_number":65,"context_line":"            cfg.CONF.set_override,"},{"line_number":66,"context_line":"            \"connection\", _orig_db_url, group\u003d\"database\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f37f8d4_496c276b","line":63,"updated":"2024-03-21 15:00:07.000000000","message":"Thanks for the change.\n\nLooking into this it seems the functional tests have a helper for this, and the unit test code uses this same bad behavior as above so needs the same fix.\n\nWe should move the render_url_str() helper from neutron/tests/functional/db/test_migrations.py to neutron/tests/common/helpers.py (or somewhere similar) then just use it everywhere.","commit_id":"62b9c4e6422ec1c57513751fcee8bfdc5e6df1c5"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"4904a4ea070145c932f9878c7a43fa699ffe0edf","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        # neutron server against this database."},{"line_number":61,"context_line":"        _orig_db_url \u003d cfg.CONF.database.connection"},{"line_number":62,"context_line":"        cfg.CONF.set_override("},{"line_number":63,"context_line":"            \u0027connection\u0027, self.engine.url.render_as_string(hide_password\u003dFalse), group\u003d\u0027database\u0027)"},{"line_number":64,"context_line":"        self.addCleanup("},{"line_number":65,"context_line":"            cfg.CONF.set_override,"},{"line_number":66,"context_line":"            \"connection\", _orig_db_url, group\u003d\"database\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dd2766bb_cc9e906d","line":63,"in_reply_to":"3f37f8d4_496c276b","updated":"2024-05-15 13:55:51.000000000","message":"\u003e the unit test code uses this same bad behavior as above so needs the same fix.\n\nI\u0027m not able to locate this code.  the unit tests pass under SQLAlchemy 2.0 so I dont know that the password matters in such cases if that\u0027s in fact what\u0027s being used.\n\nRight now neutron fullstack tests are failing and they are proposing to revert the SQLAlchemy 2.0 reqs bump, I think this should be merged ASAP instead.","commit_id":"62b9c4e6422ec1c57513751fcee8bfdc5e6df1c5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"45c3294fafe8ce1b799ea9c1bf7595a07946ffb7","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        # neutron server against this database."},{"line_number":61,"context_line":"        _orig_db_url \u003d cfg.CONF.database.connection"},{"line_number":62,"context_line":"        cfg.CONF.set_override("},{"line_number":63,"context_line":"            \u0027connection\u0027, self.engine.url.render_as_string(hide_password\u003dFalse), group\u003d\u0027database\u0027)"},{"line_number":64,"context_line":"        self.addCleanup("},{"line_number":65,"context_line":"            cfg.CONF.set_override,"},{"line_number":66,"context_line":"            \"connection\", _orig_db_url, group\u003d\"database\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7cea768e_2e9c5038","line":63,"in_reply_to":"dd2766bb_cc9e906d","updated":"2024-05-15 14:04:44.000000000","message":"Yeah, I can deal with any code duplication later. Problem is the pep8 job is also broken so we\u0027ll need to add this to https://review.opendev.org/c/openstack/neutron/+/919594 and fix everything at once.","commit_id":"62b9c4e6422ec1c57513751fcee8bfdc5e6df1c5"}]}