)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87b822ae86f2c6a6b474983f0ac679b89ab41536","unresolved":true,"context_lines":[{"line_number":17,"context_line":"receiving a 502 or 503 HTTP status code. Let\u0027s also consider this"},{"line_number":18,"context_line":"situation and add support for an additional 504 code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Close-Bug: #2059032"},{"line_number":21,"context_line":"Change-Id: I16be18c46a6796224b0793dc385b0ddec01739c4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f0e53653_d6bcd0e2","line":20,"updated":"2024-03-25 19:28:58.000000000","message":"nit: Closes-Bug","commit_id":"c3c560d0d1b0fcc39b8061f1ccc2b51f9dcb82b4"},{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"0e9620c9ef62e7c4a21de75a5482ab11f5b068c5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"receiving a 502 or 503 HTTP status code. Let\u0027s also consider this"},{"line_number":18,"context_line":"situation and add support for an additional 504 code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Close-Bug: #2059032"},{"line_number":21,"context_line":"Change-Id: I16be18c46a6796224b0793dc385b0ddec01739c4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f15c47c_7d2570a6","line":20,"in_reply_to":"f0e53653_d6bcd0e2","updated":"2024-03-26 08:31:36.000000000","message":"Done","commit_id":"c3c560d0d1b0fcc39b8061f1ccc2b51f9dcb82b4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87b822ae86f2c6a6b474983f0ac679b89ab41536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ae4d4bb_8ae8fa34","updated":"2024-03-25 19:28:58.000000000","message":"Thanks for working on this.\n\nThe OVN metadata agent has almost identical code, and would also need an update:\n\n  neutron/agent/ovn/metadata/server.py\n\nI combined the driver code last cycle, will have to see if there is a way to combine this, will put it in my PTG notes.","commit_id":"c3c560d0d1b0fcc39b8061f1ccc2b51f9dcb82b4"},{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"0e9620c9ef62e7c4a21de75a5482ab11f5b068c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a6c99034_a818e851","in_reply_to":"5ae4d4bb_8ae8fa34","updated":"2024-03-26 08:31:36.000000000","message":"Thanks. I\u0027ve fixed ovn place as well","commit_id":"c3c560d0d1b0fcc39b8061f1ccc2b51f9dcb82b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"54b883781bdc3591f16c84617c9b82f47c74b4ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf63f933_cec588f9","updated":"2024-03-26 10:41:38.000000000","message":"Code looks ok, nice patch.\n\n-1 just because this patch deserves a release note (in \"others\" section, most probably). Once merged, we should backport it.\n\n**nit (not related to this patch)**: checking this code, I realized that we have a lot of duplicated code. https://review.opendev.org/c/openstack/neutron/+/894399 was a good improvement but we need to continue re-factoring (aka. de-duplicating) the metadata code.","commit_id":"514c6beecd301f8a653f83f08ab0a06d19fdd4f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ed66815d46f576cc939a8c03139a0728c184603f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3ba5c73_cea7b963","in_reply_to":"8637651f_521847ae","updated":"2024-03-26 13:48:57.000000000","message":"Rodolfo - yes I noticed the same and put it on the PTG list, started working on a change similar to what I did previously in metadata code too 😊","commit_id":"514c6beecd301f8a653f83f08ab0a06d19fdd4f9"},{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"b5cbb4a6fdccfd6591658f8912f8f0c8329d4be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8637651f_521847ae","in_reply_to":"bf63f933_cec588f9","updated":"2024-03-26 12:16:20.000000000","message":"Thanks, I\u0027ve added the release note.","commit_id":"514c6beecd301f8a653f83f08ab0a06d19fdd4f9"}],"neutron/agent/metadata/agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"54b883781bdc3591f16c84617c9b82f47c74b4ba","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            LOG.warning(msg)"},{"line_number":278,"context_line":"            explanation \u003d str(msg)"},{"line_number":279,"context_line":"            return webob.exc.HTTPInternalServerError(explanation\u003dexplanation)"},{"line_number":280,"context_line":"        elif resp.status_code in (400, 404, 409, 502, 503, 504):"},{"line_number":281,"context_line":"            webob_exc_cls \u003d webob.exc.status_map.get(resp.status_code)"},{"line_number":282,"context_line":"            return webob_exc_cls()"},{"line_number":283,"context_line":"        else:"},{"line_number":284,"context_line":"            raise Exception(_(\u0027Unexpected response code: %s\u0027) %"},{"line_number":285,"context_line":"                            resp.status_code)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b45ee0ce_83463097","line":282,"range":{"start_line":280,"start_character":8,"end_line":282,"end_character":34},"updated":"2024-03-26 10:41:38.000000000","message":"+1 nice (and tested)","commit_id":"514c6beecd301f8a653f83f08ab0a06d19fdd4f9"}]}
