)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4a02cfa990362765444549f9f3019577e60b7471","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the previous patch, we did account for the MTU showing up"},{"line_number":10,"context_line":"in the external IDs however the code only sets it if it\u0027s using"},{"line_number":11,"context_line":"a remote managed port binding.  This code instead sets the binding"},{"line_number":12,"context_line":"for all the inerface types instead."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Change-Id: I7ff300e9634e5e3fc68d70540392109fd8b9babc"},{"line_number":15,"context_line":"Closes-Bug: 2053274"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b02a34e2_a602db8b","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":20},"updated":"2024-03-28 20:24:02.000000000","message":"nit: interface","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"8a7b572744673caab87fb43410ac732bfead547e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99ebbc81_fe8af6ba","updated":"2024-06-04 15:49:07.000000000","message":"I have restored this because I think it is an important issue that still needs to be resolved.","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"802824f06a4863d9ed474e7826019b1f869d9a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"25523afc_163549b8","updated":"2024-04-01 19:47:18.000000000","message":"This seems to have fixed things on our side, I have a few other fires to put out before I can come back to polish this right now...","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4a02cfa990362765444549f9f3019577e60b7471","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3c7a15e_b4769fdd","updated":"2024-03-28 20:24:02.000000000","message":"This was the file so it\u0027s obvious to reviewers:\n\nhttps://review.opendev.org/c/openstack/neutron/+/909684/4/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85a18dda4cf9d18ebb3f9359f9686f269c965607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e17c3511_37fd4b11","updated":"2024-06-06 13:27:20.000000000","message":"recheck","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4a02cfa990362765444549f9f3019577e60b7471","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        address6_scope_id \u003d \"\""},{"line_number":342,"context_line":"        dhcpv4_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_4)"},{"line_number":343,"context_line":"        dhcpv6_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_6)"},{"line_number":344,"context_line":"        mtu \u003d \u0027\u0027"},{"line_number":345,"context_line":"        if vtep_physical_switch:"},{"line_number":346,"context_line":"            vtep_logical_switch \u003d bp_info.bp_param.get(\u0027vtep-logical-switch\u0027)"},{"line_number":347,"context_line":"            port_type \u003d \u0027vtep\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"04299c71_04b37d42","line":344,"updated":"2024-03-28 20:24:02.000000000","message":"Is there a reason to not just move it up here? Is there a case we don\u0027t want to set the mtu? Or a case when it\u0027s 0? Which we can account for.\n\n        port_net \u003d self._plugin.get_network(\n            context, port[\u0027network_id\u0027])\n        mtu \u003d str(port_net[\u0027mtu\u0027] or \u0027\u0027)","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8d4ba2840aa66270d95020e08ef393dfd97128d9","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        address6_scope_id \u003d \"\""},{"line_number":342,"context_line":"        dhcpv4_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_4)"},{"line_number":343,"context_line":"        dhcpv6_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_6)"},{"line_number":344,"context_line":"        mtu \u003d \u0027\u0027"},{"line_number":345,"context_line":"        if vtep_physical_switch:"},{"line_number":346,"context_line":"            vtep_logical_switch \u003d bp_info.bp_param.get(\u0027vtep-logical-switch\u0027)"},{"line_number":347,"context_line":"            port_type \u003d \u0027vtep\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e871c28_1bd06c92","line":344,"in_reply_to":"04299c71_04b37d42","updated":"2024-03-29 08:37:38.000000000","message":"+1","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cc20428ab2621f780d8dc102f3d7a10d9be73f4c","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        address6_scope_id \u003d \"\""},{"line_number":342,"context_line":"        dhcpv4_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_4)"},{"line_number":343,"context_line":"        dhcpv6_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_6)"},{"line_number":344,"context_line":"        mtu \u003d \u0027\u0027"},{"line_number":345,"context_line":"        if vtep_physical_switch:"},{"line_number":346,"context_line":"            vtep_logical_switch \u003d bp_info.bp_param.get(\u0027vtep-logical-switch\u0027)"},{"line_number":347,"context_line":"            port_type \u003d \u0027vtep\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5defdcfc_459ac71f","line":344,"in_reply_to":"2e871c28_1bd06c92","updated":"2024-03-29 08:38:13.000000000","message":"And in order to make the mistake I did, we should have a test for this.","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"94bfe0c08675753a9893bd7f3eb9e93096891f1f","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        address6_scope_id \u003d \"\""},{"line_number":342,"context_line":"        dhcpv4_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_4)"},{"line_number":343,"context_line":"        dhcpv6_options \u003d self._get_port_dhcp_options(port, const.IP_VERSION_6)"},{"line_number":344,"context_line":"        mtu \u003d \u0027\u0027"},{"line_number":345,"context_line":"        if vtep_physical_switch:"},{"line_number":346,"context_line":"            vtep_logical_switch \u003d bp_info.bp_param.get(\u0027vtep-logical-switch\u0027)"},{"line_number":347,"context_line":"            port_type \u003d \u0027vtep\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf1a6b2e_8734f27a","line":344,"in_reply_to":"5defdcfc_459ac71f","updated":"2024-04-18 16:57:56.000000000","message":"Having special handling for zero value is not needed: metadata agent already ignores mtu\u003d\u00270\u0027.\n\nA reason not to propagate it for all ports is that it pollutes the NB and SB databases, increasing their sizes. We could probably set it only when the type is one of\n\n```\nOVN_VIF_PORT_TYPES \u003d (\n    \"\", ovn_const.LSP_TYPE_EXTERNAL, ovn_const.LSP_TYPE_LOCALPORT)\n```\n\n(as defined in neutron/agent/ovn/metadata/agent.py)","commit_id":"608a5f422487414f1f31abe1f2ff68bc741ba727"}]}