)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e169114a54486c4c045b279ce8496a1f160dd4f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6975fb5_2dda6ff9","updated":"2024-04-18 17:14:14.000000000","message":"Just a minor cleanup missing, otherwise good.","commit_id":"921c5d053ee633abeb8ddd536f39022f9476edc0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2924077c3f13d6893388d8587c34eb82fd713633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7380d4f7_8fbbe99f","updated":"2024-04-22 13:40:30.000000000","message":"recheck\nhmmmm, I can\u0027t see the reason in the logs why test_trunk_subport_lifecycle failed in both jobs, but very suspicious","commit_id":"9ed152ba77ce80bea7e24af55bd5164388bc461b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"948b91fcac2a48e4772bab1df587dbd234921c2f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f37e5a0_ea46703c","in_reply_to":"3377fedb_3c2b5958","updated":"2024-04-26 08:16:08.000000000","message":"I think this separation (TrunkSkeleton \u003d\u003e RPC backend | ServerSideRpcBackend \u003d\u003e RPC notifier) is fine","commit_id":"9ed152ba77ce80bea7e24af55bd5164388bc461b"},{"author":{"_account_id":30314,"name":"Sebastian Lohff","email":"sebastian.lohff@sap.com","username":"seba"},"change_message_id":"e2318afd8d100b694c4987384feda98bd9f0740d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3377fedb_3c2b5958","in_reply_to":"7380d4f7_8fbbe99f","updated":"2024-04-23 14:52:12.000000000","message":"It looks like the notifiers are not started, as they are part of ServerSideRpcBackend and the RPC server is in TrunkSkeleton. I separated them, so that the ServerSideRpcBackend with the notifiers is created unconditionally (in neutron-server and neutron-rpc-server IFF rpc is requested by a driver) and TrunkSkeleton only by start_rpc_listeners(). Also documented that in an extra block in the commit message.\n\nEssentially all the naming here should probably be cleaned up, but I wanted to have a running PoC before we decide if we want to do further cleanup in this PR or leave it for another time.\n\nSo... yeah, open for discussion. :)","commit_id":"9ed152ba77ce80bea7e24af55bd5164388bc461b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8664d21a159a92c437c90192a26bb2f4fde4ea4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f2ed9e40_cf512412","updated":"2024-05-03 21:19:19.000000000","message":"@Mitchell FYI Arista CI broke after this patch.","commit_id":"ffcaeda32adf32388c322cfc6f7a8933ef94d2a9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ad21b0b1d5e18898792491c06ad33f9556d862e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"73ffdc3a_3c920760","updated":"2024-05-02 08:45:31.000000000","message":"Thanks","commit_id":"ffcaeda32adf32388c322cfc6f7a8933ef94d2a9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1c3d0b48cedbc8b44d3195db01ab8872400b1daf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"60838e88_e5b8e692","updated":"2024-05-02 22:21:49.000000000","message":"recheck unrelated failure","commit_id":"ffcaeda32adf32388c322cfc6f7a8933ef94d2a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ef779bd0ef54aceef7d2aa09c7cc091ddbf28342","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6c53443e_e422e729","in_reply_to":"07b8205d_b8a7b229","updated":"2024-05-04 17:29:00.000000000","message":"Thank you Mitchell for quick fix!","commit_id":"ffcaeda32adf32388c322cfc6f7a8933ef94d2a9"},{"author":{"_account_id":19710,"name":"Mitchell Jameson","email":"mitchell@arista.com","username":"mitchell"},"change_message_id":"51f14c92bff920aa0e3cc465d606f6a0618f00d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07b8205d_b8a7b229","in_reply_to":"7e2c32f1_94cec1fe","updated":"2024-05-04 00:10:11.000000000","message":"Just a test that needed updating, fixed by https://review.opendev.org/c/x/networking-arista/+/918150","commit_id":"ffcaeda32adf32388c322cfc6f7a8933ef94d2a9"},{"author":{"_account_id":19710,"name":"Mitchell Jameson","email":"mitchell@arista.com","username":"mitchell"},"change_message_id":"fba20050ca9c4e41dc09085d7908016d6ac7ed32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7e2c32f1_94cec1fe","in_reply_to":"f2ed9e40_cf512412","updated":"2024-05-03 21:58:00.000000000","message":"Thanks, I\u0027ll take a look","commit_id":"ffcaeda32adf32388c322cfc6f7a8933ef94d2a9"}],"neutron/services/trunk/plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e169114a54486c4c045b279ce8496a1f160dd4f2","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            raise trunk_exc.SegmentationTypeValidatorNotFound("},{"line_number":164,"context_line":"                seg_type\u003dseg_type)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def is_rpc_enabled(self):"},{"line_number":167,"context_line":"        return self._rpc_backend is not None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def register_driver(self, driver):"}],"source_content_type":"text/x-python","patch_set":2,"id":"88c042b4_c9434627","line":166,"updated":"2024-04-18 17:14:14.000000000","message":"this is no longer used","commit_id":"921c5d053ee633abeb8ddd536f39022f9476edc0"},{"author":{"_account_id":30314,"name":"Sebastian Lohff","email":"sebastian.lohff@sap.com","username":"seba"},"change_message_id":"32dc72c31f29f45566565c7d2035f456468c91fd","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            raise trunk_exc.SegmentationTypeValidatorNotFound("},{"line_number":164,"context_line":"                seg_type\u003dseg_type)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def is_rpc_enabled(self):"},{"line_number":167,"context_line":"        return self._rpc_backend is not None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def register_driver(self, driver):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b385aac_96e2cb3b","line":166,"in_reply_to":"88c042b4_c9434627","updated":"2024-04-19 12:35:51.000000000","message":"Will do. Initially I wasn\u0027t sure if should remove it, as it looked like a method that might be used by somebody else (i.e. some off-repo driver).","commit_id":"921c5d053ee633abeb8ddd536f39022f9476edc0"}]}