)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c4ae3c37866f028ee9a8a5eef71a7637edb88cf8","unresolved":true,"context_lines":[{"line_number":11,"context_line":"whole transaction fails. Added if_exists\u003dTrue so the"},{"line_number":12,"context_line":"transaction do not fail for such deleted ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/919696"},{"line_number":15,"context_line":"Closes-Bug: #2065701"},{"line_number":16,"context_line":"Related-Bug: #2060163"},{"line_number":17,"context_line":"Change-Id: Ie0ce420414f1e6056d9df2733b7446d02c89fcfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa05fd5c_a69887ed","line":14,"updated":"2024-05-16 16:26:39.000000000","message":"this will have to be released first.","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5ad5c310462f2143bbeae951e13387a51d9027ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"whole transaction fails. Added if_exists\u003dTrue so the"},{"line_number":12,"context_line":"transaction do not fail for such deleted ports."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/919696"},{"line_number":15,"context_line":"Closes-Bug: #2065701"},{"line_number":16,"context_line":"Related-Bug: #2060163"},{"line_number":17,"context_line":"Change-Id: Ie0ce420414f1e6056d9df2733b7446d02c89fcfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e57bd637_edda688a","line":14,"in_reply_to":"fa05fd5c_a69887ed","updated":"2024-05-21 04:46:48.000000000","message":"Done","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"569ba56254178ab89408ded9ffc0d7ba97a37a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa2783c0_998bfce4","updated":"2024-05-17 16:27:27.000000000","message":"I see you backport it in ovsdbapp. What\u0027s your plan for backports for the neutron patch? Are you going to bump minimal library version (I don\u0027t think it\u0027s allowed?) or are you going to gracefully handle it somehow? (Catch an exception?)","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0f3987b0753f9f044bdf282590250b960bcb83b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17a493cb_b1681097","updated":"2024-05-15 14:42:48.000000000","message":"Need to get ovsdbapp release with https://review.opendev.org/c/openstack/ovsdbapp/+/919696 before merging","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05f133ceebf7f0b597c140870127e2c7ac13a5fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71a52d15_5db8586e","updated":"2024-05-16 16:29:28.000000000","message":"The code is fine; but I think it should Depends-On a requirements minimal version bump for ovsdbapp (not released yet.)","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6935a8c640e1b33a4b68fc3e408d9f58d64f65ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f740e614_cd885363","in_reply_to":"5fb76331_b8220ab7","updated":"2024-05-20 14:19:41.000000000","message":"I think it depends on whether the library can gracefully handle unknown arguments. I believe I checked and saw that it captures all args into *args (or some other name of the argument.), so maybe it will work? But need to confirm.","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d6c962613e79f883f8b33e931f88e0b06e6d8334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e39124bc_bc3c1fba","in_reply_to":"706f57e6_7e73591f","updated":"2024-05-21 12:52:11.000000000","message":"seems related to https://github.com/openstack/ovsdbapp/commit/f86a5985e7a309e69fa93658000b8356242b6322","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9a1beccae4904404814abf01da9b3e6ffc1c7e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7bcab1f_ef1d708b","in_reply_to":"71a52d15_5db8586e","updated":"2024-05-20 07:05:12.000000000","message":"Yes will update once we have requirements patch, for now have a release patch https://review.opendev.org/c/openstack/releases/+/919916","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a4fad503f3c4ce7432524bab1765d86f9aec5255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"706f57e6_7e73591f","in_reply_to":"7552728b_e2ab8b80","updated":"2024-05-21 11:59:34.000000000","message":"Ok checked and it fails[1] with:-\nMay 16 10:18:00.751217 np0037527850 neutron-server[70640]: DEBUG ovsdbapp.backend.ovs_idl.transaction [None req-e5e1991c-daf3-4c70-b993-8a7ed6dde890 None None] Running txn n\u003d1 command(idx\u003d0): LrpSetOptionsCommand(_result\u003dNone, entity\u003dlrp-159f1935-7f6a-4765-ba0c-d7d4d42cd97b, options\u003d{\u0027if_exists\u0027: True}) {{(pid\u003d70640) do_commit /usr/local/lib/python3.9/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nMay 16 10:18:00.752181 np0037527850 neutron-server[70640]: ERROR ovsdbapp.backend.ovs_idl.vlog [None req-e5e1991c-daf3-4c70-b993-8a7ed6dde890 None None] attempting to write bad value to column options (ovsdb error: expected string, got \u003cclass \u0027bool\u0027\u003e): ovs.db.error.Error: ovsdb error: expected string, got \u003cclass \u0027bool\u0027\u003e\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6cd/919788/2/check/devstack-platform-centos-9-stream/6cd5a10/controller/logs/screen-q-svc.txt","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9a1beccae4904404814abf01da9b3e6ffc1c7e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5fb76331_b8220ab7","in_reply_to":"aa2783c0_998bfce4","updated":"2024-05-20 07:05:12.000000000","message":"Good question, for stable i was considering backport -\u003e release -\u003e upper-constraints update -\u003e update minimal ovsdbapp in neutron.\nI see couple of backports including minimal requirement bumps https://review.opendev.org/q/file:requirements.txt+project:openstack/neutron+branch:%5Estable.* , but i recall there was some discussion on such stable backports don\u0027t much recall on what\u0027s our generic policy on these. \nIf it\u0027s not allowed need to consider alternatives with some Exception handling.","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7689983ecc1e01e72bea0daea1322212a61aae85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"22a1d4be_390cffd5","in_reply_to":"e39124bc_bc3c1fba","updated":"2024-05-28 07:24:43.000000000","message":"just to close the loop here:- the unrelated issue in functional tests got fixed with https://review.opendev.org/c/openstack/neutron/+/920101.\n\nwrt backports without ovsdbapp bump in requirements it will not work and fails as above. So we would need neutron patch with minimum requirement bump for ovsdbapp which would not work atleast in unmaintained branches as there we don\u0027t have releases for library.\nAlso as mentioned not fully sure about policy about requirements bump for libraries in stable as it\u0027s not just single patch in the ovsdbapp since current minimal version specified in requirements.txt in stable, for ex. in 2024.1 currently it\u0027s ovsdbapp\u003e\u003d2.3.0 while we have 2.6.0 in u-c so it would be major bump if we go this route. To avoid the minimal requirement bump and considering unmaintained branches case i am considering alternative[1] for stable/unmaintained branches.\n\n[1] https://review.opendev.org/c/openstack/neutron/+/920573","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"5ad5c310462f2143bbeae951e13387a51d9027ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7552728b_e2ab8b80","in_reply_to":"f740e614_cd885363","updated":"2024-05-21 04:46:48.000000000","message":"yes it captures those in **options so should work, but will check the behavior on how it get\u0027s applied.","commit_id":"8c378f3e7ea5c180513a29e225e849cf03dbccb5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7ec08e87a57a6f7c8c38bbb7d109123c630b4291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28ff64ac_1bfb7848","updated":"2024-05-21 08:33:48.000000000","message":"LGTM! The functional failures seems unrelated","commit_id":"51ccbcfae554c68351a8362f66ec6d997641abae"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"025d2fdf04c3480aa271010dcdae7049e55c188e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00839ac4_86281109","updated":"2024-05-22 00:26:39.000000000","message":"recheck bug 2065821","commit_id":"51ccbcfae554c68351a8362f66ec6d997641abae"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a4fad503f3c4ce7432524bab1765d86f9aec5255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b7487c13_2a0fb253","in_reply_to":"28ff64ac_1bfb7848","updated":"2024-05-21 11:59:34.000000000","message":"considering the failures looks related to new ovsdbapp release(2.6.0 --\u003e 2.7.1), will block the update until we are sure it\u0027s all good.","commit_id":"51ccbcfae554c68351a8362f66ec6d997641abae"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a12a993bf4ff945155f500c600fb8ce7c81c3868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c99a9bc9_7f57d035","updated":"2024-05-23 00:17:16.000000000","message":"recheck","commit_id":"79676270354112fd4062442d25a5eaefbc830d24"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ebaaf595bc41cec54949eaca1d2a1b2da0d52145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3a9dd42_ccb8e75d","updated":"2024-05-22 07:09:22.000000000","message":"recheck bug 2065821","commit_id":"79676270354112fd4062442d25a5eaefbc830d24"}]}
