)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6cb8c88b0ff6ca68f2389a04abc4b202cb513ff2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"belong to a agent and to kill all these processes. This is important to"},{"line_number":21,"context_line":"eg. kill keepalived processes started by L3 agents."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The timeout for the L2 agent restart has to be extended slightly because"},{"line_number":24,"context_line":"the service is no longer killed with SIGKILL but properly shut down."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ieb21de8a370aca24abc216f55dbd98e553a65d05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a29717be_73737912","line":23,"updated":"2024-06-25 13:04:42.000000000","message":"Seen 6 failures since this merged:-\n    https://1b2a29b80eddd4e0b174-eda1a0c854fb13a0abbfe9e278c5ab06.ssl.cf2.rackcdn.com/922119/1/gate/neutron-functional-with-uwsgi/3622d92/testr_results.html    https://86ddc5b3525cc8a57bd5-84709aab2060acc1565f07c661aff448.ssl.cf1.rackcdn.com/922119/1/check/neutron-fullstack-with-uwsgi/4213115/testr_results.html\n    https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e5d/888098/15/check/neutron-fullstack-with-uwsgi/e5d8147/testr_results.html\n    https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6c6/922470/1/check/neutron-fullstack-with-uwsgi/6c63681/testr_results.html\n    https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_522/periodic/opendev.org/openstack/neutron/master/neutron-fullstack/52235b5/testr_results.html\n    https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_14b/922074/4/check/neutron-fullstack-with-uwsgi/14bece8/testr_results.html\n\nDo we need to increase timeout more or it\u0027s some issue?","commit_id":"4a02848228a4dce926fc2c7c5271bcbf0bd7c3a4"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6cb8c88b0ff6ca68f2389a04abc4b202cb513ff2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"belong to a agent and to kill all these processes. This is important to"},{"line_number":21,"context_line":"eg. kill keepalived processes started by L3 agents."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The timeout for the L2 agent restart has to be extended slightly because"},{"line_number":24,"context_line":"the service is no longer killed with SIGKILL but properly shut down."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ieb21de8a370aca24abc216f55dbd98e553a65d05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"325ee146_729f4ee9","line":23,"updated":"2024-06-25 13:04:42.000000000","message":"Seen six failures since this patch merged:-","commit_id":"4a02848228a4dce926fc2c7c5271bcbf0bd7c3a4"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"ebf18b5daef0edb064795471eba39da39f5893ae","unresolved":false,"context_lines":[{"line_number":20,"context_line":"belong to a agent and to kill all these processes. This is important to"},{"line_number":21,"context_line":"eg. kill keepalived processes started by L3 agents."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The timeout for the L2 agent restart has to be extended slightly because"},{"line_number":24,"context_line":"the service is no longer killed with SIGKILL but properly shut down."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ieb21de8a370aca24abc216f55dbd98e553a65d05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7b8a150a_9f351985","line":23,"in_reply_to":"a29717be_73737912","updated":"2024-06-25 15:23:43.000000000","message":"I belive the failures in l2_agent_restart should be fixed by https://review.opendev.org/c/openstack/neutron/+/917429","commit_id":"4a02848228a4dce926fc2c7c5271bcbf0bd7c3a4"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7be74c7df47897bc2e344132e1b7b8af83aaacea","unresolved":true,"context_lines":[{"line_number":20,"context_line":"belong to a agent and to kill all these processes. This is important to"},{"line_number":21,"context_line":"eg. kill keepalived processes started by L3 agents."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The timeout for the L2 agent restart has to be extended slightly because"},{"line_number":24,"context_line":"the service is no longer killed with SIGKILL but properly shut down."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ieb21de8a370aca24abc216f55dbd98e553a65d05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"67dbe3f9_21f37975","line":23,"in_reply_to":"a29717be_73737912","updated":"2024-06-25 15:51:08.000000000","message":"Reported https://bugs.launchpad.net/neutron/+bug/2070390","commit_id":"4a02848228a4dce926fc2c7c5271bcbf0bd7c3a4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"abd9a4e44ae0cde05f6241ba080bfb58b52738a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d9c1b03_4c719a2f","updated":"2024-06-06 13:28:35.000000000","message":"recheck","commit_id":"4a02848228a4dce926fc2c7c5271bcbf0bd7c3a4"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2542eb3c7fb52f6c485be2c5e0998855b28600fb","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.namespace \u003d namespace"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.slice_name \u003d slice_name"},{"line_number":51,"context_line":"        self.unit_name \u003d f\u0027{self.test_name}-{self.process_name}\u0027"},{"line_number":52,"context_line":"        if self.namespace:"},{"line_number":53,"context_line":"            self.unit_name +\u003d f\u0027-{self.namespace}\u0027"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8e8a58bc_a15b3314","line":51,"updated":"2024-05-22 22:13:24.000000000","message":"We don\u0027t use f-strings much, so someone might object, although I guess it is the way forward...","commit_id":"5b50044cdeff2e8cec184946ff8e68afaf35a7a0"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"592b813d8f2ffee3bd0a2d195fa3b5c35f400389","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.namespace \u003d namespace"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.slice_name \u003d slice_name"},{"line_number":51,"context_line":"        self.unit_name \u003d f\u0027{self.test_name}-{self.process_name}\u0027"},{"line_number":52,"context_line":"        if self.namespace:"},{"line_number":53,"context_line":"            self.unit_name +\u003d f\u0027-{self.namespace}\u0027"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"40ece667_e758706f","line":51,"in_reply_to":"8e8a58bc_a15b3314","updated":"2024-05-23 09:44:15.000000000","message":"IMO it makes the code easier to read, but if you prefer I can change it.","commit_id":"5b50044cdeff2e8cec184946ff8e68afaf35a7a0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2542eb3c7fb52f6c485be2c5e0998855b28600fb","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            cmd +\u003d [\u0027--config-file\u0027, filename]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        systemd_run \u003d ["},{"line_number":78,"context_line":"            \u0027sudo\u0027,"},{"line_number":79,"context_line":"            \u0027systemd-run\u0027,"},{"line_number":80,"context_line":"            \u0027--service-type\u0027, \u0027exec\u0027,"},{"line_number":81,"context_line":"            \u0027--unit\u0027, self.unit_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd02b8a2_037a84f7","line":78,"updated":"2024-05-22 22:13:24.000000000","message":"We shouldn\u0027t be using sudo directly but via the AsyncProcess class and rootwrap. Is there a reason this can\u0027t be done that way?","commit_id":"5b50044cdeff2e8cec184946ff8e68afaf35a7a0"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"592b813d8f2ffee3bd0a2d195fa3b5c35f400389","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            cmd +\u003d [\u0027--config-file\u0027, filename]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        systemd_run \u003d ["},{"line_number":78,"context_line":"            \u0027sudo\u0027,"},{"line_number":79,"context_line":"            \u0027systemd-run\u0027,"},{"line_number":80,"context_line":"            \u0027--service-type\u0027, \u0027exec\u0027,"},{"line_number":81,"context_line":"            \u0027--unit\u0027, self.unit_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"773358c7_193c8195","line":78,"in_reply_to":"cd02b8a2_037a84f7","updated":"2024-05-23 09:44:15.000000000","message":"I don\u0027t think it makes much sense to run this asynchronously. It is short running and creates a systemd unit which then runs asynchronously, manged by systemd.\n\nI replaced the direct usage of subprocess and sudo with calls to utils.execute which goes through the rootwrap daemon.","commit_id":"5b50044cdeff2e8cec184946ff8e68afaf35a7a0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"80d0b425474bf12e2fa0755d77c47f52dec7b28f","unresolved":true,"context_lines":[{"line_number":215,"context_line":"            process_name\u003dself.NEUTRON_SERVER,"},{"line_number":216,"context_line":"            exec_name\u003dself.NEUTRON_SERVER,"},{"line_number":217,"context_line":"            config_filenames\u003dconfig_filenames,"},{"line_number":218,"context_line":"        ))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        common_utils.wait_until_true(self.server_is_live)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"559d2564_a5a0d90c","line":218,"range":{"start_line":218,"start_character":8,"end_line":218,"end_character":9},"updated":"2024-05-27 08:15:41.000000000","message":"nit: these should be one line up","commit_id":"c49e3fdfc8034e1b454ec5c4b6977abd1e237d5d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"80d0b425474bf12e2fa0755d77c47f52dec7b28f","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        self.process_fixture \u003d self.useFixture(ProcessFixture("},{"line_number":259,"context_line":"            test_name\u003dself.test_name,"},{"line_number":260,"context_line":"            process_name\u003df\u0027{constants.AGENT_PROCESS_OVS}-{self.hostname}\u0027,"},{"line_number":261,"context_line":"            slice_name\u003dself.hostname,"},{"line_number":262,"context_line":"            exec_name\u003dshutil.which("},{"line_number":263,"context_line":"                \u0027ovs_agent.py\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"93c0f869_2bf4f105","line":260,"updated":"2024-05-27 08:15:41.000000000","message":"I checked the log file names and with this change it is like these:\n\nneutron-openvswitch-agent-host-87eebef6--2024-05-23--14-52-56-340377.log  \nneutron-server--2024-05-23--14-52-50-839768.log\nneutron-openvswitch-agent-host-87eebef6--2024-05-23--14-53-45-853109.log\n\nthe extra -host-xyz--, strange that for neutron-server there is no host...","commit_id":"c49e3fdfc8034e1b454ec5c4b6977abd1e237d5d"}]}