)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fc635757ff6fd5e2c40b0a9a03a6a77809acb128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac258a44_ad2db6c6","updated":"2024-05-26 17:48:35.000000000","message":"We will need to discuss this at the weekly Neutron meeting, since given we\u0027ve introduced bugs as mentioned in your bug report.\n\nYou should also add a unit test since right now there\u0027s nothing to check either behavior.","commit_id":"549ca2b77f6adf9e63ad7b7ac3ffb50be718352e"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"7b39479fc7512ede6b19cd161801e500cc5892a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d9a8f6c_c5a876d3","in_reply_to":"ac258a44_ad2db6c6","updated":"2024-05-26 18:04:16.000000000","message":"I was looking at unit tests for this, and it doesn\u0027t seem to deviate from the ones that are currently in there. This is simply processing the value if its not in the request data but in the network.\n\nI believe the use cases are valid so I would be happy to discuss this further.","commit_id":"549ca2b77f6adf9e63ad7b7ac3ffb50be718352e"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"58480adf4cd105adffa1898e3f8a696a27561f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d34a35b_fc764785","updated":"2024-05-28 18:33:53.000000000","message":"recheck","commit_id":"23cedc969c1e1b738e621fcacbcc67281ae73cb0"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"a68aaad6c3833763e18f6e2b0e7d17547a5ca344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b5ff2692_288c759d","updated":"2024-05-30 17:47:31.000000000","message":"There seems to be something wrong with testing as the py3 unit tests complete successfully. I will recheck again, as I\u0027m unsure what the cause is since different tests are failing at different runs.","commit_id":"e17725f6eca6fd936644acee162c6dbc9afb866f"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"01f28db57f9b46de5d753c140c6cda7a0cfcd00d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8ae74549_5e533841","updated":"2024-05-29 18:22:59.000000000","message":"recheck","commit_id":"e17725f6eca6fd936644acee162c6dbc9afb866f"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"d10c955028fd52270b263f39c0acd0c9e58b4cfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dc2fd633_58382def","updated":"2024-05-30 17:47:37.000000000","message":"recheck","commit_id":"e17725f6eca6fd936644acee162c6dbc9afb866f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"da0072caedd2b08a0c6e9f16e91da2a1f382c907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9581f218_7b8ae3c9","in_reply_to":"b5ff2692_288c759d","updated":"2024-05-30 18:15:28.000000000","message":"There were some issues the past few days with some jobs, most have been addressed now. And just an fyi that if you look in the logs for a failed job and it seems unrelated to your change, you can issue a recheck but please give a reason (we track this), for example:\n\nrecheck unrelated cover job failure","commit_id":"e17725f6eca6fd936644acee162c6dbc9afb866f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a847457c816ceb480892e614dad5d20fb2094dda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a5506410_197d3e17","updated":"2024-06-06 13:29:29.000000000","message":"recheck","commit_id":"b6e95a730e028b31070831fb652c956334acc49c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"47d1d9c6b9a0ca0da15c08ced12cffad7f916ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9bea2876_fee2d68b","updated":"2024-06-03 18:57:09.000000000","message":"recheck sqlalchemy fix merged\n\nThe other failure might be related to this patch:\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 84, in wrapper\n    return func(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/neutron_tempest_plugin/scenario/test_internal_dns.py\", line 138, in test_dns_domain_and_name\n    self.check_remote_connectivity(ssh_client, \u0027leia.\u0027 + dns_domain,\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/neutron_tempest_plugin/scenario/base.py\", line 478, in check_remote_connectivity\n    self.assertTrue(self._check_remote_connectivity(\n  File \"/usr/lib/python3.10/unittest/case.py\", line 687, in assertTrue\n    raise self.failureException(msg)\nAssertionError: False is not true\n\nThat\u0027s where it\u0027s checking connectivity to \u0027leia.\u0027 + dns_domain","commit_id":"b6e95a730e028b31070831fb652c956334acc49c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1ddb27209da661ba4d8cfb1d3028e651b9f01763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"09eaba16_af1bf333","updated":"2024-06-21 20:04:35.000000000","message":"I\u0027m in principle ok with this change. However, I think it should be discussed in a Neutron drivers meeting. In the meantime, this patch should update the corresponding documentation: https://github.com/openstack/neutron/blob/master/doc/source/admin/config-dns-int.rst. Please also see if this document requires change: https://github.com/openstack/neutron/blob/master/doc/source/admin/config-dns-res.rst","commit_id":"3642fe750baa2d88a2746776862880f7d4ba8537"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cf58541b5c0e37dc0be8fcb9e0765334f9b89614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"da6e2cf0_2f0c1bdd","updated":"2024-06-28 22:54:45.000000000","message":"Please look at https://bugs.launchpad.net/neutron/+bug/2067183/comments/5","commit_id":"ac91c73141ececdc39ac53dec0132e04feffd7b7"}],"doc/source/admin/config-dns-int.rst":[{"author":{"_account_id":290,"name":"Antony Messerli","email":"antony@mes.ser.li","username":"antonym"},"change_message_id":"6ced47de3ae766b9a5ebe04f24c5ce314c84e9b7","unresolved":true,"context_lines":[{"line_number":193,"context_line":"   | description           |                                                                               |"},{"line_number":194,"context_line":"   | device_id             |                                                                               |"},{"line_number":195,"context_line":"   | device_owner          |                                                                               |"},{"line_number":196,"context_line":"   | dns_assignment        | fqdn\u003d\u0027my-port.mydomain.org.\u0027, hostname\u003d\u0027my-port\u0027, ip_address\u003d\u0027192.0.2.67\u0027     |"},{"line_number":197,"context_line":"   | dns_domain            | mydomain.org.                                                                 |"},{"line_number":198,"context_line":"   | dns_name              | my-port                                                                       |"},{"line_number":199,"context_line":"   | extra_dhcp_opts       |                                                                               |"}],"source_content_type":"text/x-rst","patch_set":16,"id":"019e4876_3b7d5975","line":196,"updated":"2024-06-27 16:39:37.000000000","message":"As you are referencing certain fields in the output, could you shorten the console output examples to highlight the changes by filtering the fields? This might help reduce the size of the output and highlight the changes you are trying to show so it\u0027s more clear to the user.","commit_id":"ac91c73141ececdc39ac53dec0132e04feffd7b7"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a6a988d7acd6b6ee8cf0f70274b4685d7243829a","unresolved":true,"context_lines":[{"line_number":2266,"context_line":"                    pass"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def _get_ovn_dhcpv4_opts(self, subnet, network, server_mac\u003dNone):"},{"line_number":2269,"context_line":"        dns_domain \u003d (network.get(\u0027dns_domain\u0027) or cfg.CONF.dns_domain)"},{"line_number":2270,"context_line":"        metadata_port_ip \u003d self._find_metadata_port_ip("},{"line_number":2271,"context_line":"            n_context.get_admin_context(), subnet)"},{"line_number":2272,"context_line":"        # TODO(dongj): Currently the metadata port is created only when"}],"source_content_type":"text/x-python","patch_set":13,"id":"60fab181_e273393d","line":2269,"updated":"2024-06-11 19:36:22.000000000","message":"nit: extra parens here, and should be right before use at L2288 since this could return early on L2278","commit_id":"7e3da1ef4243b6f3f7a2d490dde1c787e9e7e972"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"553ecd55f4365c8bf60dd16400fcb20288b5a43a","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"                    pass"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def _get_ovn_dhcpv4_opts(self, subnet, network, server_mac\u003dNone):"},{"line_number":2269,"context_line":"        dns_domain \u003d (network.get(\u0027dns_domain\u0027) or cfg.CONF.dns_domain)"},{"line_number":2270,"context_line":"        metadata_port_ip \u003d self._find_metadata_port_ip("},{"line_number":2271,"context_line":"            n_context.get_admin_context(), subnet)"},{"line_number":2272,"context_line":"        # TODO(dongj): Currently the metadata port is created only when"}],"source_content_type":"text/x-python","patch_set":13,"id":"033ed900_9df08a4a","line":2269,"in_reply_to":"60fab181_e273393d","updated":"2024-06-12 12:24:48.000000000","message":"Moved in latest patch.","commit_id":"7e3da1ef4243b6f3f7a2d490dde1c787e9e7e972"}],"neutron/plugins/ml2/extensions/dns_integration.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fc635757ff6fd5e2c40b0a9a03a6a77809acb128","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    def _process_only_port_update(self, plugin_context, request_data,"},{"line_number":237,"context_line":"                                  db_data, network):"},{"line_number":238,"context_line":"        dns_name \u003d request_data.get(dns_apidef.DNSNAME)"},{"line_number":239,"context_line":"        dns_domain \u003d request_data.get(dns_apidef.DNSDOMAIN)"},{"line_number":240,"context_line":"        dns_data_db \u003d port_obj.PortDNS.get_object("},{"line_number":241,"context_line":"            plugin_context,"},{"line_number":242,"context_line":"            port_id\u003ddb_data[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"55f02f1b_37e1fc11","line":239,"updated":"2024-05-26 17:48:35.000000000","message":"Instead of below, this line should be similar to L192-193 above. At a minimum you have to use network.get()","commit_id":"549ca2b77f6adf9e63ad7b7ac3ffb50be718352e"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"7b39479fc7512ede6b19cd161801e500cc5892a7","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def _process_only_port_update(self, plugin_context, request_data,"},{"line_number":237,"context_line":"                                  db_data, network):"},{"line_number":238,"context_line":"        dns_name \u003d request_data.get(dns_apidef.DNSNAME)"},{"line_number":239,"context_line":"        dns_domain \u003d request_data.get(dns_apidef.DNSDOMAIN)"},{"line_number":240,"context_line":"        dns_data_db \u003d port_obj.PortDNS.get_object("},{"line_number":241,"context_line":"            plugin_context,"},{"line_number":242,"context_line":"            port_id\u003ddb_data[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca752669_60543928","line":239,"in_reply_to":"55f02f1b_37e1fc11","updated":"2024-05-26 18:04:16.000000000","message":"Adjusted and updated.","commit_id":"549ca2b77f6adf9e63ad7b7ac3ffb50be718352e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cf20e54de163907df442a83371f87be91600a0ca","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    def _process_only_port_update(self, plugin_context, request_data,"},{"line_number":237,"context_line":"                                  db_data, network):"},{"line_number":238,"context_line":"        dns_name \u003d request_data.get(dns_apidef.DNSNAME)"},{"line_number":239,"context_line":"        dns_domain \u003d request_data.get(dns_apidef.DNSDOMAIN)"},{"line_number":240,"context_line":"        dns_data_db \u003d port_obj.PortDNS.get_object("},{"line_number":241,"context_line":"            plugin_context,"},{"line_number":242,"context_line":"            port_id\u003ddb_data[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"4b09244e_7c1fb79f","line":239,"updated":"2024-05-28 15:09:13.000000000","message":"Does this not work?\n\ndns_domain \u003d (request_data.get(dns_apidef.DNSDOMAIN) or\n              network.get(dns_apidef.DNSDOMAIN))\n\nThat should still default to None if neither is set and would mimic the other code.","commit_id":"26e56ec5019d44e669b309f7b237beef415d3e26"},{"author":{"_account_id":36670,"name":"Jay Jahns","email":"jayjahns@gmail.com","username":"jayjahns"},"change_message_id":"b4d34d8044c040ae76cc037a2c810b8b88b7fb61","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def _process_only_port_update(self, plugin_context, request_data,"},{"line_number":237,"context_line":"                                  db_data, network):"},{"line_number":238,"context_line":"        dns_name \u003d request_data.get(dns_apidef.DNSNAME)"},{"line_number":239,"context_line":"        dns_domain \u003d request_data.get(dns_apidef.DNSDOMAIN)"},{"line_number":240,"context_line":"        dns_data_db \u003d port_obj.PortDNS.get_object("},{"line_number":241,"context_line":"            plugin_context,"},{"line_number":242,"context_line":"            port_id\u003ddb_data[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed2d9d0d_7f6c68a0","line":239,"in_reply_to":"4b09244e_7c1fb79f","updated":"2024-05-28 15:27:33.000000000","message":"I was noticing in some tests that dns_domain is set to a blank value, but I observe that it is set to None by default. I\u0027ll make this adjustment.","commit_id":"26e56ec5019d44e669b309f7b237beef415d3e26"}]}