)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6ac896e6cd5eb75077f65515176ceaa185cd6cb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2dd70376_4afe14c3","updated":"2024-05-31 20:20:17.000000000","message":"Marking WIP since I wanted to get this out before the weekend, still have a local test running.","commit_id":"129b75a971be343ce525daf580096f00d02eaa82"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d7ec0f17fa1ebe3c8781ef0586905530bffd99c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e03fedb2_f24d94b8","updated":"2024-06-05 21:19:14.000000000","message":"I need to add a depends-on to neutron-lib patch, but will wait for gate to stablize.","commit_id":"10420692d05edb59dce9e6e2f4de40f3e335c7e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e44c2db4b4e5e2dad1d5205c3586ee0d33c5e93e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fee0db8f_303eaa46","updated":"2024-05-31 21:38:01.000000000","message":"With the related neutron-lib change, I can at least run a portion of the unit tests locally:\n\n$ env TOX_ENV_SRC_MODULES\u003d../neutron-lib tox -e py3 -- neutron.tests.unit.db.test_db_base_plugin_v2.TestNetworks\n\n...\nRan: 43 tests in 6.0880 sec.\n - Passed: 43\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\n \n I\u0027ll have to run the entire unit test suite to verify.","commit_id":"10420692d05edb59dce9e6e2f4de40f3e335c7e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c09c2fe7e730f7977f8c6fd411a63b47a940db80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d2c7dc2_81a85ef6","updated":"2024-06-05 19:08:37.000000000","message":"check experimental","commit_id":"10420692d05edb59dce9e6e2f4de40f3e335c7e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"472147592a56acb12f0fa14b0ae950b88a810178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f1c826c_1b0051dd","updated":"2024-06-11 14:24:45.000000000","message":"Need to wait for this to merge since it uses lazy\u003d\u0027subquery\u0027:\n\nhttps://review.opendev.org/c/openstack/neutron/+/921566\n\nAnd might need to add a check for that so we don\u0027t merge changes with that mode.","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"092c0376ba44d19e61d55010851abf5ecbd4dd69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37775029_3f14a2c5","updated":"2024-06-10 20:04:50.000000000","message":"The neutron-lib requirements patch has merged, and the neutron patch is in the gate, so this is good for review.","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6e7f8f5a49dc61e25cca302746d10baf66687924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"613fda23_916eb4a2","updated":"2024-06-06 13:35:14.000000000","message":"check experimental","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f0eb3c640358726ec0ff12734470cee36f1cc858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83a90050_e4fa4f1e","updated":"2024-06-08 16:07:20.000000000","message":"https://review.opendev.org/c/openstack/neutron/+/919800 should merge first, this is working since it\u0027s pulling the latest. I can update commit message if necessary to add depends-on.","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4201df57c75519d2f0b086a610d0fc577be5797d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"42b80817_8581d7e6","updated":"2024-06-07 17:14:20.000000000","message":"please set depends-on for the upper-constraint bump so we get actual results","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b05d20d2198eec6d5ccf4bc4258f38d2b663f4f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"39246b9a_a91fae9e","updated":"2024-06-07 22:57:32.000000000","message":"recheck requirements bump merged","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f49d77f7b7a46db13d5ea2d97087cd7cec719b42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"260cca3d_39902fc2","updated":"2024-06-08 15:54:52.000000000","message":"recheck unrelated test failure","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"891ac2b7cf2f33611aee9a871aa3cd5c8a1b3f0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2df7c0c_5af37924","in_reply_to":"5f1c826c_1b0051dd","updated":"2024-06-11 14:53:53.000000000","message":"Good idea about the check.","commit_id":"706b54fd209ab35e5a8e899f52eb6de427a25070"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ad12949fcdbbb9e68a4d7129ea6871c3c30cf5da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e49660f5_22234f42","updated":"2024-06-12 13:25:55.000000000","message":"Do you have some perf test regarding that change? We actually have switch to subquery donwstream because of the benefit of using it and that looks interesting?","commit_id":"602c2ce9ea715dcb5af45e4096f96e9b7a2e2b25"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0af0e5e92baa38f0c4d792666374fb49fe91f7a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a9425d51_b57b8051","updated":"2024-06-12 13:21:46.000000000","message":"This needs to update models/tag.py and add a hacking rule.","commit_id":"602c2ce9ea715dcb5af45e4096f96e9b7a2e2b25"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bc6a4174d6b027ec1fe3ef21abbabae352dda0c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9adeab49_53bd2415","updated":"2024-06-12 11:35:25.000000000","message":"https://review.opendev.org/c/openstack/neutron/+/921566 merged, rebased on top of it","commit_id":"602c2ce9ea715dcb5af45e4096f96e9b7a2e2b25"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1f5977c29a9ac690e6c1564882e0807170190abf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"690a5e25_05500ca7","in_reply_to":"e49660f5_22234f42","updated":"2024-06-12 14:19:18.000000000","message":"No, I don\u0027t have any perf numbers from this change, it was mainly driven on Mike Bayer\u0027s recommendation to move to selectin from subquery based on this ML thread:\n\nhttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/EHLQQXNG3NLLZYPDGG2ES3DINIJ7YT3N/","commit_id":"602c2ce9ea715dcb5af45e4096f96e9b7a2e2b25"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4479a904830bdec3994f75e711790076c3b92102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"02b2bbe8_ec2a340c","updated":"2024-06-12 19:12:07.000000000","message":"recheck test_resize_volume_backed_server_confirm unrelated failure","commit_id":"05fcfef6ced908d7ccf9b2bc13b76b13f055d096"}],"neutron/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0153130bf90c524fec605e335d531b5f67b7fe8d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        _pass([\"_(\u0027foo\u0027)\"], \"neutron/foo.py\", noqa\u003dTrue)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def test_check_no_sqlalchemy_lazy_subquery(self):"},{"line_number":284,"context_line":"        f \u003d checks.check_python3_no_filter"},{"line_number":285,"context_line":"        self.assertLineFails(\u0027N350\u0027, f,"},{"line_number":286,"context_line":"            \"backref\u003dorm.backref(\u0027tags\u0027, lazy\u003d\u0027subquery\u0027, viewonly\u003dTrue),\")"},{"line_number":287,"context_line":"        self.assertLineFails(\u0027N350\u0027, f,"}],"source_content_type":"text/x-python","patch_set":5,"id":"8064edb4_701fac0f","line":284,"updated":"2024-06-12 15:28:58.000000000","message":"copy/paste error :(","commit_id":"448b45e3be611fec0709a5e50656f2df8a1d1f8d"}]}