)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f4bd87ff92dd427f7545dd3fc84a11f6a5d298c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OVN] Fix virtual parent match for PortBindingUpdateVirtualPortsEvent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mentioned in change 896883, the condition should be a `is None` as per inline comment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: #2038413"},{"line_number":12,"context_line":"Change-Id: I3666cf0509747863ca2a416c8bfc065582573734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5e12f05d_c3503235","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":29},"updated":"2024-06-10 12:55:55.000000000","message":"Please use the link to the change:\n```\nAs mentioned in change [1],...\n\n[1]https://review.opendev.org/c/openstack/neutron/+/896883\n```","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"57d5bbfb17490aa824ce5925922a6f343f2a09c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OVN] Fix virtual parent match for PortBindingUpdateVirtualPortsEvent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mentioned in change 896883, the condition should be a `is None` as per inline comment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: #2038413"},{"line_number":12,"context_line":"Change-Id: I3666cf0509747863ca2a416c8bfc065582573734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c913bda9_e2813aca","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":29},"in_reply_to":"43b68570_47eedf19","updated":"2024-06-10 13:01:49.000000000","message":"Done","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"c736cd3548cd1226621927393937ca1fb23ce179","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OVN] Fix virtual parent match for PortBindingUpdateVirtualPortsEvent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mentioned in change 896883, the condition should be a `is None` as per inline comment."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: #2038413"},{"line_number":12,"context_line":"Change-Id: I3666cf0509747863ca2a416c8bfc065582573734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"43b68570_47eedf19","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":29},"in_reply_to":"5e12f05d_c3503235","updated":"2024-06-10 12:57:14.000000000","message":"will do!","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"3b99d87fcf766aeb9838321a4e4cf3d03cc84c68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"162aa9f2_0d1f3564","updated":"2024-06-10 12:14:54.000000000","message":"As communicated, the small change","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f4bd87ff92dd427f7545dd3fc84a11f6a5d298c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c82b2cff_7aeb84e0","updated":"2024-06-10 12:55:55.000000000","message":"If accepted, this patch should be backported up to 2024.1","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"c736cd3548cd1226621927393937ca1fb23ce179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"acc3d169_714f8b1a","updated":"2024-06-10 12:57:14.000000000","message":"thanks for the review!","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"57d5bbfb17490aa824ce5925922a6f343f2a09c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2053c7e5_8bdfe0aa","updated":"2024-06-10 13:01:49.000000000","message":"unit tests added for this event class.","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9926c578c786017a91fd7a5e267d9158ecf4c466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe46c93e_fab32031","in_reply_to":"2053c7e5_8bdfe0aa","updated":"2024-06-10 13:30:29.000000000","message":"I was thinking in functional test, as any other class in this file.","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"23529cc309e1720bbfb72a7ffbc92b13b178e5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81118671_c03d0686","in_reply_to":"fe46c93e_fab32031","updated":"2024-06-10 13:40:45.000000000","message":"For me it seemed more logical to create a simple unit test, to make sure this specific method was tested thoroughly.","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"23529cc309e1720bbfb72a7ffbc92b13b178e5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae87c9c5_cb77b8fc","updated":"2024-06-10 13:40:45.000000000","message":"Fixed the nits.","commit_id":"170d99f2d53f77d4c66e505f310fd9d8f3481149"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"73d84258eaad154a26e75dd107922094bce0f4ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"90d5b4f9_fd8f45e9","updated":"2024-06-10 14:59:30.000000000","message":"Thx Michel for quick fix!","commit_id":"170d99f2d53f77d4c66e505f310fd9d8f3481149"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f4bd87ff92dd427f7545dd3fc84a11f6a5d298c","unresolved":true,"context_lines":[{"line_number":611,"context_line":"            # which means we need to update the host_id information"},{"line_number":612,"context_line":"            return True"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if getattr(old, \u0027options\u0027, None) is None:"},{"line_number":615,"context_line":"            # The \"old.options\" dictionary is not being modified,"},{"line_number":616,"context_line":"            # thus the virtual parents didn\u0027t change."},{"line_number":617,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"57ec1e5a_da67666f","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":49},"updated":"2024-06-10 12:55:55.000000000","message":"This is fixing a previous code path not tested. You should include a test for it.","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"c736cd3548cd1226621927393937ca1fb23ce179","unresolved":true,"context_lines":[{"line_number":611,"context_line":"            # which means we need to update the host_id information"},{"line_number":612,"context_line":"            return True"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if getattr(old, \u0027options\u0027, None) is None:"},{"line_number":615,"context_line":"            # The \"old.options\" dictionary is not being modified,"},{"line_number":616,"context_line":"            # thus the virtual parents didn\u0027t change."},{"line_number":617,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6a36530_8b39ebb1","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":49},"in_reply_to":"57ec1e5a_da67666f","updated":"2024-06-10 12:57:14.000000000","message":"working on it 😊","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"57d5bbfb17490aa824ce5925922a6f343f2a09c5","unresolved":false,"context_lines":[{"line_number":611,"context_line":"            # which means we need to update the host_id information"},{"line_number":612,"context_line":"            return True"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if getattr(old, \u0027options\u0027, None) is None:"},{"line_number":615,"context_line":"            # The \"old.options\" dictionary is not being modified,"},{"line_number":616,"context_line":"            # thus the virtual parents didn\u0027t change."},{"line_number":617,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb38e0a7_dad11e9f","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":49},"in_reply_to":"d6a36530_8b39ebb1","updated":"2024-06-10 13:01:49.000000000","message":"Done","commit_id":"74dc845674fb254e9e119b4bae214e8f62812f74"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9926c578c786017a91fd7a5e267d9158ecf4c466","unresolved":true,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class TestPortBindingUpdateVirtualPortsEvent(base.BaseTestCase):"},{"line_number":333,"context_line":"    def setUp(self):"},{"line_number":334,"context_line":"        super(TestPortBindingUpdateVirtualPortsEvent, self).setUp()"},{"line_number":335,"context_line":"        self.driver \u003d mock.Mock()"},{"line_number":336,"context_line":"        self.event \u003d ovsdb_monitor.PortBindingUpdateVirtualPortsEvent("},{"line_number":337,"context_line":"            self.driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3745692_cc4d85d1","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":67},"updated":"2024-06-10 13:30:29.000000000","message":"nit: super().setUp()","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"23529cc309e1720bbfb72a7ffbc92b13b178e5fd","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class TestPortBindingUpdateVirtualPortsEvent(base.BaseTestCase):"},{"line_number":333,"context_line":"    def setUp(self):"},{"line_number":334,"context_line":"        super(TestPortBindingUpdateVirtualPortsEvent, self).setUp()"},{"line_number":335,"context_line":"        self.driver \u003d mock.Mock()"},{"line_number":336,"context_line":"        self.event \u003d ovsdb_monitor.PortBindingUpdateVirtualPortsEvent("},{"line_number":337,"context_line":"            self.driver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a5c4178_c9e7d276","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":67},"in_reply_to":"a3745692_cc4d85d1","updated":"2024-06-10 13:40:45.000000000","message":"Done","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9926c578c786017a91fd7a5e267d9158ecf4c466","unresolved":true,"context_lines":[{"line_number":332,"context_line":"class TestPortBindingUpdateVirtualPortsEvent(base.BaseTestCase):"},{"line_number":333,"context_line":"    def setUp(self):"},{"line_number":334,"context_line":"        super(TestPortBindingUpdateVirtualPortsEvent, self).setUp()"},{"line_number":335,"context_line":"        self.driver \u003d mock.Mock()"},{"line_number":336,"context_line":"        self.event \u003d ovsdb_monitor.PortBindingUpdateVirtualPortsEvent("},{"line_number":337,"context_line":"            self.driver)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f2716492_ddac70a1","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":19},"updated":"2024-06-10 13:30:29.000000000","message":"nit: this is not used anywhere","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"23529cc309e1720bbfb72a7ffbc92b13b178e5fd","unresolved":false,"context_lines":[{"line_number":332,"context_line":"class TestPortBindingUpdateVirtualPortsEvent(base.BaseTestCase):"},{"line_number":333,"context_line":"    def setUp(self):"},{"line_number":334,"context_line":"        super(TestPortBindingUpdateVirtualPortsEvent, self).setUp()"},{"line_number":335,"context_line":"        self.driver \u003d mock.Mock()"},{"line_number":336,"context_line":"        self.event \u003d ovsdb_monitor.PortBindingUpdateVirtualPortsEvent("},{"line_number":337,"context_line":"            self.driver)"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6f6b565e_21e81479","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":19},"in_reply_to":"f2716492_ddac70a1","updated":"2024-06-10 13:40:45.000000000","message":"Done","commit_id":"64b542d7327b5806d7e3cbad8f44da941dc25fb3"}]}