)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5f5b097e18b515bd46698904c8db69674c133226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"465219c2_454d80f5","updated":"2024-09-18 20:44:25.000000000","message":"Fix is correct. We may want to add some test case to cover it. But long term, the project should adopt mypy. Just adding a type hint to the function to define that the return type is a list of Commands would catch this.","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"9a133250a41bb2d851926e7347fc049d2fbbb625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ece4d2fb_ac83fc83","updated":"2024-06-11 08:34:09.000000000","message":"Fix make sense for me. I was surprised to see the subject and went to test it in the ovn-octavia-provider. There, creating two listeners (different protocols) results in two OVN LBs with a single VIP port, but I associated an FIP with the VIP, and both OVN LBs had that FIP correctly associated (just in case ovn-octavia-provider could be an option for you)\n\nSome tests will help as mentioned in previous comment.","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ccd6324e2de3c77236ad9f96d938a28ca36a0d8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e19ec19d_674f2d8f","updated":"2024-06-10 15:17:38.000000000","message":"Just a nit in addition to Rodolfo\u0027s comment","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"aef102013bfd8549828f8eef3bc1a4c42c4449ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3d5310c_00e08323","updated":"2024-06-10 13:09:10.000000000","message":"Please provide some testing to ensure this is fixing what is reported and we don\u0027t have future regressions.","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"87f12216c84fdb030518ee9d2eb46b297cd84f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e069a59_4072beae","in_reply_to":"465219c2_454d80f5","updated":"2024-09-19 15:18:12.000000000","message":"Then I\u0027ll +2 this patch, as long as I see you started pushing the mypy job definition and some patches on top of it. Thanks for this series.","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b7988d5556ab2faccc0dfe2e263e597d84f9aaea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70158400_7601ecfb","in_reply_to":"7e069a59_4072beae","updated":"2024-09-19 16:02:31.000000000","message":"To clarify, I don\u0027t necessarily say that a test case is not needed here (at least until mypy is in and hints are being added). But yes, it should be ok to let it through as-is, the issue is an obvious programming error (that\u0027s why a moderately smart linter could catch it).","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"462b03d9f52620755c5cef867a36fa2616ebb446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca5f85bd_0adf0067","updated":"2024-09-19 16:03:14.000000000","message":"Updated release note as per Brian\u0027s comment before pushing.","commit_id":"d8a4ad9167afd824a3f823d86a8fd33fb67c4abd"}],"releasenotes/notes/fix-issue-with-ovn-loadbalancer-fip-4e4bda00cf019f71.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ccd6324e2de3c77236ad9f96d938a28ca36a0d8c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue when associating FIPs to OVN loadbalancers. See `LP#2068644"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/neutron/+bug/2068644\u003e`__ for more details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b20872f3_a512c21b","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":40},"updated":"2024-06-10 15:17:38.000000000","message":"s/floating IPs\n\njust so it\u0027s clear","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"afd9b2872c60c01ab0916e2efef8799242d5344a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue when associating FIPs to OVN loadbalancers. See `LP#2068644"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/neutron/+bug/2068644\u003e`__ for more details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cc0233a2_80683369","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":40},"in_reply_to":"b20872f3_a512c21b","updated":"2024-09-19 16:18:44.000000000","message":"Done","commit_id":"befb7ec6f5fe8f74b41a97da64b4049d591ffa02"}]}