)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ffb0b153be4b269b4a80fa29aa2d0aaa77940c6","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the default SG rule count logic when creating SG"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the creation of SG, not to exceed the SG rule quota, the number of default SG rules that will be automatically created must be counted. It is always 2 (in case of the default SG, it is 4), but it is wrong since it depends on the default SG rules."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2067239"},{"line_number":12,"context_line":"Change-Id: Ic86826b71c1160a6891f09ca1e40135049a8948a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c1796f1_8f049b40","line":9,"updated":"2024-06-13 13:32:05.000000000","message":"Can you change this to not be one long line? Thanks","commit_id":"cc143a76cf408a4b460ff1acafad9f83a53db0e3"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"899d227dc6b70170b807c613ed2020b3d7ff5528","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the default SG rule count logic when creating SG"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the creation of SG, not to exceed the SG rule quota, the number of default SG rules that will be automatically created must be counted. It is always 2 (in case of the default SG, it is 4), but it is wrong since it depends on the default SG rules."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2067239"},{"line_number":12,"context_line":"Change-Id: Ic86826b71c1160a6891f09ca1e40135049a8948a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fb7e307e_fd0bb6da","line":9,"in_reply_to":"6c1796f1_8f049b40","updated":"2024-06-16 14:10:49.000000000","message":"I changed it. Thank you for your comment.","commit_id":"cc143a76cf408a4b460ff1acafad9f83a53db0e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ffb0b153be4b269b4a80fa29aa2d0aaa77940c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"373a7837_26236976","updated":"2024-06-13 13:32:05.000000000","message":"Adding Rodolfo since he added this code originally","commit_id":"cc143a76cf408a4b460ff1acafad9f83a53db0e3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"115ada11a40166a3e919764516d3a991c64bfa2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58d4c973_71431aeb","updated":"2024-08-21 14:25:52.000000000","message":"Looks ok and logical to separated the counting of different sg rules","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1f13e2234cf19ed31a3148b0ffc4f46f404dc133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2323566_0dc87123","updated":"2024-06-20 22:26:08.000000000","message":"Thanks for the update. I also think we should create a tempest test for this, as it should have been caught, and is testable via the API (I can verify the failure).","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1cfda7c393335884853c5764dd1f4127075cd6f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5c2d4a6_40c648a7","updated":"2024-10-28 11:50:51.000000000","message":"This patch should be backported up to 2023.2","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"17356d212376f7a871d3d667f1b82acff9f9bc85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65f49ada_a686e72c","in_reply_to":"10a5850f_326681c4","updated":"2024-10-28 13:32:44.000000000","message":"Not 2023.1, the patch [1] was implemented in 2023.2.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/883246","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"169eb7537e2ad42b1200a08120bf6b99e0ba1ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"049031b1_218fb1d3","in_reply_to":"49a65ba5_f3bbc84d","updated":"2024-08-16 13:38:03.000000000","message":"I added the new scenario test for this in openstack/neutron-tempest-plugin.\nhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/926469\nReview this patch please.\n\nThe new test will be passed after merging this patch.","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"0a5851f31cea76e6f826f7b310d29c7382926da7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10a5850f_326681c4","in_reply_to":"c5c2d4a6_40c648a7","updated":"2024-10-28 12:01:07.000000000","message":"Do I need to make new patches for other branches?\nI think this patch should be backported for all maintained branches(2023.1, 2023.2, 2024.1, 2024.2).","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1592c70a07c020e941d37f5ee06b4a579e3155f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49a65ba5_f3bbc84d","in_reply_to":"f2323566_0dc87123","updated":"2024-06-24 12:05:56.000000000","message":"+1 for tempest API test, check the neutron-tempest-plugin please for the existing tests:\nhttps://opendev.org/openstack/neutron-tempest-plugin/src/branch/master/neutron_tempest_plugin/api/admin/test_default_security_group_rules.py","commit_id":"1a440dd61b04b37d0e2a9434e802f5a1ee3c198b"}]}
