)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"95e1da4541f87e9a9593d2297cc61372bd4687ac","unresolved":true,"context_lines":[{"line_number":795,"context_line":"                    self._ovn_update_port(plugin_context, port, original_port,"},{"line_number":796,"context_line":"                                          retry_on_revision_mismatch\u003dFalse)"},{"line_number":797,"context_line":"        except ovn_revision_numbers_db.StandardAttributeIDNotFound:"},{"line_number":798,"context_line":"            LOG.debug(\"Standard attribute was not found for port %s. It must \""},{"line_number":799,"context_line":"                      \"have been deleted in the meantime.\", port[\u0027id\u0027])"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def create_port_postcommit(self, context):"},{"line_number":802,"context_line":"        \"\"\"Create a port."}],"source_content_type":"text/x-python","patch_set":1,"id":"eb5061bd_a6491dc3","line":799,"range":{"start_line":798,"start_character":69,"end_line":799,"end_character":56},"updated":"2024-06-14 19:52:23.000000000","message":"Other places in the code that deal with async \"not found\" issues like this use a similar phrase, should use the same here:\n\n\"It was possibly deleted concurrently\"","commit_id":"e1816131dd752dd135eff69797f43759aee275ee"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"73040be6359c1a1e0f25ec56aede713b50722ef2","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                    self._ovn_update_port(plugin_context, port, original_port,"},{"line_number":796,"context_line":"                                          retry_on_revision_mismatch\u003dFalse)"},{"line_number":797,"context_line":"        except ovn_revision_numbers_db.StandardAttributeIDNotFound:"},{"line_number":798,"context_line":"            LOG.debug(\"Standard attribute was not found for port %s. It must \""},{"line_number":799,"context_line":"                      \"have been deleted in the meantime.\", port[\u0027id\u0027])"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def create_port_postcommit(self, context):"},{"line_number":802,"context_line":"        \"\"\"Create a port."}],"source_content_type":"text/x-python","patch_set":1,"id":"490b9eea_fa0c4a65","line":799,"range":{"start_line":798,"start_character":69,"end_line":799,"end_character":56},"in_reply_to":"eb5061bd_a6491dc3","updated":"2024-07-15 19:11:07.000000000","message":"Done, nice phrase.","commit_id":"e1816131dd752dd135eff69797f43759aee275ee"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"95e1da4541f87e9a9593d2297cc61372bd4687ac","unresolved":true,"context_lines":[{"line_number":2487,"context_line":"        mock_notify_dhcp.assert_called_with(fake_port[\u0027id\u0027])"},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"    @mock.patch.object(ovn_client.OVNClient, \u0027update_port\u0027)"},{"line_number":2490,"context_line":"    def test__ovn_update_port_missing_stdattribute("},{"line_number":2491,"context_line":"            self, mock_update_port):"},{"line_number":2492,"context_line":"        \"\"\"Make sure exception is caught.\"\"\""},{"line_number":2493,"context_line":"        fake_port \u003d {\u0027id\u0027: \u0027port-id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"2a289f15_b86dc4b7","line":2490,"updated":"2024-06-14 19:52:23.000000000","message":"The above test is actually testing the same code path, just with the other caught exception. I think it would be better to just either copy/paste it changing the exception, or make a common test for both exceptions, especially since it verifies things were called after the exception fires.","commit_id":"e1816131dd752dd135eff69797f43759aee275ee"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"73040be6359c1a1e0f25ec56aede713b50722ef2","unresolved":false,"context_lines":[{"line_number":2487,"context_line":"        mock_notify_dhcp.assert_called_with(fake_port[\u0027id\u0027])"},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"    @mock.patch.object(ovn_client.OVNClient, \u0027update_port\u0027)"},{"line_number":2490,"context_line":"    def test__ovn_update_port_missing_stdattribute("},{"line_number":2491,"context_line":"            self, mock_update_port):"},{"line_number":2492,"context_line":"        \"\"\"Make sure exception is caught.\"\"\""},{"line_number":2493,"context_line":"        fake_port \u003d {\u0027id\u0027: \u0027port-id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"8fe70d97_3e3c590f","line":2490,"in_reply_to":"2a289f15_b86dc4b7","updated":"2024-07-15 19:11:07.000000000","message":"Done","commit_id":"e1816131dd752dd135eff69797f43759aee275ee"}]}
