)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ff11ef0ec1c903c211bbbfecd81b79d2490ee26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31422573_4221a444","updated":"2024-06-18 06:30:24.000000000","message":"recheck\n\njob: neutron-tempest-plugin-ovn\ntest: test_vlan_transparent_allowed_address_pairs\ncause: unrelated to the current patch","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"465bcc04e2edeeb329b28d829cf9c8f57006ce78","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b11ac33_5427aaf5","updated":"2024-06-25 08:30:41.000000000","message":"I don\u0027t fully understand the discussion behind this change, but I\u0027m wondering if it\u0027s easier to squash these workers into the existing neutron-rpc-service, given the fact that rpc worker was created to deploy neutron api run by wsgi mechanism ?","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5369b81c04f250b0ca43798c85e2cba381e27f97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"989abf47_9acdbe79","updated":"2024-06-25 05:48:06.000000000","message":"recheck unrelated errors\njob: neutron-tempest-plugin-openvswitch","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"556b83725696be60457a779b051f229cc993a8f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a9758dd_a2a3dccb","updated":"2024-06-24 05:25:03.000000000","message":"recheck unrelated errro\njob: neutron-tempest-plugin-ovn\ntest: test_port_security_removed_added_stateful_sg","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ae4746a6b1ef7cd2c39a17816a6712e8d47a820c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27c7c330_42359406","updated":"2024-06-26 06:57:44.000000000","message":"recheck unrelated errro in neutron-tempest-plugin-openvswitch","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d14af705b8d777bfb59be4728b0078e6c11fe93f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"348e3323_596ad79b","updated":"2024-06-24 10:35:33.000000000","message":"recheck unrelated neutron-tempest-plugin-openvswitch-enforce-scope-old-defaults","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"665c4fe740b7a9b3b277e07ee6b1ff4a5e620cc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1939cc87_65295fb5","in_reply_to":"47602d1f_11b3fcc9","updated":"2024-06-28 07:22:35.000000000","message":"I was wondering if it\u0027s worth adding a new service for, but based on the difference between rpc workers and plugin workers (and the case where only plugin workers are needed), I\u0027m now conveyed that we need the new service.","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"07e901206da140999d08aaf54af5b2d240bc3da9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47602d1f_11b3fcc9","in_reply_to":"7b11ac33_5427aaf5","updated":"2024-06-26 06:57:20.000000000","message":"The plugin services are not related to the RPC service. Actually you can have ML2 mechanism drivers, like ML2/OVN, that doesn\u0027t need a RPC server but it will be needed to run these plugin services. The plugin services (as named in the code) are periodic tasks performed by the ML2 mechanism driver; these tasks are instances of ``PeriodicWorker`` [1]. When the eventlet server starts the different processes (API, RPC, plugin):\n1) It collects and wraps all the periodic workers in one single object ``AllServicesNeutronWorker``\n2) spawns a new process executing this new wrapper class.\n3) This class executes the periodic workers in threads (not other processes).\n\nThis plugin services (or neutron-periodic-workers) process is missing when using WSGI and we need to implement it.\n\n[1]https://github.com/search?q\u003drepo%3Aopenstack%2Fneutron%20PeriodicWorker\u0026type\u003dcode","commit_id":"811f74d943aa902771dfb58a88553df099a44bc5"}],"neutron/server/periodic_eventlet.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"daa444569abe1d6946877027aebb2e6d273b3e82","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"d8732b22_28f38261","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2024-06-21 14:52:53.000000000","message":"nit: 2024","commit_id":"c090b8797ae63988dd7e7f647429210da20d920e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eee0e9e024e046f23d5036557c4007f566b353af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"90c60d51_eb22155a","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"d8732b22_28f38261","updated":"2024-06-23 08:11:14.000000000","message":"Done","commit_id":"c090b8797ae63988dd7e7f647429210da20d920e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"daa444569abe1d6946877027aebb2e6d273b3e82","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        ext_mgr.extend_resources(\u00272.0\u0027, attributes.RESOURCES)"},{"line_number":33,"context_line":"        periodic_workers_launcher \u003d service.start_periodic_workers()"},{"line_number":34,"context_line":"    except NotImplementedError:"},{"line_number":35,"context_line":"        LOG.info(\u0027Periodic workers \"AllServicesNeutronWorker\" worker was \u0027"},{"line_number":36,"context_line":"                 \u0027already started in parent process by plugin.\u0027)"},{"line_number":37,"context_line":"    else:"},{"line_number":38,"context_line":"        periodic_workers_launcher.wait()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca9704da_67e0ef11","line":35,"range":{"start_line":35,"start_character":36,"end_line":35,"end_character":60},"updated":"2024-06-21 14:52:53.000000000","message":"I don\u0027t understand the name here as I didn\u0027t see it defined in this change","commit_id":"c090b8797ae63988dd7e7f647429210da20d920e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eee0e9e024e046f23d5036557c4007f566b353af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        ext_mgr.extend_resources(\u00272.0\u0027, attributes.RESOURCES)"},{"line_number":33,"context_line":"        periodic_workers_launcher \u003d service.start_periodic_workers()"},{"line_number":34,"context_line":"    except NotImplementedError:"},{"line_number":35,"context_line":"        LOG.info(\u0027Periodic workers \"AllServicesNeutronWorker\" worker was \u0027"},{"line_number":36,"context_line":"                 \u0027already started in parent process by plugin.\u0027)"},{"line_number":37,"context_line":"    else:"},{"line_number":38,"context_line":"        periodic_workers_launcher.wait()"}],"source_content_type":"text/x-python","patch_set":3,"id":"77222da5_f2823362","line":35,"range":{"start_line":35,"start_character":36,"end_line":35,"end_character":60},"in_reply_to":"ca9704da_67e0ef11","updated":"2024-06-23 08:11:14.000000000","message":"This is the wrapper class that spawns the periodic workers as threads in a single process. Because that belongs to the particular implementation of the code, I would prefer to remove it.","commit_id":"c090b8797ae63988dd7e7f647429210da20d920e"}],"neutron/server/services_eventlet.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"45ac021497132d8da12da9158c655e3975f2021a","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def eventlet_services_server():"},{"line_number":27,"context_line":"    LOG.info(\u0027Eventlet based services process starting...\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        manager.init()"}],"source_content_type":"text/x-python","patch_set":1,"id":"b16e0f69_e3d2e8e4","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":54},"updated":"2024-06-20 09:37:51.000000000","message":"similar msg as in eventlet_rpc_server, good choice","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"10737373b872eb039d2d74eb05b3a51712508cf4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def eventlet_services_server():"},{"line_number":27,"context_line":"    LOG.info(\u0027Eventlet based services process starting...\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    try:"},{"line_number":30,"context_line":"        manager.init()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9eac4f01_d864cab1","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":54},"in_reply_to":"b16e0f69_e3d2e8e4","updated":"2024-06-26 06:57:29.000000000","message":"Done","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"}],"setup.cfg":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ae2183a7ca081e90d06ff8ad1ca3e88603f6f46","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":58,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":59,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":60,"context_line":"    neutron-services-server \u003d neutron.cmd.eventlet.server:main_services_eventlet"},{"line_number":61,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":62,"context_line":"    neutron-ovn-agent \u003d neutron.cmd.eventlet.agents.ovn_neutron_agent:main"},{"line_number":63,"context_line":"    neutron-ovn-metadata-agent \u003d neutron.cmd.eventlet.agents.ovn_metadata:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"272aa21e_841c2033","line":60,"updated":"2024-06-19 13:09:24.000000000","message":"Zigo had a good point about using \u0027service\u0027 in the name, as it clashes with the systemd \u0027.service\u0027 concept. Does \u0027neutron-worker-server\u0027 work better? I\u0027m not always great at naming things.","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d3847615689540656539611369a58e8801bb6e6","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":58,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":59,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":60,"context_line":"    neutron-services-server \u003d neutron.cmd.eventlet.server:main_services_eventlet"},{"line_number":61,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":62,"context_line":"    neutron-ovn-agent \u003d neutron.cmd.eventlet.agents.ovn_neutron_agent:main"},{"line_number":63,"context_line":"    neutron-ovn-metadata-agent \u003d neutron.cmd.eventlet.agents.ovn_metadata:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"4da1aa1c_11b56f0d","line":60,"in_reply_to":"272aa21e_841c2033","updated":"2024-06-19 13:45:27.000000000","message":"Because this service is going to execute the plugin periodic workers, I would suggest \"neutron-periodic-workers\", removing the server from the name (this is not a server attending requests) and defining what this is actually running","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"45ac021497132d8da12da9158c655e3975f2021a","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":58,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":59,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":60,"context_line":"    neutron-services-server \u003d neutron.cmd.eventlet.server:main_services_eventlet"},{"line_number":61,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":62,"context_line":"    neutron-ovn-agent \u003d neutron.cmd.eventlet.agents.ovn_neutron_agent:main"},{"line_number":63,"context_line":"    neutron-ovn-metadata-agent \u003d neutron.cmd.eventlet.agents.ovn_metadata:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c48e04da_39acef60","line":60,"in_reply_to":"4da1aa1c_11b56f0d","updated":"2024-06-20 09:37:51.000000000","message":"+1 for neutron-periodic-workers","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2fb21e10c7497f95d5dc8d36e8618c1b7d99a6ee","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    neutron-metering-agent \u003d neutron.cmd.eventlet.services.metering_agent:main"},{"line_number":58,"context_line":"    neutron-sriov-nic-agent \u003d neutron.cmd.eventlet.plugins.sriov_nic_neutron_agent:main"},{"line_number":59,"context_line":"    neutron-sanity-check \u003d neutron.cmd.sanity_check:main"},{"line_number":60,"context_line":"    neutron-services-server \u003d neutron.cmd.eventlet.server:main_services_eventlet"},{"line_number":61,"context_line":"    neutron-status \u003d neutron.cmd.status:main"},{"line_number":62,"context_line":"    neutron-ovn-agent \u003d neutron.cmd.eventlet.agents.ovn_neutron_agent:main"},{"line_number":63,"context_line":"    neutron-ovn-metadata-agent \u003d neutron.cmd.eventlet.agents.ovn_metadata:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"eb561229_0e185dbe","line":60,"in_reply_to":"c48e04da_39acef60","updated":"2024-06-21 13:54:10.000000000","message":"Done","commit_id":"59df25c33e3140fd441a8a8b41b21475af6b8c05"}]}