)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80c9601cbb0dd4c2fbdf0a01344f73e62289ee2f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix support of IPv6 only networks in OVN metadata agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix support of IPv6 only networks in OVN metadata agent"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2069482"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1bbd2a5a_1a784e28","line":9,"updated":"2024-08-13 19:44:11.000000000","message":"My only nit would be to replace this with a short summary of the fix.","commit_id":"e30872d5d2db30f59655bc23d0c4d4ca2f4eb58e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8aa5b171f68d47957432921ba41216c811412660","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix support of IPv6 only networks in OVN metadata agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix support of IPv6 only networks in OVN metadata agent"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #2069482"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ed1dab78_2d374c32","line":9,"in_reply_to":"1bbd2a5a_1a784e28","updated":"2024-08-14 00:24:52.000000000","message":"Thanks for the review! Done","commit_id":"e30872d5d2db30f59655bc23d0c4d4ca2f4eb58e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9cbf88213307f17e04c2cec1b7057b9946018a8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8cfd0f7_802e6ad3","updated":"2024-06-19 13:29:59.000000000","message":"And I\u0027m guessing since this happened we have no IPv6-only test for either OVS or OVN :(","commit_id":"5a14057768fbee58424db1f2cd9ad98a88d085fc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"757fcb78265cb6d7fd6f837175c81706e5a6d493","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fdd78dd3_1c18787c","updated":"2024-08-14 12:37:01.000000000","message":"recheck unrelated failure neutron_tempest_plugin.scenario.test_port_forwardings.PortForwardingTestJSON.test_port_forwarding_editing_and_deleting_tcp_rule","commit_id":"f7000f3d57bc59732522c4943d6ff2e9dfcf7d31"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9cbf88213307f17e04c2cec1b7057b9946018a8e","unresolved":true,"context_lines":[{"line_number":724,"context_line":"        any_ip6 \u003d False"},{"line_number":725,"context_line":"        for chassis_port in self._vif_ports(chassis_ports):"},{"line_number":726,"context_line":"            if str(chassis_port.datapath.uuid) \u003d\u003d datapath_uuid:"},{"line_number":727,"context_line":"                ip4_ips, ip6_flag \u003d self._get_port_ip4_ips_and_ip6_flag("},{"line_number":728,"context_line":"                    chassis_port)"},{"line_number":729,"context_line":"                datapath_ports_ip4_ips.extend(ip4_ips)"},{"line_number":730,"context_line":"                any_ip6 \u003d any_ip6 or ip6_flag"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f256b8e_c1ad67ba","line":727,"range":{"start_line":727,"start_character":25,"end_line":727,"end_character":33},"updated":"2024-06-19 13:29:59.000000000","message":"Can you just re-assign any_ip6 here?","commit_id":"5a14057768fbee58424db1f2cd9ad98a88d085fc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"030faef3c1e2334c53ed349cfb71ad7548a0bd28","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        any_ip6 \u003d False"},{"line_number":725,"context_line":"        for chassis_port in self._vif_ports(chassis_ports):"},{"line_number":726,"context_line":"            if str(chassis_port.datapath.uuid) \u003d\u003d datapath_uuid:"},{"line_number":727,"context_line":"                ip4_ips, ip6_flag \u003d self._get_port_ip4_ips_and_ip6_flag("},{"line_number":728,"context_line":"                    chassis_port)"},{"line_number":729,"context_line":"                datapath_ports_ip4_ips.extend(ip4_ips)"},{"line_number":730,"context_line":"                any_ip6 \u003d any_ip6 or ip6_flag"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3bdd67e_e9b9a554","line":727,"range":{"start_line":727,"start_character":25,"end_line":727,"end_character":33},"in_reply_to":"9f256b8e_c1ad67ba","updated":"2024-08-13 00:38:07.000000000","message":"No, because we are looking for any chassis_port that has an IPv6 address, Say there are two ports in the list returned by self._vif_ports. The first one has IPv6 and the second one doesn\u0027t. If I just re-assign any_ip6, we will forget the first one and at the end of the loop any_ip6 will be false","commit_id":"5a14057768fbee58424db1f2cd9ad98a88d085fc"}]}