)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0608ac4dc008e6399cd1198efd206cd784f61f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5323b59d_02da24bc","updated":"2024-06-26 08:03:28.000000000","message":"Please open a LP bug describing the rationale of this patch.","commit_id":"e40cb702c488d79f6270ccb64bc9de231eb77694"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5338704bfcfbc8d62b93a378a04dd30aa5486168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1133cc96_e8727be2","in_reply_to":"5323b59d_02da24bc","updated":"2024-06-26 08:04:42.000000000","message":"Disregard this comment, I didn\u0027t read the end of the commit message, after the change-id.","commit_id":"e40cb702c488d79f6270ccb64bc9de231eb77694"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"4b55da6498da120039690fbcadc813cf25dbefd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be86f7e0_b519ad0e","updated":"2024-06-26 19:44:32.000000000","message":"I had a look at the test failure but as far as I can see it\u0027s unrelated to this change. I could not find any indication in the log that this might have to do with how the daemon processes are managed.","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4d06ef3eaaf35a8328ead37f323b4af2d7bbee8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83395cd7_735c2a9d","updated":"2024-06-27 16:37:06.000000000","message":"recheck fullstack security group failures","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"61f029af985c9805e053ec955239b4408ad332fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b140c9a_22ace620","updated":"2024-06-26 14:39:47.000000000","message":"thx","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4d06ef3eaaf35a8328ead37f323b4af2d7bbee8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e529938c_9425fb59","in_reply_to":"2355f5f3_aa20018e","updated":"2024-06-27 16:37:06.000000000","message":"Yes could be not related to failure, what i meant was the errors are specific to this patch. The failing test was quite stable so these series of changes might be triggering it. @ralonsoh@redhat.com let\u0027s monitor a few days on how this goes. Wanted to try this out before any reverts.","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e1c0372a97e86bd8527e4cce87fc2d7c6dc47c11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b536471a_7d293e49","in_reply_to":"5521f6c9_8c63e13e","updated":"2024-06-27 06:14:34.000000000","message":"Agree with Yatin, these logs look related to this change.","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"51a75d5c016827eecb7126b8c18874106138ff0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2355f5f3_aa20018e","in_reply_to":"b536471a_7d293e49","updated":"2024-06-27 07:34:16.000000000","message":"I don\u0027t think these are related to the failure. This happens during test teardown after the failure. The timestamps in your logs are probably in local time. If you look at it with \"journalctl --utc\" you can see that this starts at \"18:40:34\". If you look at TestSecurityGroupsSameNetwork.test_securitygroup_ovs-openflow_.txt you can see that teardown starts at \"18:40:32\" with the deletion of the test host namespaces.\n\nThis is just something which is uncovered by the switch to systemd units, but these processes would not have reacted to SIGTERM even before. Before the default behavior was to just send SIGKILL to the process and to not give them a chance to shutdown cleanly. Now this is only done after it did not shutdown for 25s. The old behavior also lead to left over processes because there was no accounting of the left-over processes started by a daemon.","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"20beeb825e82e18552150664b5ff2c3fb03cac65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5521f6c9_8c63e13e","in_reply_to":"be86f7e0_b519ad0e","updated":"2024-06-27 05:33:10.000000000","message":"From journal logs[1] i see below which atleast looks related to this change\nJun 26 22:54:18 np0037816689 systemd[1]: TestAgentBandwidthReport.test_agent_configurations\\x28Open\\x20vSwitch\\x20agent\\x29\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2dc73f4ce9.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 26 22:59:08 np0037816689 systemd[1]: TestOvsConnectivitySameNetworkOnOvsBridgeControllerStop.test_controller_timeout_does_not_break_connectivity_sigterm\\x28VLANs\\x29\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2db727a282.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 26 23:06:13 np0037816689 systemd[1]: TestDhcpAgentHA.test_multiple_agents_for_network\\x28Open\\x20vSwitch\\x20agent\\x29\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2d4f9510e0.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 26 23:17:50 np0037816689 systemd[1]: TestHAL3Agent.test_external_subnet_changed\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2d2a7c83db.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 26 23:20:08 np0037816689 systemd[1]: TestHAL3Agent.test_ha_router\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2d78a62852.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 26 23:20:59 np0037816689 systemd[1]: TestHAL3Agent.test_ha_router_restart_agents_no_packet_lost\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2d25b4f223.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 26 23:30:47 np0037816689 systemd[1]: TestLegacyL3Agent.test_gateway_ip_changed\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2d0f23334e.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 27 00:07:55 np0037816689 systemd[1]: TestSecurityGroupsSameNetwork.test_securitygroup\\x28ovs\\x2dhybrid\\x29\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2d9722fc7a.service: State \u0027stop-sigterm\u0027 timed out. Killing.\nJun 27 00:11:15 np0037816689 systemd[1]: TestSecurityGroupsSameNetwork.test_securitygroup\\x28ovs\\x2dopenflow\\x29\\x2dneutron\\x2dopenvswitch\\x2dagent\\x2dhost\\x2de71d76af.service: State \u0027stop-sigterm\u0027 timed out. Killing.\n\n[1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_846/922786/2/gate/neutron-fullstack-with-uwsgi/846ca89/controller/logs/devstack.journal.gz","commit_id":"1c888c94a3457c5bc2225484e5dd86978c3d265d"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0608ac4dc008e6399cd1198efd206cd784f61f56","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        LOG.debug(\"Process started: %s\", self.process_name)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def stop(self, kill_signal\u003dNone):"},{"line_number":113,"context_line":"        if self.process_is_not_running():"},{"line_number":114,"context_line":"            return"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if kill_signal:"}],"source_content_type":"text/x-python","patch_set":1,"id":"465c55bc_cf773fec","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":41},"updated":"2024-06-26 08:03:28.000000000","message":"Now you have changed this method (that now includes \"deactivating\"), shouldn\u0027t you treat this option in a different way?","commit_id":"e40cb702c488d79f6270ccb64bc9de231eb77694"},{"author":{"_account_id":11290,"name":"Gaudenz Steinlin","email":"gaudenz.steinlin@cloudscale.ch","username":"gaudenz"},"change_message_id":"5ffe251bf517f7ee070dd282e5e6423937768128","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        LOG.debug(\"Process started: %s\", self.process_name)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def stop(self, kill_signal\u003dNone):"},{"line_number":113,"context_line":"        if self.process_is_not_running():"},{"line_number":114,"context_line":"            return"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if kill_signal:"}],"source_content_type":"text/x-python","patch_set":1,"id":"88037129_433b8e59","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":41},"in_reply_to":"465c55bc_cf773fec","updated":"2024-06-26 09:24:47.000000000","message":"IMO it\u0027s better now as before calls to stop while the process was activating/deactivating were just ignored. Now you can eg. kill a service with SIGKILL while it\u0027s deactivating. This method should try to stop the service in all states where at least some of it\u0027s processes are still running. There is no harm done by issueing `systemctl stop` several times. If the process is already deactivating it\u0027s just a noop.","commit_id":"e40cb702c488d79f6270ccb64bc9de231eb77694"}]}