)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c726d2304fd06d0e0b6a6947ac5f49e183dabbaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b2bc76d_ecd0f883","updated":"2024-07-02 14:25:24.000000000","message":"\"to err is human\" and I\u0027ve tested this patch with an environment similar to the reported one. I found a significant improvement when applying it (and my patch [1] in newer versions).\n\nSo yes, this change should be adopted. I don\u0027t know how far we\u0027ll be able to backport it because of the sqlalchemy support (that was added in 1.2)\n\n[1]https://review.opendev.org/c/openstack/neutron/+/923195","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9c9d34fe8c03d0ebb36db2f0845ace356b6b227b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e46ac554_2e68db4b","updated":"2024-07-08 17:44:40.000000000","message":"ARgh, ignore this comment, I thought i was looking at a different change","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9e66bfe99904e29dcd89fd0dc897cdeaac113623","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c06d7461_351c1b66","updated":"2024-07-08 17:44:13.000000000","message":"So the n-t-p OVN job used this version of neutron-lib:\n\nCollecting neutron-lib\u003e\u003d3.13.0 (from neutron\u003d\u003d25.0.0.0b2.dev20)\n\nWhich has this change:\n\nhttps://review.opendev.org/c/openstack/neutron-lib/+/920936\n\nBut stable/caracal (stable/2024.1) doesn\u0027t have that change, so will this break in actual deployments that use an older neutron-lib (e.g. 3.11.x) ?","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"aae56317ccb3da2a828638c6621b7db5bed4e607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ddb21425_d95e5e77","updated":"2024-07-09 14:17:14.000000000","message":"With this change postgres periodic job is broken https://bugs.launchpad.net/neutron/+bug/2072567","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a910dfa56c05208ed9eb75e567c169401c359fc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0cb429c0_ef3ae675","updated":"2024-07-05 06:35:37.000000000","message":"recheck\nTimeout in gate iptables hybrid","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"5c486092f2b11f8acb41f14359746da9f58bd41c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5de9eb87_bd7499d7","updated":"2024-07-01 19:20:41.000000000","message":"recheck - unrelated errors again.","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"18705c26bb2591a91df668b5f0d70c7a9590d4c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b84c924b_5f07a559","updated":"2024-07-03 12:16:06.000000000","message":"recheck fullstack gate","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d1a865f132e61b057f8c1a9813ac56436c0fd644","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82f66598_d56c68be","updated":"2024-07-05 09:26:49.000000000","message":"recheck neutron-tempest-plugin-openvswitch-enforce-scope-old-defaults","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c3bfd8f66f18fe94044106dd55911ea79d804f65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d64df83a_70ab0ff3","updated":"2024-07-04 10:32:51.000000000","message":"recheck neutron-tempest-plugin-ovn\nzuul CI is a bit unstable right now","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"b90f695fa3c85975320794699e7375b31ce37b1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d75c0fb_c865dcab","updated":"2024-06-28 17:27:05.000000000","message":"recheck unrelated error","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f8dfffc5d0abf6404965d089422d62187f74402d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"514f9618_3b8c0ab9","in_reply_to":"0dc48e14_b984df73","updated":"2024-07-02 17:06:25.000000000","message":"I think you will also need this in order to backport:\n\nhttps://review.opendev.org/c/openstack/neutron-lib/+/920936","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ead7ef757cd3b434af5532f176cfa03578e80fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0dc48e14_b984df73","in_reply_to":"5b2bc76d_ecd0f883","updated":"2024-07-02 14:28:47.000000000","message":"--\u003e at least up to 2023.1: https://github.com/openstack/requirements/blob/stable/2023.1/upper-constraints.txt#L151","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"}],"neutron/db/models_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6721301765ec5de3ab0cea75d1330dd367e593fd","unresolved":true,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"34096018_17f2d619","line":305,"updated":"2024-06-27 21:26:33.000000000","message":"Through your testing, did any of the other occurrences in this file that had a relationship to RBAC have a similar issue? In the entire tree there\u0027s only a handful of these RBAC relationships (this file, qos, address scopes, security groups, address groups) so didn\u0027t want to miss any optimizations if it\u0027s an easy fix. Thanks.","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d8160d9b31e4b5f5dab4de55b325adbde500f35f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"db40a0b8_cce3e800","line":305,"in_reply_to":"118b4149_c3a163c1","updated":"2024-07-02 07:23:15.000000000","message":"I replied in the LP bug. I don\u0027t see any improvement using it. Actually this patch will affect negatively the subnetpool queries when filtering their own RBAC registers.","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"2d487fcde3cd293efa9c870076b633426413f4f2","unresolved":true,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f06d6eaf_0b902fcd","line":305,"in_reply_to":"34096018_17f2d619","updated":"2024-06-28 14:48:54.000000000","message":"Hey Brian, sure! I think we can have 3 other potential paths where this could occur:\n\nQosNetworkPolicyBinding -\u003e joined (Network) -\u003e joined (RBAC rules)    \nNetworkDNSDomain  -\u003e joined (Network) -\u003e joined (RBAC rules)\nSubnetDNSPublishFixedIP -\u003e joined (Subnet) -\u003e joined (RBAC rules)\n\nBut as I\u0027m not testing these features specifically, I didn\u0027t want to propose replacing joined with selectin in all rbac use cases. Do you think this would be valid? How are we going to test?","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c4d0d0f1332415b325d5e9bb887b6ea84a365d08","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"05b170f9_76d9783b","line":305,"in_reply_to":"43165c78_1eafe979","updated":"2024-07-02 13:51:07.000000000","message":"Please disregard my last comment, we are actually retrieving the subnetpool RBACs in this query (but seems that I\u0027m blind)","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6b98496a394f16731c77b7ef63ef67c88e659e9","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"43165c78_1eafe979","line":305,"in_reply_to":"db40a0b8_cce3e800","updated":"2024-07-02 13:46:24.000000000","message":"Regarding to the LP comment [1], that refers to this patch. The SubnetPool.rbac_entries are only retrieved when we do a \"openstack subnet pool list\". The subnet pool RBAC registers are not retrieved in the \"openstack subnet list\", as you reported in this same comment. The only RBAC registers retrieved are the network RBACs. So this patch won\u0027t improve the subnet/network retrieval query.\n\n[1]https://bugs.launchpad.net/neutron/+bug/2071374/comments/2","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"5c486092f2b11f8acb41f14359746da9f58bd41c","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"118b4149_c3a163c1","line":305,"in_reply_to":"ea8a36a3_42e7b1b8","updated":"2024-07-01 19:20:41.000000000","message":"I got it! unfortunately I can\u0027t simulate problems with other paths as well as simulated with the subnets query.\n\nSo, I only see this point as a fix for the performance issue with rbacs.","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ad7e313668e9c466c6254edfaa192593bf87e8f8","unresolved":true,"context_lines":[{"line_number":302,"context_line":"                                lazy\u003d\u0027selectin\u0027)"},{"line_number":303,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.SubnetPoolRBAC,"},{"line_number":304,"context_line":"                                       backref\u003d\u0027subnetpools\u0027,"},{"line_number":305,"context_line":"                                       lazy\u003d\u0027selectin\u0027,"},{"line_number":306,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":307,"context_line":"    api_collections \u003d [subnetpool_def.COLLECTION_NAME]"},{"line_number":308,"context_line":"    collection_resource_map \u003d {subnetpool_def.COLLECTION_NAME:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea8a36a3_42e7b1b8","line":305,"in_reply_to":"f06d6eaf_0b902fcd","updated":"2024-06-28 20:25:09.000000000","message":"I guess my ask was to see, with your setup, if any other code paths with a similar joined relationship could be tested. If not we can track the work in https://bugs.launchpad.net/neutron/+bug/2069061 but I wouldn\u0027t just change them without testing.","commit_id":"46edf255bde0603fe88b2dd9f4e482590e384382"}]}