)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61b9c11b5b5de3a73dd7a7be1aa26c21102a78fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ecc6bcdb_2bd4b295","updated":"2024-06-28 19:44:38.000000000","message":"Should have a test as well, thanks.","commit_id":"8a7506139fa75b4140d4b050d56d0c57b4db3765"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3f08e4a0e4cb9197faab812e1345efef05dc22d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"efd88130_0a4c0997","in_reply_to":"ecc6bcdb_2bd4b295","updated":"2024-07-01 03:46:12.000000000","message":"done","commit_id":"8a7506139fa75b4140d4b050d56d0c57b4db3765"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b33fc54ff9daf9560faf27330e7b90e16e3f354a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f0b1479_8cdb207e","updated":"2024-07-02 09:51:14.000000000","message":"Is it possible to describe when this bug is happening? I\u0027m not asking for a reproducer, as it seems to be quite difficult, but a better explanation of how this error could happen, step by step.","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb3e9f15d899eb5602f17754889bdbda56959c5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ef98e20_8993ef8c","updated":"2024-07-01 07:02:19.000000000","message":"recheck","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"41300b22c354809c71ada712cfa71c3b0f4247a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9c31a91_93d7706d","updated":"2024-07-01 07:26:35.000000000","message":"recheck\nneutron-tempest-plugin-openvswitch failure (test_snat_external_ip) failure is not related","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc357f06ec23f133dc49db2fffec97bdf4040546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7252452_acbc429b","in_reply_to":"0f0b1479_8cdb207e","updated":"2024-07-02 13:11:25.000000000","message":"I\u0027m not very sure about how to reproduce this. But the code hit these lines in our production environments. It uses the wrong local_vlan ultimately.","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e2af0c3e9aae7dc42d25ba49ebb7bce2baa5e538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b274fa7b_dd85ed12","in_reply_to":"5ef98e20_8993ef8c","updated":"2024-07-01 07:27:31.000000000","message":"please provide some reasoning for recheck like which job failed or even better a bug id, that helps the team when we analyze the statistics","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cdecaf03c3633d895d9c350aa9d10c370e0c1c9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f64f95f5_69cc4aa1","updated":"2024-07-08 11:36:10.000000000","message":"Thanks","commit_id":"ae587c34ab59a5717630eded2fab84413f3c1742"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"648e85fc74708a883f7358f82ab144fca7fcc060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"336092d0_8795a12d","updated":"2024-07-11 02:46:00.000000000","message":"recheck","commit_id":"ae587c34ab59a5717630eded2fab84413f3c1742"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"7b0a33fa1059b3a134d4f82b65177d70b9fd4068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5bd73085_f0bb61dc","updated":"2024-07-03 00:36:20.000000000","message":"recheck","commit_id":"ae587c34ab59a5717630eded2fab84413f3c1742"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4b49e2ba47b64adb639d7b13039db20522165b93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0d35de5_754a56a9","updated":"2024-07-09 00:56:13.000000000","message":"recheck","commit_id":"ae587c34ab59a5717630eded2fab84413f3c1742"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"972d3cc54c2a688945b57f23f1a7f2557355844d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d51a4cd2_8411db6d","updated":"2024-07-09 06:56:15.000000000","message":"recheck","commit_id":"ae587c34ab59a5717630eded2fab84413f3c1742"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61b9c11b5b5de3a73dd7a7be1aa26c21102a78fc","unresolved":true,"context_lines":[{"line_number":736,"context_line":"                # the OVSDB Port other_config, since the ovs-agent\u0027s"},{"line_number":737,"context_line":"                # LocalVlanManager always allocated/updated it and then"},{"line_number":738,"context_line":"                # set_db_attribute to Port other_config before this."},{"line_number":739,"context_line":"                port_vlan_id \u003d self._get_port_vlan_tag(ovs_port.port_name)"},{"line_number":740,"context_line":"                of_port \u003d OFPort(port, ovs_port, port_vlan_id,"},{"line_number":741,"context_line":"                                 of_port.segment_id)"},{"line_number":742,"context_line":"                self.sg_port_map.create_port(of_port, port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8210cf2c_366b9c14","line":739,"updated":"2024-06-28 19:44:38.000000000","message":"Should the same be done for segment_id? Just basing on L721-722 above.","commit_id":"8a7506139fa75b4140d4b050d56d0c57b4db3765"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5dbb17055e9f9f28bc8034d174b664666b849f41","unresolved":true,"context_lines":[{"line_number":736,"context_line":"                # the OVSDB Port other_config, since the ovs-agent\u0027s"},{"line_number":737,"context_line":"                # LocalVlanManager always allocated/updated it and then"},{"line_number":738,"context_line":"                # set_db_attribute to Port other_config before this."},{"line_number":739,"context_line":"                port_vlan_id \u003d self._get_port_vlan_tag(ovs_port.port_name)"},{"line_number":740,"context_line":"                of_port \u003d OFPort(port, ovs_port, port_vlan_id,"},{"line_number":741,"context_line":"                                 of_port.segment_id)"},{"line_number":742,"context_line":"                self.sg_port_map.create_port(of_port, port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b902aebc_6b0550c8","line":739,"in_reply_to":"8210cf2c_366b9c14","updated":"2024-07-01 03:36:17.000000000","message":"Not very sure, since we not meet such issue here with segment_id.\n\nBut, if so, it\u0027s better to add those network_type and physical_network as well.","commit_id":"8a7506139fa75b4140d4b050d56d0c57b4db3765"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"41300b22c354809c71ada712cfa71c3b0f4247a9","unresolved":true,"context_lines":[{"line_number":736,"context_line":"                # the OVSDB Port other_config, since the ovs-agent\u0027s"},{"line_number":737,"context_line":"                # LocalVlanManager always allocated/updated it and then"},{"line_number":738,"context_line":"                # set_db_attribute to Port other_config before this."},{"line_number":739,"context_line":"                port_vlan_id \u003d self._get_port_vlan_tag(ovs_port.port_name)"},{"line_number":740,"context_line":"                of_port \u003d OFPort(port, ovs_port, port_vlan_id,"},{"line_number":741,"context_line":"                                 of_port.segment_id)"},{"line_number":742,"context_line":"                self.sg_port_map.create_port(of_port, port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d493858f_28f5e3a8","line":739,"in_reply_to":"b902aebc_6b0550c8","updated":"2024-07-01 07:26:35.000000000","message":"+1","commit_id":"8a7506139fa75b4140d4b050d56d0c57b4db3765"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b33fc54ff9daf9560faf27330e7b90e16e3f354a","unresolved":true,"context_lines":[{"line_number":718,"context_line":"        try:"},{"line_number":719,"context_line":"            of_port \u003d self.sg_port_map.ports[port_id]"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            port_vlan_id \u003d self._get_port_vlan_tag(ovs_port.port_name)"},{"line_number":722,"context_line":"            segment_id \u003d self._get_port_segmentation_id("},{"line_number":723,"context_line":"                ovs_port.port_name)"},{"line_number":724,"context_line":"            network_type \u003d self._get_port_network_type("},{"line_number":725,"context_line":"                ovs_port.port_name)"},{"line_number":726,"context_line":"            physical_network \u003d self._get_port_physical_network("},{"line_number":727,"context_line":"                ovs_port.port_name)"},{"line_number":728,"context_line":"            of_port \u003d OFPort(port, ovs_port, port_vlan_id,"},{"line_number":729,"context_line":"                             segment_id,"},{"line_number":730,"context_line":"                             network_type, physical_network)"},{"line_number":731,"context_line":"            self.sg_port_map.create_port(of_port, port)"},{"line_number":732,"context_line":"        else:"},{"line_number":733,"context_line":"            if of_port.ofport !\u003d ovs_port.ofport:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dcc5ade4_d1a062ef","line":730,"range":{"start_line":721,"start_character":0,"end_line":730,"end_character":60},"updated":"2024-07-02 09:51:14.000000000","message":"We are duplicating this code section, that should be an inner method.","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"bc357f06ec23f133dc49db2fffec97bdf4040546","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        try:"},{"line_number":719,"context_line":"            of_port \u003d self.sg_port_map.ports[port_id]"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            port_vlan_id \u003d self._get_port_vlan_tag(ovs_port.port_name)"},{"line_number":722,"context_line":"            segment_id \u003d self._get_port_segmentation_id("},{"line_number":723,"context_line":"                ovs_port.port_name)"},{"line_number":724,"context_line":"            network_type \u003d self._get_port_network_type("},{"line_number":725,"context_line":"                ovs_port.port_name)"},{"line_number":726,"context_line":"            physical_network \u003d self._get_port_physical_network("},{"line_number":727,"context_line":"                ovs_port.port_name)"},{"line_number":728,"context_line":"            of_port \u003d OFPort(port, ovs_port, port_vlan_id,"},{"line_number":729,"context_line":"                             segment_id,"},{"line_number":730,"context_line":"                             network_type, physical_network)"},{"line_number":731,"context_line":"            self.sg_port_map.create_port(of_port, port)"},{"line_number":732,"context_line":"        else:"},{"line_number":733,"context_line":"            if of_port.ofport !\u003d ovs_port.ofport:"}],"source_content_type":"text/x-python","patch_set":3,"id":"76ca3640_8f923f4a","line":730,"range":{"start_line":721,"start_character":0,"end_line":730,"end_character":60},"in_reply_to":"dcc5ade4_d1a062ef","updated":"2024-07-02 13:11:25.000000000","message":"Done","commit_id":"e4606e0c5490efd480662291ec4c680282a47dd6"}]}