)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e25da6308162fc161fdaa2dc20882b04635b9e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b2439e9_84f3dd2f","updated":"2024-06-29 07:11:49.000000000","message":"Hm, this isn\u0027t working right.","commit_id":"09d28030c7d9f66fe502a56134e6d0b9bd0fc42b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"96aa91b512603a7e7b59b2da03ea79dbfef89f5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e653ae7a_5f40f4ac","updated":"2024-07-12 07:52:22.000000000","message":"recheck\ndesignate job is temporarily non-voting","commit_id":"6be68a415870580dce93483cb5c8deadc3875155"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4177783709471c91173fcb5a4605669eac691de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a73321a_aa44b449","updated":"2024-07-11 06:47:15.000000000","message":"recheck - designate job failure is not related to that patch","commit_id":"6be68a415870580dce93483cb5c8deadc3875155"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"08b563c60ae6f7b6903cbb46f588f80a09fda691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"104ea61f_6af28267","updated":"2024-08-02 06:59:45.000000000","message":"recheck neutron-tempest-plugin-openvswitch-enforce-scope-old-defaults","commit_id":"6be68a415870580dce93483cb5c8deadc3875155"}],"devstack/plugin.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"511c69a7d3a26f96f23670ad99b46d97285527f3","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            if is_service_enabled br-ex-tcpdump ; then"},{"line_number":118,"context_line":"                # tcpdump monitor on br-ex for ARP, reverse ARP and ICMP v4 / v6 packets"},{"line_number":119,"context_line":"                sudo ip link set dev $PUBLIC_BRIDGE up"},{"line_number":120,"context_line":"                TCPDUMP\u003d$(which tcpdump)"},{"line_number":121,"context_line":"                if [[ ! $TCPDUMP \u0026\u0026 \"$os_CODENAME\" \u003d\u003d \"jammy\" ]]; then"},{"line_number":122,"context_line":"                    TCPDUMP\u003d/usr/bin/tcpdump"},{"line_number":123,"context_line":"                else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"c14746ad_4afa4f1d","line":120,"updated":"2024-07-10 19:38:18.000000000","message":"The problem is that if \u0027which tcpdump\u0027 returns something it\u0027s value is not used, it will fall-into the else. Seems there needs to be a nested check:\n\nif [[ ! $TCPDUMP ]]; then\n    if [[ \"$os_CODENAME\" \u003d\u003d \"jammy\" ]]; then\n    ...\nfi\n\nMy other concern is about the \"! $TCPDUMP\" check. If it\u0027s an empty string that always works, right? 😊  Using set -x in a test script seems to show it does, but I\u0027m not an expert:\n\n++ [[ ! -n \u0027\u0027 ]]","commit_id":"09d28030c7d9f66fe502a56134e6d0b9bd0fc42b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"27c6a41e3e0fe61b508d471374dd65868269425a","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            if is_service_enabled br-ex-tcpdump ; then"},{"line_number":118,"context_line":"                # tcpdump monitor on br-ex for ARP, reverse ARP and ICMP v4 / v6 packets"},{"line_number":119,"context_line":"                sudo ip link set dev $PUBLIC_BRIDGE up"},{"line_number":120,"context_line":"                TCPDUMP\u003d$(which tcpdump)"},{"line_number":121,"context_line":"                if [[ ! $TCPDUMP \u0026\u0026 \"$os_CODENAME\" \u003d\u003d \"jammy\" ]]; then"},{"line_number":122,"context_line":"                    TCPDUMP\u003d/usr/bin/tcpdump"},{"line_number":123,"context_line":"                else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"480e9d04_4ad001da","line":120,"in_reply_to":"c14746ad_4afa4f1d","updated":"2024-07-10 20:26:05.000000000","message":"Yeah ... you\u0027re right. Initially I had a nested check in PS1 but it failed bashate and I didn\u0027t notice why 😩, so I (erroneously) changed it to this.\n\nThanks for looking at this patch and pointing out the problem.","commit_id":"09d28030c7d9f66fe502a56134e6d0b9bd0fc42b"}]}