)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e27b263a256c9b1e17bab1c3d94225888a349fef","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch introduces a new configuration option for OVN"},{"line_number":10,"context_line":"called \"broadcast_arps_to_all_routers\". This option is"},{"line_number":11,"context_line":"responsible for configuring the provider networks with the"},{"line_number":12,"context_line":"\u0027broadcast-arps-to-all-routers\u0027 configuration from OVN 23.06 and newer. By"},{"line_number":13,"context_line":"enabling this option (default) OVN will flood ARP requests to all attached"},{"line_number":14,"context_line":"ports on a network. If disabled, ARP requests are only sent to routers"},{"line_number":15,"context_line":"on that network if the target MAC address matches. ARP requests that"},{"line_number":16,"context_line":"does not match a router will only be forwarded to non-router ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2710c11b_61ad5bfa","line":13,"range":{"start_line":12,"start_character":71,"end_line":13,"end_character":74},"updated":"2024-07-04 06:09:11.000000000","message":"nit: the commit message looks broken in gerrit due to the lenght","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1668b3bc4c8ef7dc5f903ca2a39e8c08f40920d8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch introduces a new configuration option for OVN"},{"line_number":10,"context_line":"called \"broadcast_arps_to_all_routers\". This option is"},{"line_number":11,"context_line":"responsible for configuring the provider networks with the"},{"line_number":12,"context_line":"\u0027broadcast-arps-to-all-routers\u0027 configuration from OVN 23.06 and newer. By"},{"line_number":13,"context_line":"enabling this option (default) OVN will flood ARP requests to all attached"},{"line_number":14,"context_line":"ports on a network. If disabled, ARP requests are only sent to routers"},{"line_number":15,"context_line":"on that network if the target MAC address matches. ARP requests that"},{"line_number":16,"context_line":"does not match a router will only be forwarded to non-router ports."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"90b6b2c6_eb8e1d03","line":13,"range":{"start_line":12,"start_character":71,"end_line":13,"end_character":74},"in_reply_to":"2710c11b_61ad5bfa","updated":"2024-07-04 08:13:28.000000000","message":"Done","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e27b263a256c9b1e17bab1c3d94225888a349fef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3754b641_04db6314","updated":"2024-07-04 06:09:11.000000000","message":"-1 for the \"is_provider_network\" check","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6c7fc24fe7a04fd637a46fe368402b62f30fe7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3a710c53_5a7b82a9","updated":"2024-07-04 12:33:35.000000000","message":"recheck","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58539789571cf24c2313928cb71ca0ab540551f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c308209d_baf6f793","updated":"2024-07-04 15:26:45.000000000","message":"recheck\n\nunrelated failures","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"12c489220a32ae0cef75a3eefff0c8fb065f9251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5c572212_f55b37f2","updated":"2024-07-05 06:06:45.000000000","message":"recheck unrelated errors in neutron-functional-with-uwsgi","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ac2d0aa5783102a153107b24330f60fcb4d36cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"429dcfce_8c15680e","updated":"2024-07-09 19:17:32.000000000","message":"I\u0027m going to update this based on my comments since I think Lucas if offline now.","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"03c8853d7536192532e94cbbae9d4923fab0ea48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7831541_aa3fd32b","updated":"2024-07-09 10:40:22.000000000","message":"Thanks","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"67264719d91ef3bfbbc25267ebd17467ad9179c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82e87cd2_92c37246","updated":"2024-07-09 13:58:30.000000000","message":"recheck\n\nunrelated failure","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8805e182ad1c976e05fcd38eed66ac2a3a1dfe8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eff3feb5_3f021dfd","updated":"2024-07-09 19:21:48.000000000","message":"Just fixed typos.","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6a8c9fffa290c60f9561554df839a8866c856ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"60e6264f_71afc08b","updated":"2024-07-15 13:26:19.000000000","message":"Thanks Brian!","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f3ce0c963a215db43ba3b9f073a4f05c9535ff3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c7ae0b1f_56f4da4b","updated":"2024-07-10 08:19:58.000000000","message":"Thanks Brian!","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c84f5881f4d0df98f02521baa1ff43ba6e2f8823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ad661a3_4ce0991f","updated":"2024-07-17 07:34:52.000000000","message":"recheck","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fce371a55e55660cf272f9da5ca28d00fa0ccf1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"56c279c2_87e67011","updated":"2024-07-18 07:46:36.000000000","message":"recheck","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"99f0fbc57430863079fd1ddf5a93ebf22265aaca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ce79a42b_5d9e41ab","updated":"2024-07-17 14:59:27.000000000","message":"recheck","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4b1f4f1ceb181988c0ca9ea6075c24a2bb72eb00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"548d73f3_e52fbf08","updated":"2024-07-19 08:05:59.000000000","message":"recheck\n\n:-(","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6f53d0426f24a112d7bf2f262184b6af4a17bbdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6e700913_801da236","updated":"2024-07-16 07:01:22.000000000","message":"recheck\n\nunrelated failure on a OVS job","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5a070e2a6863ee5c533a50106ba5c20dcbcab0b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e89a452c_e009d9fa","updated":"2024-07-16 09:32:15.000000000","message":"recheck\n\nunrelated failure on another ovs job","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48b3c069dbfc19abdec2f5a9074c6fe65ab62340","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72d67a24_470588cf","updated":"2024-07-18 12:17:49.000000000","message":"recheck\n\nunrelated openvswitch job failure","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a34c531fa2da5532f5883a5034aab6e82d3c9a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9cab5086_274fda9b","updated":"2024-07-19 14:30:32.000000000","message":"recheck\n\nunrelated test_metadata_routed test failure","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0a45d88df458695903f77454d2b075d071eeb54c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7082c4a1_4465c9a1","in_reply_to":"2dcd09f2_cfcdf453","updated":"2024-07-19 10:03:52.000000000","message":"for oom-kill issue reported https://bugs.launchpad.net/neutron/+bug/2073582","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"66f002dd9bc4b5331da04bbb62bbbb1dfe7c9a84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2dcd09f2_cfcdf453","in_reply_to":"548d73f3_e52fbf08","updated":"2024-07-19 09:14:22.000000000","message":"should be better now with the fixes merged last night, some new oom-kill issue also seen will report an issue for that.","commit_id":"f651b28c4234ab7d20ecae7d12b47cc090b92ea9"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ac2d0aa5783102a153107b24330f60fcb4d36cf","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                       \u0027all attached ports on a network. If set to False, \u0027"},{"line_number":228,"context_line":"                       \u0027ARP requests are only sent to routers on that network \u0027"},{"line_number":229,"context_line":"                       \u0027if the target MAC address matches, ARP requests that\u0027"},{"line_number":230,"context_line":"                       \u0027does not match a router will only be forwarded to \u0027"},{"line_number":231,"context_line":"                       \u0027non-router ports. Supported by OVN \u003e\u003d 23.06.\u0027)),"},{"line_number":232,"context_line":"]"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1b44ab8f_2c52eff4","line":230,"range":{"start_line":230,"start_character":24,"end_line":230,"end_character":28},"updated":"2024-07-09 19:17:32.000000000","message":"s/do","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8805e182ad1c976e05fcd38eed66ac2a3a1dfe8b","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                       \u0027all attached ports on a network. If set to False, \u0027"},{"line_number":228,"context_line":"                       \u0027ARP requests are only sent to routers on that network \u0027"},{"line_number":229,"context_line":"                       \u0027if the target MAC address matches, ARP requests that\u0027"},{"line_number":230,"context_line":"                       \u0027does not match a router will only be forwarded to \u0027"},{"line_number":231,"context_line":"                       \u0027non-router ports. Supported by OVN \u003e\u003d 23.06.\u0027)),"},{"line_number":232,"context_line":"]"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"85836671_603bd013","line":230,"range":{"start_line":230,"start_character":24,"end_line":230,"end_character":28},"in_reply_to":"1b44ab8f_2c52eff4","updated":"2024-07-09 19:21:48.000000000","message":"Done","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3afe9c8160b5ed1eb908e5e4bbe251b8c8d3567","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                help\u003d_(\u0027If enabled (default) OVN will flood ARP requests to \u0027"},{"line_number":227,"context_line":"                       \u0027all attached ports on a network. If set to False, \u0027"},{"line_number":228,"context_line":"                       \u0027ARP requests are only sent to routers on that network \u0027"},{"line_number":229,"context_line":"                       \u0027if the target MAC address matches. ARP requests that\u0027"},{"line_number":230,"context_line":"                       \u0027do not match a router will only be forwarded to \u0027"},{"line_number":231,"context_line":"                       \u0027non-router ports. Supported by OVN \u003e\u003d 23.06.\u0027)),"},{"line_number":232,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc16d8e_4e8a4bae","line":229,"updated":"2024-07-10 20:43:27.000000000","message":"missing trailing space","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6a8c9fffa290c60f9561554df839a8866c856ccc","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                help\u003d_(\u0027If enabled (default) OVN will flood ARP requests to \u0027"},{"line_number":227,"context_line":"                       \u0027all attached ports on a network. If set to False, \u0027"},{"line_number":228,"context_line":"                       \u0027ARP requests are only sent to routers on that network \u0027"},{"line_number":229,"context_line":"                       \u0027if the target MAC address matches. ARP requests that\u0027"},{"line_number":230,"context_line":"                       \u0027do not match a router will only be forwarded to \u0027"},{"line_number":231,"context_line":"                       \u0027non-router ports. Supported by OVN \u003e\u003d 23.06.\u0027)),"},{"line_number":232,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f19a0b4_31891bd8","line":229,"in_reply_to":"5fc16d8e_4e8a4bae","updated":"2024-07-15 13:26:19.000000000","message":"Done","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e27b263a256c9b1e17bab1c3d94225888a349fef","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_provider_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"46fa1d0e_ba29930d","line":1242,"range":{"start_line":1242,"start_character":12,"end_line":1242,"end_character":50},"updated":"2024-07-04 06:09:11.000000000","message":"Why this check? Is this because a provider network can be external? I think we need to re-evaluate this logic because a tunnelled network can be external too and attached to a router as GW (e.g.: [1]).\n\n[1]https://review.opendev.org/q/topic:%22bug/2052821%22","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c96c6f395464b850ae9c3d764cc94b4744ec6602","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_provider_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"38f5eef3_a61e7b6e","line":1242,"range":{"start_line":1242,"start_character":12,"end_line":1242,"end_character":50},"in_reply_to":"2deb9ab2_eb41df25","updated":"2024-07-04 09:30:44.000000000","message":"Done","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1668b3bc4c8ef7dc5f903ca2a39e8c08f40920d8","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_provider_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2deb9ab2_eb41df25","line":1242,"range":{"start_line":1242,"start_character":12,"end_line":1242,"end_character":50},"in_reply_to":"46fa1d0e_ba29930d","updated":"2024-07-04 08:13:28.000000000","message":"Thanks for this comment. I agree with u, I will re-do the logic here","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":28056,"name":"Liushy","email":"liuxie_11@163.com","username":"liuxie_11"},"change_message_id":"ab722ad488ec09a0a214164854f89a96f74e7691","unresolved":true,"context_lines":[{"line_number":1235,"context_line":"        to the ML2/OVN configuration option."},{"line_number":1236,"context_line":"        \"\"\""},{"line_number":1237,"context_line":"        context \u003d n_context.get_admin_context()"},{"line_number":1238,"context_line":"        networks \u003d self._ovn_client._plugin.get_networks(context)"},{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_external_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"},{"line_number":1246,"context_line":"            broadcast_value \u003d ls.other_config.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"dc0c71d9_45c4b9d8","line":1243,"range":{"start_line":1238,"start_character":0,"end_line":1243,"end_character":24},"updated":"2024-07-05 06:12:21.000000000","message":"You can only call get_networks once with filters\u003d{\u0027router:external\u0027: [True]}.","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8e940ff4fe91987a6687510f1217105cd36460c4","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"        to the ML2/OVN configuration option."},{"line_number":1236,"context_line":"        \"\"\""},{"line_number":1237,"context_line":"        context \u003d n_context.get_admin_context()"},{"line_number":1238,"context_line":"        networks \u003d self._ovn_client._plugin.get_networks(context)"},{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_external_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"},{"line_number":1246,"context_line":"            broadcast_value \u003d ls.other_config.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"a52f9e56_01154205","line":1243,"range":{"start_line":1238,"start_character":0,"end_line":1243,"end_character":24},"in_reply_to":"4f70e7b7_cc700d5d","updated":"2024-07-05 08:17:52.000000000","message":"Done","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"29808ce270c7a27415a5b51edd03d7e6473f813e","unresolved":true,"context_lines":[{"line_number":1235,"context_line":"        to the ML2/OVN configuration option."},{"line_number":1236,"context_line":"        \"\"\""},{"line_number":1237,"context_line":"        context \u003d n_context.get_admin_context()"},{"line_number":1238,"context_line":"        networks \u003d self._ovn_client._plugin.get_networks(context)"},{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_external_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"},{"line_number":1246,"context_line":"            broadcast_value \u003d ls.other_config.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"4f70e7b7_cc700d5d","line":1243,"range":{"start_line":1238,"start_character":0,"end_line":1243,"end_character":24},"in_reply_to":"b1bf5461_7881ff3b","updated":"2024-07-05 08:17:41.000000000","message":"Ah thanks! Makes sense, will do it","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7796440b607d94ddf7e9b72d0f952f0494f1728d","unresolved":true,"context_lines":[{"line_number":1235,"context_line":"        to the ML2/OVN configuration option."},{"line_number":1236,"context_line":"        \"\"\""},{"line_number":1237,"context_line":"        context \u003d n_context.get_admin_context()"},{"line_number":1238,"context_line":"        networks \u003d self._ovn_client._plugin.get_networks(context)"},{"line_number":1239,"context_line":"        cmds \u003d []"},{"line_number":1240,"context_line":"        for net in networks:"},{"line_number":1241,"context_line":"            # Skip if it\u0027s not a provider network"},{"line_number":1242,"context_line":"            if not utils.is_external_network(net):"},{"line_number":1243,"context_line":"                continue"},{"line_number":1244,"context_line":"            ls_name \u003d utils.ovn_name(net[\u0027id\u0027])"},{"line_number":1245,"context_line":"            ls \u003d self._nb_idl.get_lswitch(ls_name)"},{"line_number":1246,"context_line":"            broadcast_value \u003d ls.other_config.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"b1bf5461_7881ff3b","line":1243,"range":{"start_line":1238,"start_character":0,"end_line":1243,"end_character":24},"in_reply_to":"dc0c71d9_45c4b9d8","updated":"2024-07-05 06:38:31.000000000","message":"That\u0027s a very good comment.","commit_id":"96d7f8084231f518a61fcd24256996ab996a6fa6"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e27b263a256c9b1e17bab1c3d94225888a349fef","unresolved":true,"context_lines":[{"line_number":2057,"context_line":"            ovn_const.MCAST_FLOOD_UNREGISTERED:"},{"line_number":2058,"context_line":"                ovs_conf.get_igmp_flood_unregistered(),"},{"line_number":2059,"context_line":"            ovn_const.VLAN_PASSTHRU: vlan_transparent}"},{"line_number":2060,"context_line":"        if utils.is_provider_network(network):"},{"line_number":2061,"context_line":"            params[\u0027other_config\u0027][ovn_const.LS_OPTIONS_FDB_AGE_THRESHOLD] \u003d ("},{"line_number":2062,"context_line":"                ovn_conf.get_fdb_age_threshold())"},{"line_number":2063,"context_line":"            params[\u0027other_config\u0027]["}],"source_content_type":"text/x-python","patch_set":4,"id":"6f50c3a5_9911136a","line":2060,"range":{"start_line":2060,"start_character":8,"end_line":2060,"end_character":46},"updated":"2024-07-04 06:09:11.000000000","message":"Same concern here.","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c96c6f395464b850ae9c3d764cc94b4744ec6602","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"            ovn_const.MCAST_FLOOD_UNREGISTERED:"},{"line_number":2058,"context_line":"                ovs_conf.get_igmp_flood_unregistered(),"},{"line_number":2059,"context_line":"            ovn_const.VLAN_PASSTHRU: vlan_transparent}"},{"line_number":2060,"context_line":"        if utils.is_provider_network(network):"},{"line_number":2061,"context_line":"            params[\u0027other_config\u0027][ovn_const.LS_OPTIONS_FDB_AGE_THRESHOLD] \u003d ("},{"line_number":2062,"context_line":"                ovn_conf.get_fdb_age_threshold())"},{"line_number":2063,"context_line":"            params[\u0027other_config\u0027]["}],"source_content_type":"text/x-python","patch_set":4,"id":"62b8b1b7_4ffd157d","line":2060,"range":{"start_line":2060,"start_character":8,"end_line":2060,"end_character":46},"in_reply_to":"2333e587_bafed6aa","updated":"2024-07-04 09:30:44.000000000","message":"Done","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1668b3bc4c8ef7dc5f903ca2a39e8c08f40920d8","unresolved":true,"context_lines":[{"line_number":2057,"context_line":"            ovn_const.MCAST_FLOOD_UNREGISTERED:"},{"line_number":2058,"context_line":"                ovs_conf.get_igmp_flood_unregistered(),"},{"line_number":2059,"context_line":"            ovn_const.VLAN_PASSTHRU: vlan_transparent}"},{"line_number":2060,"context_line":"        if utils.is_provider_network(network):"},{"line_number":2061,"context_line":"            params[\u0027other_config\u0027][ovn_const.LS_OPTIONS_FDB_AGE_THRESHOLD] \u003d ("},{"line_number":2062,"context_line":"                ovn_conf.get_fdb_age_threshold())"},{"line_number":2063,"context_line":"            params[\u0027other_config\u0027]["}],"source_content_type":"text/x-python","patch_set":4,"id":"2333e587_bafed6aa","line":2060,"range":{"start_line":2060,"start_character":8,"end_line":2060,"end_character":46},"in_reply_to":"6f50c3a5_9911136a","updated":"2024-07-04 08:13:28.000000000","message":"Done","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3afe9c8160b5ed1eb908e5e4bbe251b8c8d3567","unresolved":true,"context_lines":[{"line_number":2062,"context_line":"                ovn_conf.get_fdb_age_threshold())"},{"line_number":2063,"context_line":"        if utils.is_external_network(network):"},{"line_number":2064,"context_line":"            params[\u0027other_config\u0027]["},{"line_number":2065,"context_line":"                ovn_const.LS_OPTIONS_BROADCAST_ARPS_ROUTERS] \u003d (\u0027true\u0027"},{"line_number":2066,"context_line":"                if ovn_conf.is_broadcast_arps_to_all_routers_enabled() else"},{"line_number":2067,"context_line":"                \u0027false\u0027)"},{"line_number":2068,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":7,"id":"f3724db4_60401053","line":2065,"updated":"2024-07-10 20:43:27.000000000","message":"should we avoid setting true when it\u0027s already the default in OVN?","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b248bd66bcacde34312d476e85986eea5eacdbec","unresolved":true,"context_lines":[{"line_number":2062,"context_line":"                ovn_conf.get_fdb_age_threshold())"},{"line_number":2063,"context_line":"        if utils.is_external_network(network):"},{"line_number":2064,"context_line":"            params[\u0027other_config\u0027]["},{"line_number":2065,"context_line":"                ovn_const.LS_OPTIONS_BROADCAST_ARPS_ROUTERS] \u003d (\u0027true\u0027"},{"line_number":2066,"context_line":"                if ovn_conf.is_broadcast_arps_to_all_routers_enabled() else"},{"line_number":2067,"context_line":"                \u0027false\u0027)"},{"line_number":2068,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":7,"id":"4b065a9f_64a88e0d","line":2065,"in_reply_to":"55f4f965_075f43a1","updated":"2024-07-15 15:50:07.000000000","message":"I have no hard opinion. But OVN team was complaining we pollute database fields with unnecessary key-values and this makes dbs too large.","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6a8c9fffa290c60f9561554df839a8866c856ccc","unresolved":true,"context_lines":[{"line_number":2062,"context_line":"                ovn_conf.get_fdb_age_threshold())"},{"line_number":2063,"context_line":"        if utils.is_external_network(network):"},{"line_number":2064,"context_line":"            params[\u0027other_config\u0027]["},{"line_number":2065,"context_line":"                ovn_const.LS_OPTIONS_BROADCAST_ARPS_ROUTERS] \u003d (\u0027true\u0027"},{"line_number":2066,"context_line":"                if ovn_conf.is_broadcast_arps_to_all_routers_enabled() else"},{"line_number":2067,"context_line":"                \u0027false\u0027)"},{"line_number":2068,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":7,"id":"55f4f965_075f43a1","line":2065,"in_reply_to":"f3724db4_60401053","updated":"2024-07-15 13:26:19.000000000","message":"I rather have it explicit, no ?\n\nIn the case of default changing value we are shielded from it. It\u0027s not likely but, it\u0027s good be on the safe side. Also explicit is good for troubleshooting.","commit_id":"f72abb2a8d09fb68d2e811fc3c77013caa7f08c3"}],"releasenotes/notes/broadcast-arp-to-all-routers-a9b1b997549d8b2f.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e27b263a256c9b1e17bab1c3d94225888a349fef","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    newer. By enabling this option (default) OVN will flood ARP requests to"},{"line_number":8,"context_line":"    all attached ports on a network. If disabled, ARP requests are only sent"},{"line_number":9,"context_line":"    to routers on that network if the target MAC address matches. ARP requests"},{"line_number":10,"context_line":"    that does not match a router will only be forwarded to non-router ports."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c9fdc4c2_d1757f5f","line":10,"updated":"2024-07-04 06:09:11.000000000","message":"nit: gerrit is complaining about \"No newline at end of right file.\"","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1668b3bc4c8ef7dc5f903ca2a39e8c08f40920d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    newer. By enabling this option (default) OVN will flood ARP requests to"},{"line_number":8,"context_line":"    all attached ports on a network. If disabled, ARP requests are only sent"},{"line_number":9,"context_line":"    to routers on that network if the target MAC address matches. ARP requests"},{"line_number":10,"context_line":"    that does not match a router will only be forwarded to non-router ports."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"271bc142_2cb90c4f","line":10,"in_reply_to":"c9fdc4c2_d1757f5f","updated":"2024-07-04 08:13:28.000000000","message":"Done","commit_id":"1d9351d6510e7aad312512a88b326f317aa4326e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ac2d0aa5783102a153107b24330f60fcb4d36cf","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration option called"},{"line_number":5,"context_line":"    \"broadcast_arps_to_all_routers\" to the \"ovn\" group. This option"},{"line_number":6,"context_line":"    is responsible for configuring the external networks with the"},{"line_number":7,"context_line":"    \u0027broadcast-arps-to-all-routers\u0027 config from OVN 23.06 and newer. By"},{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"021d722b_ff1a2db2","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":54},"updated":"2024-07-09 19:17:32.000000000","message":"``[ovn]`` config section","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ac2d0aa5783102a153107b24330f60fcb4d36cf","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration option called"},{"line_number":5,"context_line":"    \"broadcast_arps_to_all_routers\" to the \"ovn\" group. This option"},{"line_number":6,"context_line":"    is responsible for configuring the external networks with the"},{"line_number":7,"context_line":"    \u0027broadcast-arps-to-all-routers\u0027 config from OVN 23.06 and newer. By"},{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e44bee9_cd116a59","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":35},"updated":"2024-07-09 19:17:32.000000000","message":"``broadcast_arps_to_all_routers``","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8805e182ad1c976e05fcd38eed66ac2a3a1dfe8b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration option called"},{"line_number":5,"context_line":"    \"broadcast_arps_to_all_routers\" to the \"ovn\" group. This option"},{"line_number":6,"context_line":"    is responsible for configuring the external networks with the"},{"line_number":7,"context_line":"    \u0027broadcast-arps-to-all-routers\u0027 config from OVN 23.06 and newer. By"},{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f627856d_8ba644e3","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":54},"in_reply_to":"021d722b_ff1a2db2","updated":"2024-07-09 19:21:48.000000000","message":"Done","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8805e182ad1c976e05fcd38eed66ac2a3a1dfe8b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new configuration option called"},{"line_number":5,"context_line":"    \"broadcast_arps_to_all_routers\" to the \"ovn\" group. This option"},{"line_number":6,"context_line":"    is responsible for configuring the external networks with the"},{"line_number":7,"context_line":"    \u0027broadcast-arps-to-all-routers\u0027 config from OVN 23.06 and newer. By"},{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b5e1ab03_76420c72","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":35},"in_reply_to":"8e44bee9_cd116a59","updated":"2024-07-09 19:21:48.000000000","message":"Done","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ac2d0aa5783102a153107b24330f60fcb4d36cf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Added a new configuration option called"},{"line_number":5,"context_line":"    \"broadcast_arps_to_all_routers\" to the \"ovn\" group. This option"},{"line_number":6,"context_line":"    is responsible for configuring the external networks with the"},{"line_number":7,"context_line":"    \u0027broadcast-arps-to-all-routers\u0027 config from OVN 23.06 and newer. By"},{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"},{"line_number":9,"context_line":"    attached ports on a network. If disabled, ARP requests are only sent"},{"line_number":10,"context_line":"    to routers on that network if the target MAC address matches. ARP"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6130aca4_89fd184d","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":47},"updated":"2024-07-09 19:17:32.000000000","message":"s/option available in","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8805e182ad1c976e05fcd38eed66ac2a3a1dfe8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added a new configuration option called"},{"line_number":5,"context_line":"    \"broadcast_arps_to_all_routers\" to the \"ovn\" group. This option"},{"line_number":6,"context_line":"    is responsible for configuring the external networks with the"},{"line_number":7,"context_line":"    \u0027broadcast-arps-to-all-routers\u0027 config from OVN 23.06 and newer. By"},{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"},{"line_number":9,"context_line":"    attached ports on a network. If disabled, ARP requests are only sent"},{"line_number":10,"context_line":"    to routers on that network if the target MAC address matches. ARP"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"630d3f50_7b885d83","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":47},"in_reply_to":"6130aca4_89fd184d","updated":"2024-07-09 19:21:48.000000000","message":"Done","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ac2d0aa5783102a153107b24330f60fcb4d36cf","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"},{"line_number":9,"context_line":"    attached ports on a network. If disabled, ARP requests are only sent"},{"line_number":10,"context_line":"    to routers on that network if the target MAC address matches. ARP"},{"line_number":11,"context_line":"    requests that does not match a router will only be forwarded to"},{"line_number":12,"context_line":"    non-router ports."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2cd7b2f7_4314566a","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":22},"updated":"2024-07-09 19:17:32.000000000","message":"s/do","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8805e182ad1c976e05fcd38eed66ac2a3a1dfe8b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    enabling this option (default) OVN will flood ARP requests to all"},{"line_number":9,"context_line":"    attached ports on a network. If disabled, ARP requests are only sent"},{"line_number":10,"context_line":"    to routers on that network if the target MAC address matches. ARP"},{"line_number":11,"context_line":"    requests that does not match a router will only be forwarded to"},{"line_number":12,"context_line":"    non-router ports."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a1a4d780_61cbdd2a","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":22},"in_reply_to":"2cd7b2f7_4314566a","updated":"2024-07-09 19:21:48.000000000","message":"Done","commit_id":"b995862e5b38a9944f9b743afe3ae9c98f08d082"}]}