)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"531d9f8bd6b30f92527f42090ce32cd9cd351f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"508a95ba_b12bc40e","updated":"2024-07-04 11:25:46.000000000","message":"Please open a LP bug [1] and report the issue.\n\n[1]https://bugs.launchpad.net/neutron","commit_id":"bcd1fe34d4b75a8f5b4acbb97da6471e931ff2fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"298151922909d20b3255679704972a7314deac30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b8675801_c9d95d08","updated":"2024-07-05 14:13:39.000000000","message":"This is the way, IMO. Nice patch, minor comments. -1 just for visibility.","commit_id":"d95f7a44b3d79f677eba89a27357c3007590c9f7"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"298151922909d20b3255679704972a7314deac30","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            self.agent.updated_devices.add(port_data[\u0027device\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def binding_activate(self, context, **kwargs):"},{"line_number":113,"context_line":"        port_id \u003d kwargs.get(\u0027port_id\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if kwargs.get(\u0027host\u0027) !\u003d self.agent.conf.host:"},{"line_number":116,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"5771459b_97e9a792","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":39},"updated":"2024-07-05 14:13:39.000000000","message":"nit: retrieve this info after checking the host (next line)","commit_id":"d95f7a44b3d79f677eba89a27357c3007590c9f7"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d23de9ecf283196fcce6a5ab1e38f98cc4e54613","unresolved":true,"context_lines":[{"line_number":2873,"context_line":"                is_sriov_enabled \u003d any("},{"line_number":2874,"context_line":"                    item.name \u003d\u003d \"sriovnicswitch\" for item in mech_drivers"},{"line_number":2875,"context_line":"                )"},{"line_number":2876,"context_line":"                if is_sriov_enabled:"},{"line_number":2877,"context_line":"                    self.notifier.binding_activate_sriov(context, port_dict,"},{"line_number":2878,"context_line":"                                                         inactive_binding.host)"},{"line_number":2879,"context_line":"                else:"},{"line_number":2880,"context_line":"                    self.notifier.binding_activate(context, port_id,"},{"line_number":2881,"context_line":"                                                   inactive_binding.host)"},{"line_number":2882,"context_line":"                return self._make_port_binding_dict(cur_context._binding)"},{"line_number":2883,"context_line":"        raise exc.PortBindingError(port_id\u003dport_id, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7b77850d_47807263","line":2880,"range":{"start_line":2876,"start_character":15,"end_line":2880,"end_character":68},"updated":"2024-07-05 06:36:58.000000000","message":"1) This should be agnostic to any driver used.\n2) That won\u0027t work because you usually use SR-IOV with other mech drivers (OVS, OVN).","commit_id":"a05f8d7e66d322000af15e020cc287795bd4109b"},{"author":{"_account_id":5112,"name":"Seyeong Kim","email":"seyeong.kim@canonical.com","username":"xtrusia"},"change_message_id":"6cda0a9c4a360807e2a3a69433c51ca873b45eec","unresolved":true,"context_lines":[{"line_number":2873,"context_line":"                is_sriov_enabled \u003d any("},{"line_number":2874,"context_line":"                    item.name \u003d\u003d \"sriovnicswitch\" for item in mech_drivers"},{"line_number":2875,"context_line":"                )"},{"line_number":2876,"context_line":"                if is_sriov_enabled:"},{"line_number":2877,"context_line":"                    self.notifier.binding_activate_sriov(context, port_dict,"},{"line_number":2878,"context_line":"                                                         inactive_binding.host)"},{"line_number":2879,"context_line":"                else:"},{"line_number":2880,"context_line":"                    self.notifier.binding_activate(context, port_id,"},{"line_number":2881,"context_line":"                                                   inactive_binding.host)"},{"line_number":2882,"context_line":"                return self._make_port_binding_dict(cur_context._binding)"},{"line_number":2883,"context_line":"        raise exc.PortBindingError(port_id\u003dport_id, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d4c273f1_7cd862fc","line":2880,"range":{"start_line":2876,"start_character":15,"end_line":2880,"end_character":68},"in_reply_to":"0c86cdcf_5e796b4d","updated":"2024-07-05 10:42:18.000000000","message":"Thanks. I understand what you mean.\n\nLet me check it next week.\n\nThanks a lot.","commit_id":"a05f8d7e66d322000af15e020cc287795bd4109b"},{"author":{"_account_id":5112,"name":"Seyeong Kim","email":"seyeong.kim@canonical.com","username":"xtrusia"},"change_message_id":"dc2b703522cd15f8843e8442a2d93c0ea72dca11","unresolved":true,"context_lines":[{"line_number":2873,"context_line":"                is_sriov_enabled \u003d any("},{"line_number":2874,"context_line":"                    item.name \u003d\u003d \"sriovnicswitch\" for item in mech_drivers"},{"line_number":2875,"context_line":"                )"},{"line_number":2876,"context_line":"                if is_sriov_enabled:"},{"line_number":2877,"context_line":"                    self.notifier.binding_activate_sriov(context, port_dict,"},{"line_number":2878,"context_line":"                                                         inactive_binding.host)"},{"line_number":2879,"context_line":"                else:"},{"line_number":2880,"context_line":"                    self.notifier.binding_activate(context, port_id,"},{"line_number":2881,"context_line":"                                                   inactive_binding.host)"},{"line_number":2882,"context_line":"                return self._make_port_binding_dict(cur_context._binding)"},{"line_number":2883,"context_line":"        raise exc.PortBindingError(port_id\u003dport_id, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":5,"id":"82082aed_5ec9f10a","line":2880,"range":{"start_line":2876,"start_character":15,"end_line":2880,"end_character":68},"in_reply_to":"7b77850d_47807263","updated":"2024-07-05 06:43:43.000000000","message":"oh I see. Actually I would like to ask this to you. ( I thought sriovnicswitch only in when we enable sriov )\nIs there any way that let sriov-nic-agent not calling _get_new_status if the port is not sriov? I keep searching it but no luck so far.","commit_id":"a05f8d7e66d322000af15e020cc287795bd4109b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7b69ea84677319660155e5ddefc339adf8d0c5a1","unresolved":true,"context_lines":[{"line_number":2873,"context_line":"                is_sriov_enabled \u003d any("},{"line_number":2874,"context_line":"                    item.name \u003d\u003d \"sriovnicswitch\" for item in mech_drivers"},{"line_number":2875,"context_line":"                )"},{"line_number":2876,"context_line":"                if is_sriov_enabled:"},{"line_number":2877,"context_line":"                    self.notifier.binding_activate_sriov(context, port_dict,"},{"line_number":2878,"context_line":"                                                         inactive_binding.host)"},{"line_number":2879,"context_line":"                else:"},{"line_number":2880,"context_line":"                    self.notifier.binding_activate(context, port_id,"},{"line_number":2881,"context_line":"                                                   inactive_binding.host)"},{"line_number":2882,"context_line":"                return self._make_port_binding_dict(cur_context._binding)"},{"line_number":2883,"context_line":"        raise exc.PortBindingError(port_id\u003dport_id, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0c86cdcf_5e796b4d","line":2880,"range":{"start_line":2876,"start_character":15,"end_line":2880,"end_character":68},"in_reply_to":"82082aed_5ec9f10a","updated":"2024-07-05 10:36:58.000000000","message":"I would go back to my comment in [1]. What information do you need, apart from the port ID? When you receive the ``binding_activate`` call, you have (only) the port ID but you can find it in ``SriovNicSwitchAgent.network_ports``:\n* If the port is present, then it is a port that belongs to the SR-IOV agent.\n* If the port is not present, you can skip the activation.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/923467/comment/076fe198_4b85edf4/","commit_id":"a05f8d7e66d322000af15e020cc287795bd4109b"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"531d9f8bd6b30f92527f42090ce32cd9cd351f56","unresolved":true,"context_lines":[{"line_number":510,"context_line":"                   network_id\u003dnetwork_id)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @utils.disable_notifications"},{"line_number":513,"context_line":"    def binding_activate(self, context, port, host):"},{"line_number":514,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_port_binding_activate,"},{"line_number":515,"context_line":"                                    fanout\u003dTrue, version\u003d\u00271.5\u0027)"},{"line_number":516,"context_line":"        cctxt.cast(context, \u0027binding_activate\u0027, port\u003dport, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":2,"id":"076fe198_4b85edf4","line":516,"range":{"start_line":513,"start_character":4,"end_line":516,"end_character":69},"updated":"2024-07-04 11:25:46.000000000","message":"1) This is an RPC change and can\u0027t be done. You need to implement another method and increase the ``AgentNotifierApi`` API version. If this new method is used only in the SR-IOV agent, you\u0027ll need to modify it only.\n\n2) In the SR-IOV you have a list of ports that are currently provisioned by the agent (``SriovNicSwitchAgent.network_ports``). Isn\u0027t that enough to consider to treat or not this port?","commit_id":"bcd1fe34d4b75a8f5b4acbb97da6471e931ff2fa"},{"author":{"_account_id":5112,"name":"Seyeong Kim","email":"seyeong.kim@canonical.com","username":"xtrusia"},"change_message_id":"9ede2026a9949c9ccf93448c6940db09b6fd2218","unresolved":true,"context_lines":[{"line_number":510,"context_line":"                   network_id\u003dnetwork_id)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @utils.disable_notifications"},{"line_number":513,"context_line":"    def binding_activate(self, context, port, host):"},{"line_number":514,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_port_binding_activate,"},{"line_number":515,"context_line":"                                    fanout\u003dTrue, version\u003d\u00271.5\u0027)"},{"line_number":516,"context_line":"        cctxt.cast(context, \u0027binding_activate\u0027, port\u003dport, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cc4e24be_30016a17","line":516,"range":{"start_line":513,"start_character":4,"end_line":516,"end_character":69},"in_reply_to":"076fe198_4b85edf4","updated":"2024-07-04 11:33:13.000000000","message":"Thanks for the advice. I\u0027ll take a look at the point tomorrow!","commit_id":"bcd1fe34d4b75a8f5b4acbb97da6471e931ff2fa"},{"author":{"_account_id":5112,"name":"Seyeong Kim","email":"seyeong.kim@canonical.com","username":"xtrusia"},"change_message_id":"9117948b36e20d927c188c57b0f233a97aa70c6a","unresolved":true,"context_lines":[{"line_number":510,"context_line":"                   network_id\u003dnetwork_id)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @utils.disable_notifications"},{"line_number":513,"context_line":"    def binding_activate(self, context, port, host):"},{"line_number":514,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_port_binding_activate,"},{"line_number":515,"context_line":"                                    fanout\u003dTrue, version\u003d\u00271.5\u0027)"},{"line_number":516,"context_line":"        cctxt.cast(context, \u0027binding_activate\u0027, port\u003dport, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c70e3a16_16da56f6","line":516,"range":{"start_line":513,"start_character":4,"end_line":516,"end_character":69},"in_reply_to":"cc4e24be_30016a17","updated":"2024-07-05 00:10:37.000000000","message":"@ralonsoh@redhat.com\nI\u0027ve checked actual value in self.agent.network_ports which doesn\u0027t have the information I find.","commit_id":"bcd1fe34d4b75a8f5b4acbb97da6471e931ff2fa"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_sriov_nic_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"298151922909d20b3255679704972a7314deac30","unresolved":true,"context_lines":[{"line_number":555,"context_line":"        self.sriov_rpc_callback.binding_activate(**kwargs)"},{"line_number":556,"context_line":"        # Assert no bindings were added"},{"line_number":557,"context_line":"        self.assertEqual(set(), self.agent.activated_bindings)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def test_binding_deactivate(self):"},{"line_number":560,"context_line":"        # binding_deactivate() basically does nothing"},{"line_number":561,"context_line":"        # call it with both the agent\u0027s host and other host to cover"}],"source_content_type":"text/x-python","patch_set":9,"id":"87eba54d_15bf8db9","line":558,"updated":"2024-07-05 14:13:39.000000000","message":"Add another test where the port is NOT in self.agent.network_ports. Check that you print the new message \"This port is not SRIOV, skip binding for port %s\".","commit_id":"d95f7a44b3d79f677eba89a27357c3007590c9f7"}]}