)]}'
{"id":"openstack%2Fneutron~923488","triplet_id":"openstack%2Fneutron~stable%2F2024.1~Ibca174213bba3c56fc18ec2732d80054ac95e859","project":"openstack/neutron","branch":"stable/2024.1","topic":"bug/2071374","attention_set":{},"removed_from_attention_set":{"16688":{"account":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"last_update":"2024-07-06 01:26:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibca174213bba3c56fc18ec2732d80054ac95e859","subject":"Reorder subnet RBAC policy check strings","status":"MERGED","created":"2024-07-04 10:18:38.000000000","updated":"2024-07-06 01:27:44.000000000","submitted":"2024-07-06 01:26:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"923488-bug/2071374","meta_rev_id":"9792a613cbde5719969d819d9425b74136308ab4","_number":923488,"virtual_id_number":923488,"owner":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-06 01:26:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"all":[{"value":2,"date":"2024-07-05 09:25:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":2,"date":"2024-07-05 06:39:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"all":[{"value":1,"date":"2024-07-05 09:25:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-04 11:03:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-04 12:34:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-05 06:39:36.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"state":"REVIEWER"},{"updated":"2024-07-05 09:25:11.000000000","updated_by":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"reviewer":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"state":"REVIEWER"}],"messages":[{"id":"42fbb71b7d413ce22ffafc4b3926ac0cb29e6894","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2024-07-04 10:18:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de3b1387dc439a49efafe865976e6c54b75d4b99","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-04 11:03:41.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ed8da530f79b4cdbb907e1d419f5c5bd\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/61d9b325b00346218f61b12783eeeab6 : SUCCESS in 19m 22s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/5f91529446214b2288590aa1617af248 : SUCCESS in 19m 48s\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/2fc9b4f67a954410bb6db7efd7fc8000 : SUCCESS in 42m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d5f5b818c291199046aac420f4fe5cb572d43c1c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-04 12:34:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ef5ea4c66e3142918d386c0a350edc60\n\n- neutron-tempest-plugin-openvswitch https://zuul.opendev.org/t/openstack/build/2d22123c1d75429a8ef9dc31ea6bbaaa : SUCCESS in 1h 23m 40s\n- neutron-tempest-plugin-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/678fa6563f404c9fa5bfa9542e3eb3d3 : SUCCESS in 1h 40m 16s\n- neutron-tempest-plugin-openvswitch-enforce-scope-old-defaults https://zuul.opendev.org/t/openstack/build/4713910a517246ef97b75eae87e5bea7 : SUCCESS in 1h 12m 22s\n- neutron-tempest-plugin-ovn https://zuul.opendev.org/t/openstack/build/95b61581a1dd4a8daec10fff8b9a511d : SUCCESS in 1h 49m 58s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/a0747ed2ed9444378cbbca679dcd5246 : SUCCESS in 32m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/775e60987b6d40a9a6fb3d93479f9196 : SUCCESS in 40m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/841f7e881240479cb70ad059a2e1b8d6 : SUCCESS in 10m 12s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a80ebf60f22e4c66909997ddf5a718d9 : SUCCESS in 31m 12s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/e58f4941d256401db76ab089b95b16d5 : SUCCESS in 26m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9ffd42e98b8c481ebb44b6c3ef3b3388 : SUCCESS in 10m 55s\n- neutron-ovs-grenade-multinode-skip-level https://zuul.opendev.org/t/openstack/build/eaa61f06deb946aeb95969498ec52761 : SUCCESS in 1h 01m 59s\n- neutron-ovn-grenade-multinode-skip-level https://zuul.opendev.org/t/openstack/build/a1ddef1ab1ff480f8229e4d10a3c3c33 : SUCCESS in 1h 06m 45s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/3f614d722a2c4e95bd3e6aa357fea913 : SUCCESS in 56m 50s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/28a61b632b804e5987531958ebfe964b : SUCCESS in 1h 54m 16s\n- neutron-ovs-grenade-multinode https://zuul.opendev.org/t/openstack/build/69e45ad4fab74e76bc3aadc1f825a3cd : SUCCESS in 58m 14s\n- neutron-ovs-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/f9d2c8de61934ded94b80433e6ea2e30 : SUCCESS in 54m 02s\n- neutron-ovs-tempest-multinode-full https://zuul.opendev.org/t/openstack/build/6be2acb3f115422b999bb79bcc1f0786 : SUCCESS in 1h 38m 03s\n- neutron-ovs-tempest-dvr-ha-multinode-full https://zuul.opendev.org/t/openstack/build/2c544adba68a41aeaeb0c7d78cf83f78 : SUCCESS in 1h 28m 26s\n- neutron-ovn-tempest-ipv6-only-ovs-release https://zuul.opendev.org/t/openstack/build/65059c1ded544f868611cb5dfe5d502c : SUCCESS in 55m 21s\n- neutron-ovs-rally-task https://zuul.opendev.org/t/openstack/build/99a759a88ccd44f5a3f8b524e52e8f0c : SUCCESS in 1h 20m 41s\n- neutron-ovn-rally-task https://zuul.opendev.org/t/openstack/build/7a93bc6d18724333aaed7f47d989322b : SUCCESS in 1h 39m 00s\n- tempest-integrated-networking https://zuul.opendev.org/t/openstack/build/6d786c1dd9fc4f3bb1a3e451e0a7b570 : SUCCESS in 1h 19m 37s","accounts_in_message":[],"_revision_number":1},{"id":"31b54d78668deafc6e2926d6a139ccdb7041091b","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2024-07-05 06:39:36.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"db01a2c5769e141958a6b212304cd629b97e56d7","author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"date":"2024-07-05 09:25:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fa932dd4a1bc6d94c681011036455b6bfe0fe7c5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-05 09:25:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fc25b9b6526c8749111c85b7f0ed63c853deb0cb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-05 22:38:03.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"52b348cd57a2b88ee5a79ca440b98d50a22b8a60","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-06 01:26:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/faef3bc63e0347d58a80296cbb34665e\n\n- neutron-tempest-plugin-openvswitch https://zuul.opendev.org/t/openstack/build/0e536cc84af645eb8ccbf5c326653dde : SUCCESS in 2h 12m 33s\n- neutron-tempest-plugin-ovn https://zuul.opendev.org/t/openstack/build/23a8d2a3d43e4e95bb6aef4de252ce53 : SUCCESS in 2h 31m 22s\n- neutron-tempest-plugin-openvswitch-iptables_hybrid https://zuul.opendev.org/t/openstack/build/eaa5338c627c41c08642b7072b6de60c : SUCCESS in 2h 26m 11s\n- neutron-tempest-plugin-openvswitch-enforce-scope-old-defaults https://zuul.opendev.org/t/openstack/build/273901b6a1b040c38ca150d13cdd3bc5 : SUCCESS in 1h 52m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3f83998f3a3d4c868f1449c346cdd76a : SUCCESS in 11m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f3226d6d511e4713b780bf5e5e454150 : SUCCESS in 30m 11s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/71f905ca163343a086a0e3ed99199a5e : SUCCESS in 24m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0db7d16334574eda9c1abe3ab6feb055 : SUCCESS in 9m 57s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/ed7c70ef72cd40a1ac846f52b7ab2b5d : SUCCESS in 52m 52s\n- neutron-fullstack-with-uwsgi https://zuul.opendev.org/t/openstack/build/859d01dad304457e9fb276f99cf1ee7a : SUCCESS in 1h 39m 03s\n- neutron-ovs-tempest-multinode-full https://zuul.opendev.org/t/openstack/build/1255f579701f4a12919406c02b29911e : SUCCESS in 1h 25m 36s\n- neutron-ovs-grenade-multinode https://zuul.opendev.org/t/openstack/build/b794ed0a078f4055ad26c8f5f02914e1 : SUCCESS in 49m 19s\n- neutron-ovs-grenade-dvr-multinode https://zuul.opendev.org/t/openstack/build/d34c8c6398224796961da198e1c0112f : SUCCESS in 1h 05m 54s\n- neutron-ovn-tempest-ipv6-only-ovs-release https://zuul.opendev.org/t/openstack/build/81525810b5b848988ee34b3f86208b74 : SUCCESS in 50m 00s\n- tempest-integrated-networking https://zuul.opendev.org/t/openstack/build/a76b183109514610b8decd4566bf7ca0 : SUCCESS in 55m 18s","accounts_in_message":[],"_revision_number":1},{"id":"3fc4df5e7fdcf4925271cb682faca7c22d30a79d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-06 01:26:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"9792a613cbde5719969d819d9425b74136308ab4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-06 01:27:44.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/037fd873afda45468924bfc2bacae292\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/36e4f647d7cc43cb94c574867b6442e9 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f25cc2f503573e2288b61e262bcc3900c62c1a04","revisions":{"f25cc2f503573e2288b61e262bcc3900c62c1a04":{"kind":"REWORK","_number":1,"created":"2024-07-04 10:18:38.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/88/923488/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/88/923488/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/88/923488/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/88/923488/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/88/923488/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/88/923488/1"}}},"commit":{"parents":[{"commit":"c6d4a3e364b11568dfd36a11551f553c11c48308","subject":"Merge \"[OVN] Sanitize the classless-static-route DHCP option\" into stable/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/c6d4a3e364b11568dfd36a11551f553c11c48308"}]}],"author":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2024-07-02 07:29:44.000000000","tz":0},"committer":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2024-07-04 10:18:12.000000000","tz":0},"subject":"Reorder subnet RBAC policy check strings","message":"Reorder subnet RBAC policy check strings\n\nThe subnet policy rule ``ADMIN_OR_NET_OWNER_MEMBER`` requires to\nretrieve the network object from the database to read the project ID.\nWhen retrieving a list of subnets, this operation can slow down the\nAPI call. This patch is reordering the subnet RBAC policy checks to\nmake this check at the end.\n\nAs reported in the related LP bug, it is usual to have a \"creator\"\nproject where different resources are created and then shared to others;\nin this case networks and subnets. All these subnets will belong to the\nsame project. If a non-admin user from this project list all the\nsubnets, with the code before to this patch it would be needed to\nretrieve all the networks to read the project ID. With the current code\nit is needed only to check that the user is a project reader.\n\nThe following benchmark has been done in a VM running a standalone\nOpenStack deployment. One project has created 400 networks and 400\nsubnets (one per network). Each network has been shared with another\nproject. API time to process \"GET /networking/v2.0/subnets\":\n* Without this patch: 5.5 seconds (average)\n* With this patch: 0.25 seconds (average)\n\nRelated-Bug: #2071374\nRelated-Bug: #2037107\nChange-Id: Ibca174213bba3c56fc18ec2732d80054ac95e859\n(cherry picked from commit 729920da5e836fa7a27b1b85b3b2999146d905ba)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/f25cc2f503573e2288b61e262bcc3900c62c1a04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/f25cc2f503573e2288b61e262bcc3900c62c1a04"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}