)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46b0e0f45b1a886e0630f47cae717dd7a2d09b10","unresolved":true,"context_lines":[{"line_number":12,"context_line":"nova don\u0027t waits."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So added OVS_HYBRID_PLUG to the port binding options, as ovn is using the"},{"line_number":15,"context_line":"multi-chassis approach."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2069718"},{"line_number":18,"context_line":"Change-Id: I4671768a46f42d3aca566c10131892a4b38584ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cc7c49de_1d432a72","line":15,"updated":"2024-07-15 16:38:07.000000000","message":"ovn should not be setting OVS_HYBRID_PLUG\u003dtrue or false \n\nthere is only once case that this si ever possible with is when adopting form ml2/ovs and even then that is only correct until the first time the port is rebound.","commit_id":"d06d51f3d1fe7a9493ae96f847ee28a61b44b6fe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dca60539b05f85669e4a11a3c10559811e8f9048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c67af1f_87cd950e","updated":"2024-07-15 07:14:41.000000000","message":"This flag is only used by Nova (and os-vif) to use the hybrid plug strategy, that implies creating a per-VIF Linux Bridge that links to the integration bridge. The TAP interface if plugged to this Linux Bridge. This is not used in ML2/OVN.","commit_id":"d06d51f3d1fe7a9493ae96f847ee28a61b44b6fe"},{"author":{"_account_id":26832,"name":"Stefan Hoffmann","email":"stefan.hoffmann@cloudandheat.com","username":"shoffmann"},"change_message_id":"fa4a973c798187455deedeaab1a0fd4f03327d48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2163aba8_dfc341bf","updated":"2024-07-15 13:44:52.000000000","message":"recheck neutron-ovn-rally-task\n\nfollow up patch 923963 doesn\u0027t fail at this job.","commit_id":"d06d51f3d1fe7a9493ae96f847ee28a61b44b6fe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46b0e0f45b1a886e0630f47cae717dd7a2d09b10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"119bf878_a85051e6","updated":"2024-07-15 16:38:07.000000000","message":"this will signifncaly regress teh performace of ovn by reintoudced a veth pair  and linux bridge.\n\nim not quite sure what your trying to fix but this is not the correct way to do it.","commit_id":"d06d51f3d1fe7a9493ae96f847ee28a61b44b6fe"},{"author":{"_account_id":26832,"name":"Stefan Hoffmann","email":"stefan.hoffmann@cloudandheat.com","username":"shoffmann"},"change_message_id":"551664f8c12b2b3547bff005c8db461e32376ddc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b710a10d_ccc4f6fc","in_reply_to":"8c67af1f_87cd950e","updated":"2024-07-15 13:42:22.000000000","message":"Hi, in nova code I found that get_live_migration_plug_time_events()[1] calls (via has_live_migration_plug_time_event()) is_hybrid_plug_enabled()[2], where it checks if VIF_DETAILS_OVS_HYBRID_PLUG is set in VIF.details.\nAlso while debugging at my cluster with OVN setup, I saw nova-compute passing that function.\n\nSo also this flag/option is meant differently, nova uses it to check, if it needs to wait for a plug event.\nOr is there a different code path, to tell nova to wait for neutron event? (setting live_migration_wait_for_vif_plug doesn\u0027t help, also it\u0027s default true.)\n\n[1] https://opendev.org/openstack/nova/src/branch/master/nova/network/model.py#L563\n[2] https://opendev.org/openstack/nova/src/branch/master/nova/network/model.py#L499","commit_id":"d06d51f3d1fe7a9493ae96f847ee28a61b44b6fe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4238b54b1263487e79fba10014451727d5c42f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38c88a6a_c45dbb95","in_reply_to":"b710a10d_ccc4f6fc","updated":"2024-07-15 14:53:08.000000000","message":"As commented, this flag is used by nova to create a hybrid plug [1]. This plugin strategy won\u0027t work with ML2/OVN.\n\nThis flag was associated with nova \u0027has_live_migration_plug_time_event\u0027 because when a linux bridge is created and a veth interface attached to the integration bridge, Neutron replies with a \u0027vif-plugged-event\u0027. That is not happening with a native plugin strategy, where the TAP device, created by libvirt, is attached during the VM bootup.\n\nIn any case, check that statement with the Nova team.\n\nSetting -2 to prevent this patch from being merged.\n\n[1]https://github.com/openstack/nova/blob/c6d8c6972d52845774b36acb84cd08a4b2e4dcde/nova/network/os_vif_util.py#L350","commit_id":"d06d51f3d1fe7a9493ae96f847ee28a61b44b6fe"}]}