)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e8a85d187e09c95afded7fd6dbfd7659df8d98a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This ensures that other attributes such as the name and description"},{"line_number":13,"context_line":"can still be updated even when the address scope cannot be changed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes: 2074092"},{"line_number":16,"context_line":"Change-Id: I7c65a78c7b14415589099257cbb979970ceb014d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9d5122a6_0ed82b39","line":15,"updated":"2024-07-28 22:55:45.000000000","message":"In addition to Rodolfo\u0027s question, this should be:\n\nCloses-bug: #2074092","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"922dde0152825ae252fae782aefbdfe196d46dba","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This ensures that other attributes such as the name and description"},{"line_number":13,"context_line":"can still be updated even when the address scope cannot be changed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes: 2074092"},{"line_number":16,"context_line":"Change-Id: I7c65a78c7b14415589099257cbb979970ceb014d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bd2439b5_84ff26b8","line":15,"in_reply_to":"9d5122a6_0ed82b39","updated":"2024-07-30 17:27:04.000000000","message":"Done","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cccecbde1ec75357bfe7d24b7eeb514612bb94ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3eb5d5c_71311461","updated":"2024-07-26 06:07:19.000000000","message":"Actually I think the ``_validate_address_scope_id`` method is incorrect. If, as in the reported reproduced, we have 2 subnets from different subnetpools (but in the same address scope), that should work fine as long as the subnets in the same address scope do not overlap.","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"d25d5ad1294e8ff25bca70ef00e44d7fce07c3ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81ec3afe_a9d91856","in_reply_to":"e3eb5d5c_71311461","updated":"2024-07-26 08:06:14.000000000","message":"I\u0027m not sure. I think restricting address scope changes makes sense when there\u0027s two different subnets from two separate pools. I just don\u0027t think we should be blocking all changes to the subnet pool (such as name and description updates) and instead just address scope changes should be restricted.","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8e405eb9958452e70ff5665c6c9ff00abb522fe","unresolved":true,"context_lines":[{"line_number":1356,"context_line":"                self._check_subnetpool_address_scope_network_affinity("},{"line_number":1357,"context_line":"                    context, id, reader.ip_version)"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"            orig_sp.update_fields(reader.subnetpool)"},{"line_number":1360,"context_line":"            orig_sp.update()"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"        if address_scope_changed:"},{"line_number":1363,"context_line":"            # Notify about the update of subnetpool\u0027s address scope"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ba429d0_1c9eba7b","line":1360,"range":{"start_line":1359,"start_character":12,"end_line":1360,"end_character":28},"updated":"2024-07-26 05:42:56.000000000","message":"How is this patch solving the reported issue if the update command is executed after the network affinity test?","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"d25d5ad1294e8ff25bca70ef00e44d7fce07c3ba","unresolved":true,"context_lines":[{"line_number":1356,"context_line":"                self._check_subnetpool_address_scope_network_affinity("},{"line_number":1357,"context_line":"                    context, id, reader.ip_version)"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"            orig_sp.update_fields(reader.subnetpool)"},{"line_number":1360,"context_line":"            orig_sp.update()"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"        if address_scope_changed:"},{"line_number":1363,"context_line":"            # Notify about the update of subnetpool\u0027s address scope"}],"source_content_type":"text/x-python","patch_set":2,"id":"fdf8e35a_b666c57d","line":1360,"range":{"start_line":1359,"start_character":12,"end_line":1360,"end_character":28},"in_reply_to":"5ba429d0_1c9eba7b","updated":"2024-07-26 08:06:14.000000000","message":"The ``_check_subnetpool_address_scope_network_affinity`` function was previously called as a part of ``_validate_address_scope_id``. However, this would raise an exception whenever other subnets existed on a network that were not part of the subnet pool being updated.\n\nThis makes sense if the address scope is actually being changed but if it\u0027s not then there\u0027s no need to call it (and therefore no need to throw the exception). As far as I can tell, the only time to do this validation is before we actually call ``update()``. Also, given it\u0027s been split out from the ``_validate_address_scope_id`` above, I think it\u0027s essentially still being called at the same point within the ``update_subnetpool`` and ``create_subnetpool`` functions?\n\nAs a side note, we could have left ``_check_subnetpool_address_scope_network_affinity`` in the ``_validate_address_scope_id`` function and instead passed a ``address_scope_changed`` argument to it but this approach seemed cleaner to me.","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"922dde0152825ae252fae782aefbdfe196d46dba","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"                self._check_subnetpool_address_scope_network_affinity("},{"line_number":1357,"context_line":"                    context, id, reader.ip_version)"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"            orig_sp.update_fields(reader.subnetpool)"},{"line_number":1360,"context_line":"            orig_sp.update()"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"        if address_scope_changed:"},{"line_number":1363,"context_line":"            # Notify about the update of subnetpool\u0027s address scope"}],"source_content_type":"text/x-python","patch_set":2,"id":"55bda9e1_4cab11af","line":1360,"range":{"start_line":1359,"start_character":12,"end_line":1360,"end_character":28},"in_reply_to":"fdf8e35a_b666c57d","updated":"2024-07-30 17:27:04.000000000","message":"I\u0027m not sure if the above answers your question? If not, could I get a little bit more clarification on the concern here as I might be missing something.","commit_id":"cee058bbd2b52f5183897e5e8e71d5864ebe3f10"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"514ae00e1353831adaf9efb336a2e6cc9c432a9e","unresolved":true,"context_lines":[{"line_number":1221,"context_line":"            raise exc.IllegalSubnetPoolIpVersionAssociationToAddressScope("},{"line_number":1222,"context_line":"                subnetpool_id\u003dsubnetpool_id, address_scope_id\u003daddress_scope_id,"},{"line_number":1223,"context_line":"                ip_version\u003das_ip_version)"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"        self._check_subnetpool_address_scope_network_affinity("},{"line_number":1226,"context_line":"            context, subnetpool_id, ip_version)"},{"line_number":1227,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6015371c_023a293b","side":"PARENT","line":1224,"updated":"2024-08-13 09:33:35.000000000","message":"isn\u0027t it possible to add the condition here? like adding extra param to _validate_address_scope_id address_scope_changed, and in case of create that is by default True, and for update you can use the variable from l1352.","commit_id":"725f3cbd8e9dfab18cccdcb2073f49473e634346"}]}