)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"082bd2542061cdd092c360f071949301760003aa","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix setting correct \u0027reside-on-chassis-redirect\u0027 in the maintenance task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Setting of the \u0027reside-on-chassis-redirect\u0027 was skipped for non external"},{"line_number":10,"context_line":"gateway ports in patch [1] but later patch [2] removed this limitation"},{"line_number":11,"context_line":"from the ovn_client but not from the maintenance task."},{"line_number":12,"context_line":"Due to that this option wasn\u0027t updated after e.g. change of the"},{"line_number":13,"context_line":"\u0027enable_distributed_floating_ip\u0027 config option and connectivity to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2501be21_b3e0debf","line":10,"range":{"start_line":9,"start_character":44,"end_line":10,"end_character":26},"updated":"2024-07-26 11:08:17.000000000","message":"Maybe I\u0027m reading the code incorrectly but [1] is removing the provider networks from ``vlan_net_ids``, thus \u0027reside-on-chassis-redirect\u0027 was not set on external GW ports. If I\u0027m not wrong, the problem was in the LRP of the provider network not having the \u0027reside-on-chassis-redirect\u0027 option.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/871252/9/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py#730","commit_id":"8134715cfd143c4c28ccc7cb8d51ef19f5a1e814"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"afa3d5999c65e81ad59b2e680f61e0a3d3375f5e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix setting correct \u0027reside-on-chassis-redirect\u0027 in the maintenance task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Setting of the \u0027reside-on-chassis-redirect\u0027 was skipped for non external"},{"line_number":10,"context_line":"gateway ports in patch [1] but later patch [2] removed this limitation"},{"line_number":11,"context_line":"from the ovn_client but not from the maintenance task."},{"line_number":12,"context_line":"Due to that this option wasn\u0027t updated after e.g. change of the"},{"line_number":13,"context_line":"\u0027enable_distributed_floating_ip\u0027 config option and connectivity to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac81301_86a38000","line":10,"range":{"start_line":9,"start_character":44,"end_line":10,"end_character":26},"in_reply_to":"2501be21_b3e0debf","updated":"2024-07-31 12:15:31.000000000","message":"yes, it was removing provider networks from that list, and the problem here was that LRP of the vlan tenant network have reside-on-redirect-chassis set but incorrectly in such case because it was not updated if you toggle distributed_floating_ips in neutron config","commit_id":"8134715cfd143c4c28ccc7cb8d51ef19f5a1e814"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4bf52f42f8ac803199319ffe80d99477916c1e79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89ce00c2_00b1a09c","updated":"2024-07-31 15:41:47.000000000","message":"I guess there were never any specific tests for this :(","commit_id":"4b1bfb93e380b8dce78935395b2cda57076e5476"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"38c03502580174e57d7f27d7b91b6e63306cd8ef","unresolved":true,"context_lines":[{"line_number":727,"context_line":"        cmds \u003d []"},{"line_number":728,"context_line":"        # Get router ports belonging to VLAN networks"},{"line_number":729,"context_line":"        vlan_nets \u003d self._ovn_client._plugin.get_networks("},{"line_number":730,"context_line":"            context, {pnet.NETWORK_TYPE: [n_const.TYPE_VLAN]})"},{"line_number":731,"context_line":"        vlan_net_ids \u003d [vn[\u0027id\u0027] for vn in vlan_nets]"},{"line_number":732,"context_line":"        router_ports \u003d self._ovn_client._plugin.get_ports("},{"line_number":733,"context_line":"            context, {\u0027network_id\u0027: vlan_net_ids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df8301f2_8a5819f1","line":730,"range":{"start_line":730,"start_character":41,"end_line":730,"end_character":60},"updated":"2024-07-26 11:10:07.000000000","message":"Although admins usually use VLAN networks, this issue applies to VLAN and flat networks (in my env, the external network is flat). But this should be addressed in other bug.","commit_id":"8134715cfd143c4c28ccc7cb8d51ef19f5a1e814"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67247dd205110226f95ff324011f8186e9773fbb","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        cmds \u003d []"},{"line_number":728,"context_line":"        # Get router ports belonging to VLAN networks"},{"line_number":729,"context_line":"        vlan_nets \u003d self._ovn_client._plugin.get_networks("},{"line_number":730,"context_line":"            context, {pnet.NETWORK_TYPE: [n_const.TYPE_VLAN]})"},{"line_number":731,"context_line":"        vlan_net_ids \u003d [vn[\u0027id\u0027] for vn in vlan_nets]"},{"line_number":732,"context_line":"        router_ports \u003d self._ovn_client._plugin.get_ports("},{"line_number":733,"context_line":"            context, {\u0027network_id\u0027: vlan_net_ids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd44e415_92dce0a9","line":730,"range":{"start_line":730,"start_character":41,"end_line":730,"end_character":60},"in_reply_to":"03feb0a3_d03a1992","updated":"2024-07-31 14:31:35.000000000","message":"Follow up patch  https://review.opendev.org/c/openstack/neutron/+/925402","commit_id":"8134715cfd143c4c28ccc7cb8d51ef19f5a1e814"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"afa3d5999c65e81ad59b2e680f61e0a3d3375f5e","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        cmds \u003d []"},{"line_number":728,"context_line":"        # Get router ports belonging to VLAN networks"},{"line_number":729,"context_line":"        vlan_nets \u003d self._ovn_client._plugin.get_networks("},{"line_number":730,"context_line":"            context, {pnet.NETWORK_TYPE: [n_const.TYPE_VLAN]})"},{"line_number":731,"context_line":"        vlan_net_ids \u003d [vn[\u0027id\u0027] for vn in vlan_nets]"},{"line_number":732,"context_line":"        router_ports \u003d self._ovn_client._plugin.get_ports("},{"line_number":733,"context_line":"            context, {\u0027network_id\u0027: vlan_net_ids,"}],"source_content_type":"text/x-python","patch_set":1,"id":"03feb0a3_d03a1992","line":730,"range":{"start_line":730,"start_character":41,"end_line":730,"end_character":60},"in_reply_to":"df8301f2_8a5819f1","updated":"2024-07-31 12:15:31.000000000","message":"yes, I noticed that but wanted to do it in follow up patch as this wouldn\u0027t be really related to the bug","commit_id":"8134715cfd143c4c28ccc7cb8d51ef19f5a1e814"}]}