)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d4076cbfc83c8bcc293abbe2c4222199c0fddce1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"93cdbfb7_6bd7293b","updated":"2024-09-13 09:32:42.000000000","message":"recheck\niptables failure is not related","commit_id":"64fb8b85a959fdc49334706279eebad9d63b06fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2929c139a2292d8896cb3a797e4d25bcf07a0c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"47fd0c4a_f6a0354c","updated":"2024-09-13 10:02:02.000000000","message":"recheck neutron-tempest-plugin-openvswitch-iptables_hybrid","commit_id":"64fb8b85a959fdc49334706279eebad9d63b06fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"de51f93427060e2e25398db4cec3ca42e3bd978f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fe9a8de4_dd53b2bc","updated":"2024-09-13 09:12:10.000000000","message":"recheck neutron-tempest-plugin-openvswitch-iptables_hybrid","commit_id":"64fb8b85a959fdc49334706279eebad9d63b06fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1b0f27c455d476acdda6303a092e7282175b3154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a0a1330_c878cd49","updated":"2024-09-12 13:11:03.000000000","message":"recheck neutron-tempest-plugin-ovn","commit_id":"64fb8b85a959fdc49334706279eebad9d63b06fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b142381ae30833ee3afac6dd9554d868644aea38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5ea9247d_3969df66","updated":"2024-09-20 08:36:39.000000000","message":"recheck fullstack (unrelated error)","commit_id":"a2ee70eecc062a63f0d608b04cac839ee9550ce4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d02a7ba9f5d30f30609ed5799f8e1d48e7e9dbcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1a2855e8_4242ea37","updated":"2024-09-21 10:56:09.000000000","message":"recheck neutron-fullstack-with-uwsgi","commit_id":"a2ee70eecc062a63f0d608b04cac839ee9550ce4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"72f87cf1c0be1513ab22f6853bd1e947f5ca3a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"25953d6c_2624ae77","updated":"2024-09-23 06:18:39.000000000","message":"recheck neutron-ovs-tempest-multinode-full","commit_id":"a2ee70eecc062a63f0d608b04cac839ee9550ce4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76ff2c119fd00dd4d2bd7f73733d94d5be64736b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9568199a_f9779beb","updated":"2024-09-30 11:52:25.000000000","message":"hi folks, any review is welcome","commit_id":"a859760323a878ced58c2c01b6da8d0f803028be"}],"neutron/extensions/quotasv2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6a653ce88ed3b09dc45fd73d62e3a39733cc15cc","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        force \u003d body[self._resource_name].pop(\u0027force\u0027, None)"},{"line_number":134,"context_line":"        if body[self._resource_name].pop(\u0027check_limit\u0027, None):"},{"line_number":135,"context_line":"            warnings.warn(\u0027\"--check-limit\" parameter is no longer needed \u0027"},{"line_number":136,"context_line":"                          \u0027since Dalmatian (2024.2) release. By default, \u0027"},{"line_number":137,"context_line":"                          \u0027Neutron quota engine checks the resource usage \u0027"},{"line_number":138,"context_line":"                          \u0027before updating the limits\u0027)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"2836aaf5_aed4d2de","line":136,"updated":"2024-09-19 21:43:23.000000000","message":"We don\u0027t need to change this or the release note to Epoxy, right?","commit_id":"64fb8b85a959fdc49334706279eebad9d63b06fa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d5d3418fdb4e2fb6ebe3fd54602885b6863bc499","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        force \u003d body[self._resource_name].pop(\u0027force\u0027, None)"},{"line_number":134,"context_line":"        if body[self._resource_name].pop(\u0027check_limit\u0027, None):"},{"line_number":135,"context_line":"            warnings.warn(\u0027\"--check-limit\" parameter is no longer needed \u0027"},{"line_number":136,"context_line":"                          \u0027since Dalmatian (2024.2) release. By default, \u0027"},{"line_number":137,"context_line":"                          \u0027Neutron quota engine checks the resource usage \u0027"},{"line_number":138,"context_line":"                          \u0027before updating the limits\u0027)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"33b7d159_3229420b","line":136,"in_reply_to":"2836aaf5_aed4d2de","updated":"2024-09-20 05:41:45.000000000","message":"Yes","commit_id":"64fb8b85a959fdc49334706279eebad9d63b06fa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9a26859e27eb45c078d24ce9198c81881a790e39","unresolved":true,"context_lines":[{"line_number":152,"context_line":"        if force is not True:"},{"line_number":153,"context_line":"            resources \u003d resource_registry.get_all_resources()"},{"line_number":154,"context_line":"            for resource_name, limit in body[self._resource_name].items():"},{"line_number":155,"context_line":"                if limit \u003d\u003d -1:"},{"line_number":156,"context_line":"                    # limit\u003d-1 is disabling the quota thus it is not needed to"},{"line_number":157,"context_line":"                    # check the resource usage."},{"line_number":158,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":11,"id":"78b18af5_63c933bb","line":155,"updated":"2024-10-02 07:45:17.000000000","message":"nitty nit: You could define constant, something like LIMIT_DISABLED or NO_LIMIT which would have value -1 and then comment below would be not needed at all IMO as code would be more self explanatory","commit_id":"a859760323a878ced58c2c01b6da8d0f803028be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"77a9d253feb0673db28b515b1d79901e208ea3fc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        if force is not True:"},{"line_number":153,"context_line":"            resources \u003d resource_registry.get_all_resources()"},{"line_number":154,"context_line":"            for resource_name, limit in body[self._resource_name].items():"},{"line_number":155,"context_line":"                if limit \u003d\u003d -1:"},{"line_number":156,"context_line":"                    # limit\u003d-1 is disabling the quota thus it is not needed to"},{"line_number":157,"context_line":"                    # check the resource usage."},{"line_number":158,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":11,"id":"e3746494_915f6f23","line":155,"in_reply_to":"78b18af5_63c933bb","updated":"2024-10-02 08:00:59.000000000","message":"I\u0027ll push a follow-up patch","commit_id":"a859760323a878ced58c2c01b6da8d0f803028be"}],"releasenotes/notes/quota-always-checks-resource-usage-6e5e18f5c8f4b725.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a2dfca6ecba92d9155ad3bf49d4d347e0f731df6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Since Dalmatian (2024.2) release, the Neutron quota engine always checks"},{"line_number":5,"context_line":"    the current resource usage before updating the quota limits. Only when the"},{"line_number":6,"context_line":"    CLI \"--force\" parameter is passed, this check is skipped. That aligns the"},{"line_number":7,"context_line":"    Neutron quota engine behaviour with other projects."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"46b9b8a1_9ee0e97b","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"updated":"2024-09-23 16:56:54.000000000","message":"need Epoxy and 2025.1 here too then, right?","commit_id":"a2ee70eecc062a63f0d608b04cac839ee9550ce4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fef718246a5ad983ef3fcea785d936bcd2ae9c84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Since Dalmatian (2024.2) release, the Neutron quota engine always checks"},{"line_number":5,"context_line":"    the current resource usage before updating the quota limits. Only when the"},{"line_number":6,"context_line":"    CLI \"--force\" parameter is passed, this check is skipped. That aligns the"},{"line_number":7,"context_line":"    Neutron quota engine behaviour with other projects."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a01d07f8_10a6778c","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":19},"in_reply_to":"46b9b8a1_9ee0e97b","updated":"2024-09-24 13:36:00.000000000","message":"Right!","commit_id":"a2ee70eecc062a63f0d608b04cac839ee9550ce4"}]}