)]}'
{"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"16195fbf0b70c226a4ee9c51149eff23284c9129","unresolved":true,"context_lines":[{"line_number":963,"context_line":"            (\u0027external_ids\u0027, \u0027\u003d\u0027, {"},{"line_number":964,"context_line":"                ovn_const.LB_EXT_IDS_VIP_PORT_ID_KEY: lb_lsp.name})"},{"line_number":965,"context_line":"        ).execute(check_error\u003dTrue)"},{"line_number":966,"context_line":"        all_lswitches \u003d list(self._nb_idl.db_find_rows("},{"line_number":967,"context_line":"                    \u0027Logical_Switch\u0027).execute(check_error\u003dTrue))"},{"line_number":968,"context_line":"        for lb in lbs:"},{"line_number":969,"context_line":"            if not any(lb in item.load_balancer for item in all_lswitches):"}],"source_content_type":"text/x-python","patch_set":3,"id":"80672740_d6b90c89","line":966,"range":{"start_line":966,"start_character":24,"end_line":966,"end_character":28},"updated":"2024-09-19 15:20:55.000000000","message":"just out of curiosity: why do we need to convert this into a list?","commit_id":"cf334871ef2aa4484365766483a8bab1f8df18a2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ecfdd30d807c34a5058c9eefdb5595d347549a43","unresolved":true,"context_lines":[{"line_number":963,"context_line":"            (\u0027external_ids\u0027, \u0027\u003d\u0027, {"},{"line_number":964,"context_line":"                ovn_const.LB_EXT_IDS_VIP_PORT_ID_KEY: lb_lsp.name})"},{"line_number":965,"context_line":"        ).execute(check_error\u003dTrue)"},{"line_number":966,"context_line":"        all_lswitches \u003d list(self._nb_idl.db_find_rows("},{"line_number":967,"context_line":"                    \u0027Logical_Switch\u0027).execute(check_error\u003dTrue))"},{"line_number":968,"context_line":"        for lb in lbs:"},{"line_number":969,"context_line":"            if not any(lb in item.load_balancer for item in all_lswitches):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e58a0b9f_542585df","line":966,"range":{"start_line":966,"start_character":24,"end_line":966,"end_character":28},"in_reply_to":"80672740_d6b90c89","updated":"2024-09-19 16:07:01.000000000","message":"Yeah there\u0027s probably no reason for this, I see DbFindCommand result is a list. I just wasn\u0027t absolutely sure it\u0027s not some kind of a generator. I will remove this.","commit_id":"cf334871ef2aa4484365766483a8bab1f8df18a2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0c5467787cbfb9867077895f7c01823126719534","unresolved":false,"context_lines":[{"line_number":963,"context_line":"            (\u0027external_ids\u0027, \u0027\u003d\u0027, {"},{"line_number":964,"context_line":"                ovn_const.LB_EXT_IDS_VIP_PORT_ID_KEY: lb_lsp.name})"},{"line_number":965,"context_line":"        ).execute(check_error\u003dTrue)"},{"line_number":966,"context_line":"        all_lswitches \u003d list(self._nb_idl.db_find_rows("},{"line_number":967,"context_line":"                    \u0027Logical_Switch\u0027).execute(check_error\u003dTrue))"},{"line_number":968,"context_line":"        for lb in lbs:"},{"line_number":969,"context_line":"            if not any(lb in item.load_balancer for item in all_lswitches):"}],"source_content_type":"text/x-python","patch_set":3,"id":"a52866a9_80812162","line":966,"range":{"start_line":966,"start_character":24,"end_line":966,"end_character":28},"in_reply_to":"e58a0b9f_542585df","updated":"2024-09-19 16:26:15.000000000","message":"Done","commit_id":"cf334871ef2aa4484365766483a8bab1f8df18a2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"16195fbf0b70c226a4ee9c51149eff23284c9129","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                ovn_const.LB_EXT_IDS_VIP_PORT_ID_KEY: lb_lsp.name})"},{"line_number":965,"context_line":"        ).execute(check_error\u003dTrue)"},{"line_number":966,"context_line":"        all_lswitches \u003d list(self._nb_idl.db_find_rows("},{"line_number":967,"context_line":"                    \u0027Logical_Switch\u0027).execute(check_error\u003dTrue))"},{"line_number":968,"context_line":"        for lb in lbs:"},{"line_number":969,"context_line":"            if not any(lb in item.load_balancer for item in all_lswitches):"},{"line_number":970,"context_line":"                # LB is not linked anywhere."}],"source_content_type":"text/x-python","patch_set":3,"id":"a8a01541_6164ca87","line":967,"range":{"start_line":967,"start_character":20,"end_line":967,"end_character":21},"updated":"2024-09-19 15:20:55.000000000","message":"nit: weird indentation","commit_id":"cf334871ef2aa4484365766483a8bab1f8df18a2"}]}