)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a984a6d3b7fcbcf0e0ebee5187442a017c4fbd59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aefc5464_3f80a212","updated":"2024-09-27 12:20:39.000000000","message":"Looks ok","commit_id":"48d4e6a6b33cd7b5e1af048500dac9afb13a62fb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7439c4398ab8b312f3c29e4c275ba04a63b8d881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"82904f11_99696340","updated":"2024-11-05 17:43:36.000000000","message":"recheck not enough info, adding some in https://review.opendev.org/c/openstack/neutron/+/934162","commit_id":"48d4e6a6b33cd7b5e1af048500dac9afb13a62fb"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e860aeebdc45c8257f2740671f1d8c2c77c71c31","unresolved":true,"context_lines":[{"line_number":946,"context_line":"    def _handle_lb_fip_cmds(self, context, lb_lsp,"},{"line_number":947,"context_line":"                            action\u003dovn_const.FIP_ACTION_ASSOCIATE):"},{"line_number":948,"context_line":"        if not ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":949,"context_line":"            return"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        lb_lsp_fip_port \u003d lb_lsp.external_ids.get("},{"line_number":952,"context_line":"            ovn_const.OVN_PORT_NAME_EXT_ID_KEY, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"41770630_2b553d87","line":949,"updated":"2024-09-19 21:28:52.000000000","message":"Does this work correctly based on the caller?\n\n\u003e\u003e\u003e commands \u003d []\n\u003e\u003e\u003e commands.extend(None)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nTypeError: \u0027NoneType\u0027 object is not iterable","commit_id":"48d4e6a6b33cd7b5e1af048500dac9afb13a62fb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8c1bf2f224949d12a513e579fdb7ee060d6b7ab1","unresolved":true,"context_lines":[{"line_number":946,"context_line":"    def _handle_lb_fip_cmds(self, context, lb_lsp,"},{"line_number":947,"context_line":"                            action\u003dovn_const.FIP_ACTION_ASSOCIATE):"},{"line_number":948,"context_line":"        if not ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":949,"context_line":"            return"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        lb_lsp_fip_port \u003d lb_lsp.external_ids.get("},{"line_number":952,"context_line":"            ovn_const.OVN_PORT_NAME_EXT_ID_KEY, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"43e41f8d_97ded77b","line":949,"in_reply_to":"41770630_2b553d87","updated":"2024-09-20 13:46:01.000000000","message":"This is a generator, see below: `yield from self._verify_member(context, action, m)`. In Python, when a function yields, then return means \"stop iteration\" (can also be achieved with `raise StopIteration`, but it\u0027s less pythonic).","commit_id":"48d4e6a6b33cd7b5e1af048500dac9afb13a62fb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a4160c046c70af88644e694268b250896a5478b","unresolved":false,"context_lines":[{"line_number":946,"context_line":"    def _handle_lb_fip_cmds(self, context, lb_lsp,"},{"line_number":947,"context_line":"                            action\u003dovn_const.FIP_ACTION_ASSOCIATE):"},{"line_number":948,"context_line":"        if not ovn_conf.is_ovn_distributed_floating_ip():"},{"line_number":949,"context_line":"            return"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        lb_lsp_fip_port \u003d lb_lsp.external_ids.get("},{"line_number":952,"context_line":"            ovn_const.OVN_PORT_NAME_EXT_ID_KEY, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dcbaa77b_dec3a2ca","line":949,"in_reply_to":"43e41f8d_97ded77b","updated":"2024-09-20 13:46:07.000000000","message":"Done","commit_id":"48d4e6a6b33cd7b5e1af048500dac9afb13a62fb"}]}